rollbar 1.2.13 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c9a546f13548ef6139126d589b9491103e54a13
-  data.tar.gz: 3e36ffd724fb07d6bbfb3758adfa5becf98d5dee
+  metadata.gz: f16df0211259f30c790efadaf922efe258d549d5
+  data.tar.gz: 4d2a670ebac6ddfdf7bdf27de563efdc20adfc74
 SHA512:
-  metadata.gz: d4b1d68005a5af7ba02208d198dcc91753fffa25d02178103942efe0474154478cf41e8e70b140f6ef99f5eb246f598066d257664ed5147daa30c3c820a23f1d
-  data.tar.gz: 37b8bf25763ad0d623dba71f1184785d328a0998c174413ecd9c594d5cf1027ff7a17b32c1a5ad87e0c10cae2831b301917971b365a681870d22ac90428fd4d1
+  metadata.gz: 3c4379908512383a8328601c5dd13da3999c7492f9ca40b9b9e90809c9a210821616fb0da5eb80a443c7be19ae1c66127a4572816d38daf47b609fe66e78b0a1
+  data.tar.gz: d584525530951ec2d9fd65f071726a84442307e8ea466bbc7d275a0918cb30018e76688c176dd16a2846d5701d5294a36fd8d7991dab70e0fb2c7e1dc94b29f6

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Change Log
 
+## 1.3.0
+
+Performance improvements:
+
+- In the Rails, Rack, and Sinatra middlewares, request data is now gathered only when needed instead of in advance on every request. See [#194](https://github.com/rollbar/rollbar-gem/pull/194); fixes [#180](https://github.com/rollbar/rollbar-gem/issues/180)
+
+Possible breaking changes:
+
+- If the scope's `:request` or `:context` value is an object that responds to `:call`, those values will now be called when a a report is made (and their result will be used in the payload). This is very unlikely to affect anyone, but we're releasing this as a version bump just to be safe.
+
+
 ## 1.2.13
 
 New features:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.2.13)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.3.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https://rollbar.com).
@@ -9,7 +9,7 @@ Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https:/
 
 Add this line to your application's Gemfile:
 
-    gem 'rollbar', '~> 1.2.13'
+    gem 'rollbar', '~> 1.3.0'
 
 And then execute:
 

data/THANKS.md

@@ -16,6 +16,7 @@ Huge thanks to the following contributors (by github username). For the most up-
 - [firstbanco](https://github.com/firstbanco)
 - [flomotlik](https://github.com/flomotlik)
 - [Florent2](https://github.com/Florent2)
+- [gdeglin](https://github.com/gdeglin)
 - [gersmann](https://github.com/gersmann)
 - [grosser](https://github.com/grosser)
 - [ixti](https://github.com/ixti)

data/lib/rollbar.rb

@@ -220,6 +220,10 @@ module Rollbar
         data[:person] = data[:person].call if is_proc
       end
 
+      data[:request] = data[:request].call if data[:request].respond_to?(:call)
+      data[:context] = data[:context].call if data[:context].respond_to?(:call)
+      data.delete(:context) unless data[:context]
+
       schedule_payload(payload)
 
       log_instance_link(data)

data/lib/rollbar/middleware/rack/builder.rb

@@ -22,9 +22,8 @@ module Rollbar
         end
 
         def fetch_scope(env)
-          request_data = extract_request_data_from_rack(env)
           {
-            :request => request_data,
+            :request => proc { extract_request_data_from_rack(env) },
             :person => person_data_proc(env)
           }
         rescue Exception => e

data/lib/rollbar/middleware/rails/rollbar.rb

@@ -13,6 +13,8 @@ module Rollbar
         end
 
         def call(env)
+          self.request_data = nil
+
           Rollbar.reset_notifier!
 
           env['rollbar.scope'] = scope = fetch_scope(env)
@@ -34,17 +36,28 @@ module Rollbar
         end
 
         def fetch_scope(env)
-          request_data = extract_request_data_from_rack(env)
-
           # Scope a new notifier with request data and a Proc for person data
           # for any reports that happen while a controller is handling a request
+
           {
-            :request => request_data,
+            :request => proc { request_data(env) },
             :person => person_data_proc(env),
-            :context => context(request_data)
+            :context => proc { context(request_data(env)) }
           }
         end
 
+        def request_data(env)
+          Thread.current[:'_rollbar.rails.request_data'] ||= extract_request_data(env)
+        end
+
+        def request_data=(value)
+          Thread.current[:'_rollbar.rails.request_data'] = value
+        end
+
+        def extract_request_data(env)
+          extract_request_data_from_rack(env)
+        end
+
         def person_data_proc(env)
           block = proc { extract_person_data_from_controller(env) }
           return block unless defined?(ActiveRecord::Base)

data/lib/rollbar/middleware/sinatra.rb

@@ -28,9 +28,8 @@ module Rollbar
       end
 
       def fetch_scope(env)
-        request_data = extract_request_data_from_rack(env)
         {
-          :request => request_data,
+          :request => proc { extract_request_data_from_rack(env) },
           :person => person_data_proc(env)
         }
       rescue Exception => e

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.2.13"
+  VERSION = "1.3.0"
 end

data/spec/rollbar/middleware/sinatra_spec.rb

@@ -31,7 +31,7 @@ describe Rollbar::Middleware::Sinatra, :reconfigure_notifier => true do
   let(:logger_mock) { double('logger').as_null_object }
 
   before do
-    Rollbar.reconfigure do |config|
+    Rollbar.configure do |config|
       config.logger = logger_mock
       config.framework = 'Sinatra'
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.2.13
+  version: 1.3.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-05 00:00:00.000000000 Z
+date: 2014-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json