rollbar 0.9.9 → 0.9.10

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+**0.9.10**
+- Add :secret_token to default scrub_fields list
+- Session params are now scrubbed
+
 **0.9.9**
 - Fix capistrano recipe on 1.9.2 ([#36](https://github.com/rollbar/rollbar-gem/pull/36))
 - Add example of disable "test" env to initializer template

data/lib/rollbar/configuration.rb

@@ -47,7 +47,7 @@ module Rollbar
       @person_email_method = 'email'
       @project_gems = []
       @scrub_fields = [:passwd, :password, :password_confirmation, :secret,
-                       :confirm_password, :password_confirmation]
+                       :confirm_password, :password_confirmation, :secret_token]
       @use_async = false
       @use_eventmachine = false
       @web_base = DEFAULT_WEB_BASE

data/lib/rollbar/request_data_extractor.rb

@@ -16,6 +16,7 @@ module Rollbar
       cookies = rollbar_filtered_params(sensitive_params, rollbar_request_cookies(env))
       get_params = rollbar_filtered_params(sensitive_params, rollbar_get_params(env))
       post_params = rollbar_filtered_params(sensitive_params, rollbar_post_params(env))
+      session = rollbar_filtered_params(sensitive_params, env['rack.session.options'])
     
       {
         :params => get_params.merge(post_params).merge(request_params),
@@ -25,7 +26,7 @@ module Rollbar
         :GET => get_params,
         :POST => post_params,
         :cookies => cookies,
-        :session => env['rack.session.options'],
+        :session => session,
         :method => rollbar_request_method(env)
       }
     end
@@ -90,21 +91,25 @@ module Rollbar
     end
 
     def rollbar_filtered_params(sensitive_params, params)
-      params.inject({}) do |result, (key, value)|
-        if sensitive_params.include?(key.to_sym)
-          result[key] = '*' * (value.length rescue 8)
-        elsif value.is_a?(Hash)
-          result[key] = rollbar_filtered_params(sensitive_params, value)
-        elsif ATTACHMENT_CLASSES.include?(value.class.name)
-          result[key] = {
-            :content_type => value.content_type,
-            :original_filename => value.original_filename,
-            :size => value.tempfile.size
-          } rescue 'Uploaded file'
-        else
-          result[key] = value
+      if params.nil?
+        {}
+      else
+        params.inject({}) do |result, (key, value)|
+          if sensitive_params.include?(key.to_sym)
+            result[key] = '*' * (value.length rescue 8)
+          elsif value.is_a?(Hash)
+            result[key] = rollbar_filtered_params(sensitive_params, value)
+          elsif ATTACHMENT_CLASSES.include?(value.class.name)
+            result[key] = {
+              :content_type => value.content_type,
+              :original_filename => value.original_filename,
+              :size => value.tempfile.size
+            } rescue 'Uploaded file'
+          else
+            result[key] = value
+          end
+          result
         end
-        result
       end
     end
 

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.9.9"
+  VERSION = "0.9.10"
 end

data/spec/controllers/home_controller_spec.rb

@@ -91,10 +91,11 @@ describe HomeController do
 
       it "should scrub the default scrub_fields" do
         params = {
-          :passwd => "hidden",
-          :password => "hidden",
-          :secret => "hidden",
-          :notpass => "visible"
+          :passwd       => "hidden",
+          :password     => "hidden",
+          :secret       => "hidden",
+          :notpass      => "visible",
+          :secret_token => "f6805fea1cae0fb79c5e63bbdcd12bc6",
         }
 
         filtered = controller.send(:rollbar_filtered_params, Rollbar.configuration.scrub_fields, params)
@@ -103,6 +104,7 @@ describe HomeController do
         filtered[:password].should == "******"
         filtered[:secret].should == "******"
         filtered[:notpass].should == "visible"
+        filtered[:secret_token].should == "*" * 32
       end
 
       it "should scrub custom scrub_fields" do

data/spec/requests/home_spec.rb

@@ -18,6 +18,8 @@ describe HomeController do
     it "should report uncaught exceptions" do
       expect{ get 'current_user', nil, :cookie => '8%B' }.to raise_exception
 
+      Rollbar.last_report.should_not be_nil
+
       exception_info = Rollbar.last_report[:body][:trace][:exception]
       exception_info[:class].should == 'ArgumentError'
       exception_info[:message].should == 'invalid %-encoding (8%B)'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.9.9
+  version: 0.9.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-17 00:00:00.000000000 Z
+date: 2013-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -300,3 +300,4 @@ test_files:
 - spec/rollbar_spec.rb
 - spec/spec_helper.rb
 - spec/support/devise.rb
+has_rdoc: