rollbar 0.9.7 → 0.9.8

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change Log
 
+**0.9.8**
+- Fix bug introduced in 0.9.0 where setting `config.enabled = false` in `config/initializers/rollbar.rb` would be overwritten by subsequent calls to `Rollbar.configure` (as happens normally when using inside Rails).
+
 **0.9.7**
 - Use `include?` instead of `in?` for filtering (see [#34](https://github.com/rollbar/rollbar-gem/pull/34))
 

data/lib/rollbar.rb

@@ -36,7 +36,10 @@ module Rollbar
     #     config.access_token = 'abcdefg'
     #   end
     def configure
-      configuration.enabled = true
+      # if configuration.enabled has not been set yet (is still 'nil'), set to true.
+      if configuration.enabled.nil?
+        configuration.enabled = true
+      end
       yield(configuration)
     end
 

data/lib/rollbar/configuration.rb

@@ -33,7 +33,7 @@ module Rollbar
     def initialize
       @async_handler = nil
       @default_logger = lambda { Logger.new(STDERR) }
-      @enabled = false  # set to true when configure is called
+      @enabled = nil  # set to true when configure is called
       @endpoint = DEFAULT_ENDPOINT
       @exception_level_filters = {
         'ActiveRecord::RecordNotFound' => 'warning',

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.9.7"
+  VERSION = "0.9.8"
 end

data/spec/rollbar_spec.rb

@@ -38,9 +38,28 @@ describe Rollbar do
       end
     end
 
+    it 'should be enabled when freshly configured' do
+      Rollbar.configuration.enabled.should == true
+    end
+
     it 'should not be enabled when not configured' do
       Rollbar.unconfigure
       
+      Rollbar.configuration.enabled.should be_nil
+      Rollbar.report_exception(@exception).should == 'disabled'
+    end
+
+    it 'should stay disabled if configure is called again' do
+      Rollbar.unconfigure
+
+      # configure once, setting enabled to false.
+      Rollbar.configure do |config|
+        config.enabled = false
+      end
+
+      # now configure again (perhaps to change some other values)
+      Rollbar.configure do |config| end
+      
       Rollbar.configuration.enabled.should == false
       Rollbar.report_exception(@exception).should == 'disabled'
     end
@@ -439,7 +458,7 @@ describe Rollbar do
 
   # configure with some basic params
   def configure
-    Rollbar.configure do |config|
+    Rollbar.reconfigure do |config|
       # special test access token
       config.access_token = test_access_token
       config.logger = ::Rails.logger

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.9.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-11 00:00:00.000000000 Z
+date: 2013-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -300,4 +300,3 @@ test_files:
 - spec/rollbar_spec.rb
 - spec/spec_helper.rb
 - spec/support/devise.rb
-has_rdoc: