rollbar 0.9.4 → 0.9.6

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+**0.9.6**
+- Fix for Rails 4 support
+
+**0.9.5**
+- Support for configuring the access token with an environment variable.
+
 **0.9.4**
 - Fixed issue using rollbar-gem outside of Rails
 - Clarified the "details: " link log message

data/README.md

@@ -20,7 +20,23 @@ Then, run the following command from your rails root:
 
     $ rails generate rollbar YOUR_ROLLBAR_PROJECT_ACCESS_TOKEN
 
-That will create the file `config/initializers/rollbar.rb`, which holds the configuration values (currently just your access token) and is all you need to use Rollbar with Rails.
+That will create the file `config/initializers/rollbar.rb`, which holds the configuration values (currently just your access token).
+
+If you want to store your access token outside of your repo, run the same command without arguments:
+
+    $ rails generate rollbar
+
+Then, create an environment variable `ROLLBAR_ACCESS_TOKEN` and set it to your server-side access token.
+
+    $ export ROLLBAR_ACCESS_TOKEN=YOUR_ROLLBAR_PROJECT_ACCESS_TOKEN
+
+or
+   
+    $ heroku config:add ROLLBAR_ACCESS_TOKEN=YOUR_ROLLBAR_PROJECT_ACCESS_TOKEN
+
+if you are using Heroku.
+
+That's all you need to use Rollbar with Rails.
 
 To confirm that it worked, run:
 

data/THANKS

@@ -4,9 +4,11 @@ arr-ee
 dimko
 firstbanco
 JoshuaOSHickman
+juggler
 kavu
 magnolia-fan
 mipearson
+siong1987
 trisweb
 tysontate
 wbond

data/lib/generators/rollbar/rollbar_generator.rb

@@ -4,19 +4,29 @@ require 'rails/generators/named_base'
 module Rollbar
   module Generators
     class RollbarGenerator < ::Rails::Generators::Base
-      argument :access_token, :type => :string, :banner => 'access_token'
+      argument :access_token, :type => :string, :banner => 'access_token', :default => :use_env_sentinel
 
       source_root File.expand_path(File.join(File.dirname(__FILE__), 'templates'))
 
       def create_initializer
-        puts "creating initializer..."
+        say "creating initializer..."
         if access_token_configured?
-          puts "It looks like you've already configured Rollbar."
-          puts "To re-create the config file, remove it first: config/initializers/rollbar.rb"
+          say "It looks like you've already configured Rollbar."
+          say "To re-create the config file, remove it first: config/initializers/rollbar.rb"
           exit
         end
 
-        puts "access token: " << access_token
+        if access_token === :use_env_sentinel
+          say "Generator run without an access token; assuming you want to configure using an environment variable."
+          say "You'll need to add an environment variable ROLLBAR_ACCESS_TOKEN with your access token:"
+          say "\n$ export ROLLBAR_ACCESS_TOKEN=yourtokenhere"
+          say "\nIf that's not what you wanted to do:"
+          say "\n$ rm config/initializers/rollbar.rb"
+          say "$ rails generate rollbar yourtokenhere"
+          say "\n"
+        else
+          say "access token: " << access_token
+        end
 
         template 'initializer.rb', 'config/initializers/rollbar.rb',
           :assigns => { :access_token => access_token_expr }
@@ -24,25 +34,12 @@ module Rollbar
         # TODO run rake test task
       end
 
-      #def add_options!(opt)
-      #  opt.on('-a', '--access-token=token', String, "Your Rollbar project access token") { |v| options[:access_token] = v }
-      #end
-#
-#      def manifest
-#        if !access_token_configured? && !options[:access_token]
-#          puts "access_token is required. Pass --access-token=YOUR_ACCESS_TOKEN"
-#          exit
-#        end
-#        
-#        record do |m|
-#          m.template 'initializer.rb', 'config/initializers/rollbar.rb',
-#            :assigns => { :access_token => access_token_expr }
-#          # TODO run rake test task
-#        end
-#      end
-
       def access_token_expr
-        "'#{access_token}'"
+        if access_token === :use_env_sentinel
+          "ENV['ROLLBAR_ACCESS_TOKEN']"
+        else
+          "'#{access_token}'"
+        end
       end
 
       def access_token_configured?

data/lib/rollbar/rake_tasks.rb

@@ -44,12 +44,12 @@ namespace :rollbar do
         nil
       end
     end
-    
+
     class RollbarTestController < ApplicationController; end
 
     Rails.application.routes_reloader.execute_if_updated
     Rails.application.routes.draw do
-      match 'verify' => 'application#verify', :as => 'verify'
+      get 'verify' => 'application#verify', :as => 'verify'
     end
 
     puts "Processing..."

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.9.4"
+  VERSION = "0.9.6"
 end

data/rollbar.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec-rails', '~> 2.12.0'
   gem.add_development_dependency 'database_cleaner', '>= 0.9.1'
   gem.add_development_dependency 'girl_friday', '>= 0.11.1'
+  gem.add_development_dependency 'genspec', '>= 0.2.7'
 end

data/spec/generators/rollbar/rollbar_generator_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe :rollbar do
+  context "with no arguments" do
+    it "outputs a help message" do
+      subject.should output(/You'll need to add an environment variable ROLLBAR_ACCESS_TOKEN with your access token/)
+    end
+
+    it "generates a Rollbar initializer with ENV" do
+      subject.should generate("config/initializers/rollbar.rb") { |content|
+        content.should =~ /config.access_token = ENV\['ROLLBAR_ACCESS_TOKEN'\]/
+      }
+    end
+  end
+
+  with_args 'aaaabbbbccccddddeeeeffff00001111' do
+    it "generates a Rollbar initializer with access token" do
+      subject.should generate("config/initializers/rollbar.rb") do |content|
+        content.should =~ /aaaabbbbccccddddeeeeffff00001111/
+        content.should =~ /config.access_token = 'aaaabbbbccccddddeeeeffff00001111'/
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,7 @@ ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../dummyapp/config/environment', __FILE__)
 require 'rspec/rails'
 require 'database_cleaner'
+require 'genspec'
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-20 00:00:00.000000000 Z
+date: 2013-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -107,6 +107,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.11.1
+- !ruby/object:Gem::Dependency
+  name: genspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.2.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.2.7
 description: Rails plugin to catch and send exceptions to Rollbar
 email:
 - brian@rollbar.com
@@ -197,6 +213,7 @@ files:
 - spec/dummyapp/public/500.html
 - spec/dummyapp/public/favicon.ico
 - spec/dummyapp/script/rails
+- spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
 - spec/rollbar_spec.rb
 - spec/spec_helper.rb
@@ -278,6 +295,7 @@ test_files:
 - spec/dummyapp/public/500.html
 - spec/dummyapp/public/favicon.ico
 - spec/dummyapp/script/rails
+- spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
 - spec/rollbar_spec.rb
 - spec/spec_helper.rb