rollbar 0.12.16 → 0.12.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3130e2b2d1b3c726cbca30e0a4e8da37ee7dca3e
-  data.tar.gz: 8eebb4ee086cf014aeaac40b1ca1fc2077c32c05
+  metadata.gz: e3d027a33b4115d70243cffed4280b726a4dc269
+  data.tar.gz: 6718be9dc5ae48738dd4c220fb06f9f06a45e990
 SHA512:
-  metadata.gz: 5a41834e01227318af18e5255d911af94388897c683c6d63a789937a8d57b747417d9a0305ed563d4de4c506b0b4348c1a15d7abf6ce6d389ad458191f9697a9
-  data.tar.gz: f5137b1973af0fb0766e91f11e741de5965697c67915335104e54f82d05da029964dcdabb46285dbf11c13beb88d70710747b01b146c18640864493984661419
+  metadata.gz: e6e16401feb719f6f2c270db7f478d23e125ed2b86ded864ffd9f4bfcad1a151cf4b6d9f0e725bfaf6b539a3bc8daa3af243ba4d85b029f8b75b3a5483e63e9b
+  data.tar.gz: c7f031fdb97c8a935b302ed6531e815d11dee411b11f0b7ba7dcfe4f8f427aa18941e72ce5dcd3780e573ac3a96e5d123cec758fac3dbd302b1d792e62273393

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+**0.12.17**
+- Replace usage of `puts` with a configurable logger in different areas of the notifier
+- Fix error in `RollbarRequestStore` when `rollbar_person_data` isn't defined for a controller
+
 **0.12.16**
 - Scrub fields are now converted to a regular expression for broader param name matching
 - Save ActionDispatch request_id in reports if present

data/THANKS.md

@@ -10,19 +10,22 @@ Huge thanks to the following contributors (by github username). For the most up-
 - [derekrockwell](https://github.com/derekrockwell)
 - [dimko](https://github.com/dimko)
 - [dlackty](https://github.com/dlackty)
-- [fabsays](https://github.com/fabsays)
+- [fab](https://github.com/fab)
 - [firstbanco](https://github.com/firstbanco)
+- [Florent2](https://github.com/Florent2)
 - [ixti](https://github.com/ixti)
 - [jeremyvdw](https://github.com/jeremyvdw)
 - [johnknott](https://github.com/johnknott)
 - [JoshuaOSHickman](https://github.com/JoshuaOSHickman)
 - [juggler](https://github.com/juggler)
 - [kavu](https://github.com/kavu)
+- [lanej](https://github.com/lanej)
 - [magnolia-fan](https://github.com/magnolia-fan)
 - [mauricio](https://github.com/mauricio)
 - [metaskills](https://github.com/metaskills)
 - [miloops](https://github.com/miloops)
 - [mipearson](https://github.com/mipearson)
+- [mrgordon](https://github.com/mrgordon)
 - [petergoldstein](https://github.com/petergoldstein)
 - [pmen](https://github.com/pmen)
 - [rogercampos](https://github.com/rogercampos)

data/lib/rollbar.rb

@@ -189,6 +189,42 @@ module Rollbar
       end
     end
 
+    # wrappers around logger methods
+    def log_error(message)
+      begin
+        logger.error message
+      rescue => e
+        puts "[Rollbar] Error logging error:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+
+    def log_info(message)
+      begin
+        logger.info message
+      rescue => e
+        puts "[Rollbar] Error logging info:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+
+    def log_warning(message)
+      begin
+        logger.warn message
+      rescue => e
+        puts "[Rollbar] Error logging warning:"
+        puts "[Rollbar] #{message}"
+      end
+    end
+    def log_debug(message)
+      begin
+        logger.debug message
+      rescue => e
+        puts "[Rollbar] Error logging debug"
+        puts "[Rollbar] #{message}"
+      end
+    end
+
     private
     
     def attach_request_data(payload, request_data)
@@ -488,34 +524,6 @@ module Rollbar
       end
     end
 
-    # wrappers around logger methods
-    def log_error(message)
-      begin
-        logger.error message
-      rescue => e
-        puts "[Rollbar] Error logging error:"
-        puts "[Rollbar] #{message}"
-      end
-    end
-
-    def log_info(message)
-      begin
-        logger.info message
-      rescue => e
-        puts "[Rollbar] Error logging info:"
-        puts "[Rollbar] #{message}"
-      end
-    end
-
-    def log_warning(message)
-      begin
-        logger.warn message
-      rescue => e
-        puts "[Rollbar] Error logging warning:"
-        puts "[Rollbar] #{message}"
-      end
-    end
-
     # Reports an internal error in the Rollbar library. This will be reported within the configured
     # Rollbar project. We'll first attempt to provide a report including the exception traceback.
     # If that fails, we'll fall back to a more static failsafe response.

data/lib/rollbar/active_record_extension.rb

@@ -4,7 +4,7 @@ module Rollbar
 
     def report_validation_errors_to_rollbar
       self.errors.full_messages.each do |error|
-        logger.info "[Rollbar] Reporting form validation error: #{error} for #{self.to_s}"
+        Rollbar.log_info "[Rollbar] Reporting form validation error: #{error} for #{self.to_s}"
         Rollbar.report_message("Form Validation Error: #{error} for #{self.to_s}")
       end
     end

data/lib/rollbar/better_errors.rb

@@ -17,19 +17,18 @@ module BetterErrors
         person_data = controller.rollbar_person_data rescue nil
         exception_data = Rollbar.report_exception(exception, request_data, person_data)
       rescue => e
-        # TODO use logger here?
-        puts "[Rollbar] Exception while reporting exception to Rollbar: #{e}"
+        Rollbar.log_warning "[Rollbar] Exception while reporting exception to Rollbar: #{e}"
       end
 
       # if an exception was reported, save uuid in the env
       # so it can be displayed to the user on the error page
       if exception_data.is_a?(Hash)
         env['rollbar.exception_uuid'] = exception_data[:uuid]
-        puts "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
+        Rollbar.log_info "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
       elsif exception_data == 'disabled'
-        puts "[Rollbar] Exception not reported because Rollbar is disabled"
+        Rollbar.log_info "[Rollbar] Exception not reported because Rollbar is disabled"
       elsif exception_data == 'ignored'
-        puts "[Rollbar] Exception not reported because it was ignored"
+        Rollbar.log_info "[Rollbar] Exception not reported because it was ignored"
       end
 
       # now continue as normal

data/lib/rollbar/exception_reporter.rb

@@ -3,29 +3,21 @@ module Rollbar
     include RequestDataExtractor
 
     def report_exception_to_rollbar(env, exception)
-      rollbar_debug "[Rollbar] Reporting exception: #{exception.message}", :error
+      Rollbar.log_error "Reporting exception: #{exception.message}"
       request_data = extract_request_data_from_rack(env)
       person_data = extract_person_data_from_controller(env)
       exception_data = Rollbar.report_exception(exception, request_data, person_data)
       
       if exception_data.is_a?(Hash)
         env['rollbar.exception_uuid'] = exception_data[:uuid]
-        rollbar_debug "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
+        Rollbar.log_debug "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
       elsif exception_data == 'disabled'
-        rollbar_debug "[Rollbar] Exception not reported because Rollbar is disabled"
+        Rollbar.log_debug "[Rollbar] Exception not reported because Rollbar is disabled"
       elsif exception_data == 'ignored'
-        rollbar_debug "[Rollbar] Exception not reported because it was ignored"
+        Rollbar.log_debug "[Rollbar] Exception not reported because it was ignored"
       end
     rescue => e
-      rollbar_debug "[Rollbar] Exception while reporting exception to Rollbar: #{e.message}"
-    end
-
-    def rollbar_debug(message, level = :debug)
-      if defined?(Rails)
-        ::Rails.logger.send(level, message)
-      else
-        puts message
-      end
+      Rollbar.log_debug "[Rollbar] Exception while reporting exception to Rollbar: #{e.message}"
     end
   end
 end

data/lib/rollbar/goalie.rb

@@ -12,19 +12,18 @@ module Goalie
         person_data = controller.rollbar_person_data rescue nil
         exception_data = Rollbar.report_exception(exception, request_data, person_data)
       rescue => e
-        # TODO use logger here?
-        puts "[Rollbar] Exception while reporting exception to Rollbar: #{e}" 
+        Rollbar.log_warning "[Rollbar] Exception while reporting exception to Rollbar: #{e}" 
       end
       
       # if an exception was reported, save uuid in the env
       # so it can be displayed to the user on the error page
       if exception_data.is_a?(Hash)
         env['rollbar.exception_uuid'] = exception_data[:uuid]
-        puts "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
+        Rollbar.log_info "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
       elsif exception_data == 'disabled'
-        puts "[Rollbar] Exception not reported because Rollbar is disabled"
+        Rollbar.log_info "[Rollbar] Exception not reported because Rollbar is disabled"
       elsif exception_data == 'ignored'
-        puts "[Rollbar] Exception not reported because it was ignored"
+        Rollbar.log_info "[Rollbar] Exception not reported because it was ignored"
       end
 
       # now continue as normal

data/lib/rollbar/middleware/rails/rollbar_request_store.rb

@@ -13,7 +13,7 @@ module Rollbar
             @app.call(env)
           rescue
             controller = env["action_controller.instance"]
-            if controller
+            if controller and controller.respond_to? :rollbar_person_data
               env['rollbar.person_data'] = controller.rollbar_person_data
             end
             raise

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "0.12.16" 
+  VERSION = "0.12.17" 
 end

data/spec/controllers/home_controller_spec.rb

@@ -9,6 +9,7 @@ describe HomeController do
     Rollbar.configure do |config|
       config.access_token = 'aaaabbbbccccddddeeeeffff00001111'
       config.logger = logger_mock
+      config.request_timeout = 60
     end
   end
   

data/spec/dummyapp/config/initializers/rollbar.rb

@@ -1,6 +1,7 @@
 require 'rollbar/rails'
 Rollbar.configure do |config|
   config.access_token = 'aaaabbbbccccddddeeeeffff00001111'
+  config.request_timeout = 60
 
   # By default, Rollbar will try to call the `current_user` controller method
   # to fetch the logged-in user object, and then call that object's `id`,

data/spec/requests/home_spec.rb

@@ -11,6 +11,7 @@ describe HomeController do
       config.root = ::Rails.root
       config.framework = "Rails: #{::Rails::VERSION::STRING}"
       config.logger = logger_mock
+      config.request_timeout = 60
     end
   end
 

data/spec/rollbar_spec.rb

@@ -865,6 +865,7 @@ describe Rollbar do
       config.logger = ::Rails.logger
       config.root = ::Rails.root
       config.framework = "Rails: #{::Rails::VERSION::STRING}"
+      config.request_timeout = 60
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 0.12.16
+  version: 0.12.17
 platform: ruby
 authors:
 - Brian Rue
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-12 00:00:00.000000000 Z
+date: 2014-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json