rollable 0.0.1 → 0.0.2

data/lib/rollable/base.rb

@@ -1,3 +1,5 @@
+# TODO: Because of the endless blocks, some calls are too nested, needs to be fixed. Even more seperate methods
+# in seperate files would clean in up.
 module Rollable
   module Base
     def self.included(base)
@@ -19,12 +21,34 @@ module Rollable
           # Hackety hack.
           class << self; attr_reader :rollables, :role_names; end;
         end
-
+        
+        set_target_model_helpers
         set_relations_on_rollables
         set_role_validations
       end
 
       private
+
+      # DISCLAIMER: Headache and on the airport, hush.
+      # Helpers for target models like has_owner? and get_owners
+      def set_target_model_helpers
+        @rollables.select { |r| r.is_a?(String) }.each do |model|
+          model = model.constantize
+          @role_names.each do |role_name|
+            model.class_eval do
+              define_method("has_#{role_name}?") do
+                self.roles.where("name = ? ", role_name).count > 0
+              end
+
+              # TODO: get_#{role_name} doesn't sound very rubyish
+              define_method("get_#{role_name.pluralize}") do
+                self.roles.where("name = ? ", role_name).collect(&:user)
+              end
+            end
+          end
+        end
+      end
+
       def set_role_validations
         # Yugh, scope and self, ugly but it works.
         rollables = @rollables
@@ -47,12 +71,14 @@ module Rollable
               has_many :roles, :as => 'rollable'  # Define the relationship <img src="http://www.timonv.nl/wp-includes/images/smilies/icon_smile.gif" alt=":-)" class="wp-smiley">
             end
           else
+            # TODO: Check should be made earlier
             raise "#{model} is not an ActiveRecord object!"  #Again, just to be sure and nice.
           end
         end
       end
     end
 
+    # TODO: Don't need method_missing no more, use dynamic dispatch instead.
     def method_missing(method, *args)
       if method =~ /^is_([a-z]+)(?:_(?:on|of))?\?$/ #Common spell to match against regex
         role = $1

data/lib/rollable/version.rb

@@ -1,3 +1,3 @@
 module Rollable
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/rollable.gemspec

@@ -19,5 +19,6 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
   s.add_dependency "rails", ">= 3.0.0"
-  s.add_dependency "rspec"
+  s.add_dependency "rspec", "> 2"
+  s.add_dependency "rspec-rails"
 end

data/spec/rollable_test/spec/models/horse_spec.rb

@@ -1,5 +1,25 @@
 require 'spec_helper'
 
 describe Horse do
-  pending "add some examples to (or delete) #{__FILE__}"
+  context "Target helper methods" do
+    it "should have the methods" do
+      horse = Horse.create
+      horse.should respond_to("has_rider?")
+      horse.should respond_to("get_riders")
+    end
+
+    it "should respond correctly without roles" do
+      horse = Horse.create
+      horse.has_rider?.should eq(false)
+      horse.get_riders.should eq([])
+    end
+
+    it "should return correct values if roles are set" do
+      horse = Horse.create
+      user = User.create
+      user.roles.create(:rollable => horse, :name => "rider")
+      horse.has_rider?.should eq(true)
+      horse.get_riders.should include(user)
+    end
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: rollable
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Timon Vonk
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-23 00:00:00 Z
+date: 2011-05-05 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -27,13 +27,24 @@ dependencies:
   name: rspec
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">"
+      - !ruby/object:Gem::Version 
+        version: "2"
+  type: :runtime
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: rspec-rails
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
         version: "0"
   type: :runtime
-  version_requirements: *id002
+  version_requirements: *id003
 description: This gem adds agnostic roles for authorization to Rails.
 email: 
 - mail@timonv.nl