rolify 3.2.0 → 3.3.0

data/spec/generators/rolify/{role/role_generator_spec.rb → rolify_activerecord_generator_spec.rb}

@@ -1,11 +1,12 @@
-require 'spec_helper'
+require 'generators_helper'
 
+require 'rails/all'
 # Generators are not automatically loaded by Rails
-require 'generators/rolify/role/role_generator'
+require 'generators/rolify/rolify_generator'
 
-describe Rolify::Generators::RoleGenerator do
+describe Rolify::Generators::RolifyGenerator, :if => ENV['ADAPTER'] == 'active_record' do
   # Tell the generator where to put its output (what it thinks of as Rails.root)
-  destination File.expand_path("../../../../../tmp", __FILE__)
+  destination File.expand_path("../../../../tmp", __FILE__)
   teardown :cleanup_destination_root
   
   before { 
@@ -16,15 +17,19 @@ describe Rolify::Generators::RoleGenerator do
     FileUtils.rm_rf destination_root
   end
 
-  describe 'no arguments' do
-    before(:all) { arguments [] }
+  describe 'specifying only Role class name' do
+    before(:all) { arguments %w(Role) }
 
     before { 
       capture(:stdout) {
         generator.create_file "app/models/user.rb" do
-          "class User < ActiveRecord::Base\nend"
+          <<-RUBY
+          class User < ActiveRecord::Base
+          end
+          RUBY
         end
       }
+      require File.join(destination_root, "app/models/user.rb")
       run_generator 
     }
     
@@ -58,7 +63,7 @@ describe Rolify::Generators::RoleGenerator do
     end
   end
 
-  describe 'specifying user and role names' do
+  describe 'specifying User and Role class names' do
     before(:all) { arguments %w(AdminRole AdminUser) }
     
     before { 
@@ -67,6 +72,7 @@ describe Rolify::Generators::RoleGenerator do
           "class AdminUser < ActiveRecord::Base\nend"
         end
       }
+      require File.join(destination_root, "app/models/admin_user.rb")
       run_generator
     }
     
@@ -74,12 +80,12 @@ describe Rolify::Generators::RoleGenerator do
       subject { file('config/initializers/rolify.rb') }
       
       it { should exist }
-      it { should contain "Rolify.configure do |config|"}
+      it { should contain "Rolify.configure(\"AdminRole\") do |config|"}
       it { should contain "# config.use_dynamic_shortcuts" }
       it { should contain "# config.use_mongoid" }
     end
     
-    describe 'app/models/rank.rb' do
+    describe 'app/models/admin_role.rb' do
       subject { file('app/models/admin_role.rb') }
       
       it { should exist }
@@ -103,51 +109,55 @@ describe Rolify::Generators::RoleGenerator do
     end
   end
   
-  describe 'specifying orm adapter' do 
-    before(:all) { arguments [ "Role", "User", "mongoid" ] }
+  describe 'specifying namespaced User and Role class names' do
+    before(:all) { arguments %w(Admin::Role Admin::User) }
     
     before { 
       capture(:stdout) {
-        generator.create_file "app/models/user.rb" do
-<<-CLASS 
-class User
-  include Mongoid::Document
-
-  field :login, :type => String
-end
-CLASS
+        generator.create_file "app/models/admin/user.rb" do
+          <<-RUBY
+          module Admin
+            class User < ActiveRecord::Base
+              self.table_name_prefix = 'admin_'
+            end
+          end
+          RUBY
         end
       }
+      require File.join(destination_root, "app/models/admin/user.rb")
       run_generator
     }
-      
+    
     describe 'config/initializers/rolify.rb' do
       subject { file('config/initializers/rolify.rb') }
+      
       it { should exist }
-      it { should contain "Rolify.configure do |config|"}
-      it { should_not contain "# config.use_mongoid" }
+      it { should contain "Rolify.configure(\"Admin::Role\") do |config|"}
       it { should contain "# config.use_dynamic_shortcuts" }
+      it { should contain "# config.use_mongoid" }
     end
     
-    describe 'app/models/role.rb' do
-      subject { file('app/models/role.rb') }
+    describe 'app/models/admin/role.rb' do
+      subject { file('app/models/admin/role.rb') }
+      
       it { should exist }
-      it { should contain "class Role\n" }
-      it { should contain "has_and_belongs_to_many :users\n" }
+      it { should contain "class Admin::Role < ActiveRecord::Base" }
+      it { should contain "has_and_belongs_to_many :admin_users, :join_table => :admin_users_admin_roles" }
       it { should contain "belongs_to :resource, :polymorphic => true" }
-      it { should contain "field :name, :type => String" }
-      it { should contain "index({ :name => 1 }, { :unique => true })" }
-      it { should contain "  index({\n"
-                          "      { :name => 1 },\n"
-                          "      { :resource_type => 1 },\n"
-                          "      { :resource_id => 1 }\n"
-                          "    },\n"
-                          "    { unique => true })"}
     end
     
-    describe 'app/models/user.rb' do
-      subject { file('app/models/user.rb') }
-      it { should contain /class User\n  include Mongoid::Document\n  rolify\n/ }
+    describe 'app/models/admin/user.rb' do
+      subject { file('app/models/admin/user.rb') }
+      
+      it { should contain /class User < ActiveRecord::Base\n  rolify :role_cname => 'Admin::Role'\n/ }
+    end
+    
+    describe 'migration file' do
+      subject { migration_file('db/migrate/rolify_create_admin_roles.rb') }
+      
+      it { should be_a_migration }
+      it { should contain "create_table(:admin_roles)" }
+      it { should contain "create_table(:admin_users_admin_roles, :id => false) do" }
     end
   end
-end
+end

data/spec/generators/rolify/rolify_mongoid_generator_spec.rb

@@ -0,0 +1,112 @@
+require 'generators_helper'
+
+require 'mongoid'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rolify/rolify_generator'
+
+describe Rolify::Generators::RolifyGenerator, :if => ENV['ADAPTER'] == 'mongoid' do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../tmp", __FILE__)
+  teardown :cleanup_destination_root
+  
+  before { 
+    prepare_destination
+  }
+  
+  def cleanup_destination_root
+    FileUtils.rm_rf destination_root
+  end
+
+  describe 'specifying ORM adapter' do 
+    before(:all) { arguments [ "Role", "User", "--orm=mongoid" ] }
+    
+    before { 
+      capture(:stdout) {
+        generator.create_file "app/models/user.rb" do
+<<-RUBY
+class User
+  include Mongoid::Document
+
+  field :login, :type => String
+end
+RUBY
+        end
+      }
+      require File.join(destination_root, "app/models/user.rb")
+      run_generator
+    }
+      
+    describe 'config/initializers/rolify.rb' do
+      subject { file('config/initializers/rolify.rb') }
+      it { should exist }
+      it { should contain "Rolify.configure do |config|"}
+      it { should_not contain "# config.use_mongoid" }
+      it { should contain "# config.use_dynamic_shortcuts" }
+    end
+    
+    describe 'app/models/role.rb' do
+      subject { file('app/models/role.rb') }
+      it { should exist }
+      it { should contain "class Role\n" }
+      it { should contain "has_and_belongs_to_many :users\n" }
+      it { should contain "belongs_to :resource, :polymorphic => true" }
+      it { should contain "field :name, :type => String" }
+      it { should contain "  index({\n"
+                          "      { :name => 1 },\n"
+                          "      { :resource_type => 1 },\n"
+                          "      { :resource_id => 1 }\n"
+                          "    },\n"
+                          "    { unique => true })"}
+    end
+    
+    describe 'app/models/user.rb' do
+      subject { file('app/models/user.rb') }
+      it { should contain /class User\n  include Mongoid::Document\n  rolify\n/ }
+    end
+  end
+  
+  describe 'specifying namespaced User and Role class names and ORM adapter' do
+    before(:all) { arguments %w(Admin::Role Admin::User --orm=mongoid) }
+    
+    before { 
+      capture(:stdout) {
+        generator.create_file "app/models/admin/user.rb" do
+<<-RUBY
+module Admin
+  class User
+    include Mongoid::Document
+  end
+end
+RUBY
+        end
+      }
+      require File.join(destination_root, "app/models/admin/user.rb")
+      run_generator
+    }
+    
+    describe 'config/initializers/rolify.rb' do
+      subject { file('config/initializers/rolify.rb') }
+      
+      it { should exist }
+      it { should contain "Rolify.configure(\"Admin::Role\") do |config|"}
+      it { should contain "# config.use_dynamic_shortcuts" }
+      it { should_not contain "# config.use_mongoid" }
+    end
+    
+    describe 'app/models/admin/role.rb' do
+      subject { file('app/models/admin/role.rb') }
+      
+      it { should exist }
+      it { should contain "class Admin::Role" }
+      it { should contain "has_and_belongs_to_many :admin_users" }
+      it { should contain "belongs_to :resource, :polymorphic => true" }
+    end
+    
+    describe 'app/models/admin/user.rb' do
+      subject { file('app/models/admin/user.rb') }
+      
+      it { should contain /class User\n    include Mongoid::Document\n  rolify :role_cname => 'Admin::Role'\n/ }
+    end
+  end
+end

data/spec/generators_helper.rb

@@ -0,0 +1,21 @@
+require 'rubygems'
+require "bundler/setup"
+
+require 'rolify'
+require 'rolify/matchers'
+require 'rails/all'
+
+require 'coveralls'
+Coveralls.wear_merged!
+
+module TestApp
+  class Application < ::Rails::Application
+    config.root = File.dirname(__FILE__)
+  end
+end
+
+require 'ammeter/init'
+
+ENV['ADAPTER'] ||= 'active_record'
+
+

data/spec/rolify/custom_spec.rb

@@ -2,26 +2,19 @@ require "spec_helper"
 require "rolify/shared_examples/shared_examples_for_roles"
 require "rolify/shared_examples/shared_examples_for_dynamic"
 require "rolify/shared_examples/shared_examples_for_scopes"
-require "rolify/shared_examples/shared_examples_for_callbacks"  
+require "rolify/shared_examples/shared_examples_for_callbacks"
 
 describe "Using Rolify with custom User and Role class names" do
-  it_behaves_like Rolify::Role do
-    let(:user_class) { Customer }
-    let(:role_class) { Privilege }
+  def user_class
+    Customer
   end
 
-  it_behaves_like "Role.scopes" do
-    let(:user_class) { Customer } 
-    let(:role_class) { Privilege }
-  end
-
-  it_behaves_like Rolify::Dynamic do
-    let(:user_class) { Customer } 
-    let(:role_class) { Privilege }
-  end
-
-  it_behaves_like "Rolify.callbacks" do
-    let(:user_class) { Customer }
-    let(:role_class) { Privilege }
+  def role_class
+    Privilege
   end
+  
+  it_behaves_like Rolify::Role
+  it_behaves_like "Role.scopes"
+  it_behaves_like Rolify::Dynamic
+  it_behaves_like "Rolify.callbacks"
 end

data/spec/rolify/matchers_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe 'have_role', focus: true do
+  let(:object) { Object.new }
+
+  it 'delegates to has_role?' do
+    object.should_receive(:has_role?).with(:read, 'Resource') { true }
+    object.should have_role(:read, 'Resource')
+  end
+
+  it 'reports a nice failure message for should' do
+    object.should_receive(:has_role?) { false }
+    expect{
+      object.should have_role(:read, 'Resource')
+    }.to raise_error('expected to have role :read "Resource"')
+  end
+
+  it 'reports a nice failure message for should_not' do
+    object.should_receive(:has_role?) { true }
+    expect{
+      object.should_not have_role(:read, 'Resource')
+    }.to raise_error('expected not to have role :read "Resource"')
+  end
+end

data/spec/rolify/namespace_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+require "rolify/shared_examples/shared_examples_for_roles"
+require "rolify/shared_examples/shared_examples_for_dynamic"
+require "rolify/shared_examples/shared_examples_for_scopes"
+require "rolify/shared_examples/shared_examples_for_callbacks"
+
+describe "Rolify.namespace" do
+  def user_class
+    Admin::Moderator
+  end
+
+  def role_class
+    Admin::Right
+  end
+  
+  def join_table
+    "moderators_rights"
+  end
+  
+  it_behaves_like Rolify::Role
+  it_behaves_like "Role.scopes"
+  it_behaves_like Rolify::Dynamic
+  it_behaves_like "Rolify.callbacks"
+end

data/spec/rolify/resource_spec.rb

@@ -3,16 +3,18 @@ require "spec_helper"
 describe Rolify::Resource do
   before(:all) do
     reset_defaults
-    User.rolify :role_cname => "Role"
-    Forum.resourcify :role_cname => "Role"
-    Group.resourcify :role_cname => "Role"
+    User.rolify
+    Forum.resourcify
+    Group.resourcify
+    Team.resourcify
     Role.destroy_all
   end
 
   # Users
   let(:admin)   { User.first }
   let(:tourist) { User.last }
-  
+  let(:captain) { User.where(:login => "god").first }
+
   # roles
   let!(:forum_role)      { admin.add_role(:forum, Forum.first) }
   let!(:godfather_role)  { admin.add_role(:godfather, Forum) }
@@ -20,6 +22,8 @@ describe Rolify::Resource do
   let!(:grouper_role)    { admin.add_role(:grouper, Group.first) }
   let!(:tourist_role)    { tourist.add_role(:forum, Forum.last) }
   let!(:sneaky_role)     { tourist.add_role(:group, Forum.first) }
+  let!(:captain_role)    { captain.add_role(:captain, Team.first) }
+  let!(:player_role)     { captain.add_role(:player, Team.last) }
 
   describe ".with_roles" do
     subject { Group }
@@ -27,19 +31,26 @@ describe Rolify::Resource do
     it { should respond_to(:find_roles).with(1).arguments }
     it { should respond_to(:find_roles).with(2).arguments }
 
-    context "with a role name as argument" do 
-      context "on the Forum class" do 
+    context "with a role name as argument" do
+      context "on the Forum class" do
         subject { Forum }
 
-        it "should include Forum instances with forum role" do 
+        it "should include Forum instances with forum role" do
           subject.with_role(:forum).should =~ [ Forum.first, Forum.last ]
         end
-        it "should include Forum instances with godfather role" do 
+        
+        it "should include Forum instances with godfather role" do
           subject.with_role(:godfather).should =~ Forum.all.to_a
         end
+        
+        it "should be able to modify the resource", :if => ENV['ADAPTER'] == 'active_record' do
+          forum_resource = subject.with_role(:forum).first
+          forum_resource.name = "modified name"
+          expect(forum_resource.save).not_to raise_error
+        end
       end
 
-      context "on the Group class" do 
+      context "on the Group class" do
         subject { Group }
 
         it "should include Group instances with group role" do
@@ -47,20 +58,27 @@ describe Rolify::Resource do
         end
       end
 
+      context "on a Group instance" do
+        subject { Group.last }
+
+        it "should ignore nil entries" do
+          subject.subgroups.with_role(:group).should =~ [ ]
+        end
+      end
     end
 
-    context "with an array of role names as argument" do 
-      context "on the Group class" do 
+    context "with an array of role names as argument" do
+      context "on the Group class" do
         subject { Group }
-        
-        it "should include Group instances with both group and grouper roles" do 
+
+        it "should include Group instances with both group and grouper roles" do
           subject.with_roles([:group, :grouper]).should =~ [ Group.first, Group.last ]
         end
       end
     end
 
     context "with a role name and a user as arguments" do
-      context "on the Forum class" do 
+      context "on the Forum class" do
         subject { Forum }
 
         it "should get all Forum instances binded to the forum role and the admin user" do
@@ -88,7 +106,7 @@ describe Rolify::Resource do
         end
       end
 
-      context "on the Group class" do 
+      context "on the Group class" do
         subject { Group }
 
         it "should get all resources binded to the group role and the admin user" do
@@ -102,7 +120,7 @@ describe Rolify::Resource do
     end
 
     context "with an array of role names and a user as arguments" do
-      context "on the Forum class" do 
+      context "on the Forum class" do
         subject { Forum }
 
         it "should get Forum instances binded to the forum and group roles and the tourist user" do
@@ -111,7 +129,7 @@ describe Rolify::Resource do
 
       end
 
-      context "on the Group class" do 
+      context "on the Group class" do
         subject { Group }
 
         it "should get Group instances binded to the group and grouper roles and the admin user" do
@@ -120,13 +138,20 @@ describe Rolify::Resource do
 
       end
     end
-
+    
+    context "with a model not having ID column" do
+      subject { Team }
+      
+      it "should find Team instance using team_code column" do
+        subject.with_roles([:captain, :player], captain).should =~ [ Team.first, Team.last ]
+      end
+    end
   end
 
   describe ".find_role" do
 
-    context "without using a role name parameter" do 
-      
+    context "without using a role name parameter" do
+
       context "on the Forum class" do
         subject { Forum }
 
@@ -151,7 +176,7 @@ describe Rolify::Resource do
 
       context "on the Group class" do
         subject { Group }
-        
+
         it "should get all roles binded to a Group class or instance" do
           subject.find_roles.to_a.should =~ [ group_role, grouper_role ]
         end
@@ -172,7 +197,7 @@ describe Rolify::Resource do
       end
     end
 
-    context "using a role name parameter" do 
+    context "using a role name parameter" do
       context "on the Forum class" do
         subject { Forum }
 
@@ -209,7 +234,7 @@ describe Rolify::Resource do
 
       context "on the Group class" do
         subject { Group }
-        
+
         context "without using a user parameter" do
           it "should get all roles binded to a Group class or instance and group role name" do
             subject.find_roles(:group).should include(group_role)
@@ -242,7 +267,7 @@ describe Rolify::Resource do
       end
     end
 
-    context "using :any as role name parameter" do 
+    context "using :any as role name parameter" do
       context "on the Forum class" do
         subject { Forum }
 
@@ -318,27 +343,27 @@ describe Rolify::Resource do
 
     it { should respond_to :roles }
 
-    context "on a Forum instance" do 
+    context "on a Forum instance" do
       its(:roles) { should eq([ forum_role, sneaky_role ]) }
-      its(:roles) { subject.should_not include(group_role, godfather_role, tourist_role) }
+      its(:roles) { should_not include(group_role, godfather_role, tourist_role) }
     end
 
     context "on a Group instance" do
       subject { Group.last }
 
-      its(:roles) { should eq([ group_role ]) } 
+      its(:roles) { should eq([ group_role ]) }
       its(:roles) { should_not include(forum_role, godfather_role, sneaky_role, tourist_role) }
-      
+
       context "when deleting a Group instance" do
-        subject do 
+        subject do
           Group.create(:name => "to delete")
         end
-        
+
         before do
           subject.roles.create :name => "group_role1"
           subject.roles.create :name => "group_role2"
         end
-        
+
         it "should remove the roles binded to this instance" do
           expect { subject.destroy }.to change { Role.count }.by(-2)
         end

data/spec/rolify/resourcifed_and_rolifed_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+describe "Resourcify and rolify on the same model" do
+  
+  before(:all) do
+    reset_defaults
+    Role.delete_all
+    HumanResource.delete_all
+  end
+  
+  let!(:user) do
+    user = HumanResource.new login: 'Samer' 
+    user.save
+    user
+  end
+  
+  it "should add the role to the user" do
+    expect { user.add_role :admin }.to change { user.roles.count }.by(1)
+  end
+      
+  it "should create a role to the roles collection" do
+    expect { user.add_role :moderator }.to change { Role.count }.by(1)
+  end
+end

data/spec/rolify/role_spec.rb

@@ -5,23 +5,16 @@ require "rolify/shared_examples/shared_examples_for_scopes"
 require "rolify/shared_examples/shared_examples_for_callbacks"
 
 describe Rolify do
-  it_behaves_like Rolify::Role do
-    let(:user_class) { User } 
-    let(:role_class) { Role }
+  def user_class
+    User
   end
 
-  it_behaves_like "Role.scopes" do
-    let(:user_class) { User } 
-    let(:role_class) { Role }
-  end
-
-  it_behaves_like Rolify::Dynamic do
-    let(:user_class) { User } 
-    let(:role_class) { Role }
-  end
-
-  it_behaves_like "Rolify.callbacks" do
-    let(:user_class) { User }
-    let(:role_class) { Role }
+  def role_class
+    Role
   end
+  
+  it_behaves_like Rolify::Role
+  it_behaves_like "Role.scopes"
+  it_behaves_like Rolify::Dynamic
+  it_behaves_like "Rolify.callbacks"
 end

data/spec/rolify/shared_contexts.rb

@@ -1,7 +1,9 @@
 shared_context "global role", :scope => :global do
   subject { admin }
   
-  let(:admin) { user_class.first }
+  def admin
+    user_class.first
+  end
   
   before(:all) do
     load_roles
@@ -29,7 +31,9 @@ shared_context "class scoped role", :scope => :class do
     create_other_roles
   end
   
-  let(:manager) { user_class.where(:login => "moderator").first }
+  def manager
+    user_class.where(:login => "moderator").first
+  end
   
   def load_roles
     role_class.destroy_all
@@ -51,7 +55,9 @@ shared_context "instance scoped role", :scope => :instance do
     create_other_roles
   end
   
-  let(:moderator) { user_class.where(:login => "god").first }
+  def moderator
+    user_class.where(:login => "god").first
+  end
   
   def load_roles
     role_class.destroy_all