rolemodel-rails 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9809271c3cc1c97337717b8d1d79b934a215d343f9b62e4cd6be25d9a906a39
-  data.tar.gz: 7e6493f9b61aaa33adadc0957ca25e897ff36228eeb6a667b07a9f846fadccec
+  metadata.gz: 5716bd65624ca07d0abd2474a843f44406de11938b3f5be4046f64a35ee13e7b
+  data.tar.gz: 657b71bf0a3f1b2ccc7a82c80f027686c929c7a1b5d3622bd39a5cfc81471c45
 SHA512:
-  metadata.gz: 25500fd7928c067bc0dd8405fd6140d23b932aa7742e566e008c9f3c8386a74efe44321675147c2951f6cb9dabe5b047445b126b688abf651f8ccfe7b719118e
-  data.tar.gz: 2f1bf50daa539e964159cd300f24022cd6d2614cd19886608f0acc323fbfb16e207c25d40b192a4fc783bb09b9c3272d17d84d08d9429ce07e29becd62adff51
+  metadata.gz: 5954774b2b8bc6772424debb798c8ee2f868f4d20b315a9029b08b0974b77804e1dfb041f243720b21b7506a80598ab58feec39b0083e72323b5162079505eb5
+  data.tar.gz: 7ca723dafff67deac08f8553a67e3ffdea5c6300922584c2ae5db8a0e24114f60c9a10a83cadedaa47a0815a733d429c3064794371227c9568e5535480b3dc39

data/lib/generators/rolemodel/linters/eslint/eslint_generator.rb

@@ -18,8 +18,7 @@ module Rolemodel
       ].freeze
 
       def install_eslint
-        ensure_yarn
-        run "yarn add --dev #{DEV_DEPENDENCIES.join(' ')}"
+        yarn_command "add --dev #{DEV_DEPENDENCIES.join(' ')}"
       end
 
       def add_config

data/lib/generators/rolemodel/optics/base/base_generator.rb

@@ -6,8 +6,7 @@ module Rolemodel
       def add_optics_package
         say 'installing Optics package', :green
 
-        ensure_yarn
-        run 'yarn add @rolemodel/optics'
+        yarn_command 'add @rolemodel/optics'
       end
 
       def copy_templates

data/lib/generators/rolemodel/react/react_generator.rb

@@ -6,8 +6,7 @@ module Rolemodel
       @add_react = yes?('Would you like to add react?')
 
       if @add_react
-        ensure_yarn
-        run 'yarn add react react-dom'
+        yarn_command 'add react react-dom'
       end
     end
 

data/lib/generators/rolemodel/sentry/sentry_generator.rb

@@ -43,8 +43,7 @@ module Rolemodel
     def add_js_dependencies
       say 'Adding Sentry JS dependencies to package.json', :green
 
-      ensure_yarn
-      run "yarn add --dev #{JS_DEPS.join(' ')}"
+      yarn_command "add --dev #{JS_DEPS.join(' ')}"
     end
 
     def add_js_initializer

data/lib/generators/rolemodel/tailored_select/tailored_select_generator.rb

@@ -7,8 +7,7 @@ module Rolemodel
     def add_tailored_select_package
       say 'Installing Tailored Select package', :green
 
-      ensure_yarn
-      run 'yarn add @rolemodel/tailored-select'
+      yarn_command 'add @rolemodel/tailored-select'
     end
 
     def add_simple_form_input

data/lib/generators/rolemodel/testing/jasmine_playwright/jasmine_playwright_generator.rb

@@ -18,8 +18,10 @@ module Rolemodel
         raise Thor::InvocationError, 'a --github_package_token option or GITHUB_PACKAGES_TOKEN environment variable is required' if options[:github_package_token].blank?
       end
 
-      def enable_corepack_and_yarn
-        ensure_yarn
+      def add_dev_dependencies
+        say 'Adding new dev dependency to package.json', :green
+
+        yarn_command "add --dev #{DEV_DEPENDENCIES.join(' ')}"
       end
 
       def add_browser_test_script
@@ -34,12 +36,6 @@ module Rolemodel
         create_file '.node-version', NODE_VERSION, force: true
       end
 
-      def add_dev_dependencies
-        say 'Adding new dev dependency to package.json', :green
-
-        run "yarn add --dev #{DEV_DEPENDENCIES.join(' ')}"
-      end
-
       def add_spec_config_files
         say 'Adding Jasmine Playwright configuration files', :green
 

data/lib/generators/rolemodel/testing/rspec/rspec_generator.rb

@@ -27,9 +27,8 @@ module Rolemodel
       def install_playwright
         say 'Installing Playwright for system tests', :green
 
-        ensure_yarn
-        run 'yarn add --dev playwright'
-        run 'yarn run playwright install'
+        yarn_command 'add --dev playwright'
+        yarn_command 'run playwright install'
       end
 
       def add_spec_files

data/lib/generators/rolemodel/testing/vitest/vitest_generator.rb

@@ -14,17 +14,16 @@ module Rolemodel
         @vitest/ui
       ].freeze
 
-      def update_test_script
-        say 'Update yarn test command', :green
-        ensure_yarn
+      def add_dev_dependencies
+        say 'Adding new dev dependency to package.json', :green
 
-        add_package_json_script 'test', TEST_COMMAND
+        yarn_command "add --dev #{DEV_DEPENDENCIES.join(' ')}"
       end
 
-      def add_dev_dependencies
-        say 'Adding new dev dependency to package.json', :green
+      def update_test_script
+        say 'Update yarn test command', :green
 
-        run "yarn add --dev #{DEV_DEPENDENCIES.join(' ')}"
+        add_package_json_script 'test', TEST_COMMAND
       end
 
       def add_spec_config_files

data/lib/generators/rolemodel/turbo/confirm/confirm_generator.rb

@@ -6,8 +6,7 @@ module Rolemodel
       def add_turbo_confirm_package
         say 'Installing Turbo Confirm package', :green
 
-        ensure_yarn
-        run 'yarn add @rolemodel/turbo-confirm'
+        yarn_command 'add @rolemodel/turbo-confirm'
       end
 
       def add_initializer

data/lib/generators/rolemodel/turbo/form/form_generator.rb

@@ -6,8 +6,7 @@ module Rolemodel
       def add_rails_request_package
         say 'Installing @rails/request.js package', :green
 
-        ensure_yarn
-        run 'yarn add @rails/request.js'
+        yarn_command 'add @rails/request.js'
       end
 
       def add_stimulus_controller

data/lib/generators/rolemodel/ui_components/navbar/navbar_generator.rb

@@ -25,8 +25,7 @@ module Rolemodel
       def install_shoelace
         say 'Installing Shoelace package', :green
 
-        ensure_yarn
-        run 'yarn add @shoelace-style/shoelace'
+        yarn_command 'add @shoelace-style/shoelace'
       end
 
       def add_shoelace_javascript_imports

data/lib/generators/rolemodel/webpack/webpack_generator.rb

@@ -41,12 +41,6 @@ module Rolemodel
       create_file '.node-version', NODE_VERSION, force: true
     end
 
-    def enable_corepack_and_yarn
-      say 'Enabling Corepack and pinning the project to Yarn 4+', :green
-
-      ensure_yarn
-    end
-
     def force_node_to_use_es_modules
       say 'Configuring project to use ES Modules instead of CommonJS', :green
 
@@ -56,14 +50,14 @@ module Rolemodel
     def remove_obsolete_javascript_dependencies
       say 'Removing webpack & webpack-cli from package.json dependencies', :green
 
-      run 'yarn remove webpack webpack-cli'
+      yarn_command 'remove webpack webpack-cli'
     end
 
     def add_npm_packages
       say 'Adding new dev dependencies to package.json', :green
 
       dependencies = DEV_DEPS + POSTCSS_PKGS + WEBPACK_CSS_PKGS
-      run "yarn add --dev #{dependencies.join(' ')}"
+      yarn_command "add --dev #{dependencies.join(' ')}"
     end
 
     def add_webpack_config

data/lib/rolemodel/generator_base.rb

@@ -9,19 +9,25 @@ module Rolemodel
   class GeneratorBase < ::Rails::Generators::Base
     include ::Rails::Generators::BundleHelper, ReplaceContentHelper
 
-
     private
     # based on https://github.com/rails/rails/blob/main/railties/lib/rails/generators/app_base.rb#L713
     def run_bundle
       bundle_command("install --quiet", "BUNDLE_IGNORE_MESSAGES" => "1")
     end
 
+    def yarn_command(command)
+      ensure_yarn
+
+      run "yarn #{command}"
+    end
+
     # Enable Corepack and pin the project to Yarn 4+ before running any `yarn`
     # command. Empty args/opts are required: without them, Thor forwards this
     # generator's own CLI args (e.g. the test harness's --skip-bundle
     # --skip-bootsnap) into Rolemodel::Yarn#setup, which takes none and raises
     # Thor::InvocationError.
     def ensure_yarn
+      return if Rails.root.join(destination_root, '.yarnrc.yml').exist?
       invoke 'rolemodel:yarn:setup', [], {}
     end
 

data/lib/rolemodel/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rolemodel
-  VERSION = '2.3.1'
+  VERSION = '2.3.2'
 end

data/lib/rolemodel/yarn.rb

@@ -5,11 +5,10 @@ module Rolemodel
   class Yarn < ::Thor
     include ::Thor::Actions
 
-    # Enable Corepack and pin the project to Yarn 4+ (instead of the classic
-    # Yarn 1.22). Idempotent, so any generator can call it before running a
-    # `yarn` command to guarantee the modern toolchain is in place.
+    # Enable Corepack and pin the project to Yarn 4+ (instead of the classic Yarn 1.22).
     desc 'setup', 'Set the current stable version of Yarn, enable corepack, and initialize a package.json file'
     def setup
+      say 'Setting up Yarn 4+ and Corepack', :green
       # Configure the node-modules linker so webpack, Playwright, and the Rails
       # asset pipeline keep working (Yarn 4 defaults to Plug'n'Play otherwise).
       # skip if exists? to avoid overwriting any other existing config

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rolemodel-rails
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - RoleModel Software Inc