roku_builder 4.8.0 → 4.8.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (8) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG +4 -0
  3. data/Gemfile.lock +1 -1
  4. data/lib/roku_builder/plugins/manifest_inspector.rb +5 -1
  5. data/lib/roku_builder/version.rb +1 -1
  6. data/test/roku_builder/plugins/test_analyzer.rb +8 -0
  7. data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean +9 -0
  8. metadata +4 -2
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 38d4cd944ab2ba9a7b286c37cda4328f9dbe7038
4
- data.tar.gz: 0e48951e36d4ab8469c92fa74c5b3e24c922c8a3
3
+ metadata.gz: 54f63b9aa2642b16b2b4b6c6710b59351c553e16
4
+ data.tar.gz: cebf3fb789279da6f54e5c99cb9f8d6430038665
5
5
  SHA512:
6
- metadata.gz: b61247bd31d9aa8da330157c74d5b982a82785c88b7f49d8cdc8f18e4b7b54e7ec1bc627274b4b917f1c93071c9807fde71cf6eb8ab2478b7a4b130ea9e5a2b7
7
- data.tar.gz: 9dcdba8b1687c8a4b4ee5a694c172dc80967a5cc9058ca8870b61ccda0bdc12cb07f4968927c06160b165b732d8d3e327bf4e9586efe3cbc15e532a8f6a1164b
6
+ metadata.gz: 833eae2f8bf6a8afd52955ad3c187add1f7dfac6c0843654e60f1c32e98096b39a49b6bf47c81b3394a635a980857ba9910c05e1909dcfafea0b14e3120f6d60
7
+ data.tar.gz: 7332735e99b55425c5a2cfc9b6ed29472f8ddc9b955745621162c582fc2da086c4d79a5fb4f899324f059f17b8a6b6d12c7ed7a9c2858a4b5c41570852e3ab34
data/CHANGELOG CHANGED
@@ -1,3 +1,7 @@
1
+ = 4.8.1 =
2
+
3
+ - Add missing manifest validator
4
+
1
5
  = 4.8.0 =
2
6
 
3
7
  - Add Static Analyzer
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- roku_builder (4.8.0)
4
+ roku_builder (4.8.1)
5
5
  faraday (~> 0.13)
6
6
  faraday-digestauth (~> 0.2)
7
7
  git (~> 1.3)
data/lib/roku_builder/plugins/manifest_inspector.rb CHANGED
@@ -53,6 +53,10 @@ module RokuBuilder
53
53
  unless @attributes[key].to_f.to_s == @attributes[key]
54
54
  add_warning(warning: :manifestInvalidValue, key: key)
55
55
  end
56
+ when :boolean
57
+ unless ["false", "true"].include? @attributes[key]
58
+ add_warning(warning: :manifestInvalidValue, key: key)
59
+ end
56
60
  when :non_negative
57
61
  unless @attributes[key].to_f >= 0
58
62
  add_warning(warning: :manifestInvalidValue, key: key)
@@ -70,7 +74,7 @@ module RokuBuilder
70
74
  add_warning(warning: :manifestInvalidValue, key: key)
71
75
  end
72
76
  else
73
- raise ImplementationError, "Unknown Validation"
77
+ raise ImplementationError, "Unknown Validation #{type}"
74
78
  end
75
79
  end
76
80
  end
data/lib/roku_builder/version.rb CHANGED
@@ -2,5 +2,5 @@
2
2
 
3
3
  module RokuBuilder
4
4
  # Version of the RokuBuilder Gem
5
- VERSION = "4.8.0"
5
+ VERSION = "4.8.1"
6
6
  end
data/test/roku_builder/plugins/test_analyzer.rb CHANGED
@@ -77,6 +77,14 @@ module RokuBuilder
77
77
  assert_equal 9, warnings[0][:line]
78
78
  assert_equal "manifest", warnings[0][:path]
79
79
  end
80
+ def test_manifest_invalid_value_boolean
81
+ warnings = test_manifest("manifest_invalid_value_boolean")
82
+ assert_equal 1, warnings.count
83
+ assert_match(/bs_prof_enabled/, warnings[0][:message])
84
+ assert_match(/bad/, warnings[0][:message])
85
+ assert_equal 9, warnings[0][:line]
86
+ assert_equal "manifest", warnings[0][:path]
87
+ end
80
88
  def test_manifest_invalid_value_negative
81
89
  warnings = test_manifest("manifest_invalid_value_negative")
82
90
  assert_equal 1, warnings.count
data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean ADDED
@@ -0,0 +1,9 @@
1
+ title=Test
2
+ major_version=1
3
+ minor_version=0
4
+ build_version=1
5
+ mm_icon_focus_hd=pkg:/images/focus_hd.png
6
+ mm_icon_focus_sd=pkg:/images/focus_sd.png
7
+ splash_screen_hd=pkg:/images/splash_hd.png
8
+ splash_screen_sd=pkg:/images/splash_sd.png
9
+ bs_prof_enabled=bad
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: roku_builder
3
3
  version: !ruby/object:Gem::Version
4
- version: 4.8.0
4
+ version: 4.8.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - greeneca
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2018-09-26 00:00:00.000000000 Z
11
+ date: 2018-09-27 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubyzip
@@ -533,6 +533,7 @@ files:
533
533
  - test/roku_builder/test_files/analyzer_test/manifest_empty_value
534
534
  - test/roku_builder/test_files/analyzer_test/manifest_has_value
535
535
  - test/roku_builder/test_files/analyzer_test/manifest_incorrect_image_resolution
536
+ - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean
536
537
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_equals
537
538
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_float
538
539
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_integer
@@ -655,6 +656,7 @@ test_files:
655
656
  - test/roku_builder/test_files/analyzer_test/manifest_empty_value
656
657
  - test/roku_builder/test_files/analyzer_test/manifest_has_value
657
658
  - test/roku_builder/test_files/analyzer_test/manifest_incorrect_image_resolution
659
+ - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean
658
660
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_equals
659
661
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_float
660
662
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_integer