roku_builder 4.7.2 → 4.8.0

data/test/roku_builder/plugins/test_analyzer.rb

@@ -0,0 +1,344 @@
+# ********** Copyright Viacom, Inc. Apache 2.0 **********
+
+require_relative "../test_helper.rb"
+
+module RokuBuilder
+  class AnalyzerTest < Minitest::Test
+    def setup
+      Logger.set_testing
+      RokuBuilder.class_variable_set(:@@dev, false)
+      RokuBuilder.setup_plugins
+      register_plugins(Analyzer)
+      @config, @options = build_config_options_objects(AnalyzerTest, {analyze: true, working: true, quiet_analyze: true}, false)
+      @root_dir = @config.root_dir
+      @device_config = @config.device_config
+      FileUtils.cp(File.join(@root_dir, "manifest_template"), File.join(@root_dir, "manifest"))
+      @request_stubs = []
+      analyzer_config = nil
+      File.open(File.join(@root_dir, "analyzer_config.json")) do |file|
+        analyzer_config = file.read
+      end
+      @request_stubs.push(stub_request(:get, "http://devtools.web.roku.com/static-code-analyzer/config.json").
+        to_return(status: 200, body: analyzer_config, headers: {}))
+      folder = File.join(@root_dir, "source")
+      Dir.mkdir(folder) unless File.exist?(folder)
+    end
+    def teardown
+      manifest = File.join(@root_dir, "manifest")
+      FileUtils.rm(manifest) if File.exist?(manifest)
+      @request_stubs.each {|req| remove_request_stub(req)}
+    end
+    def test_analyzer_parse_commands
+      parser = OptionParser.new
+      options = {}
+      Analyzer.parse_options(parser: parser, options: options)
+      argv = ["roku", "--analyze"]
+      parser.parse! argv
+      assert options[:analyze]
+    end
+    def test_clean_app
+      warnings = test
+      assert_equal Array, warnings.class
+    end
+    def test_manifest_duplicate_attribute
+      warnings = test_manifest("manifest_duplicate_attribute")
+      assert_equal 1, warnings.count
+      assert_match(/title/, warnings[0][:message])
+      assert_equal 2, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_depricated_attribute
+      warnings = test_manifest("manifest_depricated_attribute")
+      assert_equal 1, warnings.count
+      assert_match(/subtitle/, warnings[0][:message])
+      assert_equal 2, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_empty_value
+      warnings = test_manifest("manifest_empty_value")
+      assert_equal 1, warnings.count
+      assert_match(/empty/, warnings[0][:message])
+      assert_equal 9, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_integer
+      warnings = test_manifest("manifest_invalid_value_integer")
+      assert_equal 1, warnings.count
+      assert_match(/major_version/, warnings[0][:message])
+      assert_match(/bad/, warnings[0][:message])
+      assert_equal 2, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_float
+      warnings = test_manifest("manifest_invalid_value_float")
+      assert_equal 1, warnings.count
+      assert_match(/rsg_version/, warnings[0][:message])
+      assert_match(/1/, warnings[0][:message])
+      assert_equal 9, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_negative
+      warnings = test_manifest("manifest_invalid_value_negative")
+      assert_equal 1, warnings.count
+      assert_match(/major_version/, warnings[0][:message])
+      assert_match(/-1/, warnings[0][:message])
+      assert_equal 2, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_not_equal
+      warnings = test_manifest("manifest_invalid_value_not_equal")
+      assert_equal 1, warnings.count
+      assert_match(/build_version/, warnings[0][:message])
+      assert_match(/0/, warnings[0][:message])
+      assert_equal 4, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_equals
+      warnings = test_manifest("manifest_invalid_value_equals")
+      assert_equal 1, warnings.count
+      assert_match(/screensaver_private/, warnings[0][:message])
+      assert_match(/2/, warnings[0][:message])
+      assert_equal 9, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_invalid_value_starts_with
+      warnings = test_manifest("manifest_invalid_value_starts_with")
+      refute_equal 0, warnings.count
+      assert_match(/mm_icon_focus_hd/, warnings[0][:message])
+      assert_match(/bad/, warnings[0][:message])
+      assert_match(/invalid value/, warnings[0][:message])
+      assert_equal 5, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_has_value
+      warnings = test_manifest("manifest_has_value")
+      assert_equal 1, warnings.count
+      assert_match(/rsg_version/, warnings[0][:message])
+      assert_match(/1.0/, warnings[0][:message])
+      assert_equal 9, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_missing_file
+      warnings = test_manifest("manifest_missing_file")
+      assert_equal 1, warnings.count
+      assert_match(/mm_icon_focus_hd/, warnings[0][:message])
+      assert_match(/missing.png/, warnings[0][:message])
+      assert_equal 5, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_manifest_missing_attribute
+      warnings = test_manifest("manifest_missing_attribute")
+      assert_equal 1, warnings.count
+      assert_match(/title/, warnings[0][:message])
+      assert_equal "manifest", warnings[0][:path]
+      refute warnings[0][:line]
+    end
+    def test_manifest_incorrect_image_resolution
+      warnings = test_manifest("manifest_incorrect_image_resolution")
+      assert_equal 1, warnings.count
+      assert_match(/mm_icon_focus_hd/, warnings[0][:message])
+      assert_match(/too_small.png/, warnings[0][:message])
+      assert_match(/336x210/, warnings[0][:message])
+      assert_match(/1x1/, warnings[0][:message])
+      assert_equal 5, warnings[0][:line]
+      assert_equal "manifest", warnings[0][:path]
+    end
+    def test_line_inspector_depricated_component
+      warnings = test_file(text: "\"roVideoScreen\"")
+      assert_equal 1, warnings.count
+      assert_match(/deprecated/, warnings[0][:message])
+      assert_match(/roVideoScreen/, warnings[0][:message])
+    end
+    def test_line_inspector_depricated_component_xml_file
+      warnings = test_file(text: "\"roVideoScreen\"", file: "test.xml")
+      assert_equal 1, warnings.count
+      assert_match(/roVideoScreen/, warnings[0][:message])
+    end
+    def test_line_inspector_depricated_component_in_comment
+      warnings = test_file(text: "'\"roVideoScreen\"")
+      assert_equal 0, warnings.count
+    end
+    def test_line_inspector_depricated_component_before_comment
+      warnings = test_file(text: "\"roVideoScreen\"'comment")
+      assert_equal 1, warnings.count
+      assert_match(/roVideoScreen/, warnings[0][:message])
+    end
+    def test_line_inspector_depricated_component_in_xml_comment
+      warnings = test_file(text: "<!-- \"roVideoScreen\" -->", file: "test.xml")
+      assert_equal 0, warnings.count
+    end
+    def test_line_inspector_depricated_component_before_xml_comment
+      warnings = test_file(text: "\"roVideoScreen\" <!-- comment -->", file: "test.xml")
+      assert_equal 1, warnings.count
+    end
+    def test_line_inspector_depricated_component_after_xml_comment
+      warnings = test_file(text: "<!-- comment -->\"roVideoScreen\"", file: "test.xml")
+      assert_equal 1, warnings.count
+    end
+    def test_line_inspector_depricated_component_in_xml_multiline_comment
+      warnings = test_file(text: "<!-- line1 \n\"roVideoScreen\"\n line3 -->", file: "test.xml")
+      assert_equal 0, warnings.count
+    end
+    def test_line_inspector_depricated_component_in_xml_multiline_comment_start
+      warnings = test_file(text: "<!-- \"roVideoScreen\"\n line2 -->", file: "test.xml")
+      assert_equal 0, warnings.count
+    end
+    def test_line_inspector_depricated_component_in_xml_multiline_comment
+      warnings = test_file(text: "<!-- line1 \n\"roVideoScreen\"-->", file: "test.xml")
+      assert_equal 0, warnings.count
+    end
+    def test_line_inspector_depricated_component_before_xml_multiline_comment
+      warnings = test_file(text: "\"roVideoScreen\"<!-- line1 \n line2 -->", file: "test.xml")
+      assert_equal 1, warnings.count
+    end
+    def test_line_inspector_depricated_component_after_xml_multiline_comment
+      warnings = test_file(text: "<!-- line1 \n line2 -->\"roVideoScreen\"", file: "test.xml")
+      assert_equal 1, warnings.count
+    end
+    def test_line_inspector_stop_command
+      warnings = test_file(text: "test\nstop\n")
+      assert_equal 1, warnings.count
+      assert_equal 1, warnings[0][:line]
+    end
+    def test_raf_constructor_present_import_missing
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "roku_ads()")
+      assert warnings.count > 0
+      assert_match(/constructor call is present.*import is missing/, warnings.first[:message])
+    end
+    def test_raf_constructor_present_manifest_missing
+      warnings = test_file(text: "library \"roku_ads.brs\"\nroku_ads()")
+      assert warnings.count > 0
+      assert_match(/manifest entry is missing/, warnings.first[:message])
+    end
+    def test_raf_constructor_missing_manifest_present
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "library \"roku_ads.brs\"")
+      assert warnings.count > 0
+      assert_match(/constructor call is not present/, warnings.first[:message])
+    end
+    def test_raf_manifest_present_import_missing
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "roku_ads()")
+      assert warnings.count > 0
+      assert_match(/manifest entry is present.*import is missing/, warnings.last[:message])
+    end
+    def test_raf_constructor_missing_import_present
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "library \"roku_ads.brs\"")
+      assert warnings.count > 0
+      assert_match(/constructor call is not present.*import is present/, warnings.last[:message])
+    end
+    def test_raf_proper_intergration
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "library \"roku_ads.brs\"\nroku_ads()")
+      assert_equal 1, warnings.count
+      assert_match(/integrated properly/, warnings[0][:message])
+    end
+    def test_raf_proper_intergration_different_case
+      use_manifest("manifest_raf")
+      warnings = test_file(text: "library \"Roku_Ads.brs\"\nRoku_Ads()")
+      assert_equal 1, warnings.count
+      assert_match(/integrated properly/, warnings[0][:message])
+    end
+    def test_macosx_directory
+      config = good_config(AnalyzerTest)
+      config[:projects][:project1][:folders].push("Test__MACOSX")
+      @config, @options = build_config_options_objects(AnalyzerTest, {analyze: true, working: true, quiet_analyze: true}, false, config)
+      folder = File.join(@root_dir, "Test__MACOSX")
+      Dir.mkdir(folder) unless File.exist?(folder)
+      warnings = test
+      assert_equal 1, warnings.count
+      assert_match(/MACOSX directory/, warnings[0][:message])
+      Dir.rmdir(folder) if File.exist?(folder)
+    end
+    def test_extranious_files_zip
+      warnings = test_file(text: "nothing", file: "test.zip")
+      assert_equal 1, warnings.count
+      assert_match(/extraneous file/, warnings[0][:message])
+    end
+    def test_extranious_files_md
+      warnings = test_file(text: "nothing", file: "test.md")
+      assert_equal 1, warnings.count
+      assert_match(/extraneous file/, warnings[0][:message])
+    end
+    def test_extranious_files_pkg
+      warnings = test_file(text: "nothing", file: "test.pkg")
+      assert_equal 1, warnings.count
+      assert_match(/extraneous file/, warnings[0][:message])
+    end
+    def test_source_directory
+      folder = File.join(@root_dir, "source")
+      Dir.rmdir(folder) if File.exist?(folder)
+      warnings = test
+      assert_equal 1, warnings.count
+      assert_match(/"source".*not exist/, warnings[0][:message])
+    end
+    def test_manifest_file
+      FileUtils.rm(File.join(@root_dir, "manifest"))
+      warnings = test
+      assert_equal 1, warnings.count
+      assert_match(/Manifest.*missing/, warnings[0][:message])
+    end
+    def test_logging_error
+      test_logger_with_file_content(text: "stop", severity: :error)
+    end
+    def test_logging_warning
+      test_logger_with_file_content(text: "\"roCaptionRenderer\"", severity: :warn)
+    end
+    def test_logging_info
+      test_logger_with_file_content(text: "\"roSGScreen\"", severity: :info)
+    end
+
+
+    private
+
+    def test_manifest(manifest_file = nil)
+      if manifest_file
+        use_manifest(manifest_file)
+      end
+      test
+    end
+
+    def use_manifest(manifest_file)
+      FileUtils.cp(File.join(@root_dir, manifest_file), File.join(@root_dir, "manifest"))
+    end
+
+    def test_file(text:, file: nil, quiet: true)
+      file ||= "test.brs"
+      test_file = File.join(@root_dir, "source", file)
+      File.open(test_file, "w") do |file|
+        file.write(text)
+      end
+      warnings = test(quiet)
+      FileUtils.rm(test_file) if File.exist?(test_file)
+      warnings
+    end
+
+    def test_logger_with_file_content(text:, severity:)
+      logger = Minitest::Mock.new
+
+      logger.expect(:level=, nil, [Integer])
+      logger.expect(:formatter=, nil, [Proc])
+      logger.expect(severity, nil, [String])
+
+      ::Logger.stub :new, logger do
+        warnings = test_file(text: text, quiet: false)
+      end
+
+      logger.verify
+    end
+
+    def test(quiet=true)
+      analyzer = Analyzer.new(config: @config)
+      analyzer.analyze(options: @options, quiet: quiet)
+    end
+
+    def print_all(warnings)
+      warnings.each do |warning|
+        puts warning[:message]
+      end
+    end
+  end
+end
+

data/test/roku_builder/plugins/test_loader.rb

@@ -112,5 +112,14 @@ module RokuBuilder
         loader.delete(options: @options)
       end
     end
+    def test_copy_files
+      loader = Loader.new(config: @config)
+      Dir.mktmpdir do |dir|
+        loader.copy(options: @options, path: dir)
+        assert File.exist?(File.join(dir, "manifest"))
+        assert File.exist?(File.join(dir, "source", "b"))
+        assert File.exist?(File.join(dir, "source", "c", "d"))
+      end
+    end
   end
 end

data/test/roku_builder/test_config_parser.rb

@@ -196,7 +196,7 @@ module RokuBuilder
       assert_equal "/tmp/project2", configs[:project][:directory]
     end
 
-    def test_manifest_config_project_directory_select
+    def test_manifest_config_project_directory_select_full_path
       options = build_options({validate: true, working: true})
       options.define_singleton_method(:source_commands){[:validate]}
       config = good_config(ConfigParserTest)

data/test/roku_builder/test_files/analyzer_test/analyzer_config.json

@@ -0,0 +1 @@
+{"lineInspectors":[{"regex":"\"roCaptionRenderer\"","severity":"warning","message":"Found deprecated \"roCaptionRenderer\"","category":"deprecatedComponents"},{"regex":"\"roCodeRegistrationScreen\"","severity":"warning","message":"Found deprecated \"roCodeRegistrationScreen\"","category":"deprecatedComponents"},{"regex":"\"roGridScreen\"","severity":"warning","message":"Found deprecated \"roGridScreen\"","category":"deprecatedComponents"},{"regex":"\"roKeyboardScreen\"","severity":"warning","message":"Found deprecated \"roKeyboardScreen\"","category":"deprecatedComponents"},{"regex":"\"roListScreen\"","severity":"warning","message":"Found deprecated \"roListScreen\"","category":"deprecatedComponents"},{"regex":"\"roMessageDialog\"","severity":"warning","message":"Found deprecated \"roMessageDialog\"","category":"deprecatedComponents"},{"regex":"\"roOneLineDialog\"","severity":"warning","message":"Found deprecated \"roOneLineDialog\"","category":"deprecatedComponents"},{"regex":"\"roParagraphScreen\"","severity":"warning","message":"Found deprecated \"roParagraphScreen\"","category":"deprecatedComponents"},{"regex":"\"roPinEntryDialog\"","severity":"warning","message":"Found deprecated \"roPinEntryDialog\"","category":"deprecatedComponents"},{"regex":"\"roPosterScreen\"","severity":"warning","message":"Found deprecated \"roPosterScreen\"","category":"deprecatedComponents"},{"regex":"\"roSearchHistory\"","severity":"warning","message":"Found deprecated \"roSearchHistory\"","category":"deprecatedComponents"},{"regex":"\"roSearchScreen\"","severity":"warning","message":"Found deprecated \"roSearchScreen\"","category":"deprecatedComponents"},{"regex":"\"roSGGridScreen\"","severity":"warning","message":"Found deprecated \"roSGGridScreen\"","category":"deprecatedComponents"},{"regex":"\"roSlideShow\"","severity":"warning","message":"Found deprecated \"roSlideShow\"","category":"deprecatedComponents"},{"regex":"\"roSpringboardScreen\"","severity":"warning","message":"Found deprecated \"roSpringboardScreen\"","category":"deprecatedComponents"},{"regex":"\"roTextScreen\"","severity":"warning","message":"Found deprecated \"roTextScreen\"","category":"deprecatedComponents"},{"regex":"\"roVideoScreen\"","severity":"warning","message":"Found deprecated \"roVideoScreen\"","category":"deprecatedComponents"},{"regex":"\"roImageCanvas\"","severity":"warning","message":"Found deprecated \"roImageCanvas\"","category":"deprecatedComponents"},{"regex":"\"roCaptionRendererEvent\"","severity":"warning","message":"Found deprecated \"roCaptionRendererEvent\"","category":"deprecatedComponents"},{"regex":"\"roCodeRegistrationScreenEvent\"","severity":"warning","message":"Found deprecated \"roCodeRegistrationScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roGridScreenEvent\"","severity":"warning","message":"Found deprecated \"roGridScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roKeyboardScreenEvent\"","severity":"warning","message":"Found deprecated \"roKeyboardScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roListScreenEvent\"","severity":"warning","message":"Found deprecated \"roListScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roMessageDialogEvent\"","severity":"warning","message":"Found deprecated \"roMessageDialogEvent\"","category":"deprecatedComponents"},{"regex":"\"roOneLineDialogEvent\"","severity":"warning","message":"Found deprecated \"roOneLineDialogEvent\"","category":"deprecatedComponents"},{"regex":"\"roParagraphScreenEvent\"","severity":"warning","message":"Found deprecated \"roParagraphScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roPinEntryDialogEvent\"","severity":"warning","message":"Found deprecated \"roPinEntryDialogEvent\"","category":"deprecatedComponents"},{"regex":"\"roPosterScreenEvent\"","severity":"warning","message":"Found deprecated \"roPosterScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roSearchScreenEvent\"","severity":"warning","message":"Found deprecated \"roSearchScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roSGGridScreenEvent\"","severity":"warning","message":"Found deprecated \"roSGGridScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roSlideShowEvent\"","severity":"warning","message":"Found deprecated \"roSlideShowEvent\"","category":"deprecatedComponents"},{"regex":"\"roSpringboardScreenEvent\"","severity":"warning","message":"Found deprecated \"roSpringboardScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roTextScreenEvent\"","severity":"warning","message":"Found deprecated \"roTextScreenEvent\"","category":"deprecatedComponents"},{"regex":"\"roImageCanvasEvent\"","severity":"warning","message":"Found deprecated \"roImageCanvasEvent\"","category":"deprecatedComponents"},{"regexMatch":"^.*:\\s*stop\\b.*$|^(.*[^.\\s])?\\s*\\bstop\\b\\s*([^:\\s].*)?$","regex":"([^.{,\"\\s]|^)\\s*\\bstop\\b","severity":"error","message":"STOP command is present"},{"regex":"(\"ChannelStore\"|\"roChannelStore\")","severity":"info","message":"Usage of ChannelStore is spotted. Roku billing might be integrated."},{"regex":"\"roSGScreen\"","severity":"info","message":"This is an RSG channel"},{"regex":"\"TimeGrid\"","severity":"warning","message":"TimeGrid component is found"},{"regex":"\"roTuner\"","severity":"warning","message":"roTuner component is found"},{"regex":"\"roProgramGuide\"","severity":"warning","message":"roProgramGuide component is found"}],"inspectors":{"manifestDuplicateAttribute":{"severity":"warning","message":"Found duplicate attribute in manifest: \"{0}\"","category":"manifest"},"manifestDeprecatedAttribute":{"severity":"warning","message":"Found deprecated attribute in manifest: \"{0}\"","category":"manifest"},"manifestEmptyValue":{"severity":"error","message":"\"{0}\" attribute in manifest has an empty value","category":"manifest"},"manifestInvalidValue":{"severity":"error","message":"\"{0}\" attribute in manifest has invalid value: \"{1}\"","category":"manifest"},"manifestHasValue":{"severity":"warning","message":"\"{0}\" attribute in manifest has value \"{1}\"","category":"manifest"},"manifestMissingFile":{"severity":"error","message":"\"{0}\" file used for \"{1}\" attribute is missing","category":"manifest"},"manifestMissingAttribute":{"severity":"error","message":"Manifest is missing a required attribute: \"{0}\"","category":"manifest"},"manifestIncorrectImageResolution":{"severity":"error","message":"\"{0}\" image used for \"{1}\" attribute has incorrect resolution: \"{2}\". Valid resolution is \"{3}\".","category":"manifest"},"rafConstructorPresentImportMissing":{"severity":"error","message":"RAF constructor call is present but library import is missing","category":"raf"},"rafConstructorPresentManifestMissing":{"severity":"error","message":"RAF constructor call is present but manifest entry is missing","category":"raf"},"rafConstructorMissingManifestPresent":{"severity":"warning","message":"RAF constructor call is not present but manifest entry is present","category":"raf"},"rafManifestPresentImportMissing":{"severity":"warning","message":"RAF manifest entry is present but library import is missing","category":"raf"},"rafConstructorMissingImportPresent":{"severity":"warning","message":"RAF constructor call is not present but library import is present","category":"raf"},"rafProperIntegration":{"severity":"info","message":"RAF is integrated properly","category":"raf"},"packageMacosxDirectory":{"severity":"error","message":"Package includes __MACOSX directory","category":"package"},"packageExtraneousFiles":{"severity":"error","message":"Package contains extraneous file","category":"package"},"packageSourceDirectory":{"severity":"error","message":"\"source\" directory does not exist","category":"package"},"packageManifestFile":{"severity":"error","message":"Manifest file is missing","category":"package"}},"logCategories":{"uncategorized":"Uncategorized","deprecatedComponents":"Deprecated components","manifest":"Manifest","raf":"RAF","package":"Package"}}

data/test/roku_builder/test_files/analyzer_test/manifest_depricated_attribute

@@ -0,0 +1,9 @@
+title=Test
+subtitle=test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_duplicate_attribute

@@ -0,0 +1,9 @@
+title=Test
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_empty_value

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+empty

data/test/roku_builder/test_files/analyzer_test/manifest_has_value

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+rsg_version=1.0

data/test/roku_builder/test_files/analyzer_test/manifest_incorrect_image_resolution

@@ -0,0 +1,8 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/too_small.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_equals

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+screensaver_private=2

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_float

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+rsg_version=1

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_integer

@@ -0,0 +1,8 @@
+title=Test
+major_version=bad
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_negative

@@ -0,0 +1,8 @@
+title=Test
+major_version=-1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_not_equal

@@ -0,0 +1,8 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=0
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_starts_with

@@ -0,0 +1,8 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=bad
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_missing_attribute

@@ -0,0 +1,7 @@
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_missing_file

@@ -0,0 +1,8 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/missing.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_files/analyzer_test/manifest_raf

@@ -0,0 +1,9 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png
+bs_libs_required=roku_ads_lib

data/test/roku_builder/test_files/analyzer_test/manifest_template

@@ -0,0 +1,8 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=1
+mm_icon_focus_hd=pkg:/images/focus_hd.png
+mm_icon_focus_sd=pkg:/images/focus_sd.png
+splash_screen_hd=pkg:/images/splash_hd.png
+splash_screen_sd=pkg:/images/splash_sd.png

data/test/roku_builder/test_helper.rb

@@ -77,7 +77,7 @@ def good_config(klass=nil)
     default: :project1,
     project1: {
     directory: root_dir,
-    folders: ["resources","source"],
+    folders: ["images","source"],
     files: ["manifest"],
     app_name: "<app name>",
     stage_method: :git,
@@ -93,7 +93,7 @@ def good_config(klass=nil)
   },
     project2: {
     directory: root_dir,
-    folders: ["resources","source"],
+    folders: ["images","source"],
     files: ["manifest"],
     app_name: "<app name>",
     stage_method: :script,