roku_builder 4.23.1 → 4.24.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d1ca3fbc26d92a86625530b1578517b2db8f0932f10a723e27e471a08d848da
-  data.tar.gz: 8c06399f94abd5dd482bce4111da7f647ca16497ab021ffc838c0387d924691c
+  metadata.gz: f7bfa0cdacb03d4e7ac4c9e488d9c2ceea14a2c41171539e7e7ccef1a69a4123
+  data.tar.gz: 99efccf23099acad6c86b8f55d850f75fb9a9a55f6e1e482902fe3d57b78ed72
 SHA512:
-  metadata.gz: ebd9c0cddf2a18fd73f69c864152b2e78fa942bb1ffc63862f35ad767623b3d9e109c14aa0fca8b5f5a7511967732677bb6f885aec5db8908ab8ac56257228bd
-  data.tar.gz: a6e9341c1e88ed59b10a6c2aafc6c9cff8646509e0cc7fa6092b549724d8964a5a2d822a67561fd058853b8fd8d80a25bc5df2acd4ccdf1bb10c6053f4b9d110
+  metadata.gz: 6793d4333664300a0a3920679470f414fe3adfc189190882b519c638a7c6d469e53681d07cb16ee712ca22ddaa8678acc3e37da81ed6ccb183c225bdba77325e
+  data.tar.gz: b65cb206582a70bb2c5ed2d6453104c574b2c103dac5957d277ba21f2b6e48816dceab0e8b991d20c3b47b4f7636dc10a5b499bbd8521223f9a37516d0a1918f

data/README.md

@@ -1,9 +1,9 @@
 # RokuBuilder
 
 [![Gem Version](https://badge.fury.io/rb/roku_builder.svg)](https://badge.fury.io/rb/roku_builder)
-[![Build Status](https://travis-ci.org/ViacomInc/roku_builder.svg?branch=master)](https://travis-ci.org/ViacomInc/roku_builder)
 [![Coverage Status](https://coveralls.io/repos/github/ViacomInc/roku_builder/badge.svg?branch=master)](https://coveralls.io/github/ViacomInc/roku_builder?branch=master)
 [![Code Climate](https://codeclimate.com/github/ViacomInc/roku_builder/badges/gpa.svg)](https://codeclimate.com/github/ViacomInc/roku_builder)
+<!-- [![Build Status](https://travis-ci.org/ViacomInc/roku_builder.svg?branch=master)](https://travis-ci.org/ViacomInc/roku_builder) -->
 
 A tool to help with Roku Development. Assists with many development/deployment
 tasks. More information can be found in the [wiki](https://github.com/ViacomInc/roku_builder/wiki).

data/intergration/roku_builder/test_loader.rb

@@ -15,9 +15,9 @@ module RokuBuilder
       cleanup_uuid_script
     end
     def test_sideload
-      output = `#{roku} --sideload --stage production`
+      output = `#{roku} --sideload --stage production -V`
       assert_log @uuid
-      refute_match(/WARN: Missing File/, output)
+      refute_match(/INFO: Missing File/, output)
     end
     def test_delete
       `#{roku} --sideload --working`

data/intergration/roku_builder/test_packager.rb

@@ -17,8 +17,8 @@ module RokuBuilder
     def test_package
       target = File.join(testfiles_path(PackagerIntergrationTest), "pkg.pkg")
       FileUtils.rm(target) if File.exist?(target)
-      output = `#{roku} --package --stage production --out #{target}`
-      refute_match(/WARN: Missing File/, output)
+      output = `#{roku} --package --stage production --out #{target} -V`
+      refute_match(/INFO: Missing File/, output)
       wait_assert {File.exist?(target)}
       refute File.exist?(target+".zip")
       FileUtils.rm(target) if File.exist?(target)
@@ -27,7 +27,7 @@ module RokuBuilder
       target = File.join(testfiles_path(PackagerIntergrationTest), "pkg.pkg")
       FileUtils.rm(target) if File.exist?(target)
       output = `#{roku} --package --stage production --out #{target} -V`
-      refute_match(/WARN: Missing File/, output)
+      refute_match(/INFO: Missing File/, output)
       assert_match(/#{target}/, output)
       wait_assert {File.exist?(target)}
       refute File.exist?(target+".zip")

data/lib/roku_builder/config_parser.rb

@@ -179,6 +179,7 @@ module RokuBuilder
     end
 
     def get_global_key_config
+      raise ParseError, "No Keys Configured" unless @config[:keys]
       raise ParseError, "Unknown Key: #{@parsed[:key]}" unless @config[:keys][@parsed[:key].to_sym]
       @parsed[:key] = @config[:keys][@parsed[:key].to_sym].dup
       if @config[:keys][:key_dir]  and !@parsed[:key][:keyed_pkg].start_with?("./")

data/lib/roku_builder/plugins/indentation_inspector.rb

@@ -14,7 +14,7 @@ module RokuBuilder
     end
 
     def check_line(line:, number:, comment:)
-      #byebug if number == 10 and @path.ends_with?(".brs")
+      #byebug if number == 190 and @path.ends_with?("ScreenManager.brs")
       set_indentation(line: line)
       regexp = /^#{@character}{#{@ind}}[^#{@character}]/
       unless line =~ regexp or line == "\n" or line =~ /\'indent-ignore/ or comment
@@ -47,6 +47,8 @@ module RokuBuilder
               @ind += @count
             elsif @prev_line =~ /:\s*\bfunction\b|:\s*\bsub\b/i
               @ind += @count
+            elsif @prev_line =~ /=\s*\bfunction\b|=\s*\bsub\b/i
+              @ind += @count
             elsif @prev_line =~ /^\s*\bfunction\b|^\s*\bsub\b/i
               @ind += @count
             elsif @prev_line =~ /^\s*#?if\b|^\s*#?else\b/i

data/lib/roku_builder/plugins/loader.rb

@@ -48,7 +48,6 @@ module RokuBuilder
 
     # Sideload an app onto a roku device
     def sideload(options:)
-      delete(options: options, ignoreFailure: true)
       did_build = false
       unless options[:in]
         did_build = true
@@ -173,7 +172,7 @@ module RokuBuilder
                 @logger.warn "Ignored file with invalid Roku filetype " + File.basename(diskFilePath)
               end
             else
-              @logger.warn "Missing File: #{diskFilePath}"
+              @logger.info "Missing File: #{diskFilePath}"
             end
           end
         end

data/lib/roku_builder/plugins/profiler.rb

@@ -138,8 +138,8 @@ module RokuBuilder
       lines = get_command_response(command: "sgnodes all", start_reg: start_reg, end_reg: end_reg)
       xml_string = lines.join("\n")
       stats = {"Total" => {count: 0}}
-      doc = Oga.parse_xml(xml_string)
-      handle_node(stats: stats, node: doc.children.first)
+      doc = Nokogiri::XML(xml_string)
+      handle_node(stats: stats, node: doc.root)
       stats
     end
 
@@ -171,8 +171,7 @@ module RokuBuilder
 
     def handle_node(stats:,  node:)
       if node
-        node.children.each do |element|
-          next unless element.class == Oga::XML::Element
+        node.element_children.each do |element|
           attributes = element.attributes.map{|attr| {"#{attr.name}": attr.value}}.reduce({}, :merge)
           stats[element.name] ||= {count: 0, ids: []}
           stats[element.name][:count] += 1

data/lib/roku_builder/version.rb

@@ -2,5 +2,5 @@
 
 module RokuBuilder
   # Version of the RokuBuilder Gem
-  VERSION = "4.23.1"
+  VERSION = "4.24.3"
 end

data/lib/roku_builder.rb

@@ -13,7 +13,7 @@ require 'json'
 require 'pstore'
 require "git"
 #profiler
-require 'oga'
+require 'nokogiri'
 #navigator
 require 'io/console'
 #monitor

data/roku_builder.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = "~> 2.3"
+  spec.required_ruby_version = "~> 3.0"
 
   spec.add_dependency "rubyzip",             "~> 1.2"
   spec.add_dependency "faraday",             "~> 0.13"
@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "git",                 "~> 1.3"
   spec.add_dependency "net-ping",            "~> 2.0"
   spec.add_dependency "net-telnet",          "~> 0.1"
-  spec.add_dependency "oga",                 "~> 2.11"
+  spec.add_dependency "nokogiri",            "~> 1.12"
   spec.add_dependency "win32-security",      "~> 0.5" # For windows compatibility
   spec.add_dependency "image_size",          "~> 2.0"
 

data/test/roku_builder/plugins/test_monitor.rb

@@ -138,7 +138,7 @@ module RokuBuilder
       all_text = "midline "
       txt = "split\nBrightScript Debugger> "
 
-      result = @monitor.send(:manage_text, {all_text: all_text, txt: txt})
+      result = @monitor.send(:manage_text, all_text: all_text, txt: txt)
 
       assert_equal "", result
 
@@ -148,7 +148,7 @@ module RokuBuilder
 
     def test_monitor_manage_text_connection_used
       assert_raises ExecutionError do
-        @monitor.send(:manage_text, {all_text: "", txt: "Console connection is already in use."})
+        @monitor.send(:manage_text, all_text: "", txt: "Console connection is already in use.")
       end
     end
   end

data/test/roku_builder/plugins/test_tester.rb

@@ -67,7 +67,7 @@ module RokuBuilder
       tester = Tester.new(config: config)
 
       text = "this\nis\na\ntest\nparagraph"
-      tester.send(:handle_text, {txt: text})
+      tester.send(:handle_text, txt: text)
 
       refute tester.instance_variable_get(:@in_tests)
     end
@@ -79,7 +79,7 @@ module RokuBuilder
 
       text = ["this","is","a","test","paragraph"]
 
-      tester.send(:handle_text, {txt: text.join("\n")})
+      tester.send(:handle_text, txt: text.join("\n"))
       assert_equal text, tester.instance_variable_get(:@logs)
       assert tester.instance_variable_get(:@in_tests)
     end
@@ -91,7 +91,7 @@ module RokuBuilder
       text = ["this","*Start testing*","is","a","test","*End testing*","paragraph"]
       verify_text = ["***************","***************","*Start testing*","is","a","test","*End testing*","*************","*************"]
 
-      tester.send(:handle_text, {txt: text.join("\n")})
+      tester.send(:handle_text, txt: text.join("\n"))
       refute tester.instance_variable_get(:@in_tests)
       assert_equal verify_text, tester.instance_variable_get(:@logs)
     end
@@ -103,7 +103,7 @@ module RokuBuilder
       text = ["connection already in use"]
 
       assert_raises IOError do
-        tester.send(:handle_text, {txt: text.join("\n")})
+        tester.send(:handle_text, txt: text.join("\n"))
       end
     end
   end

data/test/roku_builder/test_logger.rb

@@ -42,7 +42,7 @@ module RokuBuilder
     def test_logger_testing
       Logger.set_testing
       logger = Logger.instance
-      assert_equal "/dev/null", logger.instance_variable_get(:@logdev).instance_variable_get(:@filename)
+      assert_nil logger.instance_variable_get(:@logdev).instance_variable_get(:@filename)
     end
   end
 end

data/test/roku_builder/test_options.rb

@@ -26,7 +26,7 @@ module RokuBuilder
       parse_stub = lambda{ count+= 1; {validate: true} }
       options = Options.allocate
       options.stub(:parse, parse_stub) do
-        options.send(:initialize, {options: {validate: true}})
+        options.send(:initialize, options: {validate: true})
       end
       assert_equal 0, count
     end
@@ -133,7 +133,7 @@ module RokuBuilder
       options = Options.allocate
       options.stub(:source_command?, true) do
         assert_raises InvalidOptions do
-          options.send(:initialize, {options: {validate: true}})
+          options.send(:initialize, options: {validate: true})
           options.validate
         end
       end
@@ -164,7 +164,7 @@ module RokuBuilder
       logger.expect(:warn, nil, ["Depricated"])
       Logger.class_variable_set(:@@instance, logger)
       options.stub(:depricated_options, {validate: "Depricated"}) do
-        options.send(:initialize, {options: {validate: true}})
+        options.send(:initialize, options: {validate: true})
         options.validate
       end
       logger.verify

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roku_builder
 version: !ruby/object:Gem::Version
-  version: 4.23.1
+  version: 4.24.3
 platform: ruby
 authors:
 - greeneca
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-24 00:00:00.000000000 Z
+date: 2022-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -95,19 +95,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: oga
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '1.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: win32-security
   requirement: !ruby/object:Gem::Requirement
@@ -626,14 +626,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.3.4
 signing_key:
 specification_version: 4
 summary: Build Tool for Roku Apps