roku_builder 4.21.4 → 4.22.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 893af4ba4855d2ea781043034af83671eff43a10c14ded1648e12e45377cd9aa
-  data.tar.gz: 4f9b84df19799dd6220718b2825d4a597327c63b8c3403432b3e5a9c53542652
+  metadata.gz: fe82e43712c05c593d5627cdd0b87140186311e278aeae2c08658c6135451ba3
+  data.tar.gz: 43acac9b51f9ece09cc3c6989a0dae36ab8a5ab2d1ef996b37697c373ee1cdcb
 SHA512:
-  metadata.gz: 13cdd1828544c0580c46507047ae9425a65054e3ade6d6f8ac2f5a149faac60cc59212929b64a9226c57494a80bf1fcfb36540e684ada73df7d1215e0fb68b9d
-  data.tar.gz: e3a7197fbafbf6138b0c5831c21e3640b47d9c4b219c2bde6c924678ff05379d1f7d09490dd4ae06753ef910b57b31816dc70933803784f1fe21fe39ec1ddc41
+  metadata.gz: e53e522610ddbc4d54d0d03a7b608e6453f4baba8b5dc0c75ab450c13da02792e597310d9ee057d59b5e0544abad8b829a0ca3b27dae3f4ee4da0676f6faa2aa
+  data.tar.gz: 34629a36e098629e19c4e986c5edf86dc1c432a9ad61b61cc1fa08536ce18092d2d7f271aebf6ac8099eaeb9d10ee895f8839a50cbfc76211e9398664a92309a

data/lib/roku_builder.rb

@@ -200,7 +200,7 @@ module RokuBuilder
           stager.stage
         end
         instance = plugin.new(config: @@config)
-        instance.send(@@options.command, {options: @@options})
+        instance.send(@@options.command, **{options: @@options})
         stager.unstage if stager
       end
     end
@@ -224,7 +224,7 @@ module RokuBuilder
   def self.process_hook(hook:, params:)
     @@plugins.each do |plugin|
       if plugin.respond_to?("#{hook}_hook".to_sym)
-        plugin.send("#{hook}_hook", params)
+        plugin.send("#{hook}_hook", **params)
       end
     end
   end

data/lib/roku_builder/config_validator.rb

@@ -89,7 +89,7 @@ module RokuBuilder
       attrs = {}
       attrs[section_singular] = content
       method = "validate_#{section_singular}".to_sym
-      send(method, attrs)
+      send(method, **attrs)
     end
 
     def singularize(section:)

data/lib/roku_builder/plugins/analyzer.rb

@@ -21,6 +21,9 @@ module RokuBuilder
       parser.on("--inclide-libraries", "Include libraries in analyze") do
         options[:include_libraries] = true
       end
+      parser.on("--sca-precommand COMMAND", "Include libraries in analyze") do |command|
+        options[:sca_precommand] = command
+      end
     end
 
     def self.dependencies
@@ -30,6 +33,7 @@ module RokuBuilder
     def analyze(options:, quiet: false)
       @options = options
       @warnings = []
+      @sca_warning = {}
       performance_config = get_config("performance_config.json")
       linter_config = get_config(".roku_builder_linter.json", true)
       linter_config ||= {is_ssai: false}
@@ -64,7 +68,7 @@ module RokuBuilder
       else
         command = File.join(File.dirname(__FILE__), "sca-cmd", "bin", "sca-cmd.bat")
       end
-      results = `#{command} #{path}`.split("\n")
+      results = `#{@options[:sca_precommand]} #{command} #{path}`.split("\n")
       process_sca_results(results, ssai)
     end
 

data/lib/roku_builder/plugins/line_inspector.rb

@@ -13,38 +13,57 @@ module RokuBuilder
       File.open(file_path) do |file|
         in_xml_comment = false
         indent_inspector = IndentationInspector.new(rules: @indent_config, path: file_path) if @indent_config
+        full_file = []
+        file_no_comments = []
+        lines_to_ignore = []
         file.readlines.each_with_index do |line, line_number|
           full_line = line.dup
-          line = line.partition("'").first if file_path.end_with?(".brs")
+          line.gsub!(/'.*/, "") if file_path.end_with?(".brs")
           if file_path.end_with?(".xml")
             if in_xml_comment
               if line.gsub!(/.*-->/, "")
                 in_xml_comment = false
               else
-                line = ""
+                line = "\n"
               end
             end
             line.gsub!(/<!--.*-->/, "")
             in_xml_comment = true if line.gsub!(/<!--.*/, "")
           end
           indent_inspector.check_line(line: full_line, number: line_number, comment: in_xml_comment) if indent_inspector
-          @inspector_config.each do |line_inspector|
-            line_to_check = line
-            line_to_check = full_line if line_inspector[:include_comments]
+          if  /'.*ignore-warning/i.match(full_line)
+            lines_to_ignore.push line_number
+          end
+          full_file.push(full_line)
+          file_no_comments.push(line)
+        end
+        @warnings += indent_inspector.warnings if indent_inspector
+        no_comments = file_no_comments.join("")
+        file = full_file.join("")
+        @inspector_config.each do |line_inspector|
+          unless line_inspector[:disabled]
+            to_check = no_comments
+            to_check = file if line_inspector[:include_comments]
             match  = nil
-            if line_inspector[:case_sensitive]
-              match = /#{line_inspector[:regex]}/.match(line_to_check)
-            else
-              match = /#{line_inspector[:regex]}/i.match(line_to_check)
-            end
-            if match
-              unless /'.*ignore-warning/i.match(full_line)
-                add_warning(inspector: line_inspector, file: file_path, line: line_number, match: match)
+            start = 0
+            loop do
+              if line_inspector[:case_sensitive]
+                match = /#{line_inspector[:regex]}/.match(to_check, start)
+              else
+                match = /#{line_inspector[:regex]}/i.match(to_check, start)
+              end
+              if match
+                start = match.end(0)
+                line_number = to_check[0..match.begin(0)].split("\n", -1).count - 1
+                unless lines_to_ignore.include?(line_number)
+                  add_warning(inspector: line_inspector, file: file_path, line: line_number, match: match)
+                end
+              else
+                break
               end
             end
           end
         end
-        @warnings += indent_inspector.warnings if indent_inspector
       end
       @warnings
     end

data/lib/roku_builder/plugins/loader.rb

@@ -120,6 +120,7 @@ module RokuBuilder
     def file_path(type)
       file = @config.send(type)[:file]
       file ||= Manifest.new(config: @config).build_version
+      file ||= SecureRandom.uuid
       file = file+".zip" unless file.end_with?(".zip")
       File.join(@config.send(type)[:folder], file)
     end

data/lib/roku_builder/plugins/packager.rb

@@ -61,22 +61,15 @@ module RokuBuilder
       out[:file] ||= "key_"+dev_id+".pkg"
       @config.out = out
 
-      Dir.mktmpdir { |dir|
-        config_copy = @config.dup
-        config_copy.root_dir = dir
-        Manifest.generate({config: config_copy, attributes: {}})
-        Dir.mkdir(File.join(dir, "source"))
-        File.open(File.join(dir, "source", "main.brs"), "w") do |io|
-          io.puts "sub main()"
-          io.puts "  print \"Load\""
-          io.puts "end sub"
-        end
-        loader = Loader.new(config: config_copy)
-        options[:current] = true
-        loader.sideload(options: options)
-        sign_package(app_name_version: "key_"+dev_id, password: password, stage: options[:stage])
-        @logger.unknown("Keyed PKG: #{File.join(@config.out[:folder], @config.out[:file])}")
-      }
+      config_copy = @config.dup
+      config_copy.root_dir = ""
+      config_copy.in[:folder] = File.dirname(__FILE__)
+      config_copy.in[:file] = "key_template.zip"
+      loader = Loader.new(config: config_copy)
+      options[:in] = true
+      loader.sideload(options: options)
+      sign_package(app_name_version: "key_"+dev_id, password: password, stage: options[:stage])
+      @logger.unknown("Keyed PKG: #{File.join(@config.out[:folder], @config.out[:file])}")
     end
 
     # Sets the key on the roku device

data/lib/roku_builder/plugins/performance_config.json

@@ -10,7 +10,7 @@
     "message": "Found DoesExist check. Try using invalid check on dot reference"
   },
   {
-    "regex": "[^\\s]+\\[\"[^\"]+\"\\]",
+    "regex": "\\w+\\[\"[^\"]+\"\\]",
     "severity": "warning",
     "message": "Found AA String reference. Try switching to dot reference"
   },

data/lib/roku_builder/plugins/sca-cmd/bin/sca-cmd

@@ -7,7 +7,7 @@
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
-#      http://www.apache.org/licenses/LICENSE-2.0
+#      https://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ -80,7 +80,8 @@ case "`uname`" in
     ;;
 esac
 
-CLASSPATH=$APP_HOME/lib/sca-cmd.jar
+CLASSPATH=$APP_HOME/lib/sca-cmd.jar:$APP_HOME/lib/sca-library.jar:$APP_HOME/lib/commons-cli-1.4.jar:$APP_HOME/lib/jackson-module-jaxb-annotations-2.12.2.jar:$APP_HOME/lib/jackson-databind-2.12.2.jar:$APP_HOME/lib/jackson-annotations-2.12.2.jar:$APP_HOME/lib/jackson-core-2.12.2.jar:$APP_HOME/lib/jackson-dataformat-xml-2.12.2.jar:$APP_HOME/lib/commons-io-2.8.0.jar:$APP_HOME/lib/commons-lang3-3.12.0.jar:$APP_HOME/lib/commons-compress-1.20.jar:$APP_HOME/lib/woodstox-core-6.2.4.jar:$APP_HOME/lib/stax2-api-4.2.1.jar:$APP_HOME/lib/jakarta.xml.bind-api-2.3.2.jar:$APP_HOME/lib/jakarta.activation-api-1.2.1.jar
+
 
 # Determine the Java command to use to start the JVM.
 if [ -n "$JAVA_HOME" ] ; then
@@ -125,10 +126,11 @@ if $darwin; then
     GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\""
 fi
 
-# For Cygwin, switch paths to Windows format before running java
-if $cygwin ; then
+# For Cygwin or MSYS, switch paths to Windows format before running java
+if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
     APP_HOME=`cygpath --path --mixed "$APP_HOME"`
     CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
+
     JAVACMD=`cygpath --unix "$JAVACMD"`
 
     # We build the pattern for arguments to be converted via cygpath
@@ -154,19 +156,19 @@ if $cygwin ; then
         else
             eval `echo args$i`="\"$arg\""
         fi
-        i=$((i+1))
+        i=`expr $i + 1`
     done
     case $i in
-        (0) set -- ;;
-        (1) set -- "$args0" ;;
-        (2) set -- "$args0" "$args1" ;;
-        (3) set -- "$args0" "$args1" "$args2" ;;
-        (4) set -- "$args0" "$args1" "$args2" "$args3" ;;
-        (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
-        (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
-        (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
-        (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
-        (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
+        0) set -- ;;
+        1) set -- "$args0" ;;
+        2) set -- "$args0" "$args1" ;;
+        3) set -- "$args0" "$args1" "$args2" ;;
+        4) set -- "$args0" "$args1" "$args2" "$args3" ;;
+        5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
+        6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
+        7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
+        8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
+        9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
     esac
 fi
 
@@ -175,14 +177,9 @@ save () {
     for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
     echo " "
 }
-APP_ARGS=$(save "$@")
+APP_ARGS=`save "$@"`
 
 # Collect all arguments for the java command, following the shell quoting and substitution rules
 eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $SCA_CMD_OPTS -classpath "\"$CLASSPATH\"" com.roku.sca.cmd.CommandLineInterface "$APP_ARGS"
 
-# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
-if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
-  cd "$(dirname "$0")"
-fi
-
 exec "$JAVACMD" "$@"

data/lib/roku_builder/plugins/sca-cmd/bin/sca-cmd.bat

@@ -5,7 +5,7 @@
 @rem you may not use this file except in compliance with the License.
 @rem You may obtain a copy of the License at
 @rem
-@rem      http://www.apache.org/licenses/LICENSE-2.0
+@rem      https://www.apache.org/licenses/LICENSE-2.0
 @rem
 @rem Unless required by applicable law or agreed to in writing, software
 @rem distributed under the License is distributed on an "AS IS" BASIS,
@@ -29,6 +29,9 @@ if "%DIRNAME%" == "" set DIRNAME=.
 set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%..
 
+@rem Resolve any "." and ".." in APP_HOME to make it shorter.
+for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
+
 @rem Add default JVM options here. You can also use JAVA_OPTS and SCA_CMD_OPTS to pass JVM options to this script.
 set DEFAULT_JVM_OPTS=
 
@@ -37,7 +40,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
 
 set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
-if "%ERRORLEVEL%" == "0" goto init
+if "%ERRORLEVEL%" == "0" goto execute
 
 echo.
 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -51,7 +54,7 @@ goto fail
 set JAVA_HOME=%JAVA_HOME:"=%
 set JAVA_EXE=%JAVA_HOME%/bin/java.exe
 
-if exist "%JAVA_EXE%" goto init
+if exist "%JAVA_EXE%" goto execute
 
 echo.
 echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
@@ -61,28 +64,14 @@ echo location of your Java installation.
 
 goto fail
 
-:init
-@rem Get command-line arguments, handling Windows variants
-
-if not "%OS%" == "Windows_NT" goto win9xME_args
-
-:win9xME_args
-@rem Slurp the command line arguments.
-set CMD_LINE_ARGS=
-set _SKIP=2
-
-:win9xME_args_slurp
-if "x%~1" == "x" goto execute
-
-set CMD_LINE_ARGS=%*
-
 :execute
 @rem Setup the command line
 
-set CLASSPATH=%APP_HOME%\lib\sca-cmd.jar
+set CLASSPATH=%APP_HOME%\lib\sca-cmd.jar;%APP_HOME%\lib\sca-library.jar;%APP_HOME%\lib\commons-cli-1.4.jar;%APP_HOME%\lib\jackson-module-jaxb-annotations-2.12.2.jar;%APP_HOME%\lib\jackson-databind-2.12.2.jar;%APP_HOME%\lib\jackson-annotations-2.12.2.jar;%APP_HOME%\lib\jackson-core-2.12.2.jar;%APP_HOME%\lib\jackson-dataformat-xml-2.12.2.jar;%APP_HOME%\lib\commons-io-2.8.0.jar;%APP_HOME%\lib\commons-lang3-3.12.0.jar;%APP_HOME%\lib\commons-compress-1.20.jar;%APP_HOME%\lib\woodstox-core-6.2.4.jar;%APP_HOME%\lib\stax2-api-4.2.1.jar;%APP_HOME%\lib\jakarta.xml.bind-api-2.3.2.jar;%APP_HOME%\lib\jakarta.activation-api-1.2.1.jar
+
 
 @rem Execute sca-cmd
-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %SCA_CMD_OPTS%  -classpath "%CLASSPATH%" com.roku.sca.cmd.CommandLineInterface %CMD_LINE_ARGS%
+"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %SCA_CMD_OPTS%  -classpath "%CLASSPATH%" com.roku.sca.cmd.CommandLineInterface %*
 
 :end
 @rem End local scope for the variables with windows NT shell

data/lib/roku_builder/version.rb

@@ -2,5 +2,5 @@
 
 module RokuBuilder
   # Version of the RokuBuilder Gem
-  VERSION = "4.21.4"
+  VERSION = "4.22.3"
 end

data/test/roku_builder/plugins/test_analyzer.rb

@@ -106,7 +106,7 @@ module RokuBuilder
       warnings = test_file(text: "function test() as String 'IGNORE-WARNING\n? \"test\"\nend function")
       assert_equal 0, warnings.count
     end
-    def test_performance_for_loop_title_case
+    def test_performance_for_each_loop_title_case
       warnings = test_file(text: "For each button in buttons\n ? button\nEND FOR")
       assert_equal 0, warnings.count
     end
@@ -148,6 +148,7 @@ module RokuBuilder
       end
 
       logger.verify
+      warnings
     end
 
     def test(quiet=true)

data/test/roku_builder/plugins/test_profiler.rb

@@ -32,7 +32,8 @@ module RokuBuilder
       end
       count = 0
       read_stub = Proc.new do |size|
-        raise SystemExit if count = 2
+        shouldExit = (count = 2)
+        raise SystemExit if shouldExit
         count += 1
       end
       connection = Minitest::Mock.new

data/test/roku_builder/test_options.rb

@@ -32,14 +32,13 @@ module RokuBuilder
     end
     def test_options_parse
       parser = Minitest::Mock.new()
-      options_hash = {}
       options = Options.allocate
       parser.expect(:banner=, nil, [String])
       parser.expect(:parse!, nil)
       OptionParser.stub(:new, parser) do
         options.stub(:add_plugin_options, nil) do
           options.stub(:validate_parser, nil) do
-            options_hash = options.send(:parse)
+            options.send(:parse)
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roku_builder
 version: !ruby/object:Gem::Version
-  version: 4.21.4
+  version: 4.22.3
 platform: ruby
 authors:
 - greeneca
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2021-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -490,6 +490,7 @@ files:
 - lib/roku_builder/plugins/indentation_inspector.rb
 - lib/roku_builder/plugins/inspector.rb
 - lib/roku_builder/plugins/inspector_config.json
+- lib/roku_builder/plugins/key_template.zip
 - lib/roku_builder/plugins/line_inspector.rb
 - lib/roku_builder/plugins/linker.rb
 - lib/roku_builder/plugins/loader.rb
@@ -631,7 +632,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Build Tool for Roku Apps