roku_builder 4.11.3 → 4.11.4

Sign up to get free protection for your applications and to get access to all the features.
Files changed (8) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG +6 -1
  3. data/lib/roku_builder/plugins/manifest_inspector.rb +5 -1
  4. data/lib/roku_builder/version.rb +1 -1
  5. data/test/roku_builder/plugins/test_analyzer.rb +9 -0
  6. data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_hex +9 -0
  7. data/test/roku_builder/test_files/analyzer_test/manifest_template +2 -1
  8. metadata +4 -2
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 8a5ab9b3a553aa4583d07d6a1f901c6bf50864ba
4
- data.tar.gz: eef319757caebfe83cb0f5dbbc8080e173c70af7
3
+ metadata.gz: b5ff53d58db2b0e25b2a1f69adc4b608b944ca66
4
+ data.tar.gz: e789f00b0ff15f7d9cf35f2b0231249121d0a95e
5
5
  SHA512:
6
- metadata.gz: bbdcff01fc3ed28bc122da08425983916d7b0e6b313f0ad9952c5ba81caec908e99166c78b36c095ed4d99deae803aec9c458d37e5af447d138a4880c49d924b
7
- data.tar.gz: 4cbffd6f78db920dad7963af21a9b3b636fe422a2cbca1c82b46ca9f5b67483317e52146bd622fa021004cd0ea19bdc8a3c636e33398a4d46d6004d5965e0097
6
+ metadata.gz: f425564a2047cc34286b01a8f3345d3bed8a4f34af093588b9a34afeac9bfe93aab30bf8760442b8f1bab893696bf8822635cef1a0face8b30957e8c73a5d291
7
+ data.tar.gz: f3c04017c0498c4596508dadcebe0a4eb0a24faaee44329556b29d5c79240f71b8b53e62587d2c5a163345d8168673a436a508f49bcf7e0779b9f358beff0ee5
data/CHANGELOG CHANGED
@@ -1,4 +1,9 @@
1
- = 4.11.2 =
1
+ = 4.11.4 =
2
+
3
+ - Allow leading zeros on manifest integers
4
+ - Add missing hex manifest validation
5
+
6
+ = 4.11.3 =
2
7
 
3
8
  - Fix syntax error
4
9
  - Fix tests
data/lib/roku_builder/plugins/manifest_inspector.rb CHANGED
@@ -46,7 +46,11 @@ module RokuBuilder
46
46
  attribute_config[:validations].each_pair do |type, value|
47
47
  case type
48
48
  when :integer
49
- unless @attributes[key].to_i.to_s == @attributes[key]
49
+ unless "%0#{@attributes[key].length}i" % @attributes[key].to_i == @attributes[key]
50
+ add_warning(warning: :manifestInvalidValue, key: key)
51
+ end
52
+ when :hex
53
+ unless @attributes[key][0] == "#" and !@attributes[key][1..-1][/\H/]
50
54
  add_warning(warning: :manifestInvalidValue, key: key)
51
55
  end
52
56
  when :float
data/lib/roku_builder/version.rb CHANGED
@@ -2,5 +2,5 @@
2
2
 
3
3
  module RokuBuilder
4
4
  # Version of the RokuBuilder Gem
5
- VERSION = "4.11.3"
5
+ VERSION = "4.11.4"
6
6
  end
data/test/roku_builder/plugins/test_analyzer.rb CHANGED
@@ -39,6 +39,7 @@ module RokuBuilder
39
39
  def test_clean_app
40
40
  warnings = test
41
41
  assert_equal Array, warnings.class
42
+ assert_equal 0, warnings.count
42
43
  end
43
44
  def test_manifest_duplicate_attribute
44
45
  warnings = test_manifest("manifest_duplicate_attribute")
@@ -69,6 +70,14 @@ module RokuBuilder
69
70
  assert_equal 2, warnings[0][:line]
70
71
  assert_equal "manifest", warnings[0][:path]
71
72
  end
73
+ def test_manifest_invalid_value_hex
74
+ warnings = test_manifest("manifest_invalid_value_hex")
75
+ assert_equal 1, warnings.count
76
+ assert_match(/splash_color/, warnings[0][:message])
77
+ assert_match(/bad/, warnings[0][:message])
78
+ assert_equal 9, warnings[0][:line]
79
+ assert_equal "manifest", warnings[0][:path]
80
+ end
72
81
  def test_manifest_invalid_value_float
73
82
  warnings = test_manifest("manifest_invalid_value_float")
74
83
  assert_equal 1, warnings.count
data/test/roku_builder/test_files/analyzer_test/manifest_invalid_value_hex ADDED
@@ -0,0 +1,9 @@
1
+ title=Test
2
+ major_version=1
3
+ minor_version=0
4
+ build_version=01
5
+ mm_icon_focus_hd=pkg:/images/focus_hd.png
6
+ mm_icon_focus_sd=pkg:/images/focus_sd.png
7
+ splash_screen_hd=pkg:/images/splash_hd.png
8
+ splash_screen_sd=pkg:/images/splash_sd.png
9
+ splash_color=bad
data/test/roku_builder/test_files/analyzer_test/manifest_template CHANGED
@@ -1,8 +1,9 @@
1
1
  title=Test
2
2
  major_version=1
3
3
  minor_version=0
4
- build_version=1
4
+ build_version=01
5
5
  mm_icon_focus_hd=pkg:/images/focus_hd.png
6
6
  mm_icon_focus_sd=pkg:/images/focus_sd.png
7
7
  splash_screen_hd=pkg:/images/splash_hd.png
8
8
  splash_screen_sd=pkg:/images/splash_sd.png
9
+ splash_color=#121212
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: roku_builder
3
3
  version: !ruby/object:Gem::Version
4
- version: 4.11.3
4
+ version: 4.11.4
5
5
  platform: ruby
6
6
  authors:
7
7
  - greeneca
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-01-07 00:00:00.000000000 Z
11
+ date: 2019-01-08 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubyzip
@@ -537,6 +537,7 @@ files:
537
537
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean
538
538
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_equals
539
539
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_float
540
+ - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_hex
540
541
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_integer
541
542
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_negative
542
543
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_not_equal
@@ -662,6 +663,7 @@ test_files:
662
663
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_boolean
663
664
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_equals
664
665
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_float
666
+ - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_hex
665
667
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_integer
666
668
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_negative
667
669
  - test/roku_builder/test_files/analyzer_test/manifest_invalid_value_not_equal