roku_builder 3.13.0 → 4.0.0

data/test/roku_builder/test_config_validator.rb

@@ -4,6 +4,9 @@ require_relative "test_helper.rb"
 
 module RokuBuilder
   class ConfigValidatorTest < Minitest::Test
+    def setup
+      Logger.set_testing
+    end
 
     def test_config_manager_validate_devices
       config = good_config
@@ -191,9 +194,23 @@ module RokuBuilder
 
     def test_config_manager_validate_input_mappings
       config = good_config
-      config[:input_mapping]["a"] = ["home"]
+      config[:input_mappings]["a"] = ["home"]
       validator = ConfigValidator.new(config: config)
       assert_equal [21], validator.instance_variable_get(:@codes)
     end
+
+    def test_config_manager_validate_project_stage_method_bad
+      config = good_config
+      config[:projects][:project2][:stage_method] = :bad
+      validator = ConfigValidator.new(config: config)
+      assert_equal [18], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_stage_method_missing
+      config = good_config
+      config[:projects][:project2][:stage_method] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [23], validator.instance_variable_get(:@codes)
+    end
   end
 end

data/test/roku_builder/test_files/config_test/config.json

@@ -25,5 +25,8 @@
         }
       }
     }
+  },
+  "input_mappings": {
+    "a": ["home", "Home"]
   }
 }

data/test/roku_builder/test_files/controller_commands_test/manifest_template

@@ -0,0 +1,7 @@
+#comment
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/core_test/manifest_template

@@ -0,0 +1,7 @@
+#comment
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/inspector_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/linker_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/loader_test/manifest_template

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/manifest_test/manifest_comments

@@ -0,0 +1,6 @@
+#comment
+title=title
+
+other=
+other2=val#comment
+other3=#comment

data/test/roku_builder/test_files/manifest_test/manifest_template

@@ -0,0 +1,7 @@
+#comment
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/packager_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/packager_test/scripter_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/roku_builder_test/config.json

@@ -0,0 +1,32 @@
+{
+  "devices": {
+    "default": "roku",
+    "roku": {
+      "ip": "111.222.333.444",
+      "user": "user",
+      "password": "pass"
+    }
+  },
+  "projects": {
+    "default": "p1",
+    "p1": {
+      "directory": "/tmp",
+      "folders": ["resources","source"],
+      "files": ["manifest"],
+      "app_name": "app",
+      "stage_method": "git",
+      "stages":{
+        "production": {
+          "branch": "master",
+          "key": {
+            "keyed_pkg": "/tmp/package.pkg",
+            "password": "password"
+          }
+        }
+      }
+    }
+  },
+  "input_mappings": {
+    "a": ["home", "Home"]
+  }
+}

data/test/roku_builder/test_files/scripter_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_files/tester_test/manifest

@@ -0,0 +1,6 @@
+title=Test
+major_version=1
+minor_version=0
+build_version=010101.1
+mm_icon_focus_hd=pkg:/images/focus.png
+mm_icon_focus_sd=pkg:/images/focus.png

data/test/roku_builder/test_helper.rb

@@ -12,19 +12,52 @@ SimpleCov.start
 require "byebug"
 require "roku_builder"
 require "minitest/autorun"
+require "minitest/utils"
+require "webmock/minitest"
+
 
 RokuBuilder::Logger.set_testing
+WebMock.disable_net_connect!
+def register_plugins(plugin_class)
+  plugins = [plugin_class]
+  plugins.each do |plugin|
+    plugins.concat(plugin.dependencies)
+    unless RokuBuilder.plugins.include?(plugin)
+      RokuBuilder.register_plugin(plugin)
+    end
+  end
+end
+def build_config_options_objects(klass, options = {validate: true}, empty_plugins = true)
+  options = build_options(options, empty_plugins)
+  config = RokuBuilder::Config.new(options: options)
+  config.instance_variable_set(:@config, good_config(klass))
+  config.parse
+  [config, options]
+end
+
+def build_config_object(klass, options= {validate: true}, empty_plugins = true)
+  build_config_options_objects(klass, options, empty_plugins).first
+end
 
 def test_files_path(klass)
   klass = klass.to_s.split("::")[1].underscore
   File.join(File.dirname(__FILE__), "test_files", klass)
 end
 
-def build_options(options)
-  RokuBuilder::Options.new(options: options)
+def build_options(options = {validate: true}, empty_plugins = true)
+  if empty_plugins
+    RokuBuilder.class_variable_set(:@@plugins, [])
+    require "roku_builder/plugins/core"
+    RokuBuilder.register_plugin(RokuBuilder::Core)
+  end
+  options = RokuBuilder::Options.new(options: options)
+  options.validate
+  options
 end
 
-def good_config
+def good_config(klass=nil)
+  root_dir = "/tmp"
+  root_dir = test_files_path(klass) if klass
   {
     devices: {
     default: :roku,
@@ -37,7 +70,7 @@ def good_config
     projects: {
     default: :project1,
     project1: {
-    directory: "/tmp",
+    directory: root_dir,
     folders: ["resources","source"],
     files: ["manifest"],
     app_name: "<app name>",
@@ -46,21 +79,21 @@ def good_config
     production: {
     branch: "production",
     key: {
-    keyed_pkg: "/tmp",
-    password: "<password for pkg>"
+    keyed_pkg: File.join(root_dir, "test.pkg"),
+    password: "password"
   }
   }
   }
   },
     project2: {
-    directory: "/tmp",
+    directory: root_dir,
     folders: ["resources","source"],
     files: ["manifest"],
     app_name: "<app name>",
-    stage_method: :git,
+    stage_method: :script,
     stages:{
     production: {
-    branch: "production",
+    script: {stage: "stage_script", unstage: "unstage_script"},
     key: "a"
   }
   }
@@ -68,11 +101,11 @@ def good_config
   },
     keys: {
     a: {
-    keyed_pkg: "/tmp",
+    keyed_pkg: File.join(root_dir, "test.pkg"),
     password: "password"
   }
   },
-    input_mapping: {
+    input_mappings: {
     "a": ["home", "Home"]
   }
   }

data/test/roku_builder/test_logger.rb

@@ -6,6 +6,7 @@ module RokuBuilder
   class LoggerTest < Minitest::Test
 
     def test_logger
+      Logger.class_variable_set(:@@instance, nil)
       logger_a = Logger.instance
       logger_b = Logger.instance
       assert_equal logger_a, logger_b

data/test/roku_builder/test_manifest.rb

@@ -0,0 +1,99 @@
+# ********** Copyright Viacom, Inc. Apache 2.0 **********
+
+require_relative "test_helper.rb"
+module RokuBuilder
+  class ManifestTest < Minitest::Test
+    def setup
+      options = build_options
+      @root_dir = test_files_path(ManifestTest)
+      @config = Config.new(options: options)
+      @config.instance_variable_set(:@parsed, {root_dir: @root_dir})
+      FileUtils.cp(File.join(@root_dir, "manifest_template"), File.join(@root_dir, "manifest"))
+      Logger.set_testing
+    end
+    def teardown
+      path = File.join(@config.parsed[:root_dir], "manifest")
+      FileUtils.rm(path) if File.exist?(path)
+      @config = nil
+    end
+    def test_manifest_read
+      Manifest.new(config: @config)
+    end
+    def test_manifest_read_missing
+      FileUtils.rm(File.join(@config.parsed[:root_dir], "manifest"))
+      assert_raises ManifestError do
+        Manifest.new(config: @config)
+      end
+    end
+    def test_manifest_tite
+      manifest = Manifest.new(config: @config)
+      assert_equal "Test", manifest.title
+    end
+    def test_manifest_build_version
+      manifest = Manifest.new(config: @config)
+      assert_equal "010101.1", manifest.build_version
+    end
+    def test_manifest_build_version_zip
+      @config.instance_variable_set(:@parsed, {root_dir: File.join(@root_dir, "test.zip")})
+      manifest = Manifest.new(config: @config)
+      assert_equal "010101.1", manifest.build_version
+    end
+    def test_manifest_update_attributes
+      manifest = Manifest.new(config: @config)
+      attributes = {
+        title: "New Title"
+      }
+      manifest.update(attributes: attributes)
+      manifest = Manifest.new(config: @config)
+      assert_equal attributes[:title], manifest.title
+    end
+    def test_manifest_update_empty
+      manifest = Manifest.new(config: @config)
+      attributes = {}
+      manifest.update(attributes: attributes)
+      assert FileUtils.compare_file(File.join(@root_dir, "manifest"), File.join(@root_dir, "manifest_template"))
+    end
+    def test_manifest_update_with_comments
+      FileUtils.cp(File.join(@root_dir, "manifest_comments"), File.join(@root_dir, "manifest"))
+      manifest = Manifest.new(config: @config)
+      attributes = {}
+      manifest.update(attributes: attributes)
+      assert FileUtils.compare_file(File.join(@root_dir, "manifest"), File.join(@root_dir, "manifest_comments"))
+    end
+    def test_manifest_generate
+      FileUtils.rm(File.join(@root_dir, "manifest"))
+      attributes = {
+        title: "New Title"
+      }
+      manifest = Manifest.generate(config: @config,  attributes: attributes)
+      assert_equal attributes[:title], manifest.title
+      assert !!manifest.major_version
+      assert !!manifest.minor_version
+      assert !!manifest.build_version
+      assert !!manifest.mm_icon_focus_fhd
+      assert !!manifest.mm_icon_focus_hd
+      assert !!manifest.mm_icon_focus_sd
+    end
+    def test_manifest_increment_build_version
+      manifest = Manifest.new(config: @config)
+      assert_equal "010101.1", manifest.build_version
+      Time.stub(:now, Time.new(2001, 02, 01)) do
+        manifest.increment_build_version
+      end
+      manifest = Manifest.new(config: @config)
+      assert_equal "020101.2", manifest.build_version
+    end
+    def test_manifest_increment_single_part_build_version
+      manifest = Manifest.new(config: @config)
+      attributes = {
+        build_version: "1"
+      }
+      manifest.update(attributes: attributes)
+      assert_equal "1", manifest.build_version
+      manifest.increment_build_version
+      manifest = Manifest.new(config: @config)
+      assert_equal "2", manifest.build_version
+    end
+  end
+end
+

data/test/roku_builder/test_options.rb

@@ -4,10 +4,94 @@ require_relative "test_helper.rb"
 
 module RokuBuilder
   class OptionsTest < Minitest::Test
+    def setup
+      RokuBuilder.class_variable_set(:@@plugins, [])
+      Logger.set_testing
+    end
+    def teardown
+      RokuBuilder.class_variable_set(:@@plugins, [])
+    end
+    def test_options_initialize_no_params
+      count = 0
+      parse_stub = lambda{ count+= 1; {validate: true} }
+      options = Options.allocate
+      options.stub(:parse, parse_stub) do
+        options.send(:initialize)
+      end
+      assert_equal 1, count
+    end
+    def test_options_initialize_params
+      count = 0
+      parse_stub = lambda{ count+= 1; {validate: true} }
+      options = Options.allocate
+      options.stub(:parse, parse_stub) do
+        options.send(:initialize, {options: {validate: true}})
+      end
+      assert_equal 0, count
+    end
+    def test_options_parse
+      parser = Minitest::Mock.new()
+      options_hash = {}
+      options = Options.allocate
+      parser.expect(:banner=, nil, [String])
+      parser.expect(:parse!, nil)
+      OptionParser.stub(:new, parser) do
+        options.stub(:validate_parser, nil) do
+          options_hash = options.send(:parse)
+        end
+      end
+      parser.verify
+    end
+    def test_options_parse_validate_options_good
+      Array.class_eval { alias_method :each_option, :each  }
+      parser = Minitest::Mock.new()
+      options = Options.allocate
+      parser.expect(:instance_variable_get, build_stack, [:@stack])
+      parser.expect(:banner=, nil, [String])
+      parser.expect(:parse!, nil)
+      OptionParser.stub(:new, parser) do
+        options.send(:parse)
+      end
+      parser.verify
+      Array.class_eval { remove_method :each_option  }
+    end
+    def test_options_parse_validate_options_bad
+      Array.class_eval { alias_method :each_option, :each  }
+      parser = Minitest::Mock.new()
+      options = Options.allocate
+      parser.expect(:banner=, nil, [String])
+      parser.expect(:instance_variable_get, build_stack(false), [:@stack])
+
+      OptionParser.stub(:new, parser) do
+        assert_raises(ImplementationError) do
+          options.send(:parse)
+        end
+      end
+      parser.verify
+      Array.class_eval { remove_method :each_option  }
+    end
+    def build_stack(good = true)
+      optionsA = Minitest::Mock.new()
+      optionsB = Minitest::Mock.new()
+      list = [optionsA, optionsB]
+      stack = [list]
+      3.times do
+        optionsA.expect(:short, [ "a" ])
+        optionsA.expect(:long, [ "aOption" ])
+        if good
+          optionsB.expect(:short, [ "b" ])
+          optionsB.expect(:long, ["bOption" ])
+        else
+          optionsB.expect(:short, [ "a" ])
+          optionsB.expect(:long, [ "aOption" ])
+        end
+      end
+      stack
+    end
     def test_options_validate_extra_commands
       options = {
-        sideload: true,
-        package: true
+        configure: true,
+        validate: true
       }
       assert_raises InvalidOptions do
         build_options(options)
@@ -21,7 +105,7 @@ module RokuBuilder
     end
     def test_options_validate_extra_sources_sideload
       options = {
-        sideload: true,
+        validate: true,
         working: true,
         current: true
       }
@@ -29,125 +113,70 @@ module RokuBuilder
         build_options(options)
       end
     end
-    def test_options_validate_working
-      options = {
-        sideload: true,
-        working: true
-      }
-      build_options(options)
-    end
-    def test_options_validate_no_source
-      options = {
-        package: true
-      }
-      assert_raises InvalidOptions do
-        build_options(options)
-      end
-    end
-    def test_options_validate_bad_current
-      options = {
-        package: true,
-        current: true
-      }
-      assert_raises InvalidOptions do
-        build_options(options)
-      end
-    end
-    def test_options_validate_bad_in
-      options = {
-        package: true,
-        in: true
-      }
-      assert_raises InvalidOptions do
-        build_options(options)
-      end
-    end
-    def test_options_validate_depricated
-      options = {
-        deeplink: "a:b c:d",
-        deeplink_depricated: true
-      }
-      build_options(options)
-    end
-    def test_options_validate_current
-      options = {
-        sideload: true,
-        current: true
-      }
-      build_options(options)
-    end
     def test_options_validate_extra_sources_package
       options = {
-        package: true,
+        validate: true,
         in: "",
-        set_stage: true
+        stage: "production"
       }
       assert_raises InvalidOptions do
         build_options(options)
       end
     end
-    def test_options_exclude_command_package
+    def test_options_exclude_command
       options = build_options({
-        package:true,
-        set_stage: true
+        validate:true,
       })
+      options.define_singleton_method(:exclude_commands) {[:validate]}
       assert options.exclude_command?
     end
-    def test_options_exclude_command_build
+    def test_options_exclude_command_false
       options = build_options({
-        build:true,
-        set_stage: true
-      })
-      assert options.exclude_command?
-    end
-    def test_options_exclude_command_sideload
-      options = build_options({
-        sideload:true,
-        set_stage: true
+        validate:true,
       })
       refute options.exclude_command?
     end
-    def test_options_source_command_sideload
+    def test_options_source_command
       options = build_options({
-        sideload:true,
-        working: true
+        validate:true,
       })
+      options.define_singleton_method(:source_commands) {[:validate]}
       assert options.source_command?
     end
-    def test_options_source_command_deeplink
+    def test_options_source_commandfalse
       options = build_options({
-        deeplink: true,
+        validate: true,
       })
       refute options.source_command?
     end
     def test_options_command
       options = build_options({
-        deeplink: true,
+        validate: true,
       })
-      assert_equal :deeplink, options.command
+      assert_equal :validate, options.command
     end
     def test_options_device_command_true
       options = build_options({
-        deeplink: true,
+        validate: true,
       })
+      options.define_singleton_method(:device_commands) {[:validate]}
       assert options.device_command?
     end
     def test_options_device_command_false
       options = build_options({
-        build: true,
-        working: true
+        validate: true,
       })
       refute options.device_command?
     end
     def test_options_has_source_false
       options = build_options({
-        deeplink: true,
+        validate: true,
       })
       refute options.has_source?
     end
     def test_options_has_source_true
       options = build_options({
-        deeplink: true,
+        validate: true,
         working: true
       })
       assert options.has_source?