roku_builder 3.12.8 → 3.13.0

data/test/roku_builder/test_config_validator.rb

@@ -2,195 +2,198 @@
 
 require_relative "test_helper.rb"
 
-class ConfigValidatorTest < Minitest::Test
-
-  def test_config_manager_validate_devices
-    config = good_config
-    config[:devices] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [1], codes
-  end
-
-  def test_config_manager_validate_devices_default
-    config = good_config
-    config[:devices][:default] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [2], codes
-  end
-
-  def test_config_manager_validate_devices_default_is_symbol
-    config = good_config
-    config[:devices][:default] = "bad"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [3], codes
-  end
-
-  def test_config_manager_validate_device_ip
-    config = good_config
-    config[:devices][:roku][:ip] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [7], codes
-  end
-
-  def test_config_manager_validate_device_ip_empty
-    config = good_config
-    config[:devices][:roku][:ip] = ""
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [7], codes
-  end
-
-  def test_config_manager_validate_device_ip_default_value
-    config = good_config
-    config[:devices][:roku][:ip] = "xxx.xxx.xxx.xxx"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [7], codes
-  end
-
-  def test_config_manager_validate_device_user
-    config = good_config
-    config[:devices][:roku][:user] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [8], codes
-  end
-
-  def test_config_manager_validate_device_user_empty
-    config = good_config
-    config[:devices][:roku][:user] = ""
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [8], codes
-  end
-
-  def test_config_manager_validate_device_user_default_value
-    config = good_config
-    config[:devices][:roku][:user] = "<username>"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [8], codes
-  end
-
-  def test_config_manager_validate_device_password
-    config = good_config
-    config[:devices][:roku][:password] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [9], codes
-  end
-
-  def test_config_manager_validate_device_password_empty
-    config = good_config
-    config[:devices][:roku][:password] = ""
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [9], codes
-  end
-
-  def test_config_manager_validate_device_password_default_value
-    config = good_config
-    config[:devices][:roku][:password] = "<password>"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [9], codes
-  end
-
-  def test_config_manager_validate_projects
-    config = good_config
-    config[:projects] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [0], codes
-  end
-
-  def test_config_manager_validate_projects_default
-    config = good_config
-    config[:projects][:default] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [5], codes
-  end
-
-  def test_config_manager_validate_projects_default_default_value
-    config = good_config
-    config[:projects][:default] = "<project id>".to_sym
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [5], codes
-  end
-
-  def test_config_manager_validate_projects_default_is_symbol
-    config = good_config
-    config[:projects][:default] = "project_id"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [6], codes
-  end
-
-  def test_config_manager_validate_project_app_name
-    config = good_config
-    config[:projects][:project1][:app_name] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [10], codes
-  end
-
-  def test_config_manager_validate_project_directory
-    config = good_config
-    config[:projects][:project1][:directory] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [11], codes
-  end
-
-  def test_config_manager_validate_project_folders
-    config = good_config
-    config[:projects][:project1][:folders] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [12], codes
-  end
-
-  def test_config_manager_validate_project_folders_is_array
-    config = good_config
-    config[:projects][:project1][:folders] = "Folders"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [13], codes
-  end
-
-  def test_config_manager_validate_project_files
-    config = good_config
-    config[:projects][:project1][:files] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [14], codes
-  end
-
-  def test_config_manager_validate_project_filess_is_array
-    config = good_config
-    config[:projects][:project1][:files] = "Files"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [15], codes
-  end
-
-  def test_config_manager_validate_project_key
-    config = good_config
-    config[:projects][:project2][:stages][:production][:key] = "b"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [22], codes
-  end
-
-  def test_config_manager_validate_keys_pkg
-    config = good_config
-    config[:keys][:a][:keyed_pkg] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [19], codes
-    config = good_config
-    config[:keys][:a][:keyed_pkg] = "<path/to/signed/package>"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [19], codes
-  end
-
-  def test_config_manager_validate_keys_password
-    config = good_config
-    config[:keys][:a][:password] = nil
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [20], codes
-    config = good_config
-    config[:keys][:a][:password] = "<password>"
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [20], codes
-  end
-
-  def test_config_manager_validate_input_mappings
-    config = good_config
-    config[:input_mapping]["a"] = ["home"]
-    codes = RokuBuilder::ConfigValidator.validate_config(config: config)
-    assert_equal [21], codes
+module RokuBuilder
+  class ConfigValidatorTest < Minitest::Test
+
+    def test_config_manager_validate_devices
+      config = good_config
+      config[:devices] = nil
+      validator = ConfigValidator.new(config: config)
+      assert validator.is_fatal?
+      assert_equal [1], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_devices_default
+      config = good_config
+      config[:devices][:default] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [2], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_devices_default_is_symbol
+      config = good_config
+      config[:devices][:default] = "bad"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [3], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_ip
+      config = good_config
+      config[:devices][:roku][:ip] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [7], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_ip_empty
+      config = good_config
+      config[:devices][:roku][:ip] = ""
+      validator = ConfigValidator.new(config: config)
+      assert_equal [7], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_ip_default_value
+      config = good_config
+      config[:devices][:roku][:ip] = "xxx.xxx.xxx.xxx"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [7], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_user
+      config = good_config
+      config[:devices][:roku][:user] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [8], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_user_empty
+      config = good_config
+      config[:devices][:roku][:user] = ""
+      validator = ConfigValidator.new(config: config)
+      assert_equal [8], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_user_default_value
+      config = good_config
+      config[:devices][:roku][:user] = "<username>"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [8], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_password
+      config = good_config
+      config[:devices][:roku][:password] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [9], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_password_empty
+      config = good_config
+      config[:devices][:roku][:password] = ""
+      validator = ConfigValidator.new(config: config)
+      assert_equal [9], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_device_password_default_value
+      config = good_config
+      config[:devices][:roku][:password] = "<password>"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [9], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_projects
+      config = good_config
+      config[:projects] = nil
+      validator = ConfigValidator.new(config: config)
+      assert validator.is_valid?
+    end
+
+    def test_config_manager_validate_projects_default
+      config = good_config
+      config[:projects][:default] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [5], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_projects_default_default_value
+      config = good_config
+      config[:projects][:default] = "<project id>".to_sym
+      validator = ConfigValidator.new(config: config)
+      assert_equal [5], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_projects_default_is_symbol
+      config = good_config
+      config[:projects][:default] = "project_id"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [6], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_app_name
+      config = good_config
+      config[:projects][:project1][:app_name] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [10], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_directory
+      config = good_config
+      config[:projects][:project1][:directory] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [11], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_folders
+      config = good_config
+      config[:projects][:project1][:folders] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [12], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_folders_is_array
+      config = good_config
+      config[:projects][:project1][:folders] = "Folders"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [13], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_files
+      config = good_config
+      config[:projects][:project1][:files] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [14], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_filess_is_array
+      config = good_config
+      config[:projects][:project1][:files] = "Files"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [15], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_project_key
+      config = good_config
+      config[:projects][:project2][:stages][:production][:key] = "b"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [22], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_keys_pkg
+      config = good_config
+      config[:keys][:a][:keyed_pkg] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [19], validator.instance_variable_get(:@codes)
+      config = good_config
+      config[:keys][:a][:keyed_pkg] = "<path/to/signed/package>"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [19], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_keys_password
+      config = good_config
+      config[:keys][:a][:password] = nil
+      validator = ConfigValidator.new(config: config)
+      assert_equal [20], validator.instance_variable_get(:@codes)
+      config = good_config
+      config[:keys][:a][:password] = "<password>"
+      validator = ConfigValidator.new(config: config)
+      assert_equal [20], validator.instance_variable_get(:@codes)
+    end
+
+    def test_config_manager_validate_input_mappings
+      config = good_config
+      config[:input_mapping]["a"] = ["home"]
+      validator = ConfigValidator.new(config: config)
+      assert_equal [21], validator.instance_variable_get(:@codes)
+    end
   end
 end

data/test/roku_builder/test_controller.rb

@@ -1,188 +1,69 @@
 # ********** Copyright Viacom, Inc. Apache 2.0 **********
 
 require_relative "test_helper.rb"
-
-class ControllerTest < Minitest::Test
-  def test_controller_validate_options
-    options = {
-      sideload: true,
-      package: true
-    }
-    assert_equal RokuBuilder::EXTRA_COMMANDS, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {}
-    assert_equal RokuBuilder::NO_COMMANDS,  RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      sideload: true,
-      working: true,
-      current: true
-    }
-    assert_equal RokuBuilder::EXTRA_SOURCES, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      sideload: true,
-      working: true
-    }
-    assert_equal RokuBuilder::VALID, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      package: true
-    }
-    assert_equal RokuBuilder::NO_SOURCE, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      package: true,
-      current: true
-    }
-    assert_equal RokuBuilder::BAD_CURRENT, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      package: true,
-      in: true
-    }
-    assert_equal RokuBuilder::BAD_IN_FILE, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      deeplink: "a:b c:d",
-      deeplink_depricated: true
-    }
-    assert_equal RokuBuilder::DEPRICATED, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      sideload: true,
-      current: true
-    }
-    assert_equal RokuBuilder::VALID, RokuBuilder::Controller.send(:validate_options, {options: options})
-    options = {
-      package: true,
-      in: "",
-      set_stage: true
-    }
-    assert_equal RokuBuilder::EXTRA_SOURCES, RokuBuilder::Controller.send(:validate_options, {options: options})
-  end
-  def test_controller_configure
-    logger = Logger.new("/dev/null")
-    target_config = File.join(File.dirname(__FILE__), "test_files", "controller_test", "configure_test.json")
-    File.delete(target_config) if File.exist?(target_config)
-    assert !File.exist?(target_config)
-
-    options = {
-      configure: true,
-      config: target_config,
-    }
-
-    code = RokuBuilder::Controller.send(:configure, {options: options, logger: logger})
-
-    assert File.exist?(target_config)
-
-    options = {
-      configure: true,
-      config: target_config,
-      edit_params: "ip:111.222.333.444"
-    }
-
-    code = RokuBuilder::Controller.send(:configure, {options: options, logger: logger})
-
-    assert File.exist?(target_config)
-    config = RokuBuilder::ConfigManager.get_config(config: target_config, logger: logger)
-    assert_equal "111.222.333.444", config[:devices][config[:devices][:default]][:ip]
-
-    options = {
-      configure: true,
-      config: target_config
-    }
-
-    code = RokuBuilder::Controller.send(:configure, {options: options, logger: logger})
-
-    assert_equal RokuBuilder::CONFIG_OVERWRITE, code
-
-    File.delete(target_config) if File.exist?(target_config)
-  end
-
-  def test_controller_check_devices
-    logger = Logger.new("/dev/null")
-    ping = Minitest::Mock.new
-    options = {sideload: true, device_given: false}
-    config = {}
-    config[:devices] = {
-      a: {ip: "2.2.2.2"},
-      b: {ip: "3.3.3.3"}
-    }
-    configs = {
-      device_config: {ip: "1.1.1.1"}
-    }
-
-    Net::Ping::External.stub(:new, ping) do
-
-      ping.expect(:ping?, true, [configs[:device_config][:ip], 1, 0.2, 1])
-      code, ret = RokuBuilder::Controller.send(:check_devices, {options: options, config: config, configs: configs, logger: logger})
-      assert_equal RokuBuilder::GOOD_DEVICE, code
-
-      ping.expect(:ping?, false, [configs[:device_config][:ip], 1, 0.2, 1])
-      ping.expect(:ping?, false, [config[:devices][:a][:ip], 1, 0.2, 1])
-      ping.expect(:ping?, false, [config[:devices][:b][:ip], 1, 0.2, 1])
-      code, ret = RokuBuilder::Controller.send(:check_devices, {options: options, config: config, configs: configs, logger: logger})
-      assert_equal RokuBuilder::NO_DEVICES, code
-
-      ping.expect(:ping?, false, [configs[:device_config][:ip], 1, 0.2, 1])
-      ping.expect(:ping?, true, [config[:devices][:a][:ip], 1, 0.2, 1])
-      code, ret = RokuBuilder::Controller.send(:check_devices, {options: options, config: config, configs: configs, logger: logger})
-      assert_equal RokuBuilder::CHANGED_DEVICE, code
-      assert_equal config[:devices][:a][:ip], ret[:device_config][:ip]
-
-      options[:device_given] = true
-      ping.expect(:ping?, false, [configs[:device_config][:ip], 1, 0.2, 1])
-      code, ret = RokuBuilder::Controller.send(:check_devices, {options: options, config: config, configs: configs, logger: logger})
-      assert_equal RokuBuilder::BAD_DEVICE, code
-
-      options = {build: true, device_given: false}
-      code, ret = RokuBuilder::Controller.send(:check_devices, {options: options, config: config, configs: configs, logger: logger})
-      assert_equal RokuBuilder::GOOD_DEVICE, code
-    end
-  end
-
-  def test_controller_run_debug
-    tests = [
-      {options: {debug: true}, level: Logger::DEBUG},
-      {options: {verbose: true}, level: Logger::INFO},
-      {options: {}, level: Logger::WARN}
-    ]
-    tests.each do |test|
-      logger = Minitest::Mock.new
-      logger.expect(:level=, nil, [test[:level]])
-      RokuBuilder::Controller.stub(:validate_options, nil) do
-        RokuBuilder::ErrorHandler.stub(:handle_options_codes, nil) do
-          RokuBuilder::Controller.stub(:configure, nil) do
-            RokuBuilder::ErrorHandler.stub(:handle_configure_codes, nil) do
-              RokuBuilder::ConfigManager.stub(:load_config, nil) do
-                RokuBuilder::ErrorHandler.stub(:handle_load_codes, nil) do
-                  RokuBuilder::Controller.stub(:validate_configs, nil) do
-                    RokuBuilder::ErrorHandler.stub(:handle_configs_codes, nil) do
-                      RokuBuilder::Controller.stub(:check_devices, nil) do
-                        RokuBuilder::ErrorHandler.stub(:handle_device_codes, nil) do
-                          RokuBuilder::Controller.stub(:execute_commands, nil) do
-                            RokuBuilder::ErrorHandler.stub(:handle_command_codes, nil) do
-                              RokuBuilder::Controller.run(options: test[:options], logger: logger)
-                            end
-                          end
-                        end
-                      end
-                    end
-                  end
-                end
-              end
-            end
-          end
-        end
+module RokuBuilder
+  class ControllerTest < Minitest::Test
+    def test_controller_check_devices
+      ping = Minitest::Mock.new
+      options = build_options({sideload: true, device_given: false, working: true})
+      raw = {
+        devices: {
+        a: {ip: "2.2.2.2"},
+        b: {ip: "3.3.3.3"}
+      }
+      }
+      parsed = {
+        device_config: {ip: "1.1.1.1"}
+      }
+      config = Config.new(options: options)
+      config.instance_variable_set(:@config, raw)
+      config.instance_variable_set(:@parsed, parsed)
+
+      Net::Ping::External.stub(:new, ping) do
+
+        ping.expect(:ping?, true, [parsed[:device_config][:ip], 1, 0.2, 1])
+        code, ret = Controller.send(:check_devices, {options: options, config: config})
+        assert_equal GOOD_DEVICE, code
+
+        ping.expect(:ping?, false, [parsed[:device_config][:ip], 1, 0.2, 1])
+        ping.expect(:ping?, false, [raw[:devices][:a][:ip], 1, 0.2, 1])
+        ping.expect(:ping?, false, [raw[:devices][:b][:ip], 1, 0.2, 1])
+        code = Controller.send(:check_devices, {options: options, config: config})
+        assert_equal NO_DEVICES, code
+
+        ping.expect(:ping?, false, [parsed[:device_config][:ip], 1, 0.2, 1])
+        ping.expect(:ping?, true, [raw[:devices][:a][:ip], 1, 0.2, 1])
+        code = Controller.send(:check_devices, {options: options, config: config})
+        assert_equal CHANGED_DEVICE, code
+        assert_equal raw[:devices][:a][:ip], config.parsed[:device_config][:ip]
+
+        options[:device_given] = true
+        ping.expect(:ping?, false, [parsed[:device_config][:ip], 1, 0.2, 1])
+        code = Controller.send(:check_devices, {options: options, config: config})
+        assert_equal BAD_DEVICE, code
+
+        options = build_options({build: true, device_given: false, working: true})
+        code = Controller.send(:check_devices, {options: options, config: config})
+        assert_equal GOOD_DEVICE, code
       end
-      logger.verify
     end
-  end
 
-  def test_controller_validate_configs
-    configs = {out: {folder: "/out/folder"}}
-    exist = lambda {|args| assert_equal "/out/folder", args; true}
-    Dir.stub(:exist?, exist) do
-      assert_equal RokuBuilder::VALID, RokuBuilder::Controller.send(:validate_configs, configs: configs)
-    end
+    def test_controller_run_debug
+      tests = [
+        {options: {debug: true}, method: :set_debug},
+        {options: {verbose: true}, method: :set_info},
+        {options: {}, method: :set_warn}
+      ]
+      tests.each do |test|
+        logger = Minitest::Mock.new
+        logger.expect(:call, nil)
+
+        Logger.stub(test[:method], logger) do
+          Controller.initialize_logger(options: test[:options])
+        end
 
-    configs = {out: {folder: "/out/folder"}}
-    exist = lambda {|args| assert_equal "/out/folder", args; false}
-    Dir.stub(:exist?, exist) do
-      assert_equal RokuBuilder::MISSING_OUT_FOLDER, RokuBuilder::Controller.send(:validate_configs, configs: configs)
+        logger.verify
+      end
     end
   end
 end