roger_scsslint 0.1.0 → 1.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MzVhMDZlZTEwMTM5NmM3YzVkZGI0MTNlMjg0MmFiODI2MzQyOTRkNw==
-  data.tar.gz: !binary |-
-    MmMwYTFlZmE1ZjBlY2I2MGNkNGM4ZmQ2NDdkYWExNjc5ZjI5YWYzNA==
+SHA1:
+  metadata.gz: 7403a3fed85f817b3c0aa9ec3a579894cacb93e4
+  data.tar.gz: 29cbca5e2e12484212f6944ab2d6fb5334d0d9a9
 SHA512:
-  metadata.gz: !binary |-
-    NzY5N2NmNzUyMjkyYjkzMTBkNTdhNDdmMTU1YzA1YWZlYWQwZWQwMTIyODlj
-    NDM4OWRmZWExMjNiOTQxMDIyYThlYjE1YTNhNjg0ODFmZGJhMmY3MzdkYjAz
-    ZjI4OTYyODA1YTA4YzdlMTA3YzFlMzYzMDJjMTQyODAwODdiOGM=
-  data.tar.gz: !binary |-
-    YWI2OTI3NzVkMTViNzE2MGEzMGU4Yjg0OTQxMWE2MzNkN2FmNGI4YmVmZWMw
-    OGU3YTQyZThlZDA1ODgzMTVmZGI2YTUxNGUzNzk1YWQ4ZWYwOGVkNTcxYzU0
-    YWQzMWJiZGNhM2E5ODVmODI4OGMxNWM5NmM1YmQxNTZjOTIwYjQ=
+  metadata.gz: 25d6e7e8d86cb86ff8dac0b661854469732046bc75f9caa0748b988768c03cae78c4761c69cdb16bb1869d9e0a75a95863f16615f4588e5ec4516af7cb02aeff
+  data.tar.gz: 596cd28ca8bbeb690db2065aa51c7128069bdf8a559bce9b6c01028edd668aa26924b493cf4548d8b6b9bdff2a282a0afc1735f8ef5c247a22dae15ade9b2cb9

data/.rubocop.yml

@@ -1,6 +1,15 @@
 LineLength:
   Max: 100
 
-Style/HashSyntax:
-  Enabled:
-    False
+StringLiterals:
+  EnforcedStyle: double_quotes
+  Enabled: true
+
+Style/DotPosition:
+  EnforcedStyle: trailing
+  Enabled: true
+
+# By default, the rails cops are not run. Override in project or home
+# directory .rubocop.yml files, or by giving the -R/--rails option.
+AllCops:
+  RunRailsCops: false

data/Gemfile

@@ -1,3 +1,3 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec

data/Rakefile

@@ -1,15 +1,15 @@
-require 'rake/testtask'
-require 'rubocop/rake_task'
+require "rake/testtask"
+require "rubocop/rake_task"
 
-task :default => [:test, :rubocop]
+task default: [:test, :rubocop]
 
-desc 'Run rubocop'
+desc "Run rubocop"
 task :rubocop do
   RuboCop::RakeTask.new
 end
 
 Rake::TestTask.new do |t|
-  t.libs << 'test'
-  t.test_files = FileList['test/**/*_test.rb']
+  t.libs << "test"
+  t.test_files = FileList["test/**/*_test.rb"]
   t.verbose = true
 end

data/lib/roger_scsslint.rb

@@ -1,5 +1,5 @@
 # Roger Scss linting plugin
 module RogerScssLint; end
 
-require File.dirname(__FILE__) + '/roger_scsslint/lint'
-require File.dirname(__FILE__) + '/roger_scsslint/generator'
+require File.dirname(__FILE__) + "/roger_scsslint/lint"
+require File.dirname(__FILE__) + "/roger_scsslint/generator"

data/lib/roger_scsslint/generator.rb

@@ -1,4 +1,4 @@
-require 'open-uri'
+require "open-uri"
 
 # <- hekje
 module Roger
@@ -6,22 +6,23 @@ module Roger
   module Cli; end
 end
 
-require 'roger/cli/generate'
-require 'roger/cli/command'
-require 'roger/generators'
+require "roger/cli/generate"
+require "roger/cli/command"
+require "roger/generators"
 
 module RogerScsslint
   # Lint configuration retriever
   class Generator < Roger::Generators::Base
     include Thor::Actions
-    CONFIG_PATH = '.scss-lint.yml'
-    DEFAULT_CONFIG_URL = 'https://raw.githubusercontent.com/DigitPaint/css/master/linters/.scss-lint.yml'
+    CONFIG_PATH = ".scss-lint.yml"
+    DEFAULT_CONFIG_URL = "https://raw.githubusercontent.com/" \
+      "DigitPaint/css/master/linters/.scss-lint.yml"
 
-    desc 'Scsslint generator creates an .scss-lint.yml config file'
+    desc "Scsslint generator creates an .scss-lint.yml config file"
     class_option(
       :config,
       type: :string,
-      aliases: ['-c'],
+      aliases: ["-c"],
       desc: "Optional config file to use takes a path or url, by
              default it uses the company' default"
     )
@@ -29,8 +30,8 @@ module RogerScsslint
     class_option(
       :force,
       type: :boolean,
-      aliases: ['-f'],
-      desc: 'Always overwrite the config file'
+      aliases: ["-f"],
+      desc: "Always overwrite the config file"
     )
 
     # Write config file

data/lib/roger_scsslint/lint.rb

@@ -1,49 +1,27 @@
-require 'roger/test'
-require 'scss_lint'
-require 'scss_lint/cli'
-require 'scss_lint/runner'
+require "roger/test"
+require "scss_lint"
+require "scss_lint/cli"
+require "scss_lint/runner"
 
 module RogerScsslint
   # SCSS linter plugin for Roger
   class Lint
     # Configurability is the root of all evil
     # http://fishshell.com/docs/current/design.html#conf
-    def initialize(_options = {})
+    def initialize(*)
+      @command = "scss-lint"
     end
 
-    # access scss-lint methods to do printing ourselves
-    def modify_scsslint_cli
-      def @cli.setup_configuration_public(*args)
-        setup_configuration(*args)
-      end
-      def @cli.scan_for_lints_public(*args)
-        scan_for_lints(*args)
-      end
-      def @cli.files_to_lint_public(*args)
-        files_to_lint(*args)
-      end
-    end
-
-    def lint_report(test, runner)
-      runner.lints.sort_by { |l| [l.filename, l.location] }.map do |lint|
-        test.log(self, (lint.error? ? '[E]' : '[W]') +
-                 " #{lint.filename}:#{lint.location.line} #{lint.linter.name}: #{lint.description}")
-      end
+    def detect_scsslint
+      command = [@command, "-v", ">/dev/null"]
+      detect = system(Shellwords.join(command))
+      fail "Could not find linter. Linter should be in Gemfile. " unless detect
     end
 
     def call(test, _options)
-      test.log(self, 'SCSS linting files')
-
-      @cli = SCSSLint::CLI.new
-      modify_scsslint_cli
-      linteroptions = SCSSLint::Options.new.parse([])
-      linterconfig = @cli.setup_configuration_public(linteroptions)
-
-      @cli.files_to_lint_public(linteroptions, linterconfig).each do |file|
-        runner = SCSSLint::Runner.new(linterconfig)
-        runner.run [file]
-        lint_report(test, runner)
-      end
+      detect_scsslint
+      test.log(self, "SCSS linting files")
+      system(@command)
     end
   end
 end

data/roger_scsslint.gemspec

@@ -1,30 +1,30 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.authors = ['Hans Krutzer', 'Flurin Egger']
-  s.email = ['info@digitpaint.nl', 'hans@digitpaint.nl', 'flurin@digitpaint.nl']
-  s.name = 'roger_scsslint'
-  s.version = '0.1.0'
-  s.homepage = 'https://github.com/hkrutzer/roger_scsslint'
+  s.authors = ["Hans Krutzer", "Flurin Egger"]
+  s.email = ["info@digitpaint.nl", "hans@digitpaint.nl", "flurin@digitpaint.nl"]
+  s.name = "roger_scsslint"
+  s.version = "1.0.0"
+  s.homepage = "https://github.com/hkrutzer/roger_scsslint"
 
-  s.summary = 'Lint SCSS files within Roger'
+  s.summary = "Lint SCSS files within Roger"
   s.description = <<-EOF
     Lint SCSS files within Roger, using scss-lint.
     Will use .scss-lint.yml.
   EOF
-  s.licenses = ['MIT']
+  s.licenses = ["MIT"]
 
-  s.date = Time.now.strftime('%Y-%m-%d')
+  s.date = Time.now.strftime("%Y-%m-%d")
 
   s.files = `git ls-files`.split("\n")
-  s.require_paths = ['lib']
+  s.require_paths = ["lib"]
 
-  s.add_dependency 'roger', '~> 0.13', '>= 0.13.0'
-  s.add_dependency 'scss-lint', '~> 0.31', '>= 0.31.0'
+  s.add_dependency "roger", "~> 0.13", ">= 0.13.0"
+  s.add_dependency "scss-lint", "~> 0.31", ">= 0.31.0"
 
-  s.add_development_dependency 'rubocop', ['~> 0']
-  s.add_development_dependency 'rake', ['~> 0']
-  s.add_development_dependency 'test-unit', ['>= 0']
-  s.add_development_dependency 'thor', ['~> 0']
-  s.add_development_dependency 'mocha', ['~> 1.1.0']
+  s.add_development_dependency "rubocop", ["~> 0"]
+  s.add_development_dependency "rake", ["~> 0"]
+  s.add_development_dependency "test-unit", [">= 0"]
+  s.add_development_dependency "thor", ["~> 0"]
+  s.add_development_dependency "mocha", ["~> 1.1.0"]
 end

data/test/generator_test.rb

@@ -1,13 +1,13 @@
-require 'test/unit'
-require 'mocha/test_unit'
+require "test/unit"
+require "mocha/test_unit"
 
-require 'roger/cli'
-require_relative '../lib/roger_scsslint/generator.rb'
+require "roger/cli"
+require_relative "../lib/roger_scsslint/generator.rb"
 
 # Mock project
 class Project
   def path
-    './'
+    "./"
   end
 end
 
@@ -15,15 +15,15 @@ end
 class GeneratorTest < Test::Unit::TestCase
   #  Check if tasks is added
   def test_default_generator
-    assert_includes Roger::Cli::Generate.tasks, 'rogerscsslint::', 'Scsslint task is loaded'
+    assert_includes Roger::Cli::Generate.tasks, "rogerscsslint::", "Scsslint task is loaded"
   end
 
   def test_create_file
-    file_name = './.scss-lint.yml'
+    file_name = "./.scss-lint.yml"
     Roger::Cli::Base.expects(:project).once.returns(Project.new)
     cli = Roger::Cli::Generate.new
-    cli.invoke 'rogerscsslint::', [], ['-f']
-    assert File.exist?(file_name), 'After invoking the file is written'
+    cli.invoke "rogerscsslint::", [], ["-f"]
+    assert File.exist?(file_name), "After invoking the file is written"
 
     # Unlink file
     File.unlink file_name

data/test/lint_test.rb

@@ -1,5 +1,5 @@
-require_relative '../lib/roger_scsslint/lint.rb'
-require 'test/unit'
+require_relative "../lib/roger_scsslint/lint.rb"
+require "test/unit"
 
 # Fake tester to pass into the linter plugin
 class TesterStub
@@ -17,9 +17,9 @@ end
 # Linting plugin unit test
 class LintTest < Test::Unit::TestCase
   def setup
-    @file_name = '.scss-lint.yml'
-    assert !File.exist?(@file_name), '.scss-lint.yml file already exists.'
-    FileUtils.cp('./test/data/sample-scss-lint.yml', './.scss-lint.yml')
+    @file_name = ".scss-lint.yml"
+    assert !File.exist?(@file_name), ".scss-lint.yml file already exists."
+    FileUtils.cp("./test/data/sample-scss-lint.yml", "./.scss-lint.yml")
   end
 
   def test_lint
@@ -28,13 +28,8 @@ class LintTest < Test::Unit::TestCase
     linter = RogerScsslint::Lint.new
     linter.call(faketester, {})
 
-    testfile = 'test/data/test.scss'
     assert_equal(faketester.messages,
-                 ['SCSS linting files',
-                  "[W] #{testfile}:1 SingleLinePerSelector: Each selector "\
-                  'in a comma sequence should be on its own line',
-                  "[W] #{testfile}:2 ZeroUnit: `0px` should be written without units as `0`",
-                  "[W] #{testfile}:3 FinalNewline: Files should end with a trailing newline"])
+                 ["SCSS linting files"])
   end
 
   def teardown

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roger_scsslint
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Hans Krutzer
@@ -9,119 +9,121 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-28 00:00:00.000000000 Z
+date: 2015-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.13'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.13'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.13.0
 - !ruby/object:Gem::Dependency
   name: scss-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.31'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.31.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.31'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.31.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.0
-description: ! "    Lint SCSS files within Roger, using scss-lint.\n    Will use .scss-lint.yml.\n"
+description: |2
+      Lint SCSS files within Roger, using scss-lint.
+      Will use .scss-lint.yml.
 email:
 - info@digitpaint.nl
 - hans@digitpaint.nl
@@ -130,9 +132,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -155,17 +157,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Lint SCSS files within Roger