roger_jshint 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 831b789d136a29882a93611f9b681b2969c1e4b7
-  data.tar.gz: 18a9adf0b8b9f8a202235539116086b76fa7d88f
+  metadata.gz: 837f852c6ef0278395df76946e093ee4c52cea1f
+  data.tar.gz: 9c97f2e5133a029712a8c26fca0c21a96447d632
 SHA512:
-  metadata.gz: 34f1c96665169c62f181330510cb51c4a28ab758ddde4f6d3aabefe0a5290cdae07330963a2d4cab5905f416f2c1363df1d7a10f6a37f89ecf64d0e5b586ce76
-  data.tar.gz: bdc7d1e2ede0c399d3f41fa495485fffa19e77e09f171889ce6db3c5661b385a8c2443cf9183c9d8628854dec6320baccfba51500efcfca560b105c4c22f58f6
+  metadata.gz: eb42fd286eb3eeef32bbe615d53483847b2a30afbf7766b3d97833a60fa3753731bda7cf2b122b10fe2e824d3593b880853fb267f2ef915f47bb49bf9eb7cf2b
+  data.tar.gz: 714fabeb549664e72c04c40516acf1c233275e7302236b7a8323fb4bd3949ba9c83d447d1059a7ddc3d6dde257576e55b1649453171a2e991bcc1170d01b2064

data/.rubocop.yml

@@ -1,6 +1,18 @@
 LineLength:
   Max: 100
 
+Metrics/AbcSize:
+  Enabled:
+    False
+
 Style/HashSyntax:
   Enabled:
     False
+
+Style/StringLiterals:
+  Enabled:
+    False
+
+Metrics/MethodLength:
+  CountComments: false  # count full line comments?
+  Max: 25

data/.travis.yml

@@ -5,4 +5,3 @@ rvm:
   - 2.2.0
 before_script:
   - npm install jshint
-  - cp ./test/jshintrc .jshintrc

data/README.md

@@ -1,6 +1,8 @@
-roger_jshint
+Roger JSHint
 ============
-[![Build Status](https://travis-ci.org/hkrutzer/roger_jshint.svg?branch=master)](https://travis-ci.org/hkrutzer/roger_jshint)
+
+[![Build Status](https://travis-ci.org/DigitPaint/roger_jshint.svg)](https://travis-ci.org/DigitPaint/roger_jshint)
+
 
 Lint JavaScript files from within Roger. This plugin uses [jshint](https://github.com/jshint/jshint). If present, .jshintrc in your project will be used. If not, jshint will walk the directory tree upwards until a .jshintrc file is found. As a last resort, [jshint's default configuration](https://raw.githubusercontent.com/jshint/jshint/master/examples/.jshintrc) is used.
 

data/lib/roger_jshint/lint.rb

@@ -16,13 +16,11 @@ module RogerJsHint
         :jshint => 'jshint'
       }
       @options.update(options) if options
-
-      @jshint_command = "#{@options[:jshint]} --reporter=" +
-                        File.expand_path('jsonreporter.js', File.dirname(__FILE__)) + ' '
     end
 
     def detect_jshint
-      detect = system(format('%s -v 2>/dev/null', Shellwords.escape(@options[:jshint])))
+      command = [@options[:jshint], "-v", "2>/dev/null"]
+      detect = system(Shellwords.join(command))
       fail 'Could not find jshint. Install jshint using npm.' unless detect
     end
 
@@ -44,13 +42,16 @@ module RogerJsHint
     # @option options [Array[Regexp]] :skip Array of regular expressions to skip files
     def call(test, options)
       options = {}.update(@options).update(options)
+      command = [
+        @options[:jshint],
+        "--reporter=" + File.expand_path('jsonreporter.js', File.dirname(__FILE__))
+      ]
 
       detect_jshint
       test.log(self, 'JS-linting files')
 
       test.get_files(options[:match], options[:skip]).each do |file_path|
-        execute = @jshint_command + ' ' + Shellwords.escape(file_path)
-        output = `#{execute}`
+        output = `#{Shellwords.join(command + [Shellwords.escape(file_path)])}`
         lint = JSON.parse output
         report(test, file_path, lint)
       end

data/roger_jshint.gemspec

@@ -1,11 +1,11 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.authors = ['Hans Krutzer']
-  s.email = ['info@digitpaint.nl', 'hans@digitpaint.nl']
+  s.authors = ['Hans Krutzer', 'Flurin Egger']
+  s.email = ['info@digitpaint.nl', 'hans@digitpaint.nl', 'flurin@digitpaint.nl']
   s.name = 'roger_jshint'
-  s.version = '0.1.0'
-  s.homepage = 'https://github.com/hkrutzer/roger_scsslinter'
+  s.version = '1.0.0'
+  s.homepage = 'https://github.com/digitpaint/roger_jshint'
 
   s.summary = 'Lint JavaScript files within Roger'
   s.description = <<-EOF
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.files = `git ls-files`.split("\n")
   s.require_paths = ['lib']
 
-  s.add_dependency 'roger', '~> 0.13', '>= 0.13.0'
+  s.add_dependency 'roger', '~> 1.1', '>= 0.13.0'
 
   s.add_development_dependency 'rubocop', ['>= 0']
   s.add_development_dependency 'rake', ['>= 0']

data/test/lint_test.rb

@@ -14,12 +14,18 @@ class TesterStub
   end
 
   def get_files(_, _)
-    ['test/test.js']
+    ['test/data/test.js']
   end
 end
 
 # Linting plugin unit test
 class LintTest < Test::Unit::TestCase
+  def setup
+    @file_name = ".jshintrc"
+    assert !File.exist?(@file_name), ".jshintrc file already exists."
+    FileUtils.cp("./test/data/jshintrc", "./.jshintrc")
+  end
+
   def test_lint
     faketester = TesterStub.new
 
@@ -30,9 +36,13 @@ class LintTest < Test::Unit::TestCase
     messages.shift
 
     assert_equal(messages,
-                 ["test/test.js:0 0: Bad option: 'subsub'.",
-                  "test/test.js:1 1: 'x' is not defined.",
-                  "test/test.js:2 1: 'alert' is not defined.",
-                  "test/test.js:2 7: 'x' is not defined."])
+                 ["test/data/test.js:0 0: Bad option: 'subsub'.",
+                  "test/data/test.js:1 1: 'x' is not defined.",
+                  "test/data/test.js:2 1: 'alert' is not defined.",
+                  "test/data/test.js:2 7: 'x' is not defined."])
+  end
+
+  def teardown
+    File.unlink @file_name
   end
 end

metadata

@@ -1,75 +1,76 @@
 --- !ruby/object:Gem::Specification
 name: roger_jshint
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Hans Krutzer
+- Flurin Egger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-19 00:00:00.000000000 Z
+date: 2015-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.13'
-    - - ">="
+        version: '1.1'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.13'
-    - - ">="
+        version: '1.1'
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.13.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: |2
@@ -78,13 +79,15 @@ description: |2
 email:
 - info@digitpaint.nl
 - hans@digitpaint.nl
+- flurin@digitpaint.nl
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rubocop.yml"
-- ".travis.yml"
+- .gitignore
+- .rubocop.yml
+- .ruby-version
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md
@@ -93,10 +96,10 @@ files:
 - lib/roger_jshint/jsonreporter.js
 - lib/roger_jshint/lint.rb
 - roger_jshint.gemspec
-- test/jshintrc
+- test/data/jshintrc
+- test/data/test.js
 - test/lint_test.rb
-- test/test.js
-homepage: https://github.com/hkrutzer/roger_scsslinter
+homepage: https://github.com/digitpaint/roger_jshint
 licenses:
 - MIT
 metadata: {}
@@ -106,17 +109,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Lint JavaScript files within Roger