rodauth 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b6660226ea467fd230f849bf44098c6cd9d62bc
-  data.tar.gz: bd83d6ccffd22d79704aca7dba5bc50ee7a169a8
+  metadata.gz: 1ee1b5d6f6b049a4fcd965ce0de9d2c15ce159e5
+  data.tar.gz: 14afd3681ed969ae8eb3edf3f35f66667df22d27
 SHA512:
-  metadata.gz: 31c568259583e2edc819d3d40887fca878a84ac059d0a516b40477a09a01213b41da73638f7f85cba455cf7528b414e241bc607ae8e7225146800d2d7e7622ab
-  data.tar.gz: a6d9a5730691944339b3ace15b92ef1d64b41a0b24188c8dc0c2ccfea97056c5d338d7adbc2128306313729893c3ab8d44e579ded94540a8b9405b08f26a3542
+  metadata.gz: b9de71675de5bf39eafd398479d4917bfe342e619f21c9fa3d7c26223c00591541ac8dc22f58358aa579dc02515e1648816153d4c2f5dc6098cbda208c774ae0
+  data.tar.gz: fd038a8458ac8a88f3ca6bec26c4642a10eabf130ba2e14bbefbbc45e5f2136e4edf59452ff8d6deb43ae08ff9e9f05f09ad75a4a73bb6500a88e82bfd0526eb

data/CHANGELOG

@@ -1,4 +1,8 @@
-=== 1.2.0 (2016-06-16)
+=== 1.3.0 (2016-07-19)
+
+* Add login_maximum_length, defaulting to 255 (jeremyevans)
+
+=== 1.2.0 (2016-06-15)
 
 * Add otp_drift configuration method to otp plugin, setting number of seconds of allowed drift (jeremyevans)
 

data/README.rdoc

@@ -227,6 +227,9 @@ or columns related to features that you don't need.
 First migration.  On PostgreSQL, this should be run with the +app+ account,
 on MySQL and Microsoft SQL Server this should be run with the +ph+ account.
 
+Note that these migrations require Sequel 4.35.0+.  If you are using older
+versions of Sequel, switch the :Bignum symbols to Bignum constants.
+
   Sequel.migration do
     up do
       extension :date_arithmetic
@@ -240,7 +243,7 @@ on MySQL and Microsoft SQL Server this should be run with the +ph+ account.
 
       db = self
       create_table(:accounts) do
-        primary_key :id, :type=>Bignum
+        primary_key :id, :type=>:Bignum
         foreign_key :status_id, :account_statuses, :null=>false, :default=>1
         if db.database_type == :postgres
           citext :email, :null=>false
@@ -262,45 +265,45 @@ on MySQL and Microsoft SQL Server this should be run with the +ph+ account.
 
       # Used by the password reset feature
       create_table(:account_password_reset_keys) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
         DateTime :deadline, deadline_opts[1]
       end
 
       # Used by the account verification feature
       create_table(:account_verification_keys) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
         DateTime :requested_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
       end
 
       # Used by the remember me feature
       create_table(:account_remember_keys) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
         DateTime :deadline, deadline_opts[14]
       end
 
       # Used by the lockout feature
       create_table(:account_login_failures) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         Integer :number, :null=>false, :default=>1
       end
       create_table(:account_lockouts) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
         DateTime :deadline, deadline_opts[1]
       end
 
       # Used by the password expiration feature
       create_table(:account_password_change_times) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         DateTime :changed_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
       end
 
       # Used by the account expiration feature
       create_table(:account_activity_times) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         DateTime :last_activity_at, :null=>false
         DateTime :last_login_at, :null=>false
         DateTime :expired_at
@@ -308,13 +311,13 @@ on MySQL and Microsoft SQL Server this should be run with the +ph+ account.
 
       # Used by the single session feature
       create_table(:account_session_keys) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
       end
 
       # Used by the otp feature
       create_table(:account_otp_keys) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :key, :null=>false
         Integer :num_failures, :null=>false, :default=>0
         Time :last_use, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
@@ -322,14 +325,14 @@ on MySQL and Microsoft SQL Server this should be run with the +ph+ account.
 
       # Used by the recovery codes feature
       create_table(:account_recovery_codes) do
-        foreign_key :id, :accounts, :type=>Bignum
+        foreign_key :id, :accounts, :type=>:Bignum
         String :code
         primary_key [:id, :code]
       end
 
       # Used by the sms codes feature
       create_table(:account_sms_codes) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :phone_number, :null=>false
         Integer :num_failures
         String :code
@@ -386,7 +389,7 @@ Second migration, run using the +ph+ account:
   Sequel.migration do
     up do
       create_table(:account_password_hashes) do
-        foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+        foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
         String :password_hash, :null=>false
       end
       Rodauth.create_database_authentication_functions(self)
@@ -416,8 +419,8 @@ Second migration, run using the +ph+ account:
 
       # Used by the disallow_password_reuse feature
       create_table(:account_previous_password_hashes) do
-        primary_key :id, :type=>Bignum
-        foreign_key :account_id, :accounts, :type=>Bignum
+        primary_key :id, :type=>:Bignum
+        foreign_key :account_id, :accounts, :type=>:Bignum
         String :password_hash, :null=>false
       end
       Rodauth.create_database_previous_password_check_functions(self)

data/doc/login_password_requirements_base.rdoc

@@ -10,7 +10,10 @@ login_confirm_param :: The parameter name to use for login confirmations.
 login_does_not_meet_requirements_message :: The error message to display when
                                             the login does not meet the
                                             requirements you have set.
+login_maximum_length :: The maximum length for logins, 255 by default.
 login_minimum_length :: The minimum length for logins, 3 by default.
+login_too_long_message :: The error message fragment to show if the login is
+                           too long.
 login_too_short_message :: The error message fragment to show if the login is
                            too short.
 logins_do_not_match_message :: The error message to display when login and

data/doc/release_notes/1.3.0.txt

@@ -0,0 +1,21 @@
+= New Features
+
+* A login_maximum_length configuration method has been added.  This
+  defaults to 255, and rodauth will now show an error message if a
+  user tries to create a login longer than this setting.
+
+= Backwards Compatibility
+
+* Rodauth's documentation and test code now use :Bignum instead of
+  Bignum for database-independent 64-bit integer types.  This is
+  because using Bignum is now deprecated in Sequel as it will stop
+  working correctly in ruby 2.4+, due to the unification of Fixnum
+  and Bignum into Integer.
+
+  Rodauth's library code does not use either :Bignum or Bignum, but if
+  you are starting to use Rodauth and are copying the example
+  migration from Rodauth's documentation, or you are running the
+  migrations in Rodauth's tests, you now need to use Sequel 4.35.0+.
+
+* Some files related to the hosting of the demo site on Heroku have
+  been removed from the repository.

data/lib/rodauth/features/login_password_requirements_base.rb

@@ -4,6 +4,7 @@ module Rodauth
   LoginPasswordRequirementsBase = Feature.define(:login_password_requirements_base) do
     auth_value_method :login_confirm_param, 'login-confirm'
     auth_value_method :login_minimum_length, 3
+    auth_value_method :login_maximum_length, 255
     auth_value_method :logins_do_not_match_message, 'logins do not match'
     auth_value_method :password_confirm_param, 'password-confirm'
     auth_value_method :password_minimum_length, 6
@@ -16,6 +17,7 @@ module Rodauth
     auth_value_methods(
       :login_confirm_label,
       :login_does_not_meet_requirements_message,
+      :login_too_long_message,
       :login_too_short_message,
       :password_confirm_label,
       :password_does_not_meet_requirements_message,
@@ -79,14 +81,24 @@ module Rodauth
       "invalid login#{", #{login_requirement_message}" if login_requirement_message}"
     end
 
+    def login_too_long_message
+      "maximum #{login_maximum_length} characters"
+    end
+
     def login_too_short_message
       "minimum #{login_minimum_length} characters"
     end
 
     def login_meets_length_requirements?(login)
-      return true if login_minimum_length <= login.length
-      @login_requirement_message = login_too_short_message
-      false
+      if login_minimum_length > login.length
+        @login_requirement_message = login_too_short_message
+        false
+      elsif login_maximum_length < login.length
+        @login_requirement_message = login_too_long_message
+        false
+      else
+        true
+      end
     end
 
     def login_meets_email_requirements?(login)

data/lib/rodauth/version.rb

@@ -1,7 +1,7 @@
 # frozen-string-literal: true
 
 module Rodauth
-  VERSION = '1.2.0'.freeze
+  VERSION = '1.3.0'.freeze
 
   def self.version
     VERSION

data/spec/change_login_spec.rb

@@ -38,6 +38,13 @@ describe 'Rodauth change_login feature' do
     page.html.must_include("invalid login, minimum 3 characters")
     page.current_path.must_equal '/change-login'
 
+    fill_in 'Login', :with=>'f'*256
+    fill_in 'Confirm Login', :with=>'f'*256
+    click_button 'Change Login'
+    page.find('#error_flash').text.must_equal "There was an error changing your login"
+    page.html.must_include("invalid login, maximum 255 characters")
+    page.current_path.must_equal '/change-login'
+
     fill_in 'Login', :with=>'foo@example.com'
     fill_in 'Confirm Login', :with=>'foo2@example.com'
     click_button 'Change Login'

data/spec/migrate/001_tables.rb

@@ -11,7 +11,7 @@ Sequel.migration do
 
     db = self
     create_table(:accounts) do
-      primary_key :id, :type=>Bignum
+      primary_key :id, :type=>:Bignum
       foreign_key :status_id, :account_statuses, :null=>false, :default=>1
       if db.database_type == :postgres
         citext :email, :null=>false
@@ -33,45 +33,45 @@ Sequel.migration do
 
     # Used by the password reset feature
     create_table(:account_password_reset_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[1]
     end
 
     # Used by the account verification feature
     create_table(:account_verification_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :requested_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
     end
 
     # Used by the remember me feature
     create_table(:account_remember_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[14]
     end
 
     # Used by the lockout feature
     create_table(:account_login_failures) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       Integer :number, :null=>false, :default=>1
     end
     create_table(:account_lockouts) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[1]
     end
 
     # Used by the password expiration feature
     create_table(:account_password_change_times) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       DateTime :changed_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
     end
 
     # Used by the account expiration feature
     create_table(:account_activity_times) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       DateTime :last_activity_at, :null=>false
       DateTime :last_login_at, :null=>false
       DateTime :expired_at
@@ -79,13 +79,13 @@ Sequel.migration do
 
     # Used by the single session feature
     create_table(:account_session_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
     end
 
     # Used by the otp feature
     create_table(:account_otp_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       Integer :num_failures, :null=>false, :default=>0
       Time :last_use, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
@@ -93,14 +93,14 @@ Sequel.migration do
 
     # Used by the recovery codes feature
     create_table(:account_recovery_codes) do
-      foreign_key :id, :accounts, :type=>Bignum
+      foreign_key :id, :accounts, :type=>:Bignum
       String :code
       primary_key [:id, :code]
     end
 
     # Used by the sms codes feature
     create_table(:account_sms_codes) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :phone_number, :null=>false
       Integer :num_failures
       String :code

data/spec/migrate_password/001_tables.rb

@@ -3,7 +3,7 @@ require 'rodauth/migrations'
 Sequel.migration do
   up do
     create_table(:account_password_hashes) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :password_hash, :null=>false
     end
     Rodauth.create_database_authentication_functions(self)
@@ -33,8 +33,8 @@ Sequel.migration do
 
     # Used by the disallow_password_reuse feature
     create_table(:account_previous_password_hashes) do
-      primary_key :id, :type=>Bignum
-      foreign_key :account_id, :accounts, :type=>Bignum
+      primary_key :id, :type=>:Bignum
+      foreign_key :account_id, :accounts, :type=>:Bignum
       String :password_hash, :null=>false
     end
     Rodauth.create_database_previous_password_check_functions(self)

data/spec/migrate_travis/001_tables.rb

@@ -12,7 +12,7 @@ Sequel.migration do
 
     db = self
     create_table(:accounts) do
-      primary_key :id, :type=>Bignum
+      primary_key :id, :type=>:Bignum
       foreign_key :status_id, :account_statuses, :null=>false, :default=>1
       if db.database_type == :postgres
         citext :email, :null=>false
@@ -27,7 +27,7 @@ Sequel.migration do
     end
 
     create_table(:account_password_hashes) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :password_hash, :null=>false
     end
     Rodauth.create_database_authentication_functions(self)
@@ -41,65 +41,65 @@ Sequel.migration do
     end
 
     create_table(:account_password_reset_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[1]
     end
 
     create_table(:account_verification_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :requested_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
     end
 
     create_table(:account_remember_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[14]
     end
 
     create_table(:account_login_failures) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       Integer :number, :null=>false, :default=>1
     end
     create_table(:account_lockouts) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       DateTime :deadline, deadline_opts[1]
     end
 
     create_table(:account_password_change_times) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       DateTime :changed_at, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
     end
 
     create_table(:account_activity_times) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       DateTime :last_activity_at, :null=>false
       DateTime :last_login_at, :null=>false
       DateTime :expired_at
     end
 
     create_table(:account_session_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
     end
 
     create_table(:account_otp_keys) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :key, :null=>false
       Integer :num_failures, :null=>false, :default=>0
       Time :last_use, :null=>false, :default=>Sequel::CURRENT_TIMESTAMP
     end
 
     create_table(:account_recovery_codes) do
-      foreign_key :id, :accounts, :type=>Bignum
+      foreign_key :id, :accounts, :type=>:Bignum
       String :code
       primary_key [:id, :code]
     end
 
     create_table(:account_sms_codes) do
-      foreign_key :id, :accounts, :primary_key=>true, :type=>Bignum
+      foreign_key :id, :accounts, :primary_key=>true, :type=>:Bignum
       String :phone_number, :null=>false
       Integer :num_failures
       String :code
@@ -107,8 +107,8 @@ Sequel.migration do
     end
 
     create_table(:account_previous_password_hashes) do
-      primary_key :id, :type=>Bignum
-      foreign_key :account_id, :accounts, :type=>Bignum
+      primary_key :id, :type=>:Bignum
+      foreign_key :account_id, :accounts, :type=>:Bignum
       String :password_hash, :null=>false
     end
     Rodauth.create_database_previous_password_check_functions(self)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rodauth
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-15 00:00:00.000000000 Z
+date: 2016-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
@@ -227,6 +227,7 @@ extra_rdoc_files:
 - doc/release_notes/1.0.0.txt
 - doc/release_notes/1.1.0.txt
 - doc/release_notes/1.2.0.txt
+- doc/release_notes/1.3.0.txt
 files:
 - CHANGELOG
 - MIT-LICENSE
@@ -254,6 +255,7 @@ files:
 - doc/release_notes/1.0.0.txt
 - doc/release_notes/1.1.0.txt
 - doc/release_notes/1.2.0.txt
+- doc/release_notes/1.3.0.txt
 - doc/remember.rdoc
 - doc/reset_password.rdoc
 - doc/session_expiration.rdoc
@@ -378,7 +380,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="