rodauth-oauth 0.0.2 → 0.1.0

data/lib/generators/roda/oauth/install_generator.rb

@@ -10,7 +10,7 @@ module Rodauth::OAuth::Rails
       include ::Rails::Generators::Migration
 
       source_root "#{__dir__}/templates"
-      namespace "roda:oauth:install"
+      namespace "rodauth:oauth:install"
 
       def create_rodauth_migration
         return unless defined?(ActiveRecord::Base)

data/lib/generators/roda/oauth/templates/db/migrate/create_rodauth_oauth.rb

@@ -29,7 +29,8 @@ class CreateRodauthOAuth < ActiveRecord::Migration<%= migration_version %>
       # uncomment to enable PKCE
       # t.string :code_challenge
       # t.string :code_challenge_method
-
+      # uncomment to use OIDC nonce
+      # t.string :nonce
       t.index(%i[oauth_application_id code], unique: true)
     end
 
@@ -54,6 +55,8 @@ class CreateRodauthOAuth < ActiveRecord::Migration<%= migration_version %>
       t.datetime :revoked_at
       t.string :scopes, null: false
       t.datetime :created_at, null: false, default: -> { "CURRENT_TIMESTAMP" }
+      # uncomment to use OIDC nonce
+      # t.string :nonce
     end
   end
 end

data/lib/generators/roda/oauth/views_generator.rb

@@ -7,7 +7,7 @@ module Rodauth::OAuth
     module Generators
       class ViewsGenerator < ::Rails::Generators::Base
         source_root "#{__dir__}/templates"
-        namespace "roda:oauth:views"
+        namespace "rodauth:oauth:views"
 
         DEFAULT = %w[oauth_authorize].freeze
         VIEWS = {
@@ -16,11 +16,6 @@ module Rodauth::OAuth
         }.freeze
 
         DEPENDENCIES = {
-          active_sessions: :logout,
-          otp: :two_factor_base,
-          sms_codes: :two_factor_base,
-          recovery_codes: :two_factor_base,
-          webauthn: :two_factor_base
         }.freeze
 
         class_option :features, type: :array,

data/lib/rodauth/features/oauth.rb

@@ -1,8 +1,15 @@
 # frozen-string-literal: true
 
+require "base64"
+require "securerandom"
+require "net/http"
+
+require "rodauth/oauth/ttl_store"
+
 module Rodauth
   Feature.define(:oauth) do
     # RUBY EXTENSIONS
+    # :nocov:
     unless Regexp.method_defined?(:match?)
       module RegexpExtensions
         refine(Regexp) do
@@ -30,33 +37,30 @@ module Rodauth
       end
       using(SuffixExtensions)
     end
+    # :nocov:
 
     SCOPES = %w[profile.read].freeze
 
-    depends :login
-
     before "authorize"
     after "authorize"
-    after "authorize_failure"
 
     before "token"
-    after "token"
 
     before "revoke"
     after "revoke"
 
+    before "introspect"
+
     before "create_oauth_application"
     after "create_oauth_application"
 
-    error_flash "OAuth Authorization invalid parameters", "oauth_grant_valid_parameters"
-
     error_flash "Please authorize to continue", "require_authorization"
     error_flash "There was an error registering your oauth application", "create_oauth_application"
     notice_flash "Your oauth application has been registered", "create_oauth_application"
 
     notice_flash "The oauth token has been revoked", "revoke_oauth_token"
 
-    view "oauth_authorize", "Authorize", "authorize"
+    view "authorize", "Authorize", "authorize"
     view "oauth_applications", "Oauth Applications", "oauth_applications"
     view "oauth_application", "Oauth Application", "oauth_application"
     view "new_oauth_application", "New Oauth Application", "new_oauth_application"
@@ -66,22 +70,16 @@ module Rodauth
 
     auth_value_method :oauth_grant_expires_in, 60 * 5 # 5 minutes
     auth_value_method :oauth_token_expires_in, 60 * 60 # 60 minutes
-    auth_value_method :use_oauth_implicit_grant_type, false
+    auth_value_method :use_oauth_implicit_grant_type?, false
+    auth_value_method :use_oauth_pkce?, true
+    auth_value_method :use_oauth_access_type?, true
 
     auth_value_method :oauth_require_pkce, false
     auth_value_method :oauth_pkce_challenge_method, "S256"
 
-    # URL PARAMS
+    auth_value_method :oauth_valid_uri_schemes, %w[https]
 
-    # Authorize / token
-    %w[
-      grant_type code refresh_token client_id client_secret scope
-      state redirect_uri scopes token_type_hint token
-      access_type approval_prompt response_type
-      code_challenge code_challenge_method code_verifier
-    ].each do |param|
-      auth_value_method :"#{param}_param", param
-    end
+    auth_value_method :oauth_scope_separator, " "
 
     # Application
     APPLICATION_REQUIRED_PARAMS = %w[name description scopes homepage_url redirect_uri client_secret].freeze
@@ -89,7 +87,11 @@ module Rodauth
 
     (APPLICATION_REQUIRED_PARAMS + %w[client_id]).each do |param|
       auth_value_method :"oauth_application_#{param}_param", param
+      translatable_method :"#{param}_label", param.gsub("_", " ").capitalize
     end
+    button "Register", "oauth_application"
+    button "Authorize", "oauth_authorize"
+    button "Revoke", "oauth_token_revoke"
 
     # OAuth Token
     auth_value_method :oauth_tokens_path, "oauth-tokens"
@@ -141,11 +143,9 @@ module Rodauth
 
     auth_value_method :oauth_application_default_scope, SCOPES.first
     auth_value_method :oauth_application_scopes, SCOPES
-    auth_value_method :oauth_token_type, "Bearer"
+    auth_value_method :oauth_token_type, "bearer"
 
-    auth_value_method :invalid_request, "Request is missing a required parameter"
-    auth_value_method :invalid_client, "Invalid client"
-    auth_value_method :unauthorized_client, "Unauthorized client"
+    auth_value_method :invalid_client_message, "Invalid client"
     auth_value_method :invalid_grant_type_message, "Invalid grant type"
     auth_value_method :invalid_grant_message, "Invalid grant"
     auth_value_method :invalid_scope_message, "Invalid scope"
@@ -162,33 +162,40 @@ module Rodauth
     auth_value_method :unsupported_transform_algorithm_error_code, "invalid_request"
     auth_value_method :unsupported_transform_algorithm_message, "transform algorithm not supported"
 
+    # METADATA
+    auth_value_method :oauth_metadata_service_documentation, nil
+    auth_value_method :oauth_metadata_ui_locales_supported, nil
+    auth_value_method :oauth_metadata_op_policy_uri, nil
+    auth_value_method :oauth_metadata_op_tos_uri, nil
+
+    # Resource Server params
+    # Only required to use if the plugin is to be used in a resource server
+    auth_value_method :is_authorization_server?, true
+
     auth_value_methods(
+      :fetch_access_token,
       :oauth_unique_id_generator,
       :secret_matches?,
-      :secret_hash
+      :secret_hash,
+      :generate_token_hash,
+      :authorization_server_url,
+      :before_introspection_request
     )
 
-    redirect(:oauth_application) do |id|
-      "/#{oauth_applications_path}/#{id}"
-    end
+    auth_value_methods(:only_json?)
 
-    redirect(:require_authorization) do
-      if logged_in?
-        oauth_authorize_path
-      else
-        login_redirect
-      end
-    end
+    auth_value_method :json_request_regexp, %r{\bapplication/(?:vnd\.api\+)?json\b}i
 
-    auth_value_method :json_request_accept_regexp, %r{\bapplication/(?:vnd\.api\+)?json\b}i
-    auth_methods(:json_request?)
+    SERVER_METADATA = OAuth::TtlStore.new
 
     def check_csrf?
       case request.path
-      when oauth_token_path
+      when token_path, introspect_path
         false
-      when oauth_revoke_path
+      when revoke_path
         !json_request?
+      when authorize_path, %r{/#{oauth_applications_path}}
+        only_json? ? false : super
       else
         super
       end
@@ -199,51 +206,53 @@ module Rodauth
       super || authorization_token
     end
 
-    def json_request?
-      return @json_request if defined?(@json_request)
+    def accepts_json?
+      return true if only_json?
 
-      @json_request = request.get_header("HTTP_ACCEPT") =~ json_request_accept_regexp
+      (accept = request.env["HTTP_ACCEPT"]) && accept =~ json_request_regexp
     end
 
-    attr_reader :oauth_application
+    unless method_defined?(:json_request?)
+      # :nocov:
+      # copied from the jwt feature
+      def json_request?
+        return @json_request if defined?(@json_request)
 
-    def initialize(scope)
-      @scope = scope
+        @json_request = request.content_type =~ json_request_regexp
+      end
+      # :nocov:
     end
 
-    def state
-      param_or_nil(state_param)
+    def initialize(scope)
+      @scope = scope
     end
 
     def scopes
-      (param_or_nil(scopes_param) || oauth_application_default_scope).split(" ")
-    end
-
-    def client_id
-      param_or_nil(client_id_param)
-    end
-
-    def client_secret
-      param_or_nil(client_secret_param)
+      scope = request.params["scope"]
+      case scope
+      when Array
+        scope
+      when String
+        scope.split(" ")
+      when nil
+        [oauth_application_default_scope]
+      end
     end
 
     def redirect_uri
-      param_or_nil(redirect_uri_param) || oauth_application[oauth_applications_redirect_uri_column]
-    end
+      param_or_nil("redirect_uri") || begin
+        return unless oauth_application
 
-    def token_type_hint
-      param_or_nil(token_type_hint_param) || "access_token"
-    end
-
-    def token
-      param_or_nil(token_param)
+        redirect_uris = oauth_application[oauth_applications_redirect_uri_column].split(" ")
+        redirect_uris.size == 1 ? redirect_uris.first : nil
+      end
     end
 
     def oauth_application
       return @oauth_application if defined?(@oauth_application)
 
       @oauth_application = begin
-        client_id = param(client_id_param)
+        client_id = param_or_nil("client_id")
 
         return unless client_id
 
@@ -251,31 +260,54 @@ module Rodauth
       end
     end
 
+    def fetch_access_token
+      value = request.env["HTTP_AUTHORIZATION"]
+
+      return unless value
+
+      scheme, token = value.split(" ", 2)
+
+      return unless scheme.downcase == oauth_token_type
+
+      return if token.empty?
+
+      token
+    end
+
     def authorization_token
       return @authorization_token if defined?(@authorization_token)
 
-      @authorization_token = begin
-        value = request.get_header("HTTP_AUTHORIZATION").to_s
+      # check if there is a token
+      bearer_token = fetch_access_token
 
-        scheme, token = value.split(" ", 2)
+      return unless bearer_token
 
-        return unless scheme == "Bearer"
-
-        # check if there is a token
-        # check if token has not expired
-        # check if token has been revoked
-        oauth_token_by_token(token).where(Sequel[oauth_tokens_expires_in_column] >= Sequel::CURRENT_TIMESTAMP)
-                                   .where(oauth_tokens_revoked_at_column => nil)
-                                   .first
-      end
+      # check if token has not expired
+      # check if token has been revoked
+      @authorization_token = oauth_token_by_token(bearer_token)
     end
 
     def require_oauth_authorization(*scopes)
-      authorization_required unless authorization_token
+      token_scopes = if is_authorization_server?
+                       authorization_required unless authorization_token
+
+                       scopes << oauth_application_default_scope if scopes.empty?
+
+                       authorization_token[oauth_tokens_scopes_column].split(oauth_scope_separator)
+                     else
+                       bearer_token = fetch_access_token
+
+                       authorization_required unless bearer_token
+
+                       scopes << oauth_application_default_scope if scopes.empty?
 
-      scopes << oauth_application_default_scope if scopes.empty?
+                       # where in resource server, NOT the authorization server.
+                       payload = introspection_request("access_token", bearer_token)
 
-      token_scopes = authorization_token[:scopes].split(",")
+                       authorization_required unless payload["active"]
+
+                       payload["scope"].split(oauth_scope_separator)
+                     end
 
       authorization_required unless scopes.any? { |scope| token_scopes.include?(scope) }
     end
@@ -288,8 +320,11 @@ module Rodauth
         request.get "new" do
           new_oauth_application_view
         end
+
         request.on(oauth_applications_id_pattern) do |id|
           oauth_application = db[oauth_applications_table].where(oauth_applications_id_column => id).first
+          next unless oauth_application
+
           scope.instance_variable_set(:@oauth_application, oauth_application)
 
           request.is do
@@ -301,7 +336,9 @@ module Rodauth
           request.on(oauth_tokens_path) do
             oauth_tokens = db[oauth_tokens_table].where(oauth_tokens_oauth_application_id_column => id)
             scope.instance_variable_set(:@oauth_tokens, oauth_tokens)
-            oauth_tokens_view
+            request.get do
+              oauth_tokens_view
+            end
           end
         end
 
@@ -319,7 +356,7 @@ module Rodauth
               id = create_oauth_application
               after_create_oauth_application
               set_notice_flash create_oauth_application_notice_flash
-              redirect oauth_application_redirect(id)
+              redirect "#{request.path}/#{id}"
             end
           end
           set_error_flash create_oauth_application_error_flash
@@ -328,8 +365,102 @@ module Rodauth
       end
     end
 
+    def oauth_server_metadata(issuer = nil)
+      request.on(".well-known") do
+        request.on("oauth-authorization-server") do
+          request.get do
+            json_response_success(oauth_server_metadata_body(issuer))
+          end
+        end
+      end
+    end
+
     private
 
+    def authorization_server_url
+      base_url
+    end
+
+    def authorization_server_metadata
+      auth_url = URI(authorization_server_url)
+
+      server_metadata = SERVER_METADATA[auth_url]
+
+      return server_metadata if server_metadata
+
+      SERVER_METADATA.set(auth_url) do
+        http = Net::HTTP.new(auth_url.host, auth_url.port)
+        http.use_ssl = auth_url.scheme == "https"
+
+        request = Net::HTTP::Get.new("/.well-known/oauth-authorization-server")
+        request["accept"] = json_response_content_type
+        response = http.request(request)
+        authorization_required unless response.code.to_i == 200
+
+        # time-to-live
+        ttl = if response.key?("cache-control")
+                cache_control = response["cache_control"]
+                cache_control[/max-age=(\d+)/, 1]
+              elsif response.key?("expires")
+                Time.httpdate(response["expires"]).utc.to_i - Time.now.utc.to_i
+              end
+
+        [JSON.parse(response.body, symbolize_names: true), ttl]
+      end
+    end
+
+    def introspection_request(token_type_hint, token)
+      auth_url = URI(authorization_server_url)
+      http = Net::HTTP.new(auth_url.host, auth_url.port)
+      http.use_ssl = auth_url.scheme == "https"
+
+      request = Net::HTTP::Post.new(introspect_path)
+      request["content-type"] = json_response_content_type
+      request["accept"] = json_response_content_type
+      request.body = JSON.dump({ "token_type_hint" => token_type_hint, "token" => token })
+
+      before_introspection_request(request)
+      response = http.request(request)
+      authorization_required unless response.code.to_i == 200
+
+      JSON.parse(response.body)
+    end
+
+    def before_introspection_request(request); end
+
+    def template_path(page)
+      path = File.join(File.dirname(__FILE__), "../../../templates", "#{page}.str")
+      return super unless File.exist?(path)
+
+      path
+    end
+
+    # to be used internally. Same semantics as require account, must:
+    # fetch an authorization basic header
+    # parse client id and secret
+    #
+    def require_oauth_application
+      # get client credenntials
+      client_id = client_secret = nil
+
+      # client_secret_basic
+      if (token = ((v = request.env["HTTP_AUTHORIZATION"]) && v[/\A *Basic (.*)\Z/, 1]))
+        client_id, client_secret = Base64.decode64(token).split(/:/, 2)
+      else
+        client_id = param_or_nil("client_id")
+        client_secret = param_or_nil("client_secret")
+      end
+
+      authorization_required unless client_id
+
+      @oauth_application = db[oauth_applications_table].where(oauth_applications_client_id_column => client_id).first
+
+      # skip if using pkce
+      return if @oauth_application && use_oauth_pkce? && param_or_nil("code_verifier")
+
+      authorization_required unless @oauth_application && secret_matches?(@oauth_application, client_secret)
+    end
+
     def secret_matches?(oauth_application, secret)
       BCrypt::Password.new(oauth_application[oauth_applications_client_secret_column]) == secret
     end
@@ -346,23 +477,27 @@ module Rodauth
       Base64.urlsafe_encode64(Digest::SHA256.digest(token))
     end
 
+    def token_from_application?(oauth_token, oauth_application)
+      oauth_token[oauth_tokens_oauth_application_id_column] == oauth_application[oauth_applications_id_column]
+    end
+
     unless method_defined?(:password_hash)
+      # :nocov:
       # From login_requirements_base feature
       if ENV["RACK_ENV"] == "test"
         def password_hash_cost
           BCrypt::Engine::MIN_COST
         end
       else
-        # :nocov:
         def password_hash_cost
           BCrypt::Engine::DEFAULT_COST
         end
-        # :nocov:
       end
 
       def password_hash(password)
         BCrypt::Password.create(password, cost: password_hash_cost)
       end
+      # :nocov:
     end
 
     def generate_oauth_token(params = {}, should_generate_refresh_token = true)
@@ -400,7 +535,7 @@ module Rodauth
 
       begin
         if ds.supports_returning?(:insert)
-          ds.returning.insert(params)
+          ds.returning.insert(params).first
         else
           id = ds.insert(params)
           ds.where(oauth_tokens_id_column => id).first
@@ -410,20 +545,36 @@ module Rodauth
       end
     end
 
-    def oauth_token_by_token(token)
-      if oauth_tokens_token_hash_column
-        db[oauth_tokens_table].where(oauth_tokens_token_hash_column => generate_token_hash(token))
-      else
-        db[oauth_tokens_table].where(oauth_tokens_token_column => token)
-      end
+    def oauth_token_by_token(token, dataset = db[oauth_tokens_table])
+      ds = if oauth_tokens_token_hash_column
+             dataset.where(oauth_tokens_token_hash_column => generate_token_hash(token))
+           else
+             dataset.where(oauth_tokens_token_column => token)
+           end
+
+      ds.where(Sequel[oauth_tokens_expires_in_column] >= Sequel::CURRENT_TIMESTAMP)
+        .where(oauth_tokens_revoked_at_column => nil).first
     end
 
-    def oauth_token_by_refresh_token(token)
-      if oauth_tokens_refresh_token_hash_column
-        db[oauth_tokens_table].where(oauth_tokens_refresh_token_hash_column => generate_token_hash(token))
-      else
-        db[oauth_tokens_table].where(oauth_tokens_refresh_token_column => token)
-      end
+    def oauth_token_by_refresh_token(token, dataset = db[oauth_tokens_table])
+      ds = if oauth_tokens_refresh_token_hash_column
+             dataset.where(oauth_tokens_refresh_token_hash_column => generate_token_hash(token))
+           else
+             dataset.where(oauth_tokens_refresh_token_column => token)
+           end
+
+      ds.where(Sequel[oauth_tokens_expires_in_column] >= Sequel::CURRENT_TIMESTAMP)
+        .where(oauth_tokens_revoked_at_column => nil).first
+    end
+
+    def json_access_token_payload(oauth_token)
+      payload = {
+        "access_token" => oauth_token[oauth_tokens_token_column],
+        "token_type" => oauth_token_type,
+        "expires_in" => oauth_token_expires_in
+      }
+      payload["refresh_token"] = oauth_token[oauth_tokens_refresh_token_column] if oauth_token[oauth_tokens_refresh_token_column]
+      payload
     end
 
     # Oauth Application
@@ -441,11 +592,21 @@ module Rodauth
 
     def validate_oauth_application_params
       oauth_application_params.each do |key, value|
-        if key == oauth_application_homepage_url_param ||
-           key == oauth_application_redirect_uri_param
+        if key == oauth_application_homepage_url_param
+
+          set_field_error(key, invalid_url_message) unless check_valid_uri?(value)
+
+        elsif key == oauth_application_redirect_uri_param
 
-          set_field_error(key, invalid_url_message) unless URI::DEFAULT_PARSER.make_regexp(%w[http https]).match?(value)
+          if value.respond_to?(:each)
+            value.each do |uri|
+              next if uri.empty?
 
+              set_field_error(key, invalid_url_message) unless check_valid_uri?(uri)
+            end
+          else
+            set_field_error(key, invalid_url_message) unless check_valid_uri?(value)
+          end
         elsif key == oauth_application_scopes_param
 
           value.each do |scope|
@@ -463,10 +624,12 @@ module Rodauth
         oauth_applications_name_column => oauth_application_params[oauth_application_name_param],
         oauth_applications_description_column => oauth_application_params[oauth_application_description_param],
         oauth_applications_scopes_column => oauth_application_params[oauth_application_scopes_param],
-        oauth_applications_homepage_url_column => oauth_application_params[oauth_application_homepage_url_param],
-        oauth_applications_redirect_uri_column => oauth_application_params[oauth_application_redirect_uri_param]
+        oauth_applications_homepage_url_column => oauth_application_params[oauth_application_homepage_url_param]
       }
 
+      redirect_uris = oauth_application_params[oauth_application_redirect_uri_param]
+      redirect_uris = redirect_uris.to_a.reject(&:empty?).join(" ") if redirect_uris.respond_to?(:each)
+      create_params[oauth_applications_redirect_uri_column] = redirect_uris unless redirect_uris.empty?
       # set client ID/secret pairs
 
       create_params.merge! \
@@ -475,25 +638,18 @@ module Rodauth
           secret_hash(oauth_application_params[oauth_application_client_secret_param])
 
       create_params[oauth_applications_scopes_column] = if create_params[oauth_applications_scopes_column]
-                                                          create_params[oauth_applications_scopes_column].join(",")
+                                                          create_params[oauth_applications_scopes_column].join(oauth_scope_separator)
                                                         else
                                                           oauth_application_default_scope
                                                         end
 
-      ds = db[oauth_applications_table]
-
       id = nil
       raised = begin
-        id = if ds.supports_returning?(:insert)
-               ds.returning(oauth_applications_id_column).insert(create_params)
-             else
-               id = db[oauth_applications_table].insert(create_params)
-               db[oauth_applications_table].where(oauth_applications_id_column => id).get(oauth_applications_id_column)
-             end
-        false
+                 id = db[oauth_applications_table].insert(create_params)
+                 false
                rescue Sequel::ConstraintViolation => e
                  e
-      end
+               end
 
       if raised
         field = raised.message[/\.(.*)$/, 1]
@@ -509,19 +665,24 @@ module Rodauth
     end
 
     # Authorize
+    def before_authorize
+      require_account
+    end
 
     def validate_oauth_grant_params
+      redirect_response_error("invalid_request", request.referer || default_redirect) unless oauth_application && check_valid_redirect_uri?
+
       unless oauth_application && check_valid_redirect_uri? && check_valid_access_type? &&
              check_valid_approval_prompt? && check_valid_response_type?
         redirect_response_error("invalid_request")
       end
       redirect_response_error("invalid_scope") unless check_valid_scopes?
 
-      validate_pkce_challenge_params
+      validate_pkce_challenge_params if use_oauth_pkce?
     end
 
     def try_approval_prompt
-      approval_prompt = param_or_nil(approval_prompt_param)
+      approval_prompt = param_or_nil("approval_prompt")
 
       return unless approval_prompt && approval_prompt == "auto"
 
@@ -529,7 +690,7 @@ module Rodauth
         oauth_grants_account_id_column => account_id,
         oauth_grants_oauth_application_id_column => oauth_application[oauth_applications_id_column],
         oauth_grants_redirect_uri_column => redirect_uri,
-        oauth_grants_scopes_column => scopes.join(","),
+        oauth_grants_scopes_column => scopes.join(oauth_scope_separator),
         oauth_grants_access_type_column => "online"
       ).count.zero?
 
@@ -538,197 +699,262 @@ module Rodauth
       request.env["REQUEST_METHOD"] = "POST"
     end
 
-    def create_oauth_grant
-      create_params = {
+    def create_oauth_grant(create_params = {})
+      create_params.merge!(
         oauth_grants_account_id_column => account_id,
         oauth_grants_oauth_application_id_column => oauth_application[oauth_applications_id_column],
         oauth_grants_redirect_uri_column => redirect_uri,
-        oauth_grants_code_column => oauth_unique_id_generator,
         oauth_grants_expires_in_column => Time.now + oauth_grant_expires_in,
-        oauth_grants_scopes_column => scopes.join(",")
-      }
+        oauth_grants_scopes_column => scopes.join(oauth_scope_separator)
+      )
 
-      if (access_type = param_or_nil(access_type_param))
-        create_params[oauth_grants_access_type_column] = access_type
+      # Access Type flow
+      if use_oauth_access_type?
+        if (access_type = param_or_nil("access_type"))
+          create_params[oauth_grants_access_type_column] = access_type
+        end
       end
 
       # PKCE flow
-      if (code_challenge = param_or_nil(code_challenge_param))
-        code_challenge_method = param_or_nil(code_challenge_method_param)
+      if use_oauth_pkce?
 
-        create_params[oauth_grants_code_challenge_column] = code_challenge
-        create_params[oauth_grants_code_challenge_method_column] = code_challenge_method
-      elsif oauth_require_pkce
-        redirect_response_error("code_challenge_required")
+        if (code_challenge = param_or_nil("code_challenge"))
+          code_challenge_method = param_or_nil("code_challenge_method")
+
+          create_params[oauth_grants_code_challenge_column] = code_challenge
+          create_params[oauth_grants_code_challenge_method_column] = code_challenge_method
+        elsif oauth_require_pkce
+          redirect_response_error("code_challenge_required")
+        end
       end
 
       ds = db[oauth_grants_table]
 
       begin
-        if ds.supports_returning?(:insert)
-          ds.returning(authorize_code_column).insert(create_params)
-        else
-          id = ds.insert(create_params)
-          ds.where(oauth_grants_id_column => id).get(oauth_grants_code_column)
-        end
+        authorization_code = oauth_unique_id_generator
+        create_params[oauth_grants_code_column] = authorization_code
+        ds.insert(create_params)
+        authorization_code
       rescue Sequel::UniqueConstraintViolation
         retry
       end
     end
 
-    # Access Tokens
+    def do_authorize(redirect_url, query_params = [], fragment_params = [])
+      case param("response_type")
+      when "token"
+        redirect_response_error("invalid_request") unless use_oauth_implicit_grant_type?
 
-    def validate_oauth_token_params
-      redirect_response_error("invalid_request") unless param_or_nil(client_id_param)
+        fragment_params.replace(_do_authorize_token.map { |k, v| "#{k}=#{v}" })
+      when "code", "", nil
+        query_params.replace(_do_authorize_code.map { |k, v| "#{k}=#{v}" })
+      end
 
-      unless param_or_nil(client_secret_param)
-        redirect_response_error("invalid_request") unless param_or_nil(code_verifier_param)
+      if param_or_nil("state")
+        if !fragment_params.empty?
+          fragment_params << "state=#{param('state')}"
+        else
+          query_params << "state=#{param('state')}"
+        end
       end
 
-      unless (grant_type = param_or_nil(grant_type_param))
+      query_params << redirect_url.query if redirect_url.query
+
+      redirect_url.query = query_params.join("&") unless query_params.empty?
+      redirect_url.fragment = fragment_params.join("&") unless fragment_params.empty?
+    end
+
+    def _do_authorize_code
+      { "code" => create_oauth_grant }
+    end
+
+    def _do_authorize_token
+      create_params = {
+        oauth_tokens_account_id_column => account_id,
+        oauth_tokens_oauth_application_id_column => oauth_application[oauth_applications_id_column],
+        oauth_tokens_scopes_column => scopes
+      }
+      oauth_token = generate_oauth_token(create_params, false)
+
+      json_access_token_payload(oauth_token)
+    end
+
+    # Access Tokens
+
+    def before_token
+      require_oauth_application
+    end
+
+    def validate_oauth_token_params
+      unless (grant_type = param_or_nil("grant_type"))
         redirect_response_error("invalid_request")
       end
 
       case grant_type
       when "authorization_code"
-        redirect_response_error("invalid_request") unless param_or_nil(code_param)
+        redirect_response_error("invalid_request") unless param_or_nil("code")
 
       when "refresh_token"
-        redirect_response_error("invalid_request") unless param_or_nil(refresh_token_param)
+        redirect_response_error("invalid_request") unless param_or_nil("refresh_token")
       else
         redirect_response_error("invalid_request")
       end
     end
 
     def create_oauth_token
-      oauth_application = db[oauth_applications_table].where(
-        oauth_applications_client_id_column => param(client_id_param)
-      ).first
-
-      redirect_response_error("invalid_request") unless oauth_application
-
-      if (client_secret = param_or_nil(client_secret_param))
-        redirect_response_error("invalid_request") unless secret_matches?(oauth_application, client_secret)
-      end
-
-      case param(grant_type_param)
+      case param("grant_type")
       when "authorization_code"
-
         # fetch oauth grant
         oauth_grant = db[oauth_grants_table].where(
-          oauth_grants_code_column => param(code_param),
-          oauth_grants_redirect_uri_column => param(redirect_uri_param),
+          oauth_grants_code_column => param("code"),
+          oauth_grants_redirect_uri_column => param("redirect_uri"),
           oauth_grants_oauth_application_id_column => oauth_application[oauth_applications_id_column],
           oauth_grants_revoked_at_column => nil
         ).where(Sequel[oauth_grants_expires_in_column] >= Sequel::CURRENT_TIMESTAMP)
+                                            .for_update
                                             .first
 
         redirect_response_error("invalid_grant") unless oauth_grant
 
-        # PKCE
-        if oauth_grant[oauth_grants_code_challenge_column]
-          code_verifier = param_or_nil(code_verifier_param)
-
-          unless code_verifier && check_valid_grant_challenge?(oauth_grant, code_verifier)
-            redirect_response_error("invalid_request")
-          end
-        elsif oauth_require_pkce
-          redirect_response_error("code_challenge_required")
-        end
-
         create_params = {
           oauth_tokens_account_id_column => oauth_grant[oauth_grants_account_id_column],
           oauth_tokens_oauth_application_id_column => oauth_grant[oauth_grants_oauth_application_id_column],
           oauth_tokens_oauth_grant_id_column => oauth_grant[oauth_grants_id_column],
           oauth_tokens_scopes_column => oauth_grant[oauth_grants_scopes_column]
         }
-
-        # revoke oauth grant
-        db[oauth_grants_table].where(oauth_grants_id_column => oauth_grant[oauth_grants_id_column])
-                              .update(oauth_grants_revoked_at_column => Sequel::CURRENT_TIMESTAMP)
-
-        generate_oauth_token(create_params, oauth_grant[oauth_grants_access_type_column] == "offline")
-
+        create_oauth_token_from_authorization_code(oauth_grant, create_params)
       when "refresh_token"
         # fetch oauth token
-        oauth_token = oauth_token_by_refresh_token(param(refresh_token_param)).where(
-          oauth_tokens_oauth_application_id_column => oauth_application[oauth_applications_id_column]
-        ).where(oauth_grants_revoked_at_column => nil).first
+        oauth_token = oauth_token_by_refresh_token(param("refresh_token"))
 
         redirect_response_error("invalid_grant") unless oauth_token
 
-        token = oauth_unique_id_generator
-
         update_params = {
           oauth_tokens_oauth_application_id_column => oauth_token[oauth_grants_oauth_application_id_column],
           oauth_tokens_expires_in_column => Time.now + oauth_token_expires_in
         }
+        create_oauth_token_from_token(oauth_token, update_params)
+      else
+        redirect_response_error("invalid_grant")
+      end
+    end
 
-        if oauth_tokens_token_hash_column
-          update_params[oauth_tokens_token_hash_column] = generate_token_hash(token)
-        else
-          update_params[oauth_tokens_token_column] = token
+    def create_oauth_token_from_authorization_code(oauth_grant, create_params)
+      # PKCE
+      if use_oauth_pkce?
+        if oauth_grant[oauth_grants_code_challenge_column]
+          code_verifier = param_or_nil("code_verifier")
+
+          redirect_response_error("invalid_request") unless code_verifier && check_valid_grant_challenge?(oauth_grant, code_verifier)
+        elsif oauth_require_pkce
+          redirect_response_error("code_challenge_required")
         end
+      end
 
-        ds = db[oauth_tokens_table].where(oauth_tokens_id_column => oauth_token[oauth_tokens_id_column])
+      # revoke oauth grant
+      db[oauth_grants_table].where(oauth_grants_id_column => oauth_grant[oauth_grants_id_column])
+                            .update(oauth_grants_revoked_at_column => Sequel::CURRENT_TIMESTAMP)
 
-        oauth_token = begin
-          if ds.supports_returning?(:update)
-            ds.returning.update(update_params)
-          else
-            ds.update(update_params)
-            ds.first
-          end
-                      rescue Sequel::UniqueConstraintViolation
-                        retry
-        end
+      should_generate_refresh_token = !use_oauth_access_type? ||
+                                      oauth_grant[oauth_grants_access_type_column] == "offline"
+
+      generate_oauth_token(create_params, should_generate_refresh_token)
+    end
+
+    def create_oauth_token_from_token(oauth_token, update_params)
+      redirect_response_error("invalid_grant") unless token_from_application?(oauth_token, oauth_application)
 
-        oauth_token[oauth_tokens_token_column] = token
-        oauth_token
+      token = oauth_unique_id_generator
+
+      if oauth_tokens_token_hash_column
+        update_params[oauth_tokens_token_hash_column] = generate_token_hash(token)
       else
-        redirect_response_error("invalid_grant")
+        update_params[oauth_tokens_token_column] = token
+      end
+
+      ds = db[oauth_tokens_table].where(oauth_tokens_id_column => oauth_token[oauth_tokens_id_column])
+
+      oauth_token = begin
+        if ds.supports_returning?(:update)
+          ds.returning.update(update_params).first
+        else
+          ds.update(update_params)
+          ds.first
+        end
+                    rescue Sequel::UniqueConstraintViolation
+                      retry
+      end
+
+      oauth_token[oauth_tokens_token_column] = token
+      oauth_token
+    end
+
+    TOKEN_HINT_TYPES = %w[access_token refresh_token].freeze
+
+    # Token introspect
+
+    def validate_oauth_introspect_params
+      # check if valid token hint type
+      if param_or_nil("token_type_hint")
+        redirect_response_error("unsupported_token_type") unless TOKEN_HINT_TYPES.include?(param("token_type_hint"))
       end
+
+      redirect_response_error("invalid_request") unless param_or_nil("token")
+    end
+
+    def json_token_introspect_payload(token)
+      return { active: false } unless token
+
+      {
+        active: true,
+        scope: token[oauth_tokens_scopes_column],
+        client_id: oauth_application[oauth_applications_client_id_column],
+        # username
+        token_type: oauth_token_type
+      }
     end
 
+    def before_introspect; end
+
     # Token revocation
 
-    TOKEN_HINT_TYPES = %w[access_token refresh_token].freeze
+    def before_revoke
+      require_oauth_application
+    end
 
     def validate_oauth_revoke_params
       # check if valid token hint type
-      redirect_response_error("unsupported_token_type") unless TOKEN_HINT_TYPES.include?(token_type_hint)
+      if param_or_nil("token_type_hint")
+        redirect_response_error("unsupported_token_type") unless TOKEN_HINT_TYPES.include?(param("token_type_hint"))
+      end
 
-      redirect_response_error("invalid_request") unless param(token_param)
+      redirect_response_error("invalid_request") unless param_or_nil("token")
     end
 
     def revoke_oauth_token
-      ds = case token_type_hint
-           when "access_token"
-             oauth_token_by_token(token)
-           when "refresh_token"
-             oauth_token_by_refresh_token(token)
-           end
-      # one can only revoke tokens which haven't been revoked before, and which are
-      # either our tokens, or tokens from applications we own.
-      oauth_token = ds.where(oauth_tokens_revoked_at_column => nil)
-                      .where(
-                        Sequel.or(
-                          oauth_tokens_account_id_column => account_id,
-                          oauth_tokens_oauth_application_id_column => db[oauth_applications_table].where(
-                            oauth_applications_client_id_column => param(client_id_param),
-                            oauth_applications_account_id_column => account_id
-                          ).select(oauth_applications_id_column)
-                        )
-                      ).first
+      token = param("token")
+
+      oauth_token = if param("token_type_hint") == "refresh_token"
+                      oauth_token_by_refresh_token(token)
+                    else
+                      oauth_token_by_token(token)
+                    end
 
       redirect_response_error("invalid_request") unless oauth_token
 
+      if oauth_application
+        redirect_response_error("invalid_request") unless token_from_application?(oauth_token, oauth_application)
+      else
+        @oauth_application = db[oauth_applications_table].where(oauth_applications_id_column =>
+          oauth_token[oauth_tokens_oauth_application_id_column]).first
+      end
+
       update_params = { oauth_tokens_revoked_at_column => Sequel::CURRENT_TIMESTAMP }
 
       ds = db[oauth_tokens_table].where(oauth_tokens_id_column => oauth_token[oauth_tokens_id_column])
 
       oauth_token = if ds.supports_returning?(:update)
-                      ds.returning.update(update_params)
+                      ds.returning.update(update_params).first
                     else
                       ds.update(update_params)
                       ds.first
@@ -748,8 +974,8 @@ module Rodauth
 
     # Response helpers
 
-    def redirect_response_error(error_code, redirect_url = request.referer || default_redirect)
-      if json_request?
+    def redirect_response_error(error_code, redirect_url = redirect_uri || request.referer || default_redirect)
+      if accepts_json?
         throw_json_response_error(invalid_oauth_response_status, error_code)
       else
         redirect_url = URI.parse(redirect_url)
@@ -772,6 +998,14 @@ module Rodauth
       end
     end
 
+    def json_response_success(body)
+      response.status = 200
+      response["Content-Type"] ||= json_response_content_type
+      json_payload = _json_response_body(body)
+      response.write(json_payload)
+      request.halt
+    end
+
     def throw_json_response_error(status, error_code)
       set_response_error_status(status)
       code = if respond_to?(:"#{error_code}_error_code")
@@ -783,12 +1017,13 @@ module Rodauth
       payload["error_description"] = send(:"#{error_code}_message") if respond_to?(:"#{error_code}_message")
       json_payload = _json_response_body(payload)
       response["Content-Type"] ||= json_response_content_type
-      response["WWW-Authenticate"] = "Bearer" if status == 401
+      response["WWW-Authenticate"] = oauth_token_type.upcase if status == 401
       response.write(json_payload)
       request.halt
     end
 
     unless method_defined?(:_json_response_body)
+      # :nocov:
       def _json_response_body(hash)
         if request.respond_to?(:convert_to_json)
           request.send(:convert_to_json, hash)
@@ -796,47 +1031,56 @@ module Rodauth
           JSON.dump(hash)
         end
       end
+      # :nocov:
     end
 
     def authorization_required
-      if json_request?
+      if accepts_json?
         throw_json_response_error(authorization_required_error_status, "invalid_client")
       else
         set_redirect_error_flash(require_authorization_error_flash)
-        redirect(require_authorization_redirect)
+        redirect(authorize_path)
       end
     end
 
+    def check_valid_uri?(uri)
+      URI::DEFAULT_PARSER.make_regexp(oauth_valid_uri_schemes).match?(uri)
+    end
+
     def check_valid_scopes?
       return false unless scopes
 
-      (scopes - oauth_application[oauth_applications_scopes_column].split(",")).empty?
+      (scopes - oauth_application[oauth_applications_scopes_column].split(oauth_scope_separator)).empty?
     end
 
     def check_valid_redirect_uri?
-      redirect_uri == oauth_application[oauth_applications_redirect_uri_column]
+      oauth_application[oauth_applications_redirect_uri_column].split(" ").include?(redirect_uri)
     end
 
     ACCESS_TYPES = %w[offline online].freeze
 
     def check_valid_access_type?
-      access_type = param_or_nil(access_type_param)
+      return true unless use_oauth_access_type?
+
+      access_type = param_or_nil("access_type")
       !access_type || ACCESS_TYPES.include?(access_type)
     end
 
     APPROVAL_PROMPTS = %w[force auto].freeze
 
     def check_valid_approval_prompt?
-      approval_prompt = param_or_nil(approval_prompt_param)
+      return true unless use_oauth_access_type?
+
+      approval_prompt = param_or_nil("approval_prompt")
       !approval_prompt || APPROVAL_PROMPTS.include?(approval_prompt)
     end
 
     def check_valid_response_type?
-      response_type = param_or_nil(response_type_param)
+      response_type = param_or_nil("response_type")
 
       return true if response_type.nil? || response_type == "code"
 
-      return use_oauth_implicit_grant_type if response_type == "token"
+      return use_oauth_implicit_grant_type? if response_type == "token"
 
       false
     end
@@ -844,9 +1088,9 @@ module Rodauth
     # PKCE
 
     def validate_pkce_challenge_params
-      if param_or_nil(code_challenge_param)
+      if param_or_nil("code_challenge")
 
-        challenge_method = param_or_nil(code_challenge_method_param)
+        challenge_method = param_or_nil("code_challenge_method")
         redirect_response_error("code_challenge_required") unless oauth_pkce_challenge_method == challenge_method
       else
         return unless oauth_require_pkce
@@ -871,121 +1115,149 @@ module Rodauth
       end
     end
 
-    # /oauth-token
-    route(:oauth_token) do |r|
+    # Server metadata
+
+    def oauth_server_metadata_body(path)
+      issuer = base_url
+      issuer += "/#{path}" if path
+
+      responses_supported = %w[code]
+      response_modes_supported = %w[query]
+      grant_types_supported = %w[authorization_code]
+
+      if use_oauth_implicit_grant_type?
+        responses_supported << "token"
+        response_modes_supported << "fragment"
+        grant_types_supported << "implicit"
+      end
+      {
+        issuer: issuer,
+        authorization_endpoint: authorize_url,
+        token_endpoint: token_url,
+        registration_endpoint: "#{base_url}/#{oauth_applications_path}",
+        scopes_supported: oauth_application_scopes,
+        response_types_supported: responses_supported,
+        response_modes_supported: response_modes_supported,
+        grant_types_supported: grant_types_supported,
+        token_endpoint_auth_methods_supported: %w[client_secret_basic client_secret_post],
+        service_documentation: oauth_metadata_service_documentation,
+        ui_locales_supported: oauth_metadata_ui_locales_supported,
+        op_policy_uri: oauth_metadata_op_policy_uri,
+        op_tos_uri: oauth_metadata_op_tos_uri,
+        revocation_endpoint: revoke_url,
+        revocation_endpoint_auth_methods_supported: nil, # because it's client_secret_basic
+        introspection_endpoint: introspect_url,
+        introspection_endpoint_auth_methods_supported: %w[client_secret_basic],
+        code_challenge_methods_supported: (use_oauth_pkce? ? oauth_pkce_challenge_method : nil)
+      }
+    end
+
+    # /token
+    route(:token) do |r|
+      next unless is_authorization_server?
+
+      before_token
+
       r.post do
         catch_error do
           validate_oauth_token_params
 
           oauth_token = nil
           transaction do
-            before_token
             oauth_token = create_oauth_token
-            after_token
           end
 
-          response.status = 200
-          response["Content-Type"] ||= json_response_content_type
-          json_response = {
-            "token" => oauth_token[oauth_tokens_token_column],
-            "token_type" => oauth_token_type,
-            "expires_in" => oauth_token_expires_in
-          }
+          json_response_success(json_access_token_payload(oauth_token))
+        end
+
+        throw_json_response_error(invalid_oauth_response_status, "invalid_request")
+      end
+    end
+
+    # /introspect
+    route(:introspect) do |r|
+      next unless is_authorization_server?
+
+      before_introspect
+
+      r.post do
+        catch_error do
+          validate_oauth_introspect_params
 
-          json_response["refresh_token"] = oauth_token[oauth_tokens_refresh_token_column] if oauth_token[:refresh_token]
+          oauth_token = case param("token_type_hint")
+                        when "access_token"
+                          oauth_token_by_token(param("token"))
+                        when "refresh_token"
+                          oauth_token_by_refresh_token(param("token"))
+                        else
+                          oauth_token_by_token(param("token")) || oauth_token_by_refresh_token(param("token"))
+                        end
 
-          json_payload = _json_response_body(json_response)
-          response.write(json_payload)
-          request.halt
+          if oauth_application
+            redirect_response_error("invalid_request") if oauth_token && !token_from_application?(oauth_token, oauth_application)
+          elsif oauth_token
+            @oauth_application = db[oauth_applications_table].where(oauth_applications_id_column =>
+              oauth_token[oauth_tokens_oauth_application_id_column]).first
+          end
+
+          json_response_success(json_token_introspect_payload(oauth_token))
         end
 
         throw_json_response_error(invalid_oauth_response_status, "invalid_request")
       end
     end
 
-    # /oauth-revoke
-    route(:oauth_revoke) do |r|
-      require_account
+    # /revoke
+    route(:revoke) do |r|
+      next unless is_authorization_server?
+
+      before_revoke
 
-      # access-token
       r.post do
         catch_error do
           validate_oauth_revoke_params
 
           oauth_token = nil
           transaction do
-            before_revoke
             oauth_token = revoke_oauth_token
             after_revoke
           end
 
-          if json_request?
-            response.status = 200
-            response["Content-Type"] ||= json_response_content_type
-            json_response = {
+          if accepts_json?
+            json_response_success \
               "token" => oauth_token[oauth_tokens_token_column],
               "refresh_token" => oauth_token[oauth_tokens_refresh_token_column],
               "revoked_at" => oauth_token[oauth_tokens_revoked_at_column]
-            }
-            json_payload = _json_response_body(json_response)
-            response.write(json_payload)
-            request.halt
           else
             set_notice_flash revoke_oauth_token_notice_flash
             redirect request.referer || "/"
           end
         end
 
-        throw_json_response_error(invalid_oauth_response_status, "invalid_request")
+        redirect_response_error("invalid_request", request.referer || "/")
       end
     end
 
-    # /oauth-authorize
-    route(:oauth_authorize) do |r|
+    # /authorize
+    route(:authorize) do |r|
+      next unless is_authorization_server?
+
       require_account
       validate_oauth_grant_params
-      try_approval_prompt if request.get?
+      try_approval_prompt if use_oauth_access_type? && request.get?
+
+      before_authorize
 
       r.get do
         authorize_view
       end
 
       r.post do
-        code = nil
-        query_params = []
-        fragment_params = []
+        redirect_url = URI.parse(redirect_uri)
 
         transaction do
-          before_authorize
-          case param(response_type_param)
-          when "token"
-            redirect_response_error("invalid_request", redirect_uri) unless use_oauth_implicit_grant_type
-
-            create_params = {
-              oauth_tokens_account_id_column => account_id,
-              oauth_tokens_oauth_application_id_column => oauth_application[oauth_applications_id_column],
-              oauth_tokens_scopes_column => scopes
-            }
-            oauth_token = generate_oauth_token(create_params, false)
-
-            fragment_params << ["access_token=#{oauth_token[oauth_tokens_token_column]}"]
-            fragment_params << ["token_type=#{oauth_token_type}"]
-            fragment_params << ["expires_in=#{oauth_token_expires_in}"]
-          when "code", "", nil
-            code = create_oauth_grant
-            query_params << ["code=#{code}"]
-          else
-            redirect_response_error("invalid_request")
-          end
-          after_authorize
+          do_authorize(redirect_url)
         end
-
-        redirect_url = URI.parse(redirect_uri)
-        query_params << "state=#{state}" if state
-        query_params << redirect_url.query if redirect_url.query
-        redirect_url.query = query_params.join("&") unless query_params.empty?
-        redirect_url.fragment = fragment_params.join("&") unless fragment_params.empty?
-
         redirect(redirect_url.to_s)
       end
     end