roda 3.28.0 → 3.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2de9e0d72db9d2f1d1143c71738067798dbcc3f2786611f8f0a5f85c32f26167
-  data.tar.gz: 92645c4e9792b1217cfae3d8b430741f64212a30003cf81b393c37636dc531c0
+  metadata.gz: 47d34c142084b4dc11049861f97621177bd1071744caff3b18ad113a79308139
+  data.tar.gz: 7021cfd179b0bd159f93ff31d86b9128686686d2f63c2068863b3ffc5150b44a
 SHA512:
-  metadata.gz: 35a615a610ca645130cbd15482f6864a50a3a8727e6e4cf7bad8d63a00e40118f7a0443f88931ec24a5f416ae822a9bd8ebc101f930efff178831660d5125849
-  data.tar.gz: a6b9f48cfe249297ce8abfd3a856c65634364ea0490910b956f25fe4cd54c4b77096bd980a59276e6ed0fb4db537e99fa8b4e1e0e35441afaaf942ca7e92bb02
+  metadata.gz: 48fa41c207a4e37aaa3deb8eb773480bd015875e8f2c9ef7d4489ef6b2538ad98001afa9ab1adf7555ebc100929a5cd0b7eb1b333cc331255818583c1d1dfb25
+  data.tar.gz: 4f7103b4730ed2f51309704c8f991c5c3f7fc3c865e07ba917219b54ef9019e0bafddbdeca280bd8343c8fd1e496ca5e3444e674eb59c93e98f5bdf7eab09647

data/CHANGELOG

@@ -1,3 +1,13 @@
+= 3.29.0 (2020-02-14)
+
+* Remove specs and old release notes from the gem to reduce gem size by over 35% (jeremyevans)
+
+* Raise RodaError if trying to load a plugin that is not a module (jeremyevans)
+
+* Include SCRIPT_NAME when logging in common logger plugin (jeremyevans)
+
+* Handle invalid POST data when using the exception_page plugin (jeremyevans)
+
 = 3.28.0 (2020-01-15)
 
 * Add session_created_at and session_updated_at methods to the sessions plugin (jeremyevans)

data/README.rdoc

@@ -137,6 +137,16 @@ in your application.  It is recommended to freeze the app in production and
 during testing.  The +.app+ is an optimization, which saves a few method calls
 for every request.
 
+== Running the Application
+
+Running a Roda application is similar to running any other rack-based application
+that uses a +config.ru+ file.  You can start a basic server using +rackup+:
+
+  $ rackup
+
+Ruby web servers such as Unicorn and Puma also ship with their own programs
+that you can use to run a Roda application.
+
 == The Routing Tree
 
 Roda is called a routing tree web toolkit because the way most sites are structured,

data/doc/release_notes/3.29.0.txt

@@ -0,0 +1,15 @@
+= Improvements
+
+* The common_logger plugin now includes the SCRIPT_NAME when
+  logging, for greater compatibility with typical web server
+  logs.
+
+* The exception_page plugin now handles invalid POST data.
+  Previously, invalid POST data would cause the exception page
+  display to raise an exception.
+
+* An error is now raised if trying to load a plugin that is not a
+  module or a recognized plugin symbol.
+
+* Specs and older release notes are no longer shipped in the
+  gem, reducing gem size by over 35%.

data/lib/roda.rb

@@ -269,6 +269,7 @@ class Roda
         def plugin(plugin, *args, &block)
           raise RodaError, "Cannot add a plugin to a frozen Roda class" if frozen?
           plugin = RodaPlugins.load_plugin(plugin) if plugin.is_a?(Symbol)
+          raise RodaError, "Invalid plugin type: #{plugin.class.inspect}" unless plugin.is_a?(Module)
           plugin.load_dependencies(self, *args, &block) if plugin.respond_to?(:load_dependencies)
           include(plugin::InstanceMethods) if defined?(plugin::InstanceMethods)
           extend(plugin::ClassMethods) if defined?(plugin::ClassMethods)

data/lib/roda/plugins/caching.rb

@@ -1,5 +1,7 @@
 # frozen-string-literal: true
 
+require 'time'
+
 #
 class Roda
   module RodaPlugins

data/lib/roda/plugins/common_logger.rb

@@ -52,7 +52,7 @@ class Roda
 
           env = @_request.env
 
-          opts[:common_logger_meth].call("#{env['HTTP_X_FORWARDED_FOR'] || env["REMOTE_ADDR"] || "-"} - #{env["REMOTE_USER"] || "-"} [#{Time.now.strftime("%d/%b/%Y:%H:%M:%S %z")}] \"#{env["REQUEST_METHOD"]} #{env["PATH_INFO"]}#{"?#{env["QUERY_STRING"]}" if ((qs = env["QUERY_STRING"]) && !qs.empty?)} #{env["HTTP_VERSION"]}\" #{result[0]} #{((length = result[1]['Content-Length']) && (length unless length == '0')) || '-'} #{elapsed_time}\n")
+          opts[:common_logger_meth].call("#{env['HTTP_X_FORWARDED_FOR'] || env["REMOTE_ADDR"] || "-"} - #{env["REMOTE_USER"] || "-"} [#{Time.now.strftime("%d/%b/%Y:%H:%M:%S %z")}] \"#{env["REQUEST_METHOD"]} #{env["SCRIPT_NAME"]}#{env["PATH_INFO"]}#{"?#{env["QUERY_STRING"]}" if ((qs = env["QUERY_STRING"]) && !qs.empty?)} #{env["HTTP_VERSION"]}\" #{result[0]} #{((length = result[1]['Content-Length']) && (length unless length == '0')) || '-'} #{elapsed_time}\n")
         end
 
         # Create timer instance used for timing

data/lib/roda/plugins/exception_page.rb

@@ -267,6 +267,12 @@ END
             end.compact
 
             r = @_request
+            begin 
+              post_data = r.POST
+              missing_post = "No POST data"
+            rescue
+              missing_post = "Invalid POST data"
+            end
             info = lambda do |title, id, var, none|
               <<END
   <h3 id="#{id}">#{title}</h3>
@@ -363,7 +369,7 @@ END1
   <h2>Request information</h2>
 
   #{info.call('GET', 'get-info', r.GET, 'No GET data')}
-  #{info.call('POST', 'post-info', r.POST, 'No POST data')}
+  #{info.call('POST', 'post-info', post_data, missing_post)}
   #{info.call('Cookies', 'cookie-info', r.cookies, 'No cookie data')}
   #{info.call('Rack ENV', 'env-info', r.env, 'No Rack env?')}
 </div>

data/lib/roda/plugins/indifferent_params.rb

@@ -42,6 +42,8 @@ class Roda
       INDIFFERENT_PROC = lambda{|h,k| h[k.to_s] if k.is_a?(Symbol)}
 
       if Rack.release > '2'
+        require 'rack/query_parser'
+
         class QueryParser < Rack::QueryParser
           # Work around for invalid optimization in rack
           def parse_nested_query(qs, d=nil)

data/lib/roda/version.rb

@@ -4,7 +4,7 @@ class Roda
   RodaMajorVersion = 3
 
   # The minor version of Roda, updated for new feature releases of Roda.
-  RodaMinorVersion = 28
+  RodaMinorVersion = 29
 
   # The patch version of Roda, updated only for bug fixes from the last
   # feature release.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roda
 version: !ruby/object:Gem::Version
-  version: 3.28.0
+  version: 3.29.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-15 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -175,41 +175,6 @@ extra_rdoc_files:
 - CHANGELOG
 - doc/conventions.rdoc
 - doc/release_notes/3.7.0.txt
-- doc/release_notes/1.0.0.txt
-- doc/release_notes/1.1.0.txt
-- doc/release_notes/1.2.0.txt
-- doc/release_notes/1.3.0.txt
-- doc/release_notes/2.0.0.txt
-- doc/release_notes/2.1.0.txt
-- doc/release_notes/2.10.0.txt
-- doc/release_notes/2.11.0.txt
-- doc/release_notes/2.12.0.txt
-- doc/release_notes/2.13.0.txt
-- doc/release_notes/2.14.0.txt
-- doc/release_notes/2.15.0.txt
-- doc/release_notes/2.16.0.txt
-- doc/release_notes/2.17.0.txt
-- doc/release_notes/2.18.0.txt
-- doc/release_notes/2.19.0.txt
-- doc/release_notes/2.2.0.txt
-- doc/release_notes/2.20.0.txt
-- doc/release_notes/2.21.0.txt
-- doc/release_notes/2.22.0.txt
-- doc/release_notes/2.23.0.txt
-- doc/release_notes/2.24.0.txt
-- doc/release_notes/2.25.0.txt
-- doc/release_notes/2.26.0.txt
-- doc/release_notes/2.27.0.txt
-- doc/release_notes/2.28.0.txt
-- doc/release_notes/2.29.0.txt
-- doc/release_notes/2.3.0.txt
-- doc/release_notes/2.4.0.txt
-- doc/release_notes/2.5.0.txt
-- doc/release_notes/2.5.1.txt
-- doc/release_notes/2.6.0.txt
-- doc/release_notes/2.7.0.txt
-- doc/release_notes/2.8.0.txt
-- doc/release_notes/2.9.0.txt
 - doc/release_notes/3.0.0.txt
 - doc/release_notes/3.1.0.txt
 - doc/release_notes/3.2.0.txt
@@ -239,47 +204,12 @@ extra_rdoc_files:
 - doc/release_notes/3.26.0.txt
 - doc/release_notes/3.27.0.txt
 - doc/release_notes/3.28.0.txt
+- doc/release_notes/3.29.0.txt
 files:
 - CHANGELOG
 - MIT-LICENSE
 - README.rdoc
-- Rakefile
 - doc/conventions.rdoc
-- doc/release_notes/1.0.0.txt
-- doc/release_notes/1.1.0.txt
-- doc/release_notes/1.2.0.txt
-- doc/release_notes/1.3.0.txt
-- doc/release_notes/2.0.0.txt
-- doc/release_notes/2.1.0.txt
-- doc/release_notes/2.10.0.txt
-- doc/release_notes/2.11.0.txt
-- doc/release_notes/2.12.0.txt
-- doc/release_notes/2.13.0.txt
-- doc/release_notes/2.14.0.txt
-- doc/release_notes/2.15.0.txt
-- doc/release_notes/2.16.0.txt
-- doc/release_notes/2.17.0.txt
-- doc/release_notes/2.18.0.txt
-- doc/release_notes/2.19.0.txt
-- doc/release_notes/2.2.0.txt
-- doc/release_notes/2.20.0.txt
-- doc/release_notes/2.21.0.txt
-- doc/release_notes/2.22.0.txt
-- doc/release_notes/2.23.0.txt
-- doc/release_notes/2.24.0.txt
-- doc/release_notes/2.25.0.txt
-- doc/release_notes/2.26.0.txt
-- doc/release_notes/2.27.0.txt
-- doc/release_notes/2.28.0.txt
-- doc/release_notes/2.29.0.txt
-- doc/release_notes/2.3.0.txt
-- doc/release_notes/2.4.0.txt
-- doc/release_notes/2.5.0.txt
-- doc/release_notes/2.5.1.txt
-- doc/release_notes/2.6.0.txt
-- doc/release_notes/2.7.0.txt
-- doc/release_notes/2.8.0.txt
-- doc/release_notes/2.9.0.txt
 - doc/release_notes/3.0.0.txt
 - doc/release_notes/3.1.0.txt
 - doc/release_notes/3.10.0.txt
@@ -303,6 +233,7 @@ files:
 - doc/release_notes/3.26.0.txt
 - doc/release_notes/3.27.0.txt
 - doc/release_notes/3.28.0.txt
+- doc/release_notes/3.29.0.txt
 - doc/release_notes/3.3.0.txt
 - doc/release_notes/3.4.0.txt
 - doc/release_notes/3.5.0.txt
@@ -415,147 +346,6 @@ files:
 - lib/roda/response.rb
 - lib/roda/session_middleware.rb
 - lib/roda/version.rb
-- spec/all.rb
-- spec/assets/css/app.scss
-- spec/assets/css/no_access.css
-- spec/assets/css/raw.css
-- spec/assets/js/head/app.js
-- spec/composition_spec.rb
-- spec/define_roda_method_spec.rb
-- spec/env_spec.rb
-- spec/freeze_spec.rb
-- spec/integration_spec.rb
-- spec/matchers_spec.rb
-- spec/opts_spec.rb
-- spec/plugin/_after_hook_spec.rb
-- spec/plugin/all_verbs_spec.rb
-- spec/plugin/assets_preloading_spec.rb
-- spec/plugin/assets_spec.rb
-- spec/plugin/backtracking_array_spec.rb
-- spec/plugin/branch_locals_spec.rb
-- spec/plugin/caching_spec.rb
-- spec/plugin/chunked_spec.rb
-- spec/plugin/class_level_routing_spec.rb
-- spec/plugin/class_matchers_spec.rb
-- spec/plugin/common_logger_spec.rb
-- spec/plugin/content_for_spec.rb
-- spec/plugin/content_security_policy_spec.rb
-- spec/plugin/cookies_spec.rb
-- spec/plugin/csrf_spec.rb
-- spec/plugin/default_headers_spec.rb
-- spec/plugin/default_status_spec.rb
-- spec/plugin/delay_build_spec.rb
-- spec/plugin/delegate_spec.rb
-- spec/plugin/delete_empty_headers_spec.rb
-- spec/plugin/direct_call_spec.rb
-- spec/plugin/disallow_file_uploads_spec.rb
-- spec/plugin/drop_body_spec.rb
-- spec/plugin/early_hints_spec.rb
-- spec/plugin/empty_root_spec.rb
-- spec/plugin/environments_spec.rb
-- spec/plugin/error_email_spec.rb
-- spec/plugin/error_handler_spec.rb
-- spec/plugin/error_mail_spec.rb
-- spec/plugin/exception_page_spec.rb
-- spec/plugin/flash_spec.rb
-- spec/plugin/h_spec.rb
-- spec/plugin/halt_spec.rb
-- spec/plugin/hash_matcher_spec.rb
-- spec/plugin/hash_routes_spec.rb
-- spec/plugin/head_spec.rb
-- spec/plugin/header_matchers_spec.rb
-- spec/plugin/heartbeat_spec.rb
-- spec/plugin/hooks_spec.rb
-- spec/plugin/indifferent_params_spec.rb
-- spec/plugin/json_parser_spec.rb
-- spec/plugin/json_spec.rb
-- spec/plugin/mail_processor_spec.rb
-- spec/plugin/mailer_spec.rb
-- spec/plugin/match_affix_spec.rb
-- spec/plugin/match_hook_spec.rb
-- spec/plugin/middleware_spec.rb
-- spec/plugin/middleware_stack_spec.rb
-- spec/plugin/module_include_spec.rb
-- spec/plugin/multi_route_spec.rb
-- spec/plugin/multi_run_spec.rb
-- spec/plugin/multi_view_spec.rb
-- spec/plugin/multibyte_string_matcher_spec.rb
-- spec/plugin/named_templates_spec.rb
-- spec/plugin/not_allowed_spec.rb
-- spec/plugin/not_found_spec.rb
-- spec/plugin/optimized_string_matchers_spec.rb
-- spec/plugin/padrino_render_spec.rb
-- spec/plugin/param_matchers_spec.rb
-- spec/plugin/params_capturing_spec.rb
-- spec/plugin/partials_spec.rb
-- spec/plugin/pass_spec.rb
-- spec/plugin/path_matchers_spec.rb
-- spec/plugin/path_rewriter_spec.rb
-- spec/plugin/path_spec.rb
-- spec/plugin/placeholder_string_matchers_spec.rb
-- spec/plugin/precompile_templates_spec.rb
-- spec/plugin/public_spec.rb
-- spec/plugin/render_each_spec.rb
-- spec/plugin/render_locals_spec.rb
-- spec/plugin/render_spec.rb
-- spec/plugin/request_aref_spec.rb
-- spec/plugin/request_headers_spec.rb
-- spec/plugin/response_request_spec.rb
-- spec/plugin/route_block_args_spec.rb
-- spec/plugin/route_csrf_spec.rb
-- spec/plugin/run_append_slash_spec.rb
-- spec/plugin/run_handler_spec.rb
-- spec/plugin/sessions_spec.rb
-- spec/plugin/shared_vars_spec.rb
-- spec/plugin/sinatra_helpers_spec.rb
-- spec/plugin/slash_path_empty_spec.rb
-- spec/plugin/static_routing_spec.rb
-- spec/plugin/static_spec.rb
-- spec/plugin/status_303_spec.rb
-- spec/plugin/status_handler_spec.rb
-- spec/plugin/streaming_spec.rb
-- spec/plugin/strip_path_prefix_spec.rb
-- spec/plugin/symbol_matchers_spec.rb
-- spec/plugin/symbol_status_spec.rb
-- spec/plugin/symbol_views_spec.rb
-- spec/plugin/timestamp_public_spec.rb
-- spec/plugin/type_routing_spec.rb
-- spec/plugin/typecast_params_spec.rb
-- spec/plugin/unescape_path_spec.rb
-- spec/plugin/view_options_spec.rb
-- spec/plugin_spec.rb
-- spec/redirect_spec.rb
-- spec/request_spec.rb
-- spec/response_spec.rb
-- spec/route_spec.rb
-- spec/session_middleware_spec.rb
-- spec/session_spec.rb
-- spec/spec_helper.rb
-- spec/version_spec.rb
-- spec/views/_test.erb
-- spec/views/a.erb
-- spec/views/a.rdoc
-- spec/views/about.erb
-- spec/views/about.str
-- spec/views/about/_test.css.gz
-- spec/views/about/_test.erb
-- spec/views/about/_test.erb.gz
-- spec/views/about/comp_test.erb
-- spec/views/b.erb
-- spec/views/c.erb
-- spec/views/comp_layout.erb
-- spec/views/comp_test.erb
-- spec/views/content-yield.erb
-- spec/views/each.str
-- spec/views/home.erb
-- spec/views/home.str
-- spec/views/iv.erb
-- spec/views/layout-alternative.erb
-- spec/views/layout-yield.erb
-- spec/views/layout.erb
-- spec/views/layout.str
-- spec/views/multiple-layout.erb
-- spec/views/multiple.erb
 homepage: http://roda.jeremyevans.net
 licenses:
 - MIT

data/Rakefile

@@ -1,108 +0,0 @@
-require "rake"
-require "rake/clean"
-require "rdoc/task"
-
-NAME = 'roda'
-VERS = lambda do
-  require_relative 'lib/roda/version'
-  Roda::RodaVersion
-end
-CLEAN.include ["#{NAME}-*.gem", "rdoc", "coverage", "www/public/*.html", "www/public/rdoc", "spec/assets/app.*.css", "spec/assets/app.*.js", "spec/assets/app.*.css.gz", "spec/assets/app.*.js.gz", "spec/iv.erb"]
-
-# Gem Packaging and Release
-
-desc "Packages #{NAME}"
-task :package=>[:clean] do |p|
-  sh %{gem build #{NAME}.gemspec}
-end
-
-### RDoc
-
-RDOC_OPTS = ["--line-numbers", "--inline-source", '--title', 'Roda: Routing tree web toolkit']
-
-begin
-  gem 'hanna-nouveau'
-  RDOC_OPTS.concat(['-f', 'hanna'])
-rescue Gem::LoadError
-end
-
-RDOC_OPTS.concat(['--main', 'README.rdoc'])
-RDOC_FILES = %w"README.rdoc CHANGELOG MIT-LICENSE lib/**/*.rb" + Dir["doc/*.rdoc"] + Dir['doc/release_notes/*.txt']
-
-RDoc::Task.new do |rdoc|
-  rdoc.rdoc_dir = "rdoc"
-  rdoc.options += RDOC_OPTS
-  rdoc.rdoc_files.add RDOC_FILES
-end
-
-RDoc::Task.new(:website_rdoc) do |rdoc|
-  rdoc.rdoc_dir = "www/public/rdoc"
-  rdoc.options += RDOC_OPTS
-  rdoc.rdoc_files.add RDOC_FILES
-end
-
-### Website
-
-desc "Make local version of website"
-task :website_base do
-  sh %{#{FileUtils::RUBY} -I lib www/make_www.rb}
-end
-
-desc "Make local version of website, with rdoc"
-task :website => [:website_base, :website_rdoc]
-
-desc "Serve local version of website via rackup"
-task :serve => :website do
-  sh %{#{FileUtils::RUBY} -C www -S rackup}
-end
-
-
-### Specs
-
-spec = proc do |env|
-  env.each{|k,v| ENV[k] = v}
-  sh "#{FileUtils::RUBY} spec/all.rb"
-  env.each{|k,v| ENV.delete(k)}
-end
-
-desc "Run specs"
-task "spec" do
-  spec.call({})
-end
-
-task :default=>:spec
-
-desc "Run specs with coverage"
-task "spec_cov" do
-  spec.call('COVERAGE'=>'1')
-end
-  
-desc "Run specs with branch coverage"
-task "spec_branch_cov" do
-  spec.call('COVERAGE'=>'1', 'BRANCH_COVERAGE'=>'1')
-end
-  
-desc "Run specs with -w, some warnings filtered"
-task "spec_w" do
-  rubyopt = ENV['RUBYOPT']
-  ENV['RUBYOPT'] = "#{rubyopt} -w"
-  spec.call('WARNING'=>'1')
-  ENV['RUBYOPT'] = rubyopt
-end
-
-### Other
-
-desc "Print #{NAME} version"
-task :version do
-  puts VERS.call
-end
-
-desc "Start an IRB shell using the extension"
-task :irb do
-  require 'rbconfig'
-  ruby = ENV['RUBY'] || File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
-  irb = ENV['IRB'] || File.join(RbConfig::CONFIG['bindir'], File.basename(ruby).sub('ruby', 'irb'))
-  sh %{#{irb} -I lib -r #{NAME}}
-end
-
-