rocksky 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e27b27d24d5d5c59963b65031fb641ecb90cb322a9107f3a62a431e6d1973a0c
-  data.tar.gz: 4a314bfa67627103279e453ab7f3563f3c0265c02ca0c1db1ca88259ca26cb33
+  metadata.gz: 84425f844d397e7187168e44115168f310f5a48269da6b1f3efc424cbf9991aa
+  data.tar.gz: 89e6d0d11fd1f88ec4e80498251f1d1d24cc4e77587860b7c96b0508306a3817
 SHA512:
-  metadata.gz: 498b7790bd6961f4a5e118ab4485bf124afb9283fb838a38f6c21195fa50ba47e22bc10ae98518e6804401e3b8de63e5580cb8957a3690f0dcf39a4e72d18de9
-  data.tar.gz: 3f1bb359b30802470a0c7d59ea921850ee43060bba3c67ba8f672eebb1d01c3d6814135462b47c029104bbfb3f5bb32de2b592ffab590c6521f703c3b37995f9
+  metadata.gz: b48c2675d3ecedc52f6b2c7b70a728d927dd69a2564bfe16bc8b55101dfbf866e44b67957b1ad866c57819b0b66360aa637745a73c87238b0c769aa5b5b5e49a
+  data.tar.gz: bbc58f41ea90eda2c8878cde5e6c182a364a5d8de5f4056ab5e6baad5178c67756cf2f02da5343a2b1a679d83839c02b0c1787de64ec6119a42c979abc9a9e2a

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.9.1
+
+- Fix a segfault when tearing down a `RemotePlayer` / `RemoteController`.
+  `#close` freed the native handle while the `#listen` background thread was
+  still blocked inside `#next_command` / `#next_event` (a use-after-free). It now
+  stops the background task and **joins** the listen thread — so the poll has
+  returned — before freeing. `#next_command` / `#next_event` also no-op once the
+  handle is released.
+
 ## 0.3.0
 
 - `feed.get_stories` now accepts optional `feed:` (at-uri) and `following:`

data/lib/rocksky/remote.rb

@@ -57,6 +57,8 @@ module Rocksky
     # Block until the next controller command, returned as a symbol-keyed Hash
     # (e.g. +{ action: "play" }+), or +nil+ once disconnected.
     def next_command
+      return nil if @ptr.null?
+
       cmd = Rocksky.unwrap(C.rocksky_remote_player_next_command(@ptr))
       cmd && Rocksky.symbolize(cmd)
     end
@@ -103,7 +105,12 @@ module Rocksky
     def close
       return if @ptr.null?
 
-      @thread&.kill
+      # Stop the background task so a blocked #next_command returns nil and the
+      # #listen loop exits, then WAIT for that thread to leave the native call
+      # before freeing — freeing the handle while a poll is in flight is a
+      # use-after-free (segfault).
+      C.rocksky_remote_player_disconnect(@ptr)
+      @thread&.join unless @thread == Thread.current
       @thread = nil
       C.rocksky_remote_player_free(@ptr)
       @ptr = Fiddle::Pointer.new(0)
@@ -166,6 +173,8 @@ module Rocksky
     # Block until the next update, returned as a symbol-keyed Hash (each carries a
     # +:type+), or +nil+ once disconnected.
     def next_event
+      return nil if @ptr.null?
+
       ev = Rocksky.unwrap(C.rocksky_remote_controller_next_event(@ptr))
       ev && Rocksky.symbolize(ev)
     end
@@ -244,7 +253,12 @@ module Rocksky
     def close
       return if @ptr.null?
 
-      @thread&.kill
+      # Stop the background task so a blocked #next_event returns nil and the
+      # #listen loop exits, then WAIT for that thread to leave the native call
+      # before freeing — freeing the handle while a poll is in flight is a
+      # use-after-free (segfault).
+      C.rocksky_remote_controller_disconnect(@ptr)
+      @thread&.join unless @thread == Thread.current
       @thread = nil
       C.rocksky_remote_controller_free(@ptr)
       @ptr = Fiddle::Pointer.new(0)

data/lib/rocksky/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rocksky
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rocksky
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Rocksky