rocketjob_mission_control 4.3.0 → 6.0.0.beta

data/test/controllers/rocket_job_mission_control/jobs_controller_test.rb

@@ -1,9 +1,8 @@
-require_relative '../../test_helper'
-require_relative '../../compare_hashes'
+require_relative "../../test_helper"
+require_relative "../../compare_hashes"
 
 module RocketJobMissionControl
   class JobsControllerTest < ActionController::TestCase
-
     class PausableJob < RocketJob::Job
       self.pausable = true
 
@@ -27,11 +26,12 @@ module RocketJobMissionControl
       end
 
       let :failed_job do
-        job = KaboomBatchJob.new(slice_size: 1)
+        job = KaboomBatchJob.new
+        job.input_category.slice_size = 1
         job.upload do |stream|
-          stream << 'first record'
-          stream << 'second record'
-          stream << 'third record'
+          stream << "first record"
+          stream << "second record"
+          stream << "third record"
         end
         job.save!
 
@@ -49,29 +49,27 @@ module RocketJobMissionControl
 
       let :one_job_for_every_state do
         job_states.collect do |state|
-          RocketJob::Jobs::SimpleJob.create!(state: state, worker_name: 'worker', started_at: (Time.now - 0.5))
+          RocketJob::Jobs::SimpleJob.create!(state: state, worker_name: "worker", started_at: (Time.now - 0.5))
         end
       end
 
-      [:pause, :resume, :abort, :retry, :fail].each do |state|
+      %i[pause resume abort retry fail].each do |state|
         describe "PATCH ##{state}" do
-          describe 'with an invalid job id' do
+          describe "with an invalid job id" do
             before do
-              params = {id: 42, job: {id: 42, priority: 12}}
-              params = {params: params} if Rails.version.to_i >= 5
-              patch state, params
+              patch state, params: {id: 42, job: {id: 42, priority: 12}}
             end
 
-            it 'redirects' do
+            it "redirects" do
               assert_redirected_to jobs_path
             end
 
-            it 'adds a flash alert message' do
-              assert_equal I18n.t(:failure, scope: [:job, :find], id: 42), flash[:alert]
+            it "adds a flash alert message" do
+              assert_equal I18n.t(:failure, scope: %i[job find], id: 42), flash[:alert]
             end
           end
 
-          describe 'with a valid job id' do
+          describe "with a valid job id" do
             before do
               case state
               when :pause, :fail, :abort
@@ -82,69 +80,62 @@ module RocketJobMissionControl
                 pausable_job.fail!
               end
               params = {id: pausable_job.id, job: {id: pausable_job.id, priority: pausable_job.priority}}
-              params = {params: params} if Rails.version.to_i >= 5
-              patch state, params
+              patch state, params: params
             end
 
-            it 'redirects to the job' do
+            it "redirects to the job" do
               assert_redirected_to job_path(pausable_job.id)
             end
 
-            it 'transitions the job' do
+            it "transitions the job" do
               refute_equal state, pausable_job.state
             end
           end
         end
       end
 
-      describe 'PATCH #run_now' do
+      describe "PATCH #run_now" do
         let(:scheduled_job) { RocketJob::Jobs::SimpleJob.create!(run_at: 2.days.from_now) }
 
         before do
-          params = {id: scheduled_job.id}
-          params = {params: params} if Rails.version.to_i >= 5
-          patch :run_now, params
+          patch :run_now, params: {id: scheduled_job.id}
         end
 
-        it 'redirects to the job path' do
+        it "redirects to the job path" do
           assert_redirected_to job_path(scheduled_job.id)
         end
 
-        it 'updates run_at' do
+        it "updates run_at" do
           assert_nil scheduled_job.reload.run_at
         end
       end
 
-
       describe "PATCH #update" do
-        describe 'with an invalid job id' do
+        describe "with an invalid job id" do
           before do
-            params = {id: 42, job: {id: 42, priority: 12}}
-            params = {params: params} if Rails.version.to_i >= 5
-            patch :update, params
+            patch :update, params: {id: 42, job: {id: 42, priority: 12}}
           end
 
-          it 'redirects' do
+          it "redirects" do
             assert_redirected_to jobs_path
           end
 
-          it 'adds a flash alert message' do
-            assert_equal I18n.t(:failure, scope: [:job, :find], id: 42), flash[:alert]
+          it "adds a flash alert message" do
+            assert_equal I18n.t(:failure, scope: %i[job find], id: 42), flash[:alert]
           end
         end
 
         describe "with a valid job id" do
           before do
-            params = {id: job.id, job: {id: job.id, priority: 12, blah: 23, description: '', log_level: '', state: 'failed'}}
-            params = {params: params} if Rails.version.to_i >= 5
-            patch :update, params
+            params = {id: job.id, job: {id: job.id, priority: 12, blah: 23, description: "", log_level: "", state: "failed"}}
+            patch :update, params: params
           end
 
-          it 'redirects to the job' do
+          it "redirects to the job" do
             assert_redirected_to job_path(job.id)
           end
 
-          it 'updates the job correctly' do
+          it "updates the job correctly" do
             assert_equal 12, job.reload.priority
           end
 
@@ -157,97 +148,87 @@ module RocketJobMissionControl
         end
       end
 
-      describe 'GET #show' do
-        describe 'with an invalid job id' do
+      describe "GET #show" do
+        describe "with an invalid job id" do
           before do
-            params = {id: 42}
-            params = {params: params} if Rails.version.to_i >= 5
-            get :show, params
+            get :show, params: {id: 42}
           end
 
-          it 'redirects' do
+          it "redirects" do
             assert_redirected_to jobs_path
           end
 
-          it 'adds a flash alert message' do
-            assert_equal I18n.t(:failure, scope: [:job, :find], id: 42), flash[:alert]
+          it "adds a flash alert message" do
+            assert_equal I18n.t(:failure, scope: %i[job find], id: 42), flash[:alert]
           end
         end
 
         describe "with a valid job id" do
           before do
-            params = {id: job.id}
-            params = {params: params} if Rails.version.to_i >= 5
-            get :show, params
+            get :show, params: {id: job.id}
           end
 
-          it 'succeeds' do
+          it "succeeds" do
             assert_response :success
           end
 
-          it 'assigns the job' do
+          it "assigns the job" do
             assert_equal job.id, assigns(:job).id
           end
         end
       end
 
-      describe 'GET #exception' do
-        describe 'with an invalid job id' do
+      describe "GET #exception" do
+        describe "with an invalid job id" do
           before do
-            params = {id: 42}
-            params = {params: params} if Rails.version.to_i >= 5
-            get :exception, params
+            get :exception, params: {id: 42}
           end
 
-          it 'redirects' do
+          it "redirects" do
             assert_redirected_to jobs_path
           end
 
-          it 'adds a flash alert message' do
-            assert_equal I18n.t(:failure, scope: [:job, :find], id: 42), flash[:alert]
+          it "adds a flash alert message" do
+            assert_equal I18n.t(:failure, scope: %i[job find], id: 42), flash[:alert]
           end
         end
 
-        describe 'with a valid job id' do
-          describe 'without an exception' do
+        describe "with a valid job id" do
+          describe "without an exception" do
             before do
-              params = {id: failed_job.id, error_type: 'Blah'}
-              params = {params: params} if Rails.version.to_i >= 5
-              get :exception, params
+              get :exception, params: {id: failed_job.id, error_type: "Blah"}
             end
 
-            it 'redirects to job path' do
+            it "redirects to job path" do
               assert_redirected_to job_path(failed_job.id)
             end
 
-            it 'notifies the user' do
-              assert_equal I18n.t(:no_errors, scope: [:job, :failures]), flash[:notice]
+            it "notifies the user" do
+              assert_equal I18n.t(:no_errors, scope: %i[job failures]), flash[:notice]
             end
           end
 
-          describe 'with exception' do
+          describe "with exception" do
             before do
-              params = {id: failed_job.id, error_type: 'ArgumentError'}
-              params = {params: params} if Rails.version.to_i >= 5
-              get :exception, params
+              get :exception, params: {id: failed_job.id, error_type: "ArgumentError"}
             end
 
-            it 'succeeds' do
+            it "succeeds" do
               assert_response :success
             end
 
-            it 'assigns the job' do
+            it "assigns the job" do
               assert_equal failed_job.id, assigns(:job).id
             end
 
-            it 'paginates' do
+            it "paginates" do
               assert_equal 0, assigns(:pagination)[:offset], assigns(:pagination)
               assert_equal 1, assigns(:pagination)[:total], assigns(:pagination)
             end
 
-            it 'returns the first exception' do
-              assert_equal 'ArgumentError', assigns(:failure_exception).class_name
-              assert_equal 'Blowing up on record: 1', assigns(:failure_exception).message
+            it "returns the first exception" do
+              assert_equal "ArgumentError", assigns(:failure_exception).class_name
+              assert_equal "Blowing up on record: 1", assigns(:failure_exception).message
               assert assigns(:failure_exception).backtrace.present?
             end
           end
@@ -256,17 +237,17 @@ module RocketJobMissionControl
 
       ([:index] + job_states).each do |state|
         describe "GET ##{state}" do
-          describe 'html' do
+          describe "html" do
             describe "with no #{state} servers" do
               before do
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
@@ -277,23 +258,23 @@ module RocketJobMissionControl
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
           end
 
-          describe 'json' do
+          describe "json" do
             describe "with no #{state} server" do
               before do
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json     = JSON.parse(response.body)
                 expected = {
@@ -313,81 +294,79 @@ module RocketJobMissionControl
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json          = JSON.parse(response.body)
                 expected_data = {
                   aborted:   {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
+                    "1"           => "",
                     "2"           => /UTC/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.aborted.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.aborted.first.id}},
                     "DT_RowClass" => "card callout callout-aborted"
                   },
                   failed:    {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
+                    "1"           => "",
                     "2"           => /UTC/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.failed.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.failed.first.id}},
                     "DT_RowClass" => "card callout callout-failed"
                   },
                   paused:    {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
+                    "1"           => "",
                     "2"           => /UTC/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.paused.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.paused.first.id}},
                     "DT_RowClass" => "card callout callout-paused"
                   },
                   completed: {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
+                    "1"           => "",
                     "2"           => /UTC/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.completed.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.completed.first.id}},
                     "DT_RowClass" => "card callout callout-completed"
                   },
                   running:   {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
+                    "1"           => "",
                     "2"           => /UTC/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.running.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.running.first.id}},
                     "DT_RowClass" => "card callout callout-running"
                   },
                   queued:    {
                     "0"           => /#{RocketJob::Jobs::SimpleJob.name}/,
-                    "1"           => '',
-                    "2"           => /UTC/,
+                    "1"           => "",
+                    "2"           => /0/,
                     "3"           => /ms/,
-                    "4"           => /\/jobs\/#{RocketJob::Jobs::SimpleJob.queued.first.id}/,
+                    "4"           => %r{/jobs/#{RocketJob::Jobs::SimpleJob.queued.first.id}},
                     "DT_RowClass" => "card callout callout-queued"
-                  },
+                  }
                 }
 
                 if state == :index
-                  assert_equal 0, json['draw']
-                  assert_equal 6, json['recordsTotal']
-                  assert_equal 6, json['recordsFiltered']
-                  compare_array_of_hashes expected_data.values, json['data']
+                  assert_equal 0, json["draw"]
+                  assert_equal 6, json["recordsTotal"]
+                  assert_equal 6, json["recordsFiltered"]
+                  compare_array_of_hashes(expected_data.values, json["data"])
                 else
-                  assert_equal 0, json['draw']
-                  assert_equal 1, json['recordsTotal']
-                  assert_equal 1, json['recordsFiltered']
+                  assert_equal 0, json["draw"]
+                  assert_equal 1, json["recordsTotal"]
+                  assert_equal 1, json["recordsFiltered"]
                   # Columns change by state
-                  #compare_hash expected_data[state], json['data'].first
+                  # compare_hash expected_data[state], json['data'].first
                 end
               end
             end
-
           end
-
         end
       end
 
-      describe 'role base authentication control' do
+      describe "role base authentication control" do
         %i[index aborted completed failed paused queued running scheduled].each do |method|
           it "#{method} has read access as default" do
             get method, format: :json
@@ -396,7 +375,7 @@ module RocketJobMissionControl
         end
 
         %i[update abort retry pause resume run_now fail].each do |method|
-          describe "#{method}" do
+          describe method.to_s do
             before do
               case method
               when :pause, :fail, :abort
@@ -408,13 +387,12 @@ module RocketJobMissionControl
               end
 
               @params = {id: pausable_job.id, job: {id: pausable_job.id, priority: pausable_job.priority}}
-              @params = {params: @params} if Rails.version.to_i >= 5
             end
 
             %i[admin editor operator manager].each do |role|
               it "redirects with #{method} method and role #{role}" do
                 set_role(role)
-                patch method, @params
+                patch method, params: @params
                 assert_response(:redirect)
               end
             end
@@ -423,7 +401,7 @@ module RocketJobMissionControl
               it "raises authentication error for #{role}" do
                 set_role(role)
                 assert_raises AccessGranted::AccessDenied do
-                  patch method, @params
+                  patch method, params: @params
                 end
               end
             end
@@ -431,12 +409,11 @@ module RocketJobMissionControl
         end
       end
 
-      [:view_slice, :edit_slice].each do |method|
+      %i[view_slice edit_slice].each do |method|
         describe "with a failed slice" do
           it "access ##{method}" do
             params = {:error_type => "ArgumentError", "record_number" => "9", "id" => failed_job.id}
-            params = {params: params} if Rails.version.to_i >= 5
-            get method, params
+            get method, params: params
             assert_response :success
           end
         end
@@ -444,25 +421,24 @@ module RocketJobMissionControl
 
       describe "#update slice" do
         before do
-          params = { "job" => { "records" => [ "1", "2", "3"] }, "error_type" => "CSV::MalformedCSVError", "offset" => "1", "id" => failed_job.id.to_s }
-          params = {params: params} if Rails.version.to_i >= 5
-          post :update_slice, params
+          params = {"job" => {"records" => %w[1 2 3]}, "error_type" => "CSV::MalformedCSVError", "offset" => "1", "id" => failed_job.id.to_s}
+          post :update_slice, params: params
         end
 
-        it 'redirects' do
+        it "redirects" do
           assert_redirected_to view_slice_job_path(failed_job, error_type: "CSV::MalformedCSVError")
         end
 
-        it 'adds a flash success message' do
-          assert_equal 'slice updated', flash[:success]
+        it "adds a flash success message" do
+          assert_equal "slice updated", flash[:success]
         end
       end
     end
 
     def set_role(r)
-      Config.authorization_callback = -> do
+      Config.authorization_callback = lambda {
         {roles: [r]}
-      end
+      }
     end
   end
 end