rocketchat 0.1.19 → 0.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 140d7b5f967bb7df8cd40519f7a8c1bcbd3910b8afd128433430e60a162f14c3
-  data.tar.gz: bb14c666d3e4a0920b506d548f68d70d817f51b4ff83ec23188207488665b2d1
+  metadata.gz: b5f446da6cb7e901ef27edc15d4294fdb1db3a7c6386c35aeec2acbf513a2246
+  data.tar.gz: 19bda5415f803dd4a7cf7bc05ec2ec1fcf925d364e55068f0d7630d28e5da190
 SHA512:
-  metadata.gz: 67dd8d2cd758c87a762cf428f4c72211163c185d29ed03c6368ebdce6e648964a46bb69024571c003799a6abfb0fbef8c073dde2e847e81a6b092d462c0cc971
-  data.tar.gz: 7279c2d80e049e8b580c6128ff44f9542a0f63f58c73c6ad3e13aa988e73f4450b20324b4d919fa08081152c66b54624432863fea0286664a7958d162d9a8505
+  metadata.gz: d9c94588357cbeb32f18afe79b3439bded7fc8191b31627a440288642842d971119591cdf47e981836c7ea8b3d4ff76ed36040701b6c0fb24d33e9e7a349ef1a
+  data.tar.gz: b14f92c34a2b9a6f17d4da573b793268b3c8f83590326b5faca1e1d6b0b4ebba5bbdea73c1ea5bcc406aa5a729988ac6eb230359f1fbbb8de23b2694b60bc652

data/.rubocop.yml

@@ -1,24 +1,73 @@
-require: rubocop-rspec
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 2.5
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/LineLength:
+  Max: 120
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
 
 Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
     - "spec/shared/*.rb"
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/MethodLength:
   Max: 15
   Exclude:
     - "**/*_spec.rb"
 
-Style/NumericLiterals:
-  Exclude:
-    - "**/*_spec.rb"
-
 RSpec/ExampleLength:
   Max: 10
 
 RSpec/MultipleExpectations:
   Max: 5
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 15
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/NumericLiterals:
+  Exclude:
+    - "**/*_spec.rb"
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true

data/.travis.yml

@@ -5,11 +5,10 @@ env:
 language: ruby
 
 rvm:
-  - 2.2
-  - 2.3
-  - 2.4
   - 2.5
   - 2.6
+  - 2.7
+  - 3.0
 
 before_install:
   - gem update bundler
@@ -24,7 +23,7 @@ before_script:
   - ./cc-test-reporter before-build
 
 script:
-  - rubocop
+  - bundle exec rubocop
   - bundle exec rake
 
 after_script:

data/CHANGELOG.md

@@ -3,9 +3,16 @@
 ## Unreleased
 - None
 
+## [0.1.20](releases/tag/v0.1.20) - 2021-03-29
+### Added
+- [#34] Support for channels.members and groups.members ([@alinavancea][])
+
+### Deprecation
+- [#35] Drop Ruby 2.3 and 2.4 support ([@abrom][])
+
 ## [0.1.19](releases/tag/v0.1.19) - 2019-03-01
 ### Fixed
-- Address CVE-2020-8130 - `rake` OS command injection vulnerability
+- Address CVE-2020-8130 - `rake` OS command injection vulnerability ([@abrom][])
 
 ## [0.1.18](releases/tag/v0.1.18) - 2018-01-05
 ### Added
@@ -13,19 +20,19 @@
 
 ## [0.1.17](releases/tag/v0.1.17) - 2019-01-05
 ### Deprecation
-- Drop Ruby 2.1 from build matrix
+- Drop Ruby 2.1 from build matrix ([@abrom][])
 
 ## [0.1.16](releases/tag/v0.1.16) - 2018-10-3
 ### Deprecation
-- Drop Ruby 2.0 from build matrix
+- Drop Ruby 2.0 from build matrix ([@abrom][])
 
 ### Added
 - [#27] Support for channels.online ([@chrisstime][])
-- `rubocop-rspec` dependency and fixed new lints
+- [#28] `rubocop-rspec` dependency and fixed new lints ([@abrom][])
 
 ## [0.1.15](releases/tag/v0.1.15) - 2017-12-21
 ### Fixed
-- Updated yard to resolve potential security vulnerability
+- Updated yard to resolve potential security vulnerability ([@abrom][])
 
 ## [0.1.14](releases/tag/v0.1.14) - 2017-10-9
 ### Added
@@ -33,16 +40,16 @@
 
 ## [0.1.13](releases/tag/v0.1.13) - 2017-10-9
 ### Added
-- Support for channel/group addAll endpoint
+- Support for channel/group addAll endpoint ([@abrom][])
 
 ## [0.1.12](releases/tag/v0.1.12) - 2017-08-28
 ### Fixed
-- GET request parameter encoding
+- GET request parameter encoding ([@abrom][])
 
 ## [0.1.11](releases/tag/v0.1.11) - 2017-08-22
 ### Fixed
 - [#15] Response parser improvements ([@reist][],[@danischreiber][])
-- [#17] Fixed a missing dependency issue with `net/http`
+- [#17] Fixed a missing dependency issue with `net/http` ([@abrom][])
 
 ### Added
 - [#14] Add/remove moderator from room ([@danischreiber][])
@@ -53,11 +60,11 @@
 
 ## [0.1.9](releases/tag/v0.1.9) - 2017-07-16
 ### Fixed
-- Update chat message handlers to support Ruby 2.0
+- Update chat message handlers to support Ruby 2.0 ([@abrom][])
 
 ## [0.1.8](releases/tag/v0.1.8) - 2017-07-16
 ### Added
-- Messages chat API support
+- Messages chat API support ([@abrom][])
 
 ## [0.1.7](releases/tag/v0.1.7) - 2017-07-16
 ### Added
@@ -74,7 +81,7 @@
 
 ## [0.1.4](releases/tag/v0.1.4) - 2017-07-9
 ### Fixed
-- Fixed a missing dependency issue with `uri`
+- Fixed a missing dependency issue with `uri` ([@abrom][])
 
 ## [0.1.2](releases/tag/v0.1.2) - 2017-05-24
 ### Added
@@ -82,15 +89,15 @@
 
 ## [0.1.1](releases/tag/v0.1.1) - 2017-05-1
 ### Added
-- Support for settings get/set endpoints
+- Support for settings get/set endpoints ([@abrom][])
 
 ## [0.0.8](releases/tag/v0.0.8) - 2017-04-30
 ### Added
-- Support for Users `getPresence` endpoint
+- Support for Users `getPresence` endpoint ([@abrom][])
 
 ## [0.0.7](releases/tag/v0.0.7) - 2017-04-30
 ### Added
-- Support for Users `list` endpoint
+- Support for Users `list` endpoint ([@abrom][])
 
 ## [0.0.6](releases/tag/v0.0.6) - 2017-04-25
 ### Fixed
@@ -99,3 +106,12 @@
 ## [0.0.5](releases/tag/v0.0.5) - 2017-04-25
 ### Added
 - [#1] Added Users `info` and `delete` endpoints ([@reist][])
+
+[@abrom]: https://github.com/abrom
+[@reist]: https://github.com/reist
+[@danischreiber]: https://github.com/danischreiber
+[@hardik127]: https://github.com/hardik127
+[@chrisstime]: https://github.com/chrisstime
+[@christianmoretti]: https://github.com/christianmoretti
+[@alinavancea]: https://github.com/alinavancea
+              

data/README.md

@@ -68,6 +68,7 @@ This gem supports the following Rocket.Chat APIs (Tested against Rocket.Chat v0.
 * [/api/v1/channels.setTopic](docs/channels.md#channelsset_attr)
 * [/api/v1/channels.setType](docs/channels.md#channelsset_attr)
 * [/api/v1/channels.online](docs/channels.md#channelsonline)
+* [/api/v1/channels.members](docs/channels.md#channelsmembers)
 * /api/v1/channels.unarchive
 
 #### Groups
@@ -89,6 +90,7 @@ This gem supports the following Rocket.Chat APIs (Tested against Rocket.Chat v0.
 * /api/v1/groups.setReadOnly
 * /api/v1/groups.setTopic
 * /api/v1/groups.setType
+* [/api/v1/groups.members](docs/groups.md#groupsmembers)
 * /api/v1/groups.unarchive
 
 #### Users

data/lib/rocket_chat/error.rb

@@ -2,8 +2,12 @@
 
 module RocketChat
   class Error < StandardError; end
+
   class HTTPError < Error; end
+
   class InvalidMethodError < HTTPError; end
+
   class JsonParseError < Error; end
+
   class StatusError < Error; end
 end

data/lib/rocket_chat/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RocketChat
-  VERSION = '0.1.19'
+  VERSION = '0.1.20'
 end

data/lib/rocket_chat/im_summary.rb

@@ -19,7 +19,7 @@ module RocketChat
       data['joined']
     end
 
-    # Qty of menbers in the chat
+    # Qty of members in the chat
     def members
       data['members']
     end

data/lib/rocket_chat/messages/room.rb

@@ -11,9 +11,11 @@ module RocketChat
 
       def self.inherited(subclass)
         field = subclass.name.split('::')[-1].downcase
-        collection = field + 's'
+        collection = "#{field}s"
         subclass.send(:define_singleton_method, :field) { field }
         subclass.send(:define_singleton_method, :collection) { collection }
+
+        super
       end
 
       #
@@ -283,6 +285,25 @@ module RocketChat
         )['success']
       end
 
+      #
+      # *.members* REST API
+      # @param [String] room_id Rocket.Chat room id
+      # @param [String] name Rocket.Chat room name
+      # @param [Integer] offset Query offset
+      # @param [Integer] count Query count/limit
+      # @param [Hash] sort Query field sort hash. eg `{ msgs: 1, name: -1 }`
+      # @return [Users[]]
+      # @raise [HTTPError, StatusError]
+      #
+      def members(room_id: nil, name: nil, offset: nil, count: nil, sort: nil)
+        response = session.request_json(
+          self.class.api_path('members'),
+          body: room_params(room_id, name).merge(build_list_body(offset, count, sort, nil, nil))
+        )
+
+        response['members'].map { |hash| RocketChat::User.new hash } if response['success']
+      end
+
       private
 
       attr_reader :session

data/lib/rocket_chat/messages/user.rb

@@ -69,7 +69,7 @@ module RocketChat
           method: :post,
           body: {
             userId: id,
-            data: user_option_hash(options, true)
+            data: user_option_hash(options, include_personal_fields: true)
           }
         )
         RocketChat::User.new response['user']
@@ -179,7 +179,7 @@ module RocketChat
 
       attr_reader :session
 
-      def user_option_hash(options, include_personal_fields = false)
+      def user_option_hash(options, include_personal_fields: false)
         args = [options, :active, :roles, :join_default_channels, :require_password_change,
                 :send_welcome_email, :verified, :custom_fields]
         args += %i[username email name password] if include_personal_fields

data/lib/rocket_chat/request_helper.rb

@@ -111,7 +111,7 @@ module RocketChat
         add_body(req, body) if body
       else
         uri = path
-        uri += '?' + body.map { |k, v| "#{k}=#{v}" }.join('&') if body
+        uri += "?#{body.map { |k, v| "#{k}=#{v}" }.join('&')}" if body
         req = Net::HTTP::Get.new(uri, headers)
       end
 

data/rocketchat.gemspec

@@ -15,6 +15,7 @@ Gem::Specification.new do |spec|
   spec.description   = 'Rocket.Chat REST API v1 for Ruby'
   spec.homepage      = 'https://github.com/abrom/rocketchat-ruby'
   spec.license       = 'MIT'
+  spec.required_ruby_version = ['>= 2.5.0', '< 3.1.0']
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|docs)/}) }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
@@ -23,9 +24,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', ['>= 1.11', '< 3.0']
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.62'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.31'
+  spec.add_development_dependency 'rubocop', '~> 1.12'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.10'
+  spec.add_development_dependency 'rubocop-rake', '~> 0.5'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.2'
   spec.add_development_dependency 'simplecov', '~> 0.16'
-  spec.add_development_dependency 'webmock', '~> 2.3'
+  spec.add_development_dependency 'webmock', '~> 3.12'
   spec.add_development_dependency 'yard', '~> 0.9.11'
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rocketchat
 version: !ruby/object:Gem::Version
-  version: 0.1.19
+  version: 0.1.20
 platform: ruby
 authors:
 - int512
 - abrom
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-01 00:00:00.000000000 Z
+date: 2021-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -65,28 +65,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.62'
+        version: '1.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.62'
+        version: '1.12'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.31'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -107,14 +135,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.12'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -176,7 +204,7 @@ homepage: https://github.com/abrom/rocketchat-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -184,15 +212,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: Rocket.Chat REST API v1 for Ruby
 test_files: []