rock_rms 4.5.0 → 4.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59e90862a4b1de48956ca5013d237994dee60ac3
-  data.tar.gz: ee44b3c8fdcfe8a733d684f10cfe12cd797c9087
+  metadata.gz: 1a3054295b2deca69b1eb80316e76a7167a8c5cb
+  data.tar.gz: ebb9413e249d73551942e07377f64c329b44c028
 SHA512:
-  metadata.gz: 4774e516bd2ecb8c093393aa0effd7a4b2c621df478f27096f1705c1c0d1f00b7b852d948bcd2d44d8a269c527647484782ac7f3c92a05845d8eb0c1ce47e8ea
-  data.tar.gz: 5741aff3e3087ff2fa0463ecf4dfb90a3616ee1c92e3a59ecbc77ff74b43973528ac14128509dc65ae469e04052c2bfece0a68361aa84b9586e3ffbcb8f6a070
+  metadata.gz: 37eb36da20fe40cd761337d53eeaf5464cb6f3e0f93c0b2d51233ca87ead149c4aa3bac9e01f19e672e1c2dca4dd78d0a72f7fccaab3892de62285e95817aa6c
+  data.tar.gz: 64e62fbdc08a874012edbae3c5ad65b177d8da89be1f0de20d21d2e21ecfb4a4c23d3d79f57d90f551a9ef04eca3637262af1c56c6a359d8da0644eec88a0996

data/lib/rock_rms/client.rb

@@ -4,10 +4,12 @@ require 'faraday_middleware/parse_oj'
 
 Dir[File.expand_path('../resources/*.rb', __FILE__)].each { |f| require f }
 require File.expand_path('../response/base.rb', __FILE__)
+require File.expand_path('../recurring_frequencies.rb', __FILE__)
 Dir[File.expand_path('../response/*.rb', __FILE__)].each { |f| require f }
 
 module RockRMS
   class Client
+    include RecurringFrequencies
     include RockRMS::Client::Attribute
     include RockRMS::Client::AttributeValue
     include RockRMS::Client::Batch

data/lib/rock_rms/recurring_frequencies.rb

@@ -0,0 +1,11 @@
+module RecurringFrequencies
+  RECURRING_FREQUENCIES = {
+    'one-time'      => 130,
+    'weekly'        => 132,
+    'bi-weekly'     => 133,
+    'twice-a-month' => 134,
+    'monthly'       => 135,
+    'quarterly'     => 153,
+    'yearly'        => 155
+  }.freeze
+end

data/lib/rock_rms/resources/recurring_donation.rb

@@ -27,7 +27,7 @@ module RockRMS
 
         options = {
           'AuthorizedPersonAliasId'     => authorized_person_id,
-          'TransactionFrequencyValueId' => RECURRING_FREQUENCIES[frequency],
+          'TransactionFrequencyValueId' => RecurringFrequencies::RECURRING_FREQUENCIES[frequency],
           'StartDate'                   => start_date,
           'NextPaymentDate'             => next_payment_date,
           'IsActive'                    => active,
@@ -56,16 +56,6 @@ module RockRMS
 
       private
 
-      RECURRING_FREQUENCIES = {
-        'one-time'      => 130,
-        'weekly'        => 132,
-        'bi-weekly'     => 133,
-        'twice-a-month' => 134,
-        'monthly'       => 135,
-        'quarterly'     => 153,
-        'yearly'        => 155
-      }.freeze
-
       def translate_funds(funds)
         funds.map do |fund|
           {

data/lib/rock_rms/response/recurring_donation.rb

@@ -4,20 +4,28 @@ module RockRMS
       MAP = {
         id: 'Id',
         active: 'IsActive',
+        financial_gateway_id: 'FinancialGatewayId',
         foreign_key: 'ForeignKey',
+        frequency: 'TransactionFrequencyValueId',
         next_payment_date: 'NextPaymentDate',
         payment_details: 'FinancialPaymentDetail',
         person_id: 'AuthorizedPersonAliasId',
+        start_date: 'StartDate',
         transaction_details: 'ScheduledTransactionDetails',
         transaction_code: 'TransactionCode'
       }.freeze
 
       def format_single(data)
         result = to_h(MAP, data)
+        result[:frequency]           = find_frequency_by_id(result[:frequency])
         result[:transaction_details] = RecurringDonationDetails.format(result[:transaction_details])
         result[:payment_details]     = PaymentDetail.format(result[:payment_details])
         result
       end
+
+      def find_frequency_by_id(type_id)
+        RecurringFrequencies::RECURRING_FREQUENCIES.key(type_id)
+      end
     end
   end
 end

data/lib/rock_rms/version.rb

@@ -1,3 +1,3 @@
 module RockRMS
-  VERSION = '4.5.0'.freeze
+  VERSION = '4.6.0'.freeze
 end

data/spec/rock_rms/response/recurring_donation_spec.rb

@@ -12,10 +12,32 @@ RSpec.describe RockRMS::Response::RecurringDonation, type: :model do
       end
     end
 
+    it 'has the following keys' do
+      response = result.first
+      expected_keys = %i[
+        id
+        active
+        financial_gateway_id
+        foreign_key
+        frequency
+        next_payment_date
+        payment_details
+        person_id
+        start_date
+        transaction_details
+        transaction_code
+      ]
+
+      expect(response.keys).to eq(expected_keys)
+    end
+
     it 'translates keys' do
       result.zip(parsed) do |r, p|
         expect(r[:id]).to eq(p['Id'])
+        expect(r[:active]).to eq(p['IsActive'])
+        expect(r[:financial_gateway_id]).to eq(p['FinancialGatewayId'])
         expect(r[:foreign_key]).to eq(p['ForeignKey'])
+        expect(r[:frequency]).to eq('monthly')
         expect(r[:next_payment_date]).to eq(p['NextPaymentDate'])
         expect(r[:person_id]).to eq(p['AuthorizedPersonAliasId'])
         expect(r[:transaction_details]).to eq(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rock_rms
 version: !ruby/object:Gem::Version
-  version: 4.5.0
+  version: 4.6.0
 platform: ruby
 authors:
 - Taylor Brooks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-22 00:00:00.000000000 Z
+date: 2018-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -184,6 +184,7 @@ files:
 - lib/rock_rms.rb
 - lib/rock_rms/client.rb
 - lib/rock_rms/error.rb
+- lib/rock_rms/recurring_frequencies.rb
 - lib/rock_rms/resources/attribute.rb
 - lib/rock_rms/resources/attribute_value.rb
 - lib/rock_rms/resources/batch.rb