rock_rms 3.9.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d90a904297b23290523da3e063a61f5cbb76a8ed
-  data.tar.gz: '03943e2c02fb2ceab23a892798614a154a1c5a84'
+  metadata.gz: a826c9dad155cd2dde1432bcf622307375bc5e16
+  data.tar.gz: e5053d52043a7c4b7bc5e8a8089c4abc8623b2a9
 SHA512:
-  metadata.gz: 686e3dc2fdfc3328eb324f5e028cea1fd6644b159942535b2d23df6ceda43d11b5fd45d9cf533dc1e3e94de253e752670f07b02e06abad3fac2e03fb6c7eb7f7
-  data.tar.gz: c06a373d5b5d7c09582cf7daec6e42ca06743f96dfef13f6c9b6a5401ed4660f361b1efe51b6a21c04f9449ddabd9c4c1f88b09c02ded477db38920ce703f914
+  metadata.gz: abfce0335816d7d9ec0235fd08424781b75287a13c68acbfd86d4d6bd3c3dd365adafbc013eab222dfb3eb25080466249d8df999a0d57a31190a551b46ddeab2
+  data.tar.gz: 11c7835281d1a541223d726125032d1508a40a054a2d25a659204f5396f8f591972c849a0fd33290c597b936b79a850b57a690faff3319e972d7554ab2d2f09d

data/README.md

@@ -14,7 +14,7 @@ I'm a big fan of Rock so if you have problems using the gem or would like to see
 Add this line to your application's Gemfile:
 ````ruby
   # in your Gemfile
-  gem 'rock_rms', '~> 3.7'
+  gem 'rock_rms', '~> 4.0'
 
   # then...
   bundle install

data/lib/rock_rms/client.rb

@@ -14,7 +14,7 @@ module RockRMS
     include RockRMS::Client::Gateway
     include RockRMS::Client::Group
     include RockRMS::Client::GroupMember
-    include RockRMS::Client::PaymentMethod
+    include RockRMS::Client::PaymentDetail
     include RockRMS::Client::Person
     include RockRMS::Client::PhoneNumber
     include RockRMS::Client::RecurringDonation

data/lib/rock_rms/resources/payment_detail.rb

@@ -0,0 +1,56 @@
+module RockRMS
+  class Client
+    module PaymentDetail
+      def list_payment_details(options = {})
+        res = get(payment_detail_path, options)
+        Response::PaymentDetail.format(res)
+      end
+
+      def create_payment_detail(payment_type:, foreign_key: nil, card_type: nil)
+        options = {
+          'CurrencyTypeValueId' => cast_payment_type(payment_type),
+          'CreditCardTypeValueId' => cast_card_type(card_type),
+          'ForeignKey' => foreign_key
+        }
+
+        post(payment_detail_path, options)
+      end
+
+      def delete_payment_detail(id)
+        delete(payment_detail_path(id))
+      end
+
+      private
+
+      def cast_payment_type(payment_type)
+        case payment_type
+        when 'card'
+          156
+        when 'bank account', 'ach'
+          157
+        end
+      end
+
+      def cast_card_type(card_type)
+        case card_type
+        when 'visa'
+          7
+        when 'mastercard'
+          8
+        when 'amex'
+          159
+        when 'discover'
+          160
+        when 'diner'
+          161
+        when 'jcb'
+          162
+        end
+      end
+
+      def payment_detail_path(id = nil)
+        id ? "FinancialPaymentDetails/#{id}" : 'FinancialPaymentDetails'
+      end
+    end
+  end
+end

data/lib/rock_rms/resources/transaction.rb

@@ -23,7 +23,7 @@ module RockRMS
         batch_id:,
         date:,
         funds:,
-        payment_type:,
+        payment_detail_id:,
         source_type_id: 10,
         transaction_code: nil,
         summary: nil,
@@ -36,7 +36,7 @@ module RockRMS
           'ScheduledTransactionId' => recurring_donation_id,
           'BatchId' => batch_id,
           'FinancialGatewayId' => gateway_id,
-          'FinancialPaymentDetailId' => payment_type,
+          'FinancialPaymentDetailId' => payment_detail_id,
           'TransactionCode' => transaction_code,
           'TransactionDateTime' => date,
           'TransactionDetails'  => translate_funds(funds),

data/lib/rock_rms/response/{payment_method.rb → payment_detail.rb}

@@ -1,6 +1,6 @@
 module RockRMS
   module Response
-    class PaymentMethod < Base
+    class PaymentDetail < Base
       MAP = {
         id: 'Id',
         exp_month: 'ExpirationMonth',

data/lib/rock_rms/response/recurring_donation.rb

@@ -15,7 +15,7 @@ module RockRMS
       def format_single(data)
         result = to_h(MAP, data)
         result[:transaction_details] = RecurringDonationDetails.format(result[:transaction_details])
-        result[:payment_details]     = PaymentMethod.format(result[:payment_details])
+        result[:payment_details]     = PaymentDetail.format(result[:payment_details])
         result
       end
     end

data/lib/rock_rms/response/saved_payment_method.rb

@@ -13,7 +13,7 @@ module RockRMS
 
       def format_single(data)
         response = to_h(MAP, data)
-        response[:payment_details] = PaymentMethod.format(response[:payment_details])
+        response[:payment_details] = PaymentDetail.format(response[:payment_details])
         response
       end
     end

data/lib/rock_rms/response/transaction.rb

@@ -21,7 +21,7 @@ module RockRMS
       def format_single(data)
         response                   = to_h(MAP, data)
         response[:details]         = TransactionDetail.format(response[:details])
-        response[:payment_details] = PaymentMethod.format(response[:payment_details])
+        response[:payment_details] = PaymentDetail.format(response[:payment_details])
         response[:person]          = format_person(response[:person])
         response[:amount]          = calculate_total(response[:details])
         response

data/lib/rock_rms/version.rb

@@ -1,3 +1,3 @@
 module RockRMS
-  VERSION = '3.9.0'.freeze
+  VERSION = '4.0.0'.freeze
 end

data/spec/rock_rms/resources/{payment_method_spec.rb → payment_detail_spec.rb}

@@ -1,26 +1,26 @@
 require 'spec_helper'
 
-RSpec.describe RockRMS::Client::PaymentMethod, type: :model do
+RSpec.describe RockRMS::Client::PaymentDetail, type: :model do
   include_context 'resource specs'
 
-  describe '#list_payment_methods' do
+  describe '#list_payment_details' do
     it 'returns a array' do
-      resource = client.list_payment_methods
+      resource = client.list_payment_details
       expect(resource).to be_a(Array)
       expect(resource.first).to be_a(Hash)
     end
   end
 
-  describe '#create_payment_method' do
+  describe '#create_payment_detail' do
     context 'arguments' do
       it 'require `payment_type`' do
-        expect { client.create_payment_method }
+        expect { client.create_payment_detail }
           .to raise_error(ArgumentError, /payment_type/)
       end
     end
 
     subject(:resource) do
-      client.create_payment_method(payment_type: 'card')
+      client.create_payment_detail(payment_type: 'card', card_type: 'amex')
     end
 
     it 'returns integer' do
@@ -32,6 +32,7 @@ RSpec.describe RockRMS::Client::PaymentMethod, type: :model do
         .with(
           'FinancialPaymentDetails',
           'CurrencyTypeValueId' => 156,
+          'CreditCardTypeValueId' => 159,
           'ForeignKey' => nil
         )
         .and_call_original
@@ -39,14 +40,15 @@ RSpec.describe RockRMS::Client::PaymentMethod, type: :model do
     end
   end
 
-  describe '#delete_payment_method' do
+  describe '#delete_payment_detail' do
     it 'returns nothing' do
-      expect(client.delete_payment_method(123)).to eq(nil)
+      expect(client.delete_payment_detail(123)).to eq(nil)
     end
 
     it 'passes id' do
       expect(client).to receive(:delete).with('FinancialPaymentDetails/123')
-      client.delete_payment_method(123)
+      client.delete_payment_detail(123)
     end
   end
+
 end

data/spec/rock_rms/resources/transaction_spec.rb

@@ -63,7 +63,7 @@ RSpec.describe RockRMS::Client::Transaction, type: :model do
         batch_id: 1,
         date: 1,
         funds: [{ amount: 450, fund_id: 2 }],
-        payment_type: 1,
+        payment_detail_id: 1,
         transaction_code: 'asdf',
         summary: 'taco tuesday',
         recurring_donation_id: 1

data/spec/rock_rms/response/{payment_method_spec.rb → payment_detail_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-RSpec.describe RockRMS::Response::PaymentMethod, type: :model do
-  let(:parsed) { JSON.parse(FixturesHelper.read('payment_methods.json')) }
+RSpec.describe RockRMS::Response::PaymentDetail, type: :model do
+  let(:parsed) { JSON.parse(FixturesHelper.read('payment_details.json')) }
 
   describe '.format' do
     subject(:result) { described_class.format(parsed) }

data/spec/support/rock_mock.rb

@@ -29,7 +29,7 @@ class RockMock < Sinatra::Base
     gateways:      'FinancialGateways',
     group:         'Groups/:id',
     groups:        'Groups',
-    payment_methods: 'FinancialPaymentDetails',
+    payment_details: 'FinancialPaymentDetails',
     people_search: 'People/Search',
     person_by_alias: 'People/GetByPersonAliasId/:id',
     phone_numbers: 'PhoneNumbers',
@@ -48,7 +48,7 @@ class RockMock < Sinatra::Base
   {
     create_group_member: 'GroupMembers',
     create_transaction: 'FinancialTransactions',
-    create_payment_method: 'FinancialPaymentDetails',
+    create_payment_detail: 'FinancialPaymentDetails',
     create_batch: 'FinancialBatches',
     create_recurring_donation: 'FinancialScheduledTransactions',
     create_refund: 'FinancialTransactionRefunds',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rock_rms
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Taylor Brooks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-10 00:00:00.000000000 Z
+date: 2018-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -190,7 +190,7 @@ files:
 - lib/rock_rms/resources/gateway.rb
 - lib/rock_rms/resources/group.rb
 - lib/rock_rms/resources/group_member.rb
-- lib/rock_rms/resources/payment_method.rb
+- lib/rock_rms/resources/payment_detail.rb
 - lib/rock_rms/resources/person.rb
 - lib/rock_rms/resources/phone_number.rb
 - lib/rock_rms/resources/recurring_donation.rb
@@ -208,7 +208,7 @@ files:
 - lib/rock_rms/response/group.rb
 - lib/rock_rms/response/group_location.rb
 - lib/rock_rms/response/location.rb
-- lib/rock_rms/response/payment_method.rb
+- lib/rock_rms/response/payment_detail.rb
 - lib/rock_rms/response/person.rb
 - lib/rock_rms/response/phone_number.rb
 - lib/rock_rms/response/recurring_donation.rb
@@ -225,7 +225,7 @@ files:
 - spec/rock_rms/resources/gateway_spec.rb
 - spec/rock_rms/resources/group_member_spec.rb
 - spec/rock_rms/resources/group_spec.rb
-- spec/rock_rms/resources/payment_method_spec.rb
+- spec/rock_rms/resources/payment_detail_spec.rb
 - spec/rock_rms/resources/person_spec.rb
 - spec/rock_rms/resources/phone_number_spec.rb
 - spec/rock_rms/resources/recurring_donation_spec.rb
@@ -239,7 +239,7 @@ files:
 - spec/rock_rms/response/group_location_spec.rb
 - spec/rock_rms/response/group_spec.rb
 - spec/rock_rms/response/location_spec.rb
-- spec/rock_rms/response/payment_method_spec.rb
+- spec/rock_rms/response/payment_detail_spec.rb
 - spec/rock_rms/response/phone_number_spec.rb
 - spec/rock_rms/response/recurring_donation_details_spec.rb
 - spec/rock_rms/response/recurring_donation_spec.rb
@@ -254,7 +254,7 @@ files:
 - spec/support/fixtures/campuses.json
 - spec/support/fixtures/create_batch.json
 - spec/support/fixtures/create_group_member.json
-- spec/support/fixtures/create_payment_method.json
+- spec/support/fixtures/create_payment_detail.json
 - spec/support/fixtures/create_recurring_donation.json
 - spec/support/fixtures/create_refund.json
 - spec/support/fixtures/create_refund_reason.json
@@ -269,7 +269,7 @@ files:
 - spec/support/fixtures/groups_with_locations.json
 - spec/support/fixtures/groups_with_members.json
 - spec/support/fixtures/locations.json
-- spec/support/fixtures/payment_methods.json
+- spec/support/fixtures/payment_details.json
 - spec/support/fixtures/people_search.json
 - spec/support/fixtures/person_by_alias.json
 - spec/support/fixtures/phone_numbers.json

data/lib/rock_rms/resources/payment_method.rb

@@ -1,38 +0,0 @@
-module RockRMS
-  class Client
-    module PaymentMethod
-      def list_payment_methods(options = {})
-        res = get(payment_method_path, options)
-        Response::PaymentMethod.format(res)
-      end
-
-      def create_payment_method(payment_type:, foreign_key: nil)
-        options = {
-          'CurrencyTypeValueId' => cast_payment_type(payment_type),
-          'ForeignKey' => foreign_key
-        }
-
-        post(payment_method_path, options)
-      end
-
-      def delete_payment_method(id)
-        delete(payment_method_path(id))
-      end
-
-      private
-
-      def cast_payment_type(payment_type)
-        case payment_type
-        when 'card'
-          156
-        when 'bank account', 'ach'
-          157
-        end
-      end
-
-      def payment_method_path(id = nil)
-        id ? "FinancialPaymentDetails/#{id}" : 'FinancialPaymentDetails'
-      end
-    end
-  end
-end