rock_rms 1.3.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1b5a8912599ca1d74291a287765abdf6f283efb
-  data.tar.gz: 031df795a7215c4d7c5c2ea350ae9e465b7a9c25
+  metadata.gz: 765aea7d65ac938d72b224db13b53ef9a14a01a4
+  data.tar.gz: e61962b4c4647bd2c0a75a654c6662ab9a3adcd0
 SHA512:
-  metadata.gz: e55025ccb035d05122bb77d4ea7028c35313b48ef607c39d1e119fc72d80b108fe7763fa785613d3aa33b17d47afece8a17a2690f27947437b9784751229250b
-  data.tar.gz: 1c8b77ad4eca61e4284a6eabcac460ef3fcdb795d3db0aa3654de546ecb58838e5545b4da744d1f499fc180c9dbbfd8fdc732756bdca58ae55aa9672c686e98d
+  metadata.gz: 2fbbab71f6c18d1ee19ec069ac1eec9223240bff7a9e38dfcf7256e9d6f4d018af61f1c7be2a15ee07f886eeb950637ae2f210ebfd20136bf7a311882ae61ca4
+  data.tar.gz: ae2d0c9953da765fe8af28c1b672bfb97006c260d97254447e945776f8c1ea77657562280d45463dcaa52b576b1df3fe4fa253d0864bf7c92888ea11ef06ba4f

data/lib/rock_rms/resources/transaction_detail.rb

@@ -2,16 +2,18 @@ module RockRMS
   class Client
     module TransactionDetail
       def list_transaction_details(options = {})
-        get(transaction_detail_path, options)
+        res = get(transaction_detail_path, options)
+        RockRMS::Responses::TransactionDetail.format(res)
       end
 
       def find_transaction_detail(id)
-        get(transaction_detail_path(id))
+        res = get(transaction_detail_path(id))
+        RockRMS::Responses::TransactionDetail.format(res)
       end
 
-      def update_transaction_detail(id, account_id:)
+      def update_transaction_detail(id, fund_id:)
         options = {
-          'AccountId' => account_id
+          'AccountId' => fund_id
         }
         patch(transaction_detail_path(id), options)
       end

data/lib/rock_rms/responses/donation.rb

@@ -1,25 +1,39 @@
 module RockRMS
   module Responses
     class Donation
+      MAP = {
+        id: 'Id',
+        date: 'TransactionDateTime',
+        person_id: 'AuthorizedPersonAliasId',
+        batch_id: 'BatchId',
+        recurring_donation_id: 'ScheduledTransactionId',
+        summary: 'Summary',
+        transaction_code: 'TransactionCode',
+        details: 'TransactionDetails'
+      }.freeze
+
       def self.format(response)
         if response.is_a?(Array)
-          response.map { |donation| format_donation(donation) }
+          response.map { |data| format_single(data) }
         else
-          format_donation(response)
+          format_single(response)
+        end
+      end
+
+      def self.format_single(data)
+        response = MAP.each.with_object({}) do |(l, r), object|
+          object[l] = if l == :details
+                        RockRMS::Responses::TransactionDetail.format(data[r])
+                      else
+                        data[r]
+                      end
         end
+        response[:amount] = calculate_total(response[:details])
+        response
       end
 
-      def self.format_donation(donation)
-        {
-          id:     donation['Id'],
-          date:   donation['TransactionDateTime'],
-          amount: donation['TransactionDetails'].reduce(0) { |sum, td| sum + td['Amount'] },
-          person_id: donation['AuthorizedPersonAliasId'],
-          fund:   '',
-          batch_id: donation['BatchId'],
-          recurring_donation_id: donation['ScheduledTransactionId'],
-          summary: donation['Summary']
-        }
+      def self.calculate_total(details)
+        details.reduce(0) { |sum, td| sum + td[:amount] }
       end
     end
   end

data/lib/rock_rms/responses/transaction_detail.rb

@@ -0,0 +1,25 @@
+module RockRMS
+  module Responses
+    class TransactionDetail
+      MAP = {
+        id: 'Id',
+        fund_id: 'AccountId',
+        amount: 'Amount'
+      }.freeze
+
+      def self.format(data)
+        if data.is_a?(Array)
+          data.map { |object| format_single(object) }
+        else
+          format_single(data)
+        end
+      end
+
+      def self.format_single(data)
+        MAP.each.with_object({}) do |(l, r), object|
+          object[l] = data[r]
+        end
+      end
+    end
+  end
+end

data/lib/rock_rms/version.rb

@@ -1,3 +1,3 @@
 module RockRMS
-  VERSION = '1.3.0'.freeze
+  VERSION = '2.0.0'.freeze
 end

data/spec/rock_rms/resources/transaction_detail_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+RSpec.describe RockRMS::Client::TransactionDetail, type: :model do
+  include_context 'resource specs'
+
+  describe '#list_transaction_details' do
+    it 'returns a array' do
+      resource = client.list_transaction_details
+      expect(resource).to be_a(Array)
+      expect(resource.first).to be_a(Hash)
+    end
+  end
+
+  describe '#find_transaction_detail(id)' do
+    it 'returns a hash' do
+      expect(client.find_transaction_detail(123)).to be_a(Hash)
+    end
+
+    it 'queries ' do
+      expect(client).to receive(:get).with('FinancialTransactionDetails/123')
+        .and_call_original
+
+      resource = client.find_transaction_detail(123)
+
+      expect(resource[:id]).to eq(345)
+    end
+
+    it 'formats with TransactionDetail' do
+      response = double
+      expect(RockRMS::Responses::TransactionDetail).to receive(:format).with(response)
+      allow(client).to receive(:get).and_return(response)
+      client.find_transaction_detail(123)
+    end
+  end
+
+  describe '#update_transaction_detail' do
+    subject(:resource) do
+      client.update_transaction_detail(
+        123,
+        fund_id: 2,
+      )
+    end
+
+    it 'returns nothing' do
+      expect(client.update_transaction_detail(123, fund_id: 5)).to eq(nil)
+    end
+
+    it 'passes options' do
+      expect(client).to receive(:patch)
+        .with(
+          'FinancialTransactionDetails/123',
+          'AccountId' => 2
+        ).and_call_original
+      resource
+    end
+  end
+end

data/spec/rock_rms/responses/donation_spec.rb

@@ -19,6 +19,11 @@ RSpec.describe RockRMS::Responses::Donation, type: :model do
         expect(r[:batch_id]).to eq(p['BatchId'])
         expect(r[:recurring_donation_id]).to eq(p['ScheduledTransactionId'])
         expect(r[:summary]).to eq(p['Summary'])
+        expect(r[:transaction_code]).to eq(p['TransactionCode'])
+        expect(r[:details]).to eq(
+          RockRMS::Responses::TransactionDetail.format(p['TransactionDetails'])
+        )
+        expect(r[:amount]).to eq(100.00)
       end
     end
   end

data/spec/rock_rms/responses/transaction_detail_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+RSpec.describe RockRMS::Responses::TransactionDetail, type: :model do
+  let(:parsed) { JSON.parse(FixturesHelper.read('transaction_details.json')) }
+
+  describe '.format' do
+    subject(:result) { described_class.format(parsed) }
+
+    context 'when response is array' do
+      it 'returns an array' do
+        expect(described_class.format([])).to be_a(Array)
+      end
+    end
+
+    it 'translates keys' do
+      result.zip(parsed) do |r, p|
+        expect(r[:id]).to eq(p['Id'])
+        expect(r[:fund_id]).to eq(p['AccountId'])
+        expect(r[:amount]).to eq(p['Amount'])
+      end
+    end
+  end
+end

data/spec/support/fixtures/donations.json

@@ -33,7 +33,11 @@
         "TransactionCode": 1239,
         "TransactionDateTime": "2013-01-06T00:00:00",
         "TransactionTypeValue": null,
-        "TransactionDetails": [],
+        "TransactionDetails": [{
+          "Id": 345,
+          "AccountId": 23,
+          "Amount": 100.00
+        }],
         "TransactionTypeValueId": 53
     }
 ]

data/spec/support/fixtures/transaction_detail.json

@@ -0,0 +1,23 @@
+{
+  "TransactionId": 1422,
+  "AccountId": 23,
+  "IsNonCash": false,
+  "Amount": 100.00,
+  "Summary": null,
+  "EntityTypeId": null,
+  "EntityId": null,
+  "Account": null,
+  "EntityType": null,
+  "CreatedDateTime": "2018-01-25T02:00:14.973",
+  "ModifiedDateTime": "2018-01-25T02:00:14.973",
+  "CreatedByPersonAliasId": null,
+  "ModifiedByPersonAliasId": null,
+  "ModifiedAuditValuesAlreadyUpdated": false,
+  "Attributes": null,
+  "AttributeValues": null,
+  "Id": 345,
+  "Guid": "a3bdcc01-5476-4e08-8245-dec2630c9471",
+  "ForeignId": null,
+  "ForeignGuid": null,
+  "ForeignKey": null
+}

data/spec/support/fixtures/transaction_details.json

@@ -0,0 +1,25 @@
+[
+  {
+    "TransactionId": 1422,
+    "AccountId": 23,
+    "IsNonCash": false,
+    "Amount": 100.00,
+    "Summary": null,
+    "EntityTypeId": null,
+    "EntityId": null,
+    "Account": null,
+    "EntityType": null,
+    "CreatedDateTime": "2018-01-25T02:00:14.973",
+    "ModifiedDateTime": "2018-01-25T02:00:14.973",
+    "CreatedByPersonAliasId": null,
+    "ModifiedByPersonAliasId": null,
+    "ModifiedAuditValuesAlreadyUpdated": false,
+    "Attributes": null,
+    "AttributeValues": null,
+    "Id": 345,
+    "Guid": "a3bdcc01-5476-4e08-8245-dec2630c9471",
+    "ForeignId": null,
+    "ForeignGuid": null,
+    "ForeignKey": null
+  }
+]

data/spec/support/rock_mock.rb

@@ -26,8 +26,10 @@ class RockMock < Sinatra::Base
     groups:        'Groups',
     people_search: 'People/Search',
     phone_numbers: 'PhoneNumbers',
-    recurring_donation: 'FinancialScheduledTransactions/:id',
-    recurring_donations: 'FinancialScheduledTransactions'
+    recurring_donation:  'FinancialScheduledTransactions/:id',
+    recurring_donations: 'FinancialScheduledTransactions',
+    transaction_detail:  'FinancialTransactionDetails/:id',
+    transaction_details: 'FinancialTransactionDetails'
   }.each do |json, end_point|
     get "/api/#{end_point}" do
       json_response 200, "#{json}.json"
@@ -49,7 +51,8 @@ class RockMock < Sinatra::Base
   [
     'FinancialBatches/:id',
     'FinancialScheduledTransactions/:id',
-    'FinancialTransactions/:id'
+    'FinancialTransactions/:id',
+    'FinancialTransactionDetails/:id'
   ].each do |end_point|
     patch "/api/#{end_point}" do
       content_type :json
@@ -60,12 +63,12 @@ class RockMock < Sinatra::Base
   post '/api/Auth/Login' do
     content_type :json
 
-    response['Cache-Control'] = 'no-cache'
+    response['Cache-Control']          = 'no-cache'
     response['Content-Secuity-Policy'] = "frame-ancestors 'self'"
-    response['Date'] = Time.now.httpdate
-    response['Expires'] = '-1'
-    response['Pragma'] = 'no-cache'
-    response['Set-Cookie'] = [
+    response['Date']                   = Time.now.httpdate
+    response['Expires']                = '-1'
+    response['Pragma']                 = 'no-cache'
+    response['Set-Cookie']             = [
       ".ROCK=#{SecureRandom.hex(100)}",
       "expires=#{(Time.now + 14).httpdate}",
       'path=/',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rock_rms
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Taylor Brooks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2018-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -205,6 +205,7 @@ files:
 - lib/rock_rms/responses/phone_number.rb
 - lib/rock_rms/responses/recurring_donation.rb
 - lib/rock_rms/responses/recurring_donation_details.rb
+- lib/rock_rms/responses/transaction_detail.rb
 - lib/rock_rms/version.rb
 - rock_rms.gemspec
 - spec/rock_rms/client_spec.rb
@@ -216,6 +217,7 @@ files:
 - spec/rock_rms/resources/person_spec.rb
 - spec/rock_rms/resources/phone_number_spec.rb
 - spec/rock_rms/resources/recurring_donation_spec.rb
+- spec/rock_rms/resources/transaction_detail_spec.rb
 - spec/rock_rms/responses/campus_spec.rb
 - spec/rock_rms/responses/donation_spec.rb
 - spec/rock_rms/responses/group_location_spec.rb
@@ -224,6 +226,7 @@ files:
 - spec/rock_rms/responses/phone_number_spec.rb
 - spec/rock_rms/responses/recurring_donation_details_spec.rb
 - spec/rock_rms/responses/recurring_donation_spec.rb
+- spec/rock_rms/responses/transaction_detail_spec.rb
 - spec/rock_rms_spec.rb
 - spec/spec_helper.rb
 - spec/support/client_factory.rb
@@ -248,6 +251,8 @@ files:
 - spec/support/fixtures/recurring_donation.json
 - spec/support/fixtures/recurring_donation_details.json
 - spec/support/fixtures/recurring_donations.json
+- spec/support/fixtures/transaction_detail.json
+- spec/support/fixtures/transaction_details.json
 - spec/support/fixtures_helper.rb
 - spec/support/rock_mock.rb
 homepage: https://github.com/taylorbrooks/rock_rms