rock_config 0.0.1 → 0.0.2

data/README.md

@@ -30,13 +30,13 @@ Given the file elastic_search.yml:
 
 RockConfig allows you to read these settings with an API like this:
 
-    elastic_config = RockConfig.for :elastic_search
+    elastic_config = RockConfig.for "elastic_search"
     elastic_config.host # > 127.0.0.1
 
 RockConfig automatically chooses the current application environment. You select the environment yourself
 with: 
 
-    RockConfig.for :elastic_search, :production
+    RockConfig.for "elastic_search", "production"
 
 RockConfig scans predefined directories for config files. By default, it tries to scan directory
 `config` in the project root. You can add more directories:

data/lib/rock_config.rb

@@ -1,4 +1,5 @@
 require "rock_config/version"
+require "rock_config/errors"
 require "rock_config/environment_detector"
 require "rock_config/configuration"
 require "rock_config/manager"
@@ -7,8 +8,6 @@ require "rock_config/yaml_loader"
 require "rock_config/config"
 
 module RockConfig
-  class ConfigNotFound < Exception; end
-
   class << self
     def for(config_name, environment = detect_environment)
       manager.fetch(config_name, environment)

data/lib/rock_config/errors.rb

@@ -0,0 +1,6 @@
+module RockConfig
+  class Error < StandardError; end
+  class ConfigLoadError < Error; end
+  class ConfigNotFoundError < Error; end
+  class EnvironmentNotFoundError < Error; end
+end

data/lib/rock_config/manager.rb

@@ -7,7 +7,12 @@ module RockConfig
 
     def fetch(config_name, environment)
       if config = @configs[config_name]
-        config.send environment
+        if config_for_environment = config.send(environment)
+          return config_for_environment
+        else
+          raise EnvironmentNotFoundError, 
+            'Environment "%s" not found' % environment
+        end
       end
     end
 

data/lib/rock_config/scanner.rb

@@ -13,7 +13,7 @@ module RockConfig
         end
       end
 
-      raise ConfigNotFound, "Config not found"
+      raise ConfigNotFoundError, "Config not found"
     end
   end
 end

data/lib/rock_config/version.rb

@@ -1,3 +1,3 @@
 module RockConfig
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/rock_config/yaml_loader.rb

@@ -26,6 +26,8 @@ module RockConfig
 
     def load_yaml_from(path)
       YAML.load_file(path)
+    rescue Psych::SyntaxError => e
+      raise ConfigLoadError, e.message
     end
   end
 end

data/spec/manager_spec.rb

@@ -18,14 +18,18 @@ module RockConfig
       manager_result.should eq("yay")
     end
 
-    it "returns nul if config not found" do
+    it "raises error if the config doesnt have the environment"  do
+      result = mock("Config")
+      result.should_receive(:send).with("development") { nil }
+
       scanner = mock("Scanner")
       scanner.should_receive(:new) .with(configuration) { scanner }
-      scanner.should_receive(:find).with("sample")      { nil }
+      scanner.should_receive(:find).with("sample")      { result }
 
       manager = Manager.new(configuration, scanner)
-
-      manager.fetch("sample", "development").should be_nil
+      expect do
+        manager_result  = manager.fetch "sample", "development"
+      end.to raise_error(EnvironmentNotFoundError)
     end
   end
 end

data/spec/scanner_spec.rb

@@ -15,7 +15,7 @@ module RockConfig
     it "finds nothing when the target doesnt exist" do
       expect do
         scanner.find("database")
-      end.to raise_error(ConfigNotFound)
+      end.to raise_error(ConfigNotFoundError)
     end
 
     it "scans additional directories" do

data/spec/yaml_loader_spec.rb

@@ -17,7 +17,7 @@ module RockConfig
 
       expect do
         config = loader.find_at(directory, "database_invalid")
-      end.to raise_error(Psych::SyntaxError)
+      end.to raise_error(RockConfig::ConfigLoadError)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rock_config
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-02 00:00:00.000000000 Z
+date: 2012-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -76,6 +76,7 @@ files:
 - lib/rock_config/config.rb
 - lib/rock_config/configuration.rb
 - lib/rock_config/environment_detector.rb
+- lib/rock_config/errors.rb
 - lib/rock_config/manager.rb
 - lib/rock_config/scanner.rb
 - lib/rock_config/version.rb
@@ -126,4 +127,3 @@ test_files:
 - spec/scanner_spec.rb
 - spec/spec_helper.rb
 - spec/yaml_loader_spec.rb
-has_rdoc: