robut 0.3.0 → 0.4.0

data/test/mocks/connection_mock.rb

@@ -4,23 +4,7 @@ class Robut::ConnectionMock < Robut::Connection
 
   def initialize(config = nil)
     self.config = config || self.class.config
-    self.store = Robut::Storage::HashStore
+    self.store  = Robut::Storage::HashStore
+    self.client = Jabber::Client.new ''
   end
-
-  def replies
-    @replies ||= []
-  end
-  
-  def reply(msg, to = nil)
-    replies << msg
-  end
-  
-  def handle_message(plugins, time, nick, message)
-    messages << [time, nick, message]
-  end
-  
-  def messages
-    @messages ||= []
-  end
-  
 end

data/test/mocks/presence_mock.rb

@@ -0,0 +1,25 @@
+require 'robut/storage/hash_store'
+
+class Robut::PresenceMock < Robut::Room
+
+  def initialize(connection)
+    self.connection = connection
+  end
+
+  def replies
+    @replies ||= []
+  end
+  
+  def reply(msg, to = nil)
+    replies << msg
+  end
+  
+  def handle_message(plugins, time, nick, message)
+    messages << [time, nick, message]
+  end
+  
+  def messages
+    @messages ||= []
+  end
+  
+end

data/test/test_helper.rb

@@ -1,7 +1,9 @@
 require 'robut'
 require 'test/unit'
+require 'mocks/presence_mock'
 require 'mocks/connection_mock'
 
 Robut::ConnectionMock.configure do |config|
   config.nick = "Robut t. Robot"
-end
+  config.mention_name = "robut"
+end

data/test/unit/connection_test.rb

@@ -1,4 +1,5 @@
 require 'test_helper'
+require 'robut/plugin/echo'
 
 class SimplePlugin
   include Robut::Plugin
@@ -52,31 +53,61 @@ class ReplyMock
   def room
     "my_room@test.com"
   end
+
+  def add_message_callback(code, reply_to)
+    true
+  end
+
+  def join(path)
+    true
+  end
 end
 
+class RoomMock < Robut::Room
+
+  def initialize(connection)
+    @muc = ReplyMock.new
+    @connection = connection
+  end
+
+end
+
+class PMMock < Robut::PM
+
+  def initialize(connection)
+    @connection = connection
+  end
+end
+
+
 class ConnectionTest < Test::Unit::TestCase
 
   def setup
     Robut::Plugin.plugins = [SimplePlugin]
     @connection = Robut::Connection.new({
         :jid => 'abc@def.com',
-        :nick => "Test Robut"
+        :nick => "Test Robut",
+        :mention_name => 'test'
       })
   end
 
   def test_end_to_end_message
     Robut::Plugin.plugins = [Robut::Plugin::Echo]
-    @connection.muc = ReplyMock.new
-    @connection.handle_message(plugins(@connection), Time.now, 'Justin', '@test echo Test Message')
-    message = @connection.muc.messages.first
-    assert_equal(@connection.muc.room, message.to.to_s)
+    justin = Jabber::JID.new('justin@example.com')
+    @connection.roster = mock_roster(justin)
+    room = RoomMock.new(@connection)
+    room.handle_message(plugins(room), Time.now, 'Justin Weiss', '@test echo Test Message')
+    message = room.muc.messages.first
+    assert_equal(room.muc.room, message.to.to_s)
     assert_equal("Test Message", message.body)
   end
 
   def test_handle_message_delegates_to_plugin
-    plugins = plugins(@connection)
+    presence = Robut::Presence.new(@connection)
+    plugins = plugins(presence)
     assert !plugins.first.run, "The plugin was not set up correctly."
-    @connection.handle_message(plugins, Time.now, 'Justin', 'Test Message')
+
+    presence.handle_message(plugins, Time.now, 'Justin', 'Test Message')
     assert plugins.first.run, "The plugin's handle_message method should have been run"
   end
 
@@ -84,8 +115,10 @@ class ConnectionTest < Test::Unit::TestCase
     Robut::Plugin.plugins = [Robut::Plugin::Echo]
     sender = Jabber::JID.new('justin@example.com')
     @connection.client = ReplyMock.new
-    @connection.handle_message(plugins(@connection, sender), Time.now, 'Justin', '@test echo Test Message')
-    message = @connection.client.messages.first
+    pm = PMMock.new(@connection)
+
+    pm.handle_message(plugins(pm, sender), Time.now, 'Justin', '@test echo Test Message')
+    message = pm.connection.client.messages.first
     assert_equal(sender, message.to)
     assert_equal("Test Message", message.body)
   end
@@ -94,16 +127,11 @@ class ConnectionTest < Test::Unit::TestCase
     Robut::Plugin.plugins = [ReplyToUserPlugin]
     @connection.client = ReplyMock.new
     justin = Jabber::JID.new('justin@example.com')
-    @connection.roster = OpenStruct.new({
-    :items => {
-      justin => OpenStruct.new({
-        :iname => "Justin Weiss"
-          })
-        }
-    })
-
-    @connection.handle_message(plugins(@connection), Time.now, 'justin WEISS', 'Test Message')
-    message = @connection.client.messages.first
+    @connection.roster = mock_roster(justin)
+    pm = Robut::PM.new(@connection, justin)
+
+    pm.handle_message(plugins(pm), Time.now, 'justin WEISS', 'Test Message')
+    message = pm.connection.client.messages.first
     assert_equal(justin, message.to.to_s)
     assert_equal(:chat, message.type)
     assert_equal("Reply", message.body)
@@ -112,17 +140,22 @@ class ConnectionTest < Test::Unit::TestCase
   def test_reply_directly_to_room
     Robut::Plugin.plugins = [ReplyToRoomPlugin]
     sender = Jabber::JID.new('justin@example.com')
-    @connection.muc = ReplyMock.new
-    @connection.handle_message(plugins(@connection, sender), Time.now, 'Justin', '@test echo Test Message')
-    message = @connection.muc.messages.first
-    assert_equal(@connection.muc.room, message.to.to_s)
+    room = RoomMock.new(@connection)
+
+    room.handle_message(plugins(room, sender), Time.now, 'Justin', '@test echo Test Message')
+    message = room.muc.messages.first
+    assert_equal(room.muc.room, message.to.to_s)
     assert_equal("Reply", message.body)
   end
 
   private
 
-  def plugins(connection, sender = nil)
-    Robut::Plugin.plugins.map { |p| p.new(connection, sender) }
+  def plugins(presence, sender = nil)
+    Robut::Plugin.plugins.map { |p| p.new(presence, sender) }
+  end
+
+  def mock_roster(jid)
+    OpenStruct.new( :items => { jid => OpenStruct.new(:iname => "Justin Weiss") } )
   end
 
 end

data/test/unit/plugin/alias_test.rb

@@ -6,7 +6,8 @@ class Robut::Plugin::AliasTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
-    @plugin = Robut::Plugin::Alias.new(@connection)
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Alias.new(@presence)
     @plugin.aliases = {}
   end
   
@@ -18,7 +19,7 @@ class Robut::Plugin::AliasTest < Test::Unit::TestCase
   def test_thinks_this_is_that
     @plugin.handle(Time.now, "@john", "@robut alias this @robut echo that")
     @plugin.handle(Time.now, "@john", "this")
-    message = @plugin.connection.messages.first
+    message = @plugin.reply_to.messages.first
     assert_equal "@john", message[1]
     assert_equal "@robut echo that", message[2]
   end
@@ -36,7 +37,7 @@ class Robut::Plugin::AliasTest < Test::Unit::TestCase
   def test_can_apply_aliases_with_quotes
     @plugin.handle(Time.now, "@john", '@robut alias "long string" "some other long string"')
     @plugin.handle(Time.now, "@john", "long string")
-    message = @plugin.connection.messages.first
+    message = @plugin.reply_to.messages.first
     assert_equal "@john", message[1]
     assert_equal "some other long string", message[2]    
   end
@@ -63,7 +64,7 @@ class Robut::Plugin::AliasTest < Test::Unit::TestCase
     @plugin.handle(Time.now, "@john", "@robut alias this that")
     @plugin.handle(Time.now, "@john", "@robut alias something something else")
     @plugin.handle(Time.now, "@john", "@robut aliases")
-    assert_equal ["something => something else\nthis => that"], @plugin.connection.replies
+    assert_equal ["something => something else\nthis => that"], @plugin.reply_to.replies
   end
   
   def test_can_clear_aliases

data/test/unit/plugin/echo_test.rb

@@ -5,22 +5,23 @@ class Robut::Plugin::EchoTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
-    @plugin = Robut::Plugin::Echo.new(@connection)
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Echo.new(@presence)
   end
 
   def test_replies_with_this
     @plugin.handle(Time.now, "@john", "@robut echo this")
-    assert_equal ["this"], @plugin.connection.replies
+    assert_equal ["this"], @plugin.reply_to.replies
   end
 
   def test_replies_with_nicks
     @plugin.handle(Time.now, "@john", "@robut echo @justin look over here!")
-    assert_equal ["@justin look over here!"], @plugin.connection.replies
+    assert_equal ["@justin look over here!"], @plugin.reply_to.replies
   end
   
   def test_doesnt_reply_with_empty
     @plugin.handle(Time.now, "@john", "@robut echo")
-    assert_equal [], @plugin.connection.replies    
+    assert_equal [], @plugin.reply_to.replies
   end
   
 end

data/test/unit/plugin/help_test.rb

@@ -14,9 +14,10 @@ class Robut::Plugin::HelpTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
+    @presence = Robut::PresenceMock.new(@connection)
     Robut::Plugin.plugins << Robut::Plugin::Echo
     Robut::Plugin.plugins << Robut::Plugin::Help
-    @plugin = Robut::Plugin::Help.new(@connection)
+    @plugin = Robut::Plugin::Help.new(@presence)
   end
 
   def teardown
@@ -29,7 +30,7 @@ class Robut::Plugin::HelpTest < Test::Unit::TestCase
       "Supported commands:",
       "@robut echo <message> - replies to the channel with <message>",
       "@robut help - displays this message",
-    ], @plugin.connection.replies
+    ], @plugin.reply_to.replies
   end
 
   def test_empty_help
@@ -39,7 +40,7 @@ class Robut::Plugin::HelpTest < Test::Unit::TestCase
       "Supported commands:",
       "@robut echo <message> - replies to the channel with <message>",
       "@robut help - displays this message",
-    ], @plugin.connection.replies
+    ], @plugin.reply_to.replies
   end
 end
   

data/test/unit/plugin/later_test.rb

@@ -5,7 +5,8 @@ class Robut::Plugin::LaterTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
-    @plugin = Robut::Plugin::Later.new(@connection)
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Later.new(@presence)
     @plugin.instance_eval do
       def threader; yield; end # no threads
       def sleep(*prms); end # just skip the whole sleeping part
@@ -14,8 +15,8 @@ class Robut::Plugin::LaterTest < Test::Unit::TestCase
 
   def test_replies_with_minutes
     @plugin.handle(Time.now, "@john", "@robut in 0 minutes msg me")
-    assert_equal ["Ok, see you in 0 minutes"], @plugin.connection.replies
-    message = @plugin.connection.messages.first
+    assert_equal ["Ok, see you in 0 minutes"], @plugin.reply_to.replies
+    message = @plugin.reply_to.messages.first
     assert message
     assert_equal message[1], "@john"
     assert_equal message[2], "@robut msg me"
@@ -23,17 +24,17 @@ class Robut::Plugin::LaterTest < Test::Unit::TestCase
 
   def test_replies_with_sec
     @plugin.handle(Time.now, "@john", "@robut in 1 sec msg me")
-    assert_equal ["Ok, see you in 1 sec"], @plugin.connection.replies
+    assert_equal ["Ok, see you in 1 sec"], @plugin.reply_to.replies
   end
   
   def test_replies_with_hr
     @plugin.handle(Time.now, "@john", "@robut in 1 hr msg me")
-    assert_equal ["Ok, see you in 1 hr"], @plugin.connection.replies
+    assert_equal ["Ok, see you in 1 hr"], @plugin.reply_to.replies
   end
 
   def test_replies_with_hrs
     @plugin.handle(Time.now, "@john", "@robut in 2 hrs msg me")
-    assert_equal ["Ok, see you in 2 hrs"], @plugin.connection.replies
+    assert_equal ["Ok, see you in 2 hrs"], @plugin.reply_to.replies
   end
   
 end

data/test/unit/plugin/lunch_test.rb

@@ -5,30 +5,31 @@ class Robut::Plugin::LunchTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
-    @plugin = Robut::Plugin::Lunch.new(@connection)
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Lunch.new(@presence)
     @plugin.places = ["Pho"]
   end
 
   def test_handle_returns_pho_for_lunch
     @plugin.handle(Time.now, "John", "lunch?")
-    assert_equal ["Pho!"], @plugin.connection.replies
+    assert_equal ["Pho!"], @plugin.reply_to.replies
   end
   
   def test_handle_returns_all_places_for_lunch_places
     @plugin.new_place("Teriyaki")
     @plugin.handle(Time.now, "John", "@robut lunch places")
-    assert_equal ["Pho, Teriyaki"], @plugin.connection.replies
+    assert_equal ["Pho, Teriyaki"], @plugin.reply_to.replies
   end
   
   def test_handle_new_lunch_place
     @plugin.handle(Time.now, "John", "@robut new lunch place Green Leaf")
-    assert_equal ["Ok, I'll add \"Green Leaf\" to the the list of lunch places"], @plugin.connection.replies
+    assert_equal ["Ok, I'll add \"Green Leaf\" to the the list of lunch places"], @plugin.reply_to.replies
     assert @plugin.places.include?("Green Leaf")
   end
   
   def test_handle_remove_lunch_place
     @plugin.handle(Time.now, "John", "@robut remove lunch place Pho")
-    assert_equal ["I removed \"Pho\" from the list of lunch places"], @plugin.connection.replies
+    assert_equal ["I removed \"Pho\" from the list of lunch places"], @plugin.reply_to.replies
     assert @plugin.places.empty?
   end
 

data/test/unit/plugin/pick_test.rb

@@ -0,0 +1,35 @@
+require 'test_helper'
+require 'robut/plugin/pick'
+require 'mocha'
+
+class Robut::Plugin::PickTest < Test::Unit::TestCase
+
+  def setup
+    @connection = Robut::ConnectionMock.new
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Pick.new(@presence)
+  end
+
+  def test_replies_with_correct_response
+    @plugin.stubs(:random).returns(0)
+    @plugin.handle(Time.now, "@john", "@robut pick a, b, c")
+    assert_equal ["And the winner is... a"], @plugin.reply_to.replies
+  end
+  
+  def test_does_nothing_when_no_options_are_given
+    @plugin.handle(Time.now, "@john", "@robut pick")
+    assert @plugin.reply_to.replies.empty?
+  end
+
+  def test_replies_only_option_if_given_one_options
+    @plugin.handle(Time.now, "@john", "@robut pick a")
+    assert_equal ["And the winner is... a"], @plugin.reply_to.replies
+  end
+  
+  def test_handles_spaces
+    @plugin.stubs(:random).returns(1)
+    @plugin.handle(Time.now, "@john", "@robut pick this is the first option, this is the second option, this is the third option")
+    assert_equal ["And the winner is... this is the second option"], @plugin.reply_to.replies
+  end
+  
+end

data/test/unit/plugin/ping_test.rb

@@ -5,17 +5,18 @@ class Robut::Plugin::PingTest < Test::Unit::TestCase
 
   def setup
     @connection = Robut::ConnectionMock.new
-    @plugin = Robut::Plugin::Ping.new(@connection)
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Ping.new(@presence)
   end
 
   def test_replies_wih_pong
     @plugin.handle(Time.now, "@john", "@robut ping")
-    assert_equal ["pong"], @plugin.connection.replies
+    assert_equal ["pong"], @plugin.reply_to.replies
   end
 
   def test_replies_wih_sec
     @plugin.handle(Time.now, "@john", "@robut ping pong")
-    assert_equal [], @plugin.connection.replies
+    assert_equal [], @plugin.reply_to.replies
   end
   
 end

data/test/unit/plugin/quips_test.rb

@@ -0,0 +1,58 @@
+require 'test_helper'
+require 'robut/plugin/quips'
+
+class Robut::Plugin::QuipsTest < Test::Unit::TestCase
+
+  def setup
+    @connection = Robut::ConnectionMock.new
+    @presence = Robut::PresenceMock.new(@connection)
+    @plugin = Robut::Plugin::Quips.new(@presence)
+    @plugin.store["quips"] = ["the fancier i try and make it, the more complicated it gets!", "It works on my machine ..."]
+  end
+
+  def test_add_quip_adds_a_quip_to_the_database
+    @plugin.handle(Time.now, "John", "@robut add quip So, are we self managing now?")
+    assert_equal ["I added the quip to the quip database"], @plugin.reply_to.replies
+    assert_equal "So, are we self managing now?", @plugin.quips.last
+  end
+
+  def test_add_quip_without_a_quip_is_ignored
+    @plugin.handle(Time.now, "John", "@robut add quip ")
+    assert_equal [], @plugin.reply_to.replies
+    assert_equal 2, @plugin.quips.length
+  end
+
+  def test_add_quip_doesnt_add_duplicates
+    @plugin.handle(Time.now, "John", "@robut add quip the fancier i try and make it, the more complicated it gets!")
+    assert_equal ["I didn't add the quip, since it was already added"], @plugin.reply_to.replies
+    assert_equal 2, @plugin.quips.length
+  end
+
+  def test_remove_quip
+    @plugin.handle(Time.now, "John", "@robut remove quip the fancier i try and make it, the more complicated it gets!")
+    assert_equal ["I removed the quip from the quip database"], @plugin.reply_to.replies
+    assert_equal 1, @plugin.quips.length
+  end
+
+  def test_remove_nonexisting_quip_returns_error_message
+    @plugin.handle(Time.now, "John", "@robut remove quip boooooooo")
+    assert_equal ["I couldn't remove the quip, since it wasn't in the quip database"], @plugin.reply_to.replies
+    assert_equal 2, @plugin.quips.length
+  end
+
+  def test_quip_me_returns_a_random_quip
+    seed = srand(1)
+    begin
+      @plugin.handle(Time.now, "John", "@robut quip")
+      assert_equal ["It works on my machine ..."], @plugin.reply_to.replies
+    ensure
+      srand(seed)
+    end
+  end
+
+  def test_quip_me_returns_an_error_if_no_quips
+    @plugin.store["quips"] = []
+    @plugin.handle(Time.now, "John", "@robut quip")
+    assert_equal ["I don't know any quips"], @plugin.reply_to.replies
+  end
+end