robust_excel_ole 1.35 → 1.36

data/spec/workbook_specs/workbook_misc_spec.rb

@@ -47,6 +47,253 @@ describe Workbook do
     end
   end
 
+  describe "writable=" do
+
+    it "should change from writable to readonly back to writable" do
+      book = Workbook.open(@simple_file1)
+      book.ReadOnly.should be false
+      book.writable = true
+      book.ReadOnly.should be false
+      book.writable = false
+      book.ReadOnly.should be true
+      book.writable = true
+      book.ReadOnly.should be false
+    end
+
+    it "should change from readonly to writable back to readonly" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      book.writable = false
+      book.ReadOnly.should be true
+      book.writable = true
+      book.ReadOnly.should be false
+      book.writable = false
+      book.ReadOnly.should be true
+    end
+
+    it "should change read-only to writable mode for an unsaved workbook" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = false
+      book.ReadOnly.should be true
+      book.writable = true
+      book.ReadOnly.should be false
+      book.Saved.should be false
+      sheet[1,1].should == new_value
+    end
+
+    it "should save changes and change from read-only to writable with option :save" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = true, {if_unsaved: :save}
+      book.ReadOnly.should be false
+      book.Saved.should be true
+      sheet[1,1].should_not == old_value
+      sheet[1,1].should == new_value
+    end
+
+    it "should discard changes and change from read-only to writable with option :forget" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = true, {if_unsaved: :forget}
+      book.ReadOnly.should be false
+      book.close
+      book2 = Workbook.open(@simple_file1)
+      sheet2 = book2.sheet(1)
+      sheet2[1,1].should == old_value
+      sheet2[1,1].should_not == new_value
+    end
+
+    it "should raise error when tying to change writable to read-only mode for an unsaved workbook with option :raise" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = true
+      book.ReadOnly.should be false
+      expect{
+        book.writable = false, {if_unsaved: :raise}
+      }.to raise_error(WorkbookNotSaved)
+    end
+
+    it "should save changes and change from writable to read-only with option :save" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = false, {if_unsaved: :save}
+      book.ReadOnly.should be true
+      sheet[1,1].should_not == old_value
+      sheet[1,1].should == new_value
+    end
+
+    it "should discard changes and change from writable to read-only with option :forget" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book.writable = false, {if_unsaved: :forget}
+      book.ReadOnly.should be true
+      book.close
+      book2 = Workbook.open(@simple_file1)
+      sheet2 = book2.sheet(1)
+      sheet2[1,1].should == old_value
+      sheet2[1,1].should_not == new_value
+    end
+
+    context "with :if_unsaved => :excel or :alert and from read-only to read-write" do
+     
+      before do
+        @book = Workbook.open(@simple_file1, v: true, readonly: true)
+        @book.ReadOnly.should be false
+        @sheet = @book.sheet(1)
+        @old_value = @sheet[1,1]
+        @sheet[1,1] = (@sheet[1,1] == "foo" ? "bar" : "foo")
+        @new_value = @sheet[1,1] 
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
+      end
+
+      after do
+        @key_sender.close
+      end
+
+      # question to the user, whether the workbook shall be reopened and discard any changes
+
+      it "should discard changes and reopen the workbook, if user answers 'yes'" do
+        @key_sender.puts "{enter}"
+        @book.writable = true, {if_unsaved: :excel}
+        @book.ReadOnly.should be false
+        @book.Saved.should be false
+        @sheet[1,1].should == @new_value
+        @book.close(if_unsaved: :forget)
+        book1 = Workbook.open(@simple_file1)
+        sheet = book1.sheet(1)
+        sheet[1,1].should == @old_value
+      end
+
+      it "should not discard changes and reopen the workbook, if user answers 'no'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        # strangely, in the "no" case, the question will sometimes be repeated three times
+        #@book.excel.Visible = true
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @book.writable = true, {if_unsaved: :excel}
+        @book.ReadOnly.should be false
+        @book.Saved.should be false
+        @sheet[1,1].should == @new_value
+        @book.close(if_unsaved: :forget)
+        book1 = Workbook.open(@simple_file1)
+        sheet = book1.sheet(1)
+        sheet[1,1].should == @old_value
+      end
+     
+    end
+
+    context "with :if_unsaved => :excel or :alert and from writable to read-only" do
+     
+      before do
+        @book = Workbook.open(@simple_file1, v: true, readonly: false)
+        @book.ReadOnly.should be false
+        @sheet = @book.sheet(1)
+        @old_value = @sheet[1,1]
+        @sheet[1,1] = (@sheet[1,1] == "foo" ? "bar" : "foo")
+        @new_value = @sheet[1,1] 
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
+      end
+
+      after do
+        @key_sender.close
+      end
+
+      # question to the user, whether to save the changes before changing read-only mode
+      it "should save the workbook, if user answers 'no' and 'yes'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "Yes"
+        @key_sender.puts "{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        @sheet[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+      it "should discard (not save) the workbook, if user answers 'no' and 'no'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "No"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        @sheet[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+      it "should not save (discard) changes and not reopen the workbook, if user answers 'no' and 'cancel'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "Cancel"
+        @key_sender.puts "{right}{right}{enter}"
+        @key_sender.puts "{right}{right}{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        @sheet[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1, if_unsaved: :forget)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+    end
+
+  end
+
   describe "for_this_workbook" do
 
     before do
@@ -728,10 +975,10 @@ describe Workbook do
       }.to_not raise_error
       expect {
         @book1.namevalue_global("foo", :default => :__not_provided)
-      }.to raise_error(NameNotFound, /name "foo" not in #<Workbook: another_workbook/)
+      }.to raise_error(NameNotFound, /cannot find name "foo"/)
       expect {
         @book1.namevalue_global("foo")
-      }.to raise_error(NameNotFound, /name "foo" not in #<Workbook: another_workbook/)
+      }.to raise_error(NameNotFound, /cannot find name "foo"/)
       @book1.namevalue_global("foo", :default => nil).should be_nil
       @book1.namevalue_global("foo", :default => 1).should == 1
       expect {

data/spec/workbook_specs/workbook_open_spec.rb

@@ -35,13 +35,13 @@ describe Workbook do
     @simple_file_network_path = "N:/data/workbook.xls"
     network = WIN32OLE.new('WScript.Network')
     computer_name = network.ComputerName
-    @simple_file_hostname_share_path = "//#{computer_name}/#{absolute_path('spec/data/workbook.xls').tr('\\','/').gsub('C:','c$')}"
+    @simple_file_hostname_share_path = "//#{computer_name}/spec/data/workbook.xls"
+    @simple_file_hostname_share_other_path = "//#{computer_name}/spec/more_data/workbook.xls"
     @simple_file_network_path_other_path = "N:/data/more_data/workbook.xls"
-    @simple_file_hostname_share_path_other_path = "//#{computer_name}/#{absolute_path('spec/more_data/workbook.xls').tr('\\','/').gsub('C:','c$')}"
     @simple_file_network_path1 = @simple_file_network_path
     @simple_file_hostname_share_path1 = @simple_file_hostname_share_path
     @simple_file_network_path_other_path1 = @simple_file_network_path_other_path
-    @simple_file_hostname_share_path_other_path1 = @simple_file_hostname_share_path_other_path
+    @simple_file_hostname_share_other_path1 = @simple_file_hostname_share_other_path
     @simple_file_xlsm1 = @simple_file_xlsm
     @simple_file_xlsx1 = @simple_file_xlsx
     #@linked_file = @dir + '/workbook_linked.xlsm'
@@ -56,6 +56,289 @@ describe Workbook do
     rm_tmp(@dir)
   end
 
+  describe "changing ReadOnly mode" do
+
+    it "should change from writable to readonly back to writable" do
+      book = Workbook.open(@simple_file1)
+      book.ReadOnly.should be false
+      book2 = Workbook.open(@simple_file1, read_only: true)
+      book2.should == book
+      book2.ReadOnly.should be true
+      book3 = Workbook.open(@simple_file1, read_only: false)
+      book3.should == book
+      book3.ReadOnly.should be false
+      book3.close
+    end
+
+    it "should change from readonly to writable back to readonly" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      book2 = Workbook.open(@simple_file1, read_only: false)
+      book2.should == book
+      book2.ReadOnly.should be false
+      book3 = Workbook.open(@simple_file1, read_only: true)
+      book3.should == book
+      book3.ReadOnly.should be true
+      book3.close
+    end
+
+    it "should raise error when read-only workbook unsaved and trying to reopen workbook writable by default" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      expect{
+        Workbook.open(@simple_file1, read_only: false)
+      }.to raise_error(WorkbookNotSaved)
+    end
+
+    it "should raise error when read-only workbook unsaved and trying to reopen workbook writable with option :raise" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      expect{
+        Workbook.open(@simple_file1, read_only: false, if_unsaved: :raise)
+      }.to raise_error(WorkbookNotSaved)
+    end
+
+    it "should save changes and change from read-only to writable with option :save" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book2 = Workbook.open(@simple_file1, if_unsaved: :save, read_only: false)
+      book2.should == book
+      book2.ReadOnly.should be false
+      sheet[1,1].should_not == old_value
+      sheet[1,1].should == new_value
+    end
+
+    it "should discard changes and change from read-only to writable with options :forget" do
+      book = Workbook.open(@simple_file1, read_only: true)
+      book.ReadOnly.should be true
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book2 = Workbook.open(@simple_file1, if_unsaved: :forget, read_only: false)
+      book2.ReadOnly.should be false
+      book2.close
+      book3 = Workbook.open(@simple_file1)
+      sheet3 = book3.sheet(1)
+      sheet3[1,1].should == old_value
+      sheet3[1,1].should_not == new_value
+    end
+
+
+    it "should raise error when writable workbook unsaved and trying to reopen workbook read-only by default" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      expect{
+        Workbook.open(@simple_file1, read_only: true)
+      }.to raise_error(WorkbookNotSaved)
+    end
+
+    it "should raise error when writable workbook unsaved and trying to reopen workbook read-only with option :raise" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      expect{
+        Workbook.open(@simple_file1, read_only: true, if_unsaved: :raise)
+      }.to raise_error(WorkbookNotSaved)
+    end
+
+    it "should save changes and change from writable to read-only with option :save" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book2 = Workbook.open(@simple_file1, if_unsaved: :save, read_only: true)
+      book2.should == book
+      book2.ReadOnly.should be true
+      sheet[1,1].should_not == old_value
+      sheet[1,1].should == new_value
+    end
+
+    it "should discard changes and change from writable to read-only with options :forget" do
+      book = Workbook.open(@simple_file1, read_only: false)
+      book.ReadOnly.should be false
+      sheet = book.sheet(1)
+      old_value = sheet[1,1]
+      sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+      new_value = sheet[1,1]
+      book2 = Workbook.open(@simple_file1, if_unsaved: :forget, read_only: true)
+      book2.should == book
+      book2.ReadOnly.should be true
+      book2.close
+      book3 = Workbook.open(@simple_file1)
+      sheet3 = book3.sheet(1)
+      sheet3[1,1].should == old_value
+      sheet3[1,1].should_not == new_value
+    end
+
+    context "with :if_unsaved => :excel or :alert and from read-only to writable" do
+     
+      before do
+        @book = Workbook.open(@simple_file1, v: true, readonly: true)
+        @book.ReadOnly.should be false
+        @sheet = @book.sheet(1)
+        @old_value = @sheet[1,1]
+        @sheet[1,1] = (@sheet[1,1] == "foo" ? "bar" : "foo")
+        @new_value = @sheet[1,1] 
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
+      end
+
+      after do
+        @key_sender.close
+      end
+
+      # question to the user, whether the workbook shall be reopened and discard any changes
+      it "should discard changes and reopen the workbook, if user answers 'yes'" do
+        @key_sender.puts "{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: false, if_unsaved: :excel)
+        book2.ReadOnly.should be false
+        book2.Saved.should be true
+        book2.sheet(1)[1,1].should == @old_value
+        book2.close
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+      it "should not discard changes and reopen the workbook, if user answers 'no'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        # strangely, in the "no" case, the question will sometimes be repeated three times
+        #@book.excel.Visible = true
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: false, if_unsaved: :excel)
+        book2.ReadOnly.should be false
+        book2.Saved.should be false
+        book2.sheet(1)[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+    end
+
+    context "with :if_unsaved => :excel or :alert and from writable to read-only" do
+     
+      before do
+        Excel.kill_all
+        sleep 1
+        @book = Workbook.open(@simple_file1, v: true, readonly: false)
+        @book.ReadOnly.should be false
+        @sheet = @book.sheet(1)
+        @old_value = @sheet[1,1]
+        @sheet[1,1] = (@sheet[1,1] == "foo" ? "bar" : "foo")
+        @new_value = @sheet[1,1] 
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
+      end
+
+      after do
+        @key_sender.close
+      end
+
+      # question to the user, whether to save the changes before changing read-only mode
+      it "should discard changes and reopen the workbook, if user answers 'yes'" do
+        @key_sender.puts "{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be true
+        book2.sheet(1)[1,1].should == @new_value
+        book2.close
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @new_value
+      end
+
+      it "should save the workbook, if user answers 'no' and 'yes'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "Yes"
+        @key_sender.puts "{enter}"
+        @key_sender.puts "{enter}"
+        # another question: asking the user to save the workbook as a copy
+        # so far no automatic key response here
+
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        book2.sheet(1)[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+
+      it "should discard (not save) the workbook, if user answers 'no' and 'no'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "No"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        book2.sheet(1)[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+      it "should not save (discard) changes and not reopen the workbook, if user answers 'no' and 'cancel'" do
+        # "No" is right to "Yes" (the  default). --> language independent
+        @key_sender.puts "{right}{enter}"
+        # 2nd question to the user: whether the workbook shall be reopened and discard any changes 
+        # "No" is right to "Yes" (the  default). --> language independent       
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        @key_sender.puts "{right}{enter}"
+        # 3rd question whether the workbook shall be saved
+        # "Cancel"
+        @key_sender.puts "{right}{right}{enter}"
+        @key_sender.puts "{right}{right}{enter}"
+        @key_sender.puts "{right}{right}{enter}"
+        book2 = Workbook.open(@simple_file1, read_only: true, if_unsaved: :excel)
+        book2.ReadOnly.should be true
+        book2.Saved.should be false
+        book2.sheet(1)[1,1].should == @new_value
+        book2.close(if_unsaved: :forget)
+        book3 = Workbook.open(@simple_file1, if_unsaved: :forget)
+        sheet3 = book3.sheet(1)
+        sheet3[1,1].should == @old_value
+      end
+
+    end
+
+  end
+
   describe "linked workbooks" do
 
     context "standard" do
@@ -88,9 +371,8 @@ describe Workbook do
       end
 
       it "should raise error when trying to change the read-only mode of the linked workbook" do
-        expect{
-          Workbook.open(@sub_file, :read_only => true)
-        }.to raise_error(WorkbookReadOnly, /could not change read-only mode/)
+        book2 = Workbook.open(@sub_file, :read_only => true)
+        book2.ReadOnly.should be true
       end
     end
   end
@@ -396,12 +678,12 @@ describe Workbook do
     it "should raise an WorkbookBlockederror" do
       book1 = Workbook.open(@simple_file_hostname_share_path1)
       expect{
-        Workbook.open(@simple_file_hostname_share_path_other_path1)
+        Workbook.open(@simple_file_hostname_share_other_path1)
       }.to raise_error(WorkbookBlocked)
     end
 
     it "should raise an WorkbookBlockederror" do
-      book1 = Workbook.open(@simple_file_hostname_share_path_other_path1)
+      book1 = Workbook.open(@simple_file_hostname_share_other_path1)
       expect{
         Workbook.open(@simple_file_hostname_share_path1)
       }.to raise_error(WorkbookBlocked)
@@ -415,7 +697,7 @@ describe Workbook do
     end
 
     it "should raise an WorkbookBlockederror" do
-      book1 = Workbook.open(@simple_file_hostname_share_path_other_path1)
+      book1 = Workbook.open(@simple_file_hostname_share_other_path1)
       expect{
         Workbook.open(@simple_file_network_path1)
       }.to raise_error(WorkbookBlocked)
@@ -424,7 +706,7 @@ describe Workbook do
     it "should raise an WorkbookBlockederror" do
       book1 = Workbook.open(@simple_file_network_path1)
       expect{
-        Workbook.open(@simple_file_hostname_share_path_other_path1)
+        Workbook.open(@simple_file_hostname_share_other_path1)
       }.to raise_error(WorkbookBlocked)
     end
 
@@ -572,14 +854,14 @@ describe Workbook do
         abs_filename = General.absolute_path(@simple_file_hostname_share_path1)
         @ole_wb = ws.Open(abs_filename)
         expect{
-          Workbook.open(@simple_file_hostname_share_path_other_path1)
+          Workbook.open(@simple_file_hostname_share_other_path1)
         }.to raise_error(WorkbookBlocked)
       end
 
       it "should raise WorkbookBlocked error" do
         ole_e1 = WIN32OLE.new('Excel.Application')
         ws = ole_e1.Workbooks
-        abs_filename = General.absolute_path(@simple_file_hostname_share_path_other_path1)
+        abs_filename = General.absolute_path(@simple_file_hostname_share_other_path1)
         @ole_wb = ws.Open(abs_filename)
         expect{
           Workbook.open(@simple_file_hostname_share_path1)
@@ -612,14 +894,14 @@ describe Workbook do
         abs_filename = General.absolute_path(@simple_file_network_path1)
         @ole_wb = ws.Open(abs_filename)
         expect{
-          Workbook.open(@simple_file_hostname_share_path_other_path1)
+          Workbook.open(@simple_file_hostname_share_other_path1)
         }.to raise_error(WorkbookBlocked)
       end
 
       it "should raise WorkbookBlocked error" do
         ole_e1 = WIN32OLE.new('Excel.Application')
         ws = ole_e1.Workbooks
-        abs_filename = General.absolute_path(@simple_file_hostname_share_path_other_path1)
+        abs_filename = General.absolute_path(@simple_file_hostname_share_other_path1)
         @ole_wb = ws.Open(abs_filename)
         expect{
           Workbook.open(@simple_file_network_path1)
@@ -902,7 +1184,7 @@ describe Workbook do
         book2 = book1
         book1.close(:if_unsaved => :forget)
         book1.should_not be_alive
-        book1.reopen
+        book1.open
         book1.should be_a Workbook
         book1.should be_alive
         book1.should === book2
@@ -2734,6 +3016,15 @@ describe Workbook do
             old_book.sheet(1)[1,1].should == @old_value
           end
 
+          it "should let the old book open, if :if_obstructed is :accept" do
+            new_book = Workbook.open(@simple_file1, :if_obstructed => :accept)
+            @book.should be_alive
+            new_book.should be_alive
+            new_book.filename.downcase.should == @simple_file_other_path1.downcase
+            old_book = Workbook.open(@simple_file_other_path1, :if_unsaved => :forget)
+            old_book.sheet(1)[1,1].should == @old_value
+          end
+
           it "should save the old book, close it, and open the new book, if :if_obstructed is :save" do
             new_book = Workbook.open(@simple_file1, :if_obstructed => :save)
             @book.should_not be_alive
@@ -3082,7 +3373,7 @@ describe Workbook do
         book1 = @book
         @book.close
         @book.should_not be_alive
-        @book.reopen
+        @book.open
         @book.should be_a Workbook
         @book.should be_alive
         @book.should === book1