robust_excel_ole 1.30 → 1.31

data/spec/list_object_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './spec_helper')
+require_relative 'spec_helper'
 
 $VERBOSE = nil
 
@@ -107,28 +107,93 @@ describe ListObject do
 
   describe "getting and setting values" do
 
-    context "with new table" do
+    context "with various column names" do
+
+      context "with standard" do
+
+        before do
+          @table = Table.new(@sheet, "table_name", [12,1], 3, ["Person1","Win/Sales", "xiq-Xs", "OrderID", "YEAR", "length in m", "Amo%untSal___es"])
+          @table_row1 = @table[1]
+        end
+
+        it "should read and set values via alternative column names" do
+          @table_row1.person1.should be nil
+          @table_row1.person1 = "John"
+          @table_row1.person1.should == "John"
+          @sheet[13,1].Value.should == "John"
+          @table_row1.Person1 = "Herbert"
+          @table_row1.Person1.should == "Herbert"
+          @sheet[13,1].Value.should == "Herbert"
+          @table_row1.win_sales.should be nil
+          @table_row1.win_sales = 42
+          @table_row1.win_sales.should == 42
+          @sheet[13,2].Value.should == 42
+          @table_row1.Win_Sales = 80
+          @table_row1.Win_Sales.should == 80
+          @sheet[13,2].Value.should == 80
+          @table_row1.xiq_xs.should == nil
+          @table_row1.xiq_xs = 90
+          @table_row1.xiq_xs.should == 90
+          @sheet[13,3].Value.should == 90
+          @table_row1.xiq_Xs = 100
+          @table_row1.xiq_Xs.should == 100
+          @sheet[13,3].Value.should == 100
+          @table_row1.order_id.should == nil
+          @table_row1.order_id = 1
+          @table_row1.order_id.should == 1
+          @sheet[13,4].Value.should == 1
+          @table_row1.OrderID = 2
+          @table_row1.OrderID.should == 2
+          @sheet[13,4].Value.should == 2
+          @table_row1.year = 1984
+          @table_row1.year.should == 1984
+          @sheet[13,5].Value.should == 1984
+          @table_row1.YEAR = 2020
+          @table_row1.YEAR.should == 2020
+          @sheet[13,5].Value.should == 2020
+          @table_row1.length_in_m.should == nil
+          @table_row1.length_in_m = 20
+          @table_row1.length_in_m.should == 20
+          @sheet[13,6].Value.should == 20
+          @table_row1.length_in_m = 40
+          @table_row1.length_in_m.should == 40
+          @sheet[13,6].Value.should == 40
+          @table_row1.amo_unt_sal___es.should == nil
+          @table_row1.amo_unt_sal___es = 80
+          @table_row1.amo_unt_sal___es.should == 80
+          @sheet[13,7].Value.should == 80
+        end
 
-      before do
-        @table = Table.new(@sheet, "table_name", [1,1], 3, ["Person","Amo%untSales"])
-        @table_row1 = @table[1]
       end
 
-      it "should read and set values via alternative column names" do
-        @table_row1.person.should be nil
-        @table_row1.person = "John"
-        @table_row1.person.should == "John"
-        @sheet[2,1].Value.should == "John"
-        @table_row1.amount_sales.should be nil
-        @table_row1.amount_sales = 42
-        @table_row1.amount_sales.should == 42
-        @sheet[2,2].Value.should == 42
-        @table_row1.Person = "Herbert"
-        @table_row1.Person.should == "Herbert"
-        @sheet[2,1].Value.should == "Herbert"
-        @table_row1.AmountSales = 80
-        @table_row1.AmountSales.should == 80
-        @sheet[2,2].Value.should == 80
+      context "with umlauts" do
+
+        before do
+          @table = Table.new(@sheet, "table_name", [1,1], 3, ["Verkäufer", "Straße", "area in m²"])
+          @table_row1 = @table[1]
+        end
+
+        it "should read and set values via alternative column names" do
+          @table_row1.verkaeufer.should be nil
+          @table_row1.verkaeufer = "John"
+          @table_row1.verkaeufer.should == "John"
+          @sheet[2,1].Value.should == "John"
+          @table_row1.Verkaeufer = "Herbert"
+          @table_row1.Verkaeufer.should == "Herbert"
+          @sheet[2,1].Value.should == "Herbert"
+          @table_row1.strasse.should be nil
+          @table_row1.strasse = 42
+          @table_row1.strasse.should == 42
+          @sheet[2,2].Value.should == 42
+          @table_row1.Strasse = 80
+          @table_row1.Strasse.should == 80
+          @sheet[2,2].Value.should == 80
+          @table_row1.area_in_m3.should be nil
+          @table_row1.area_in_m3 = 10
+          @table_row1.area_in_m3.should == 10
+          @sheet[2,3].Value.should == 10
+        end
+
       end
 
     end

data/spec/range_spec.rb

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-require File.join(File.dirname(__FILE__), './spec_helper')
+require_relative 'spec_helper'
 
 include RobustExcelOle
 include General
@@ -73,19 +73,6 @@ describe RobustExcelOle::Range do
       end
     end
 
-    it "should work with [] doing cashing synchonized, from #each to #[]" do
-      @range2[0].Value.should == 'simple'
-      @range2[1].Value.should == 'file'
-      @range2[2].Value.should == 'sheet2'
-      i = 0
-      @range2.each do |cell|
-        cell.Value = 'foo' if i == 0
-        cell.Value = 'bar' if i == 1
-        cell.Value = 'simple' if i == 2
-        i += 1
-      end
-    end
-
   end
 
   describe "#values" do

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 require "rspec"
 require 'tmpdir'
 require "fileutils"
-require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+require_relative '../lib/robust_excel_ole'
 
 # @private
 module RobustExcelOle::SpecHelpers

data/spec/workbook_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './spec_helper')
+require_relative 'spec_helper'
 require 'pathname'
 
 $VERBOSE = nil

data/spec/workbook_specs/workbook_all_spec.rb

@@ -1,33 +1,13 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 $VERBOSE = nil
 
-require File.expand_path("workbook_open_spec", File.dirname(__FILE__)) 
-require File.expand_path("workbook_close_spec", File.dirname(__FILE__))
-require File.expand_path("workbook_save_spec", File.dirname(__FILE__))
-require File.expand_path("workbook_misc_spec", File.dirname(__FILE__))
-require File.expand_path("workbook_sheet_spec", File.dirname(__FILE__))
-require File.expand_path("workbook_unobtr_spec", File.dirname(__FILE__))
-require File.expand_path("workbook_subclass_spec", File.dirname(__FILE__))
-
-=begin
-$VERBOSE = nil
-
-include General
-
-unless Object.method_defined?(:require_relative)
-  def require_relative path
-    require File.expand_path(path, File.dirname(__FILE__))  
-  end
-end
-
-require_relative "workbook_open_spec"
-require_relative "workbook_close_spec"
-require_relative "workbook_save_spec"
-require_relative "workbook_misc_spec"
-require_relative "workbook_sheet_spec"
-require_relative "workbook_unobtr_spec"
-require_relative "workbook_subclass_spec"
-=end
+require_relative 'workbook_open_spec'
+require_relative 'workbook_close_spec'
+require_relative 'workbook_save_spec'
+require_relative 'workbook_misc_spec'
+require_relative 'workbook_sheet_spec'
+require_relative 'workbook_unobtr_spec'
+require_relative 'workbook_subclass_spec'

data/spec/workbook_specs/workbook_close_spec.rb

@@ -1,7 +1,7 @@
 
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil

data/spec/workbook_specs/workbook_misc_spec.rb

@@ -1,13 +1,14 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
-
+require_relative '../spec_helper'
 
 $VERBOSE = nil
 
 include RobustExcelOle
 include General
 
+using ToReoRefinement
+
 describe Workbook do
 
   before(:all) do
@@ -24,7 +25,6 @@ describe Workbook do
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
     @another_simple_file = @dir + '/another_workbook.xls'
-    @linked_file = @dir + '/workbook_linked.xlsm'
     @simple_file_xlsm = @dir + '/workbook.xls'
     @simple_file_xlsx = @dir + '/workbook.xlsx'
     @simple_file1 = @simple_file

data/spec/workbook_specs/workbook_open_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil
@@ -24,7 +24,6 @@ describe Workbook do
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
     @another_simple_file = @dir + '/another_workbook.xls'
-    @linked_file = @dir + '/workbook_linked.xlsm'
     @simple_file_xlsm = @dir + '/workbook.xlsm'
     @simple_file_xlsx = @dir + '/workbook.xlsx'
     @simple_file1 = @simple_file
@@ -43,6 +42,10 @@ describe Workbook do
     @simple_file_hostname_share_path_other_path1 = @simple_file_hostname_share_path_other_path
     @simple_file_xlsm1 = @simple_file_xlsm
     @simple_file_xlsx1 = @simple_file_xlsx
+    #@linked_file = @dir + '/workbook_linked.xlsm'
+    #@sub_file = @dir + '/workbook_sub.xlsm'
+    @main_file = @dir + '/workbook_linked3.xlsm'
+    @sub_file = @dir + '/workbook_linked_sub.xlsm'
     @error_message_excel = "provided Excel option value is neither an Excel object nor a valid option"
   end
 
@@ -51,6 +54,45 @@ describe Workbook do
     rm_tmp(@dir)
   end
 
+  describe "linked workbooks" do
+
+    context "standard" do
+
+      before do
+        @book1 = Workbook.open(@main_file)
+      end
+
+      it "should open the main workbook and the linked workbook" do
+        @book1.should be_alive
+        @book1.should be_a Workbook
+        @book1.filename.should == @main_file
+        Excel.current.workbooks.map{|b| b.filename}.should == [@main_file, @sub_file]
+        book2 = Workbook.open(@sub_file)
+        book2.should be_alive
+        book2.should be_a Workbook
+        book2.filename.should == @sub_file
+      end
+
+      it "should close the main workbook" do
+        @book1.close
+        Excel.current.workbooks.map{|b| b.filename}.should == [@sub_file]
+      end
+
+      it "should raise error when trying to close the linked workbook" do
+        book2 = Workbook.open(@sub_file)
+        expect{
+         book2.close
+        }.to raise_error(WorkbookLinked)
+      end
+
+      it "should raise error when trying to change the read-only mode of the linked workbook" do
+        expect{
+          book2 = Workbook.open(@sub_file, :read_only => true)
+        }.to raise_error(WorkbookLinked)
+      end
+    end
+  end
+
   describe "basic tests with xlsx-workbooks" do
 
     context "with simple file" do
@@ -2631,8 +2673,6 @@ describe Workbook do
           @book.should be_alive
         end
 
-        
-
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
           # strangely, in the "no" case, the question will sometimes be repeated three time
@@ -2984,7 +3024,7 @@ describe Workbook do
     context "with various file formats" do
 
       it "should open linked workbook" do
-        book = Workbook.open(@linked_file, :visible => true)
+        book = Workbook.open(@main_file, :visible => true)
         book.close
       end
 

data/spec/workbook_specs/workbook_save_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil

data/spec/workbook_specs/workbook_sheet_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil

data/spec/workbook_specs/workbook_subclass_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 # @private
 module My 

data/spec/workbook_specs/workbook_unobtr_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil
@@ -24,8 +24,10 @@ describe Workbook do
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
     @another_simple_file = @dir + '/another_workbook.xls'
-    @linked_file = @dir + '/workbook_linked.xlsm'
-    @linked_sub_file = @dir + '/workbook_linked_sub.xlsm'
+    #@main_file = @dir + '/workbook_linked.xlsm'
+    #@linked_sub_file = @dir + '/workbook_sub.xlsm'
+    @main_file = @dir + '/workbook_linked3.xlsm'
+    @sub_file = @dir + '/workbook_linked_sub.xlsm'
     @simple_file_xlsm = @dir + '/workbook.xlsm'
     @simple_file_xlsx = @dir + '/workbook.xlsx'
     @simple_file1 = @simple_file
@@ -231,41 +233,7 @@ describe Workbook do
   end
 
   describe "Workbook.for_reading, for_modifying" do
-
-  
-
-    
-      
-        
-        
-      
-      
-        
-      
-          
-        
-        
-      
-        
-      
-
-      
-        
-
-      
-    
       
-      
-          
-      
-        
-      
-  
-  
-      
-
-    
-    
     context "with open writable book" do
 
       before do
@@ -336,56 +304,66 @@ describe Workbook do
  
   end
 
-  describe "with referenced book" do
+  describe "with referenced workbooks" do
 
     context "with no books" do
 
-      it "should open in read-only" do
-        Workbook.unobtrusively(@linked_sub_file, :writable => false) do |book|            
+      it "should open the linked workbook in read-only" do
+        Workbook.unobtrusively(@sub_file, :writable => false) do |book|            
           book.ReadOnly.should be true
-          book.filename.should == @linked_sub_file
+          book.filename.should == @sub_file
         end
+        Excel.current.workbooks.should == [] 
       end
 
-      it "should raise error when trying to change" do
+      it "should open the workbook and its linked workbook in read-only" do
+        Workbook.unobtrusively(@main_file, :writable => false) do |book|            
+          book.ReadOnly.should be true
+          book.filename.should == @main_file
+          book.excel.workbooks.map{|b| b.filename}.should == [@sub_file, @main_file]
+        end
+        Excel.current.workbooks.map{|b| b.filename}.should  == [@sub_file] 
+      end
 
-        expect{
-          Workbook.unobtrusively(@linked_sub_file, :writable => false) do |book|            
-            book.ReadOnly.should be true
-            book.filename.should == @linked_sub_file
-            book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
-          end
-        }.to raise_error(WorkbookReadOnly)
+      it "should not write the linked workbook and close it" do
+        Workbook.unobtrusively(@sub_file, :writable => false) do |book|            
+          book.ReadOnly.should be true
+          book.filename.should == @sub_file
+          @old_value = book.sheet(1)[1,1].Value
+          book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
+        end
+        Excel.current.workbooks.should == [] 
+      end
 
+      it "should not write the main workbook and close the linked file as well" do
+        Workbook.unobtrusively(@main_file, :writable => false) do |book|            
+          book.ReadOnly.should be true
+          book.filename.should == @main_file
+          @old_value = book.sheet(1)[1,1].Value
+          book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
+        end
+        Excel.current.workbooks.map{|b| b.filename}.should == [@sub_file] 
       end
+
     end
 
     context "with open books" do
 
       before do
-        @book_main = Workbook.open(@linked_file)
-        @book_sub = Workbook.open(@linked_sub_file)
+        @book_main = Workbook.open(@main_file)
       end
 
       it "should leave the read-only mode" do
-        Workbook.unobtrusively(@linked_sub_file, :read_only_default => true) do |book|            
+        Workbook.unobtrusively(@sub_file, :read_only_default => true) do |book|            
           book.ReadOnly.should be false
-          book.should == @book_sub
-          book.filename.should == @book_sub.filename
-          book.excel.should == @book_sub.excel
         end
       end
       
       it "should force to read-only" do
         expect{
-          Workbook.unobtrusively(@linked_sub_file, :if_unsaved => :forget, :read_only => true) do |book|            
-            book.ReadOnly.should be true
-            book.should == @book_sub
-            book.filename.should == @book_sub.filename
-            book.excel.should == @book_sub.excel
-            book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
+          Workbook.unobtrusively(@sub_file, :read_only => true) do
           end
-          }.to raise_error(WorkbookReadOnly)
+        }.to raise_error(WorkbookLinked)
       end
     end
   end