robust_excel_ole 1.27 → 1.32

data/spec/workbook_specs/workbook_open_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil
@@ -24,7 +24,6 @@ describe Workbook do
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
     @another_simple_file = @dir + '/another_workbook.xls'
-    @linked_file = @dir + '/workbook_linked.xlsm'
     @simple_file_xlsm = @dir + '/workbook.xlsm'
     @simple_file_xlsx = @dir + '/workbook.xlsx'
     @simple_file1 = @simple_file
@@ -43,6 +42,10 @@ describe Workbook do
     @simple_file_hostname_share_path_other_path1 = @simple_file_hostname_share_path_other_path
     @simple_file_xlsm1 = @simple_file_xlsm
     @simple_file_xlsx1 = @simple_file_xlsx
+    #@linked_file = @dir + '/workbook_linked.xlsm'
+    #@sub_file = @dir + '/workbook_sub.xlsm'
+    @main_file = @dir + '/workbook_linked3.xlsm'
+    @sub_file = @dir + '/workbook_linked_sub.xlsm'
     @error_message_excel = "provided Excel option value is neither an Excel object nor a valid option"
   end
 
@@ -51,6 +54,45 @@ describe Workbook do
     rm_tmp(@dir)
   end
 
+  describe "linked workbooks" do
+
+    context "standard" do
+
+      before do
+        @book1 = Workbook.open(@main_file)
+      end
+
+      it "should open the main workbook and the linked workbook" do
+        @book1.should be_alive
+        @book1.should be_a Workbook
+        @book1.filename.should == @main_file
+        Excel.current.workbooks.map{|b| b.filename}.should == [@main_file, @sub_file]
+        book2 = Workbook.open(@sub_file)
+        book2.should be_alive
+        book2.should be_a Workbook
+        book2.filename.should == @sub_file
+      end
+
+      it "should close the main workbook" do
+        @book1.close
+        Excel.current.workbooks.map{|b| b.filename}.should == [@sub_file]
+      end
+
+      it "should raise error when trying to close the linked workbook" do
+        book2 = Workbook.open(@sub_file)
+        expect{
+         book2.close
+        }.to raise_error(WorkbookLinked)
+      end
+
+      it "should raise error when trying to change the read-only mode of the linked workbook" do
+        expect{
+          book2 = Workbook.open(@sub_file, :read_only => true)
+        }.to raise_error(WorkbookLinked)
+      end
+    end
+  end
+
   describe "basic tests with xlsx-workbooks" do
 
     context "with simple file" do
@@ -96,7 +138,7 @@ describe Workbook do
           book.should be_alive
           book.should be_a Workbook
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
         end
       end
     end
@@ -192,7 +234,7 @@ describe Workbook do
           book.should be_alive
           book.should be_a Workbook
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
         end
       end
     end
@@ -273,6 +315,17 @@ describe Workbook do
       bookstore = Bookstore.new
     end
 
+    it "should fetch a network path file given a not via Reo opened hostname share file" do
+      ole_e1 = WIN32OLE.new('Excel.Application')
+      ws = ole_e1.Workbooks
+      abs_filename = General.absolute_path(@simple_file_hostname_share_path)
+      @ole_wb = ws.Open(abs_filename)
+      book2 = Workbook.open(@simple_file_network_path)
+      #book2.should === @ole_wb.to_reo
+      book2.Fullname.should == @ole_wb.Fullname
+      book2.excel.Workbooks.Count.should == 1
+    end
+
     it "should fetch a network path file given a hostname share file" do
       book1 = Workbook.open(@simple_file_hostname_share_path)
       book2 = Workbook.open(@simple_file_network_path)
@@ -398,7 +451,7 @@ describe Workbook do
           book.filename.should == @simple_file_network_path1
           book.Fullname.should == @ole_wb.Fullname
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
           book.excel.Workbooks.Count.should == 1
         end
       end
@@ -414,7 +467,7 @@ describe Workbook do
           book.filename.should == @simple_file_hostname_share_path1.downcase
           book.Fullname.should == @ole_wb.Fullname
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
           book.excel.Workbooks.Count.should == 1
         end
       end
@@ -470,7 +523,7 @@ describe Workbook do
           book.filename.should == @simple_file_network_path1
           book.Fullname.should == @ole_wb.Fullname
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
           book.excel.Workbooks.Count.should == 1
         end
       end
@@ -486,7 +539,7 @@ describe Workbook do
           book.filename.should == @simple_file_hostname_share_path1.downcase
           book.Fullname.should == @ole_wb.Fullname
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
           book.excel.Workbooks.Count.should == 1
         end
       end      
@@ -584,11 +637,11 @@ describe Workbook do
 
       it "should connect to an unknown hostname share path workbook" do
         Workbook.open(@simple_file_hostname_share_path1) do |book|
-          book.filename.should == @simple_file_hostname_share_path1.downcase
+          book.filename.should == @simple_file_network_path1
           book.should be_alive
           book.should be_a Workbook
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
           book.excel.Workbooks.Count.should == 1
         end
       end
@@ -607,7 +660,7 @@ describe Workbook do
         book1 = Workbook.open(@simple_file1)
         book1.should be_alive
         book1.should be_a Workbook
-        Excel.excels_number.should == 1
+        Excel.instance_count.should == 1
         book1.ReadOnly.should be false
         book1.excel.Visible.should be false
         book1.CheckCompatibility.should be true
@@ -626,7 +679,7 @@ describe Workbook do
         book1.should be_alive
         book1.should be_a Workbook
         book1.excel.should == excel1
-        Excel.excels_number.should == 1        
+        Excel.instance_count.should == 1        
         book1.excel.Visible.should be false
       end
 
@@ -636,7 +689,7 @@ describe Workbook do
         book1.should be_alive
         book1.should be_a Workbook
         book1.excel.should == excel1
-        Excel.excels_number.should == 1        
+        Excel.instance_count.should == 1        
         book1.excel.Visible.should be true
       end
 
@@ -646,7 +699,7 @@ describe Workbook do
         book1.should be_alive
         book1.should be_a Workbook
         book1.excel.should_not == excel1
-        Excel.excels_number.should == 2        
+        Excel.instance_count.should == 2        
       end
 
       it "should set the options in a given known Excel" do
@@ -661,7 +714,7 @@ describe Workbook do
         book1 = Workbook.open(@simple_file1)
         book1.should be_alive
         book1.should be_a Workbook
-        Excel.excels_number.should == 1
+        Excel.instance_count.should == 1
         book1.excel.ole_excel.Hwnd.should == ole_excel1.Hwnd
       end
 
@@ -682,7 +735,7 @@ describe Workbook do
           book.should be_alive
           book.should be_a Workbook
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
-          Excel.excels_number.should == 1
+          Excel.instance_count.should == 1
         end
       end
 
@@ -762,7 +815,7 @@ describe Workbook do
         Workbook.open(@simple_file1) do |book|
           book.filename.should == @simple_file1
           book.excel.ole_excel.Hwnd.should == @ole_wb1.Application.Hwnd
-          Excel.excels_number.should == 2
+          Excel.instance_count.should == 2
         end
       end
 
@@ -770,7 +823,7 @@ describe Workbook do
         Workbook.open(@different_file1) do |book|
           book.filename.should == @different_file1
           book.excel.ole_excel.Hwnd.should == @ole_wb2.Application.Hwnd
-          Excel.excels_number.should == 2
+          Excel.instance_count.should == 2
         end
       end
 
@@ -859,9 +912,9 @@ describe Workbook do
       before do
         @book = Workbook.open(@simple_file1, :if_unsaved => :accept)
         sheet = @book.sheet(1)
-        @old_value = sheet[1,1].Value
-        sheet[1,1] = (sheet[1,1].Value == "foo" ? "bar" : "foo")
-        @new_value = sheet[1,1].Value
+        @old_value = sheet[1,1]
+        sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+        @new_value = sheet[1,1]
         @book.Saved.should be false
       end
 
@@ -875,7 +928,7 @@ describe Workbook do
         new_book.should be_alive
         new_book.Saved.should be false      
         @book.Saved.should be false  
-        new_book.sheet(1)[1,1].Value.should == @new_value
+        new_book.sheet(1)[1,1].should == @new_value
         new_book.should == @book
       end
 
@@ -2546,7 +2599,7 @@ describe Workbook do
 
     it "should new_excel" do
       book = Workbook.open(@simple_file1)
-      book.sheet(1)[1,1].Value = "foo"
+      book.sheet(1)[1,1] = "foo"
       book.Saved.should be false
       book2 = Workbook.open(@simple_file1, :if_unsaved => :new_excel)
     end
@@ -2614,24 +2667,24 @@ describe Workbook do
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
-          expect{
+          #expect{
             Workbook.open(@simple_file, :if_unsaved => :alert)    
-            }.to raise_error(UnexpectedREOError)
+          #  }.to raise_error(UnexpectedREOError)
           @book.should be_alive
+          @book.Saved.should be false
         end
 
-        
-
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
           # strangely, in the "no" case, the question will sometimes be repeated three time
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
-          expect{
+          #expect{
             Workbook.open(@simple_file, :if_unsaved => :excel)
-          }.to raise_error(UnexpectedREOError)
+          #}.to raise_error(UnexpectedREOError)
           @book.should be_alive
+          @book.Saved.should be false
         end
 
       end
@@ -2653,9 +2706,9 @@ describe Workbook do
             #@sheet_count = @book.ole_workbook.Worksheets.Count
             sheet = @book.sheet(1)
             #@book.add_sheet(@sheet, :as => 'a_name')
-            @old_value = sheet[1,1].Value
-            sheet[1,1] = (sheet[1,1].Value == "foo" ? "bar" : "foo")
-            @new_value = sheet[1,1].Value
+            @old_value = sheet[1,1]
+            sheet[1,1] = (sheet[1,1] == "foo" ? "bar" : "foo")
+            @new_value = sheet[1,1]
             @book.Saved.should be false
           end
 
@@ -2676,7 +2729,7 @@ describe Workbook do
             new_book.should be_alive
             new_book.filename.downcase.should == @simple_file.downcase
             old_book = Workbook.open(@simple_file_other_path1, :if_obstructed => :forget)
-            old_book.sheet(1)[1,1].Value.should == @old_value
+            old_book.sheet(1)[1,1].should == @old_value
           end
 
           it "should save the old book, close it, and open the new book, if :if_obstructed is :save" do
@@ -2685,7 +2738,7 @@ describe Workbook do
             new_book.should be_alive
             new_book.filename.downcase.should == @simple_file1.downcase
             old_book = Workbook.open(@simple_file_other_path1, :if_obstructed => :forget)
-            old_book.sheet(1)[1,1].Value.should == @new_value
+            old_book.sheet(1)[1,1].should == @new_value
             #old_book.ole_workbook.Worksheets.Count.should ==  @sheet_count + 1
             old_book.close
           end
@@ -2701,7 +2754,7 @@ describe Workbook do
             new_book.should be_alive
             new_book.filename.downcase.should == @simple_file1.downcase
             old_book = Workbook.open(@simple_file_other_path1, :if_obstructed => :forget)
-            old_book.sheet(1)[1,1].Value.should == @new_value
+            old_book.sheet(1)[1,1].should == @new_value
             #old_book.ole_workbook.Worksheets.Count.should ==  @sheet_count + 1
             old_book.close
           end
@@ -2716,11 +2769,11 @@ describe Workbook do
             new_book = Workbook.open(@simple_file1, :if_obstructed => :new_excel)
             @book.should be_alive
             @book.Saved.should be false
-            @book.sheet(1)[1,1].Value.should == @new_value
+            @book.sheet(1)[1,1].should == @new_value
             new_book.should be_alive
             new_book.filename.should_not == @book.filename
             new_book.excel.should_not == @book.excel
-            new_book.sheet(1)[1,1].Value.should == @book.sheet(1)[1,1].Value
+            new_book.sheet(1)[1,1].should == @book.sheet(1)[1,1]
           end
 
           it "should raise an error, if :if_obstructed is default" do
@@ -2866,8 +2919,8 @@ describe Workbook do
         book.ReadOnly.should be true
         book.should be_alive
         sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        old_cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         book.Saved.should be false
         expect{
           new_book = Workbook.open(@simple_file1, :read_only => false, :if_unsaved => :accept)
@@ -2879,8 +2932,8 @@ describe Workbook do
         book.ReadOnly.should be false
         book.should be_alive
         sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        old_cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         book.Saved.should be false
         expect{
           new_book = Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :accept)
@@ -2892,8 +2945,8 @@ describe Workbook do
         book.ReadOnly.should be true
         book.should be_alive
         sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        old_cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         book.Saved.should be false
         new_book = Workbook.open(@simple_file1, :read_only => false, :if_unsaved => :forget)
         new_book.ReadOnly.should be false 
@@ -2901,7 +2954,7 @@ describe Workbook do
         book.should_not be_alive   
         new_book.should_not == book 
         new_sheet = new_book.sheet(1)
-        new_cell_value = new_sheet[1,1].Value
+        new_cell_value = new_sheet[1,1]
         new_cell_value.should == old_cell_value
       end
 
@@ -2910,8 +2963,8 @@ describe Workbook do
         book.ReadOnly.should be false
         book.should be_alive
         sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value        
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        old_cell_value = sheet[1,1]        
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         book.Saved.should be false
         expect{
           Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :accept)
@@ -2923,13 +2976,13 @@ describe Workbook do
         book.ReadOnly.should be false
         book.should be_alive
         sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value        
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        old_cell_value = sheet[1,1]        
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         book.Saved.should be false
         new_book = Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :save)
         new_book.ReadOnly.should be true
         new_sheet = new_book.sheet(1)
-        new_cell_value = new_sheet[1,1].Value
+        new_cell_value = new_sheet[1,1]
         new_cell_value.should_not == old_cell_value
       end
 
@@ -2973,7 +3026,7 @@ describe Workbook do
     context "with various file formats" do
 
       it "should open linked workbook" do
-        book = Workbook.open(@linked_file, :visible => true)
+        book = Workbook.open(@main_file, :visible => true)
         book.close
       end
 

data/spec/workbook_specs/workbook_save_spec.rb

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-require File.join(File.dirname(__FILE__), './../spec_helper')
+require_relative '../spec_helper'
 
 
 $VERBOSE = nil
@@ -213,8 +213,8 @@ describe Workbook do
           file.puts "garbage"
         end
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false
         @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_blocked => :forget)
         @book.should_not be_alive
@@ -225,7 +225,7 @@ describe Workbook do
         new_book.close
         old_book = Workbook.open(@simple_file1)
         old_sheet = old_book.sheet(1)
-        old_sheet[1,1].Value.should == cell_value
+        old_sheet[1,1].should == cell_value
         old_book.close
       end
 
@@ -235,8 +235,8 @@ describe Workbook do
           file.puts "garbage"
         end
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false
         @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_blocked => :save)
         @book.should_not be_alive
@@ -247,7 +247,7 @@ describe Workbook do
         new_book.close
         old_book = Workbook.open(@simple_file1)
         old_sheet = old_book.sheet(1)
-        old_sheet[1,1].Value.should_not == cell_value
+        old_sheet[1,1].should_not == cell_value
         old_book.close
       end
 
@@ -268,8 +268,8 @@ describe Workbook do
 
       it "should raise an error if the blocking workbook was unsaved with :if_blocked => :close_if_saved" do
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false      
         expect{
           @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_blocked => :close_if_saved)
@@ -363,8 +363,8 @@ describe Workbook do
           file.puts "garbage"
         end
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false
         @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_obstructed => :forget)
         @book.should_not be_alive
@@ -375,7 +375,7 @@ describe Workbook do
         new_book.close
         old_book = Workbook.open(@simple_file1)
         old_sheet = old_book.sheet(1)
-        old_sheet[1,1].Value.should == cell_value
+        old_sheet[1,1].should == cell_value
         old_book.close
       end
 
@@ -385,8 +385,8 @@ describe Workbook do
           file.puts "garbage"
         end
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false
         @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_obstructed => :save)
         @book.should_not be_alive
@@ -397,7 +397,7 @@ describe Workbook do
         new_book.close
         old_book = Workbook.open(@simple_file1)
         old_sheet = old_book.sheet(1)
-        old_sheet[1,1].Value.should_not == cell_value
+        old_sheet[1,1].should_not == cell_value
         old_book.close
       end
 
@@ -418,8 +418,8 @@ describe Workbook do
 
       it "should raise an error if the blocking workbook was unsaved with :if_blocked => :close_if_saved" do
         sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        cell_value = sheet[1,1]
+        sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
         @book.Saved.should be false      
         expect{
           @book2.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_obstructed => :close_if_saved)
@@ -509,12 +509,12 @@ describe Workbook do
 
         it "should simple save if file name is equal to the old one with :if_exists => :overwrite" do
           sheet = @book.sheet(1)
-          sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
-          new_value = sheet[1,1].Value
+          sheet[1,1] = sheet[1,1] == "foo" ? "bar" : "foo"
+          new_value = sheet[1,1]
           @book.save_as(@simple_file1, :if_exists => :overwrite)
           new_book = Workbook.open(@simple_file1)
           new_sheet = new_book.sheet(1)
-          new_sheet[1,1].Value.should == new_value
+          new_sheet[1,1].should == new_value
           new_book.close
         end
 
@@ -550,8 +550,8 @@ describe Workbook do
           it "should save if user answers 'yes'" do
             # "Yes" is to the left of "No", which is the  default. --> language independent
             @key_sender.puts "{right}{right}{right}{enter}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
-            #@key_sender.puts "{left}{enter}"
-            #@key_sender.puts "{left}{enter}"
+            @key_sender.puts "{left}{enter}"
+            @key_sender.puts "{left}{enter}"
             @book.save_as(@simple_save_file1, :if_exists => :alert)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should > @garbage_length
@@ -683,4 +683,3 @@ describe Workbook do
     end
   end
 end
-