robust_excel_ole 1.11 → 1.12

data/spec/workbook_specs/workbook_misc_spec.rb

@@ -198,6 +198,7 @@ describe Workbook do
     end
   end
 
+=begin
   describe "default-visible" do
 
     it "should keep the visibility of the open workbook" do
@@ -288,28 +289,28 @@ describe Workbook do
       excel2 = book1.excel
       excel2.should == excel1
       excel2.Visible.should be false
-      book2.Windows(book2.Name).Visible.should be true
+      book2.Windows(book2.Name).Visible.should be true      
     end
 
     it "should open the workbook visible if the workbook is new" do
       book1 = Workbook.open(@simple_file1, :default => {:visible => true})
-      book1.visible.should be true
       book1.excel.Visible.should be true
       book1.Windows(book1.Name).Visible.should be true
+      book1.visible.should be true      
     end
 
     it "should open the workbook invisible if the workbook is new" do
       book1 = Workbook.open(@simple_file1, :default => {:visible => false})
-      book1.visible.should be false
       book1.excel.Visible.should be false
       book1.Windows(book1.Name).Visible.should be false
+      book1.visible.should be false      
     end
 
     it "should open the workbook invisible per default if the workbook is new" do
       book1 = Workbook.open(@simple_file1)
-      book1.visible.should be false
       book1.excel.Visible.should be false
       book1.Windows(book1.Name).Visible.should be true
+      book1.visible.should be false      
     end
 
     it "should open the workbook visible if the old Excel is closed" do
@@ -322,9 +323,9 @@ describe Workbook do
       excel1.close
       book2 = Workbook.open(@simple_file1, :default => {:visible => true})
       excel2 = book2.excel
-      book2.visible.should be true
-      excel2.Visible.should be true
       book1.Windows(book1.Name).Visible.should be true
+      excel2.Visible.should be true  
+      book2.visible.should be true
     end
 
     it "should open the workbook invisible if the old Excel is closed" do
@@ -337,13 +338,15 @@ describe Workbook do
       excel1.close
       book2 = Workbook.open(@simple_file1, :default => {:visible => false})
       excel2 = book2.excel
-      book2.visible.should be false
       excel2.Visible.should be false
       book1.Windows(book1.Name).Visible.should be false
+      book2.visible.should be false      
     end
 
   end
 
+=end
+
   describe "force-visible" do
 
     it "should change the visibility of the workbooks" do
@@ -386,7 +389,7 @@ describe Workbook do
     it "should set :visible to false" do
       book1 = Workbook.open(@simple_file, :visible => false)
       book1.excel.Visible.should be false
-      book1.Windows(book1.Name).Visible.should be false
+      book1.Windows(book1.Name).Visible.should be true
       book1.visible.should be false
     end
 
@@ -418,7 +421,7 @@ describe Workbook do
       excel1 = Excel.create
       book1 = Workbook.open(@simple_file, :visible => false)
       book1.excel.Visible.should be false
-      book1.Windows(book1.Name).Visible.should be false
+      book1.Windows(book1.Name).Visible.should be true
       book1.visible.should be false
     end
 
@@ -469,7 +472,7 @@ describe Workbook do
       book1 = Workbook.open(@simple_file)
       book2 = Workbook.open(@different_file, :default_excel => :new, :visible => false)
       book2.excel.Visible.should be false
-      book2.Windows(book2.Name).Visible.should be false
+      book2.Windows(book2.Name).Visible.should be true
       book2.visible.should be false
     end
 
@@ -667,7 +670,7 @@ describe Workbook do
     end
   end
 
-  describe "nameval, set_nameval, [], []=" do
+  describe "namevalue_glob, set_namevalue_glob, [], []=" do
   
     before do
       @book1 = Workbook.open(@another_simple_file)
@@ -727,10 +730,10 @@ describe Workbook do
       @book1.namevalue_glob("foo", :default => 1).should == 1
       expect {
           @book1.set_namevalue_glob("foo","bar")
-      }.to raise_error(NameNotFound, /name "foo" not in #<Workbook: another_workbook/)
+      }.to raise_error(RangeNotEvaluatable, /cannot assign value to range named "foo"/)
       expect {
           @book1["foo"] = "bar"
-      }.to raise_error(NameNotFound, /name "foo" not in #<Workbook: another_workbook/)
+      }.to raise_error(RangeNotEvaluatable, /cannot assign value to range named "foo"/)
       @book1.namevalue_glob("empty", :default => 1).should be_nil
     end    
 
@@ -754,7 +757,7 @@ describe Workbook do
       @book1.namevalue_glob("localname").should == "simple"
     end
 
-    it "should color the cell" do
+    it "should color the cell (deprecated)" do
       @book1.set_namevalue_glob("new", "bar")
       @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == -4142
       @book1.set_namevalue_glob("new", "bar", :color => 4)
@@ -768,7 +771,20 @@ describe Workbook do
       #book2.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 42
     end
 
-    it "should save without color" do
+    it "should color the cell" do
+      @book1.set_namevalue_glob("new", "bar")
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == -4142
+      @book1.color_if_modified = 4
+      @book1.set_namevalue_glob("new", "bar")
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 4
+      @book1["new"].should == "bar"
+      @book1["new"] = "bar"
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 42
+      @book1.save
+      @book1.close
+    end
+
+    it "should save without color (deprecated)" do
       @book1.set_namevalue_glob("new", "bar", :color => 4)
       @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 4
       @book1.save(:discoloring => true)
@@ -916,7 +932,7 @@ describe Workbook do
         excel1 = Excel.new(:reuse => false, :visible => false)
         book1 = Workbook.open(@simple_file, :visible => false)
         excel1.Visible.should be false
-        book1.Windows(book1.Name).Visible.should be false
+        book1.Windows(book1.Name).Visible.should be true
         book1.visible.should be false
       end
 
@@ -985,7 +1001,7 @@ describe Workbook do
         excel1 = Excel.new(:reuse => false, :visible => false)
         book1 = Workbook.open(@simple_file, :visible => false)
         excel1.Visible.should be false
-        book1.Windows(book1.Name).Visible.should be false
+        book1.Windows(book1.Name).Visible.should be true
         book1.visible.should be false
         excel1.visible = true
         book2 = Workbook.open(@different_file)
@@ -1035,7 +1051,7 @@ describe Workbook do
         @book2.visible = false
         @book2.Saved.should be true
         @book2.excel.Visible.should be false
-        @book2.Windows(@book2.Name).Visible.should be false
+        @book2.Windows(@book2.Name).Visible.should be true
         @book2.visible.should be false
       end
 

data/spec/workbook_specs/workbook_open_spec.rb

@@ -32,7 +32,9 @@ describe Workbook do
     @simple_file_other_path1 = @simple_file_other_path
     @another_simple_file1 = @another_simple_file
     @simple_file_direct = File.join(File.dirname(__FILE__), 'data') + '/workbook.xls'
-    @simple_file_via_network = File.join('N:/', 'data') + '/workbook.xls'
+    #@simple_file_via_network = File.join('N:/', 'data') + '/workbook.xls'
+    @simple_file_network_path = "N:/data/workbook.xls"
+    @simple_file_hostname_share_path = '//DESKTOP-A3C5CJ6/spec/data/workbook.xls'
 
   end
 
@@ -43,7 +45,7 @@ describe Workbook do
 
   describe "connecting to unknown workbooks" do
 
-     context "with none workbook" do
+    context "with none workbook" do
 
       it "should open one new Excel with the worbook" do
         book1 = Workbook.open(@simple_file1)
@@ -114,7 +116,7 @@ describe Workbook do
       before do
         ole_e1 = WIN32OLE.new('Excel.Application')
         ws = ole_e1.Workbooks
-        abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+        abs_filename = General.absolute_path(@simple_file1)
         @ole_wb = ws.Open(abs_filename)
       end
 
@@ -124,6 +126,7 @@ describe Workbook do
           book.should be_alive
           book.should be_a Workbook
           book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
+          Excel.excels_number.should == 1
         end
       end
 
@@ -150,6 +153,18 @@ describe Workbook do
           }.to raise_error(WorkbookNotSaved, /workbook is already open but not saved: "workbook.xls"/)
       end
 
+      it "should let the workbook open, if :if_unsaved is :save" do        
+        @ole_wb.Worksheets.Add
+        sheet_num = @ole_wb.Worksheets.Count
+        new_book = Workbook.open(@simple_file1, :if_unsaved => :save)
+        new_book.should be_alive
+        new_book.should be_a Workbook
+        new_book.Worksheets.Count.should == sheet_num
+        new_book.close
+        new_book2 = Workbook.open(@simple_file1)
+        new_book2.Worksheets.Count.should == sheet_num
+      end
+
       it "should let the workbook open, if :if_unsaved is :accept" do        
         @ole_wb.Worksheets.Add
         sheet_num = @ole_wb.Worksheets.Count
@@ -157,6 +172,10 @@ describe Workbook do
         new_book.should be_alive
         new_book.should be_a Workbook
         new_book.Worksheets.Count.should == sheet_num
+        new_book.Saved.should be false
+        new_book.close(:if_unsaved => :forget)
+        new_book2 = Workbook.open(@simple_file1)
+        new_book2.Worksheets.Count.should == sheet_num - 1
       end
 
       it "should close the workbook, if :if_unsaved is :forget" do        
@@ -175,11 +194,11 @@ describe Workbook do
       before do
         ole_e1 = WIN32OLE.new('Excel.Application')
         ws1 = ole_e1.Workbooks
-        abs_filename1 = General.absolute_path(@simple_file1).tr('/','\\')
+        abs_filename1 = General.absolute_path(@simple_file1)
         @ole_wb1 = ws1.Open(abs_filename1)
         ole_e2 = WIN32OLE.new('Excel.Application')
         ws2 = ole_e2.Workbooks
-        abs_filename2 = General.absolute_path(@different_file1).tr('/','\\')
+        abs_filename2 = General.absolute_path(@different_file1)
         @ole_wb2 = ws2.Open(abs_filename2)
       end
 
@@ -187,6 +206,7 @@ describe Workbook do
         Workbook.open(@simple_file1) do |book|
           book.filename.should == @simple_file1
           book.excel.ole_excel.Hwnd.should == @ole_wb1.Application.Hwnd
+          Excel.excels_number.should == 2
         end
       end
 
@@ -194,13 +214,12 @@ describe Workbook do
         Workbook.open(@different_file1) do |book|
           book.filename.should == @different_file1
           book.excel.ole_excel.Hwnd.should == @ole_wb2.Application.Hwnd
+          Excel.excels_number.should == 2
         end
       end
 
     end
 
-
-
   end
 
   describe "with already open Excel instances and an open unsaved workbook" do
@@ -209,7 +228,7 @@ describe Workbook do
       @ole_excel1 = WIN32OLE.new('Excel.Application')
       @ole_excel2 = WIN32OLE.new('Excel.Application')
       #@ole_workbook1 = @ole_excel1.Workbooks.Open(@simple_file1, { 'ReadOnly' => false })
-      abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+      abs_filename = General.absolute_path(@simple_file1)
       @ole_workbook1 = @ole_excel1.Workbooks.Open(abs_filename, nil, false)
       @ole_workbook1.Worksheets.Add
     end
@@ -332,6 +351,14 @@ describe Workbook do
 
     context "with :force => {:excel}" do
 
+      it "should raise if excel is not alive" do
+        excel1 = Excel.create
+        excel1.close
+        expect{
+          book1 = Workbook.open(@simple_file1, :force => {:excel => excel1})
+          }.to raise_error(ExcelREOError, "excel is not alive")
+      end
+
       it "should open in a provided Excel" do
         book1 = Workbook.open(@simple_file1, :force => {:excel => :new})
         book2 = Workbook.open(@simple_file1, :force => {:excel => :new})
@@ -354,11 +381,9 @@ describe Workbook do
 
   describe "network paths" do
 
-    it "should open the workbokk via network path" do
-      book1 = Workbook.open(@simple_file)
-      expect{
-        book2 = Workbook.open(@simple_file_via_network)
-      }.to_not raise_error
+    it "should open the workbook via network path" do
+      book1 = Workbook.open(@simple_file_hostname_share_path)
+      book2 = Workbook.open(@simple_file_network_path)
       book1.should === book2
       book1.Fullname.should == book2.Fullname
     end
@@ -371,7 +396,7 @@ describe Workbook do
 
       before do
         @book = Workbook.open(@simple_file1)        
-        abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+        abs_filename = General.absolute_path(@simple_file1)
         @ole_book = WIN32OLE.connect(abs_filename)
       end
 
@@ -387,7 +412,7 @@ describe Workbook do
 
       it "should yield different Workbook objects for different Excel books" do
         book3 = Workbook.open(@different_file1)
-        abs_filename2 = General.absolute_path(@different_file1).tr('/','\\')
+        abs_filename2 = General.absolute_path(@different_file1)
         ole_book2 = WIN32OLE.connect(abs_filename2)
         book2 = Workbook.new(ole_book2)
         book2.should_not === @book
@@ -483,7 +508,7 @@ describe Workbook do
     it "should uplift an open unknown workbook" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
-      abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+      abs_filename = General.absolute_path(@simple_file1)
       ole_workbook = ws.Open(abs_filename)
       new_book = Workbook.new(ole_workbook)
       new_book.Fullname.should == ole_workbook.Fullname
@@ -493,7 +518,7 @@ describe Workbook do
     it "should uplift an open unknown workbook and make it visible" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
-      abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+      abs_filename = General.absolute_path(@simple_file1)
       ole_workbook = ws.Open(abs_filename)
       new_book = Workbook.new(ole_workbook, :visible => true)
       new_book.Fullname.should == ole_workbook.Fullname
@@ -505,7 +530,7 @@ describe Workbook do
     it "should uplift an open unknown workbook and make it visible and readonly" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
-      abs_filename = General.absolute_path(@simple_file1).tr('/','\\')
+      abs_filename = General.absolute_path(@simple_file1)
       ole_workbook = ws.Open(abs_filename)
       new_book = Workbook.new(ole_workbook, :visible => true)
       new_book.Fullname.should == ole_workbook.Fullname
@@ -607,22 +632,22 @@ describe Workbook do
       end
 
       it "should fetch the workbook" do
-        workbook = @book.ole_workbook
-        new_book = Workbook.new(workbook)
+        ole_workbook = @book.ole_workbook
+        new_book = Workbook.new(ole_workbook)
         new_book.should be_a Workbook
         new_book.should be_alive
         new_book.should == @book
         new_book.filename.should == @book.filename
         new_book.excel.should == @book.excel
         new_book.excel.Visible.should be false
-        new_book.excel.DisplayAlerts.should be false
+        #new_book.excel.DisplayAlerts.should be false
         new_book.should === @book
         new_book.close
       end
 
       it "should fetch the workbook" do
-        workbook = @book.ole_workbook
-        new_book = Workbook.new(workbook, :visible => true)
+        ole_workbook = @book.ole_workbook
+        new_book = Workbook.new(ole_workbook, :visible => true)
         new_book.should be_a Workbook
         new_book.should be_alive
         new_book.should == @book
@@ -635,8 +660,8 @@ describe Workbook do
       end
 
       it "should yield an identical Workbook and set visible value" do
-        workbook = @book.ole_workbook
-        new_book = Workbook.new(workbook, :visible => true)
+        ole_workbook = @book.ole_workbook
+        new_book = Workbook.new(ole_workbook, :visible => true)
         new_book.excel.displayalerts = true
         new_book.should be_a Workbook
         new_book.should be_alive
@@ -703,6 +728,26 @@ describe Workbook do
         book2.close
       end
 
+      it "should yield identical Workbook objects for identical Excel books when reopening with current excel" do
+        @book.should be_alive
+        @book.close
+        @book.should_not be_alive
+        book2 = Workbook.open(@simple_file1, :default => {:excel => :current})
+        book2.should === @book
+        book2.should be_alive
+        book2.close
+      end
+
+      it "should yield identical Workbook objects for identical Excel books when reopening with current excel" do
+        @book.should be_alive
+        @book.close
+        @book.should_not be_alive
+        book2 = Workbook.open(@simple_file1, :force => {:excel => :current})
+        book2.should === @book
+        book2.should be_alive
+        book2.close
+      end
+
       it "should yield identical Workbook objects when reopening and the Excel is closed" do
         @book.should be_alive
         @book.close
@@ -887,14 +932,14 @@ describe Workbook do
         book4.should be_alive
         book4.should be_a Workbook
         book4.excel.should == book2.excel
-        #book4.Readonly.should == true
+        book4.Readonly.should == true
         book4.should_not == book2 
         book4.close
         book5 = Workbook.open(@simple_file1, :force => {:excel => book2})
         book5.should be_alive
         book5.should be_a Workbook
         book5.excel.should == book2.excel
-        #book5.Readonly.should == true
+        book5.Readonly.should == true
         book5.should_not == book2 
         book5.close
         book3.close
@@ -1043,14 +1088,14 @@ describe Workbook do
         book4.should be_alive
         book4.should be_a Workbook
         book4.excel.should == book2.excel
-        #book4.Readonly.should == true
+        book4.Readonly.should == true
         book4.should_not == book2 
         book4.close
         book5 = Workbook.open(@simple_file1, :excel => book2)
         book5.should be_alive
         book5.should be_a Workbook
         book5.excel.should == book2.excel
-        #book5.Readonly.should == true
+        book5.Readonly.should == true
         book5.should_not == book2 
         book5.close
         book3.close
@@ -1201,14 +1246,14 @@ describe Workbook do
         book4.should be_alive
         book4.should be_a Workbook
         book4.excel.should == book2.excel
-        #book4.Readonly.should == false
+        book4.Readonly.should == true
         book4.should_not == book2 
         book4.close
         book5 = Workbook.open(@simple_file1, :force_excel => book2)
         book5.should be_alive
         book5.should be_a Workbook
         book5.excel.should == book2.excel
-        #book5.Readonly.should == false
+        book5.Readonly.should == true
         book5.should_not == book2 
         book5.close
         book3.close
@@ -1920,6 +1965,7 @@ describe Workbook do
         @book = Workbook.open(@simple_file)
         @sheet = @book.sheet(1)
         @book.add_sheet(@sheet, :as => 'a_name')
+        @book.visible = true
       end
 
       after do
@@ -1953,13 +1999,22 @@ describe Workbook do
 
         it "should open the new book and close the unsaved book, if user answers 'yes'" do
           # "Yes" is the  default. --> language independent
-          @key_sender.puts "{enter}"
+          #@key_sender.puts "{enter}"
           @new_book = Workbook.open(@simple_file1, :if_unsaved => :alert)
           @new_book.should be_alive
           @new_book.filename.downcase.should == @simple_file1.downcase
           @book.should_not be_alive
         end
 
+        it "should open the new book and close the unsaved book, if user answers 'yes'" do
+          # "Yes" is the  default. --> language independent
+          @key_sender.puts "{enter}"
+          @new_book = Workbook.open(@simple_file1, :if_unsaved => :excel)
+          @new_book.should be_alive
+          @new_book.filename.downcase.should == @simple_file1.downcase
+          @book.should_not be_alive
+        end
+
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
           # strangely, in the "no" case, the question will sometimes be repeated three times
@@ -1973,19 +2028,11 @@ describe Workbook do
           @book.should be_alive
         end
 
-        it "should open the new book and close the unsaved book, if user answers 'yes'" do
-          # "Yes" is the  default. --> language independent
-          @key_sender.puts "{enter}"
-          @new_book = Workbook.open(@simple_file1, :if_unsaved => :excel)
-          @new_book.should be_alive
-          @new_book.filename.downcase.should == @simple_file1.downcase
-          #@book.should_not be_alive
-        end
+        
 
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
-          # strangely, in the "no" case, the question will sometimes be repeated three times
-          #@book.excel.Visible = true
+          # strangely, in the "no" case, the question will sometimes be repeated three time
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
@@ -2055,7 +2102,7 @@ describe Workbook do
               if :if_obstructed is :close_if_saved" do
             expect{
               new_book = Workbook.open(@simple_file1, :if_obstructed => :close_if_saved)
-            }.to raise_error(WorkbookBlocked, /workbook with the same name in a different path is unsaved/)
+            }.to raise_error(WorkbookBlocked, /same name in a different path/)
             @book.save
             new_book = Workbook.open(@simple_file1, :if_obstructed => :close_if_saved)
             @book.should_not be_alive
@@ -2222,7 +2269,7 @@ describe Workbook do
 
     context "with :read_only" do
       
-      it "should reopen the book with writable (unsaved changes from readonly will not be saved)" do
+      it "should not reopen the book with writable" do
         book = Workbook.open(@simple_file1, :read_only => true)
         book.ReadOnly.should be true
         book.should be_alive
@@ -2234,27 +2281,10 @@ describe Workbook do
         new_book.ReadOnly.should be false 
         new_book.should be_alive
         book.should be_alive   
-        new_book.should == book 
-        new_sheet = new_book.sheet(1)
-        new_cell_value = new_sheet[1,1].Value
-        new_cell_value.should == old_cell_value
+        new_book.should == book         
       end
 
-      it "should not raise an error when trying to reopen the book as read_only while the writable book had unsaved changes" do
-        book = Workbook.open(@simple_file1, :read_only => false)
-        book.ReadOnly.should be false
-        book.should be_alive
-        sheet = book.sheet(1)
-        old_cell_value = sheet[1,1].Value        
-        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
-        book.Saved.should be false
-        new_book = Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :accept)
-        new_book.ReadOnly.should be true
-        new_book.Saved.should be true
-        new_book.should == book
-      end
-
-      it "should reopen the book with writable in the same Excel instance (unsaved changes from readonly will not be saved)" do
+      it "should not reopen the book with writable" do
         book = Workbook.open(@simple_file1, :read_only => true)
         book.ReadOnly.should be true
         book.should be_alive
@@ -2262,28 +2292,39 @@ describe Workbook do
         old_cell_value = sheet[1,1].Value
         sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
         book.Saved.should be false
-        new_book = Workbook.open(@simple_file1, :if_unsaved => :accept, :force => {:excel => book.excel}, :read_only => false)
+        new_book = Workbook.open(@simple_file1, :read_only => false, :if_unsaved => :forget)
         new_book.ReadOnly.should be false 
         new_book.should be_alive
-        book.should be_alive   
-        new_book.should == book 
+        book.should_not be_alive   
+        new_book.should_not == book 
         new_sheet = new_book.sheet(1)
         new_cell_value = new_sheet[1,1].Value
         new_cell_value.should == old_cell_value
       end
 
-      it "should reopen the book with readonly (unsaved changes of the writable should be saved)" do
-        book = Workbook.open(@simple_file1, :force => {:excel => :new}, :read_only => false)
+      it "should raise an error when trying to reopen the book as read_only while the writable book had unsaved changes" do
+        book = Workbook.open(@simple_file1, :read_only => false)
         book.ReadOnly.should be false
         book.should be_alive
         sheet = book.sheet(1)
         old_cell_value = sheet[1,1].Value        
         sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
         book.Saved.should be false
-        new_book = Workbook.open(@simple_file1, :force => {:excel => book.excel}, :read_only => true, :if_unsaved => :accept)
+        expect{
+          Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :accept)
+        }.to raise_error(OptionInvalid)
+      end
+
+      it "should not raise an error when trying to reopen the book as read_only while the writable book had unsaved changes" do
+        book = Workbook.open(@simple_file1, :read_only => false)
+        book.ReadOnly.should be false
+        book.should be_alive
+        sheet = book.sheet(1)
+        old_cell_value = sheet[1,1].Value        
+        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
+        book.Saved.should be false
+        new_book = Workbook.open(@simple_file1, :read_only => true, :if_unsaved => :save)
         new_book.ReadOnly.should be true
-        new_book.Saved.should be true
-        new_book.should == book
         new_sheet = new_book.sheet(1)
         new_cell_value = new_sheet[1,1].Value
         new_cell_value.should_not == old_cell_value