robust_excel_ole 1.1.5 → 1.1.6

data/lib/robust_excel_ole/version.rb

@@ -1,3 +1,3 @@
 module RobustExcelOle
-  VERSION = "1.1.5"
+  VERSION = "1.1.6"
 end

data/robust_excel_ole.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   
   s.summary     = "RobustExcelOle automates processing Excel workbooks in Windows by using the win32ole library."
   s.description = "RobustExcelOle automates reading and writing Excel workbooks in Windows by using the win32ole library.
-                   It is disigned to cope with several kinds of concurrency of both simultaneously running
+                   It is designed to cope with several kinds of concurrency of both simultaneously running
                    Excel instances and simultanously happening user interactions.
                    RobustExcelOle deals with various cases of Excel (and user) behaviour,
                    supplies workarounds for some Excel bugs, and supports referenced libraries."                 

data/spec/book_spec.rb

@@ -34,7 +34,7 @@ describe Book do
 
   after do
     Excel.kill_all
-    #rm_tmp(@dir)
+    rm_tmp(@dir)
   end
 
   describe "create file" do

data/spec/book_specs/book_close_spec.rb

@@ -228,9 +228,9 @@ describe Book do
               expect {
               @book.close(:if_unsaved => :excel)
               }.to_not raise_error
-              @book.ole_workbook.Saved.should be false
-              @book.ole_workbook.should_not == nil
-              @book.should be_alive
+              #@book.ole_workbook.Saved.should be false
+              #@book.ole_workbook.should_not == nil
+              #@book.should be_alive
             else
               @book.excel.Workbooks.Count.should == 1
               @book.close(:if_unsaved => :excel)

data/spec/book_specs/book_misc_spec.rb

@@ -32,7 +32,7 @@ describe Book do
 
   after do
     Excel.kill_all
-    #rm_tmp(@dir)
+    rm_tmp(@dir)
   end
 
   describe "create file" do
@@ -753,6 +753,30 @@ describe Book do
       @book1.Worksheets.Item(1).Delete
       @book1.nameval("localname").should == "simple"
     end
+
+    it "should color the cell" do
+      @book1.set_nameval("new", "bar")
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == -4142
+      @book1.set_nameval("new", "bar", :color => 4)
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 4
+      @book1["new"].should == "bar"
+      @book1["new"] = "bar"
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 42
+      @book1.save
+      @book1.close
+      #book2 = Book.open(@simple_file1, :visible =>  true)
+      #book2.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 42
+    end
+
+    it "should save without color" do
+      @book1.set_nameval("new", "bar", :color => 4)
+      @book1.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 4
+      @book1.save(:discoloring => true)
+      @book1.close
+      #book2 = Book.open(@simple_file1, :visible =>  true)
+      #book2.Names.Item("new").RefersToRange.Interior.ColorIndex.should == 0
+    end
+
   end
 
   describe "rename_range" do

data/spec/book_specs/book_open_spec.rb

@@ -34,7 +34,146 @@ describe Book do
 
   after do
     Excel.kill_all
-    #rm_tmp(@dir)
+    rm_tmp(@dir)
+  end
+
+  describe "with already open Excel instances and an open unsaved workbook" do
+
+    before do
+      @ole_excel1 = WIN32OLE.new('Excel.Application')
+      @ole_excel2 = WIN32OLE.new('Excel.Application')
+      @ole_workbook1 = @ole_excel1.Workbooks.Open(@simple_file1, { 'ReadOnly' => false })
+      @ole_workbook1.Worksheets.Add
+    end
+
+    context "with simple general situations" do
+      
+      it "should simply open" do
+        book = Workbook.open(@simple_file1, :if_unsaved => :accept)
+        book.should be_alive
+        book.should be_a Book
+      end
+
+      it "should open in a new Excel" do
+        book2 = Workbook.open(@simple_file1, :force => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should_not == @ole_excel1 
+        book2.Readonly.should be true
+      end
+
+      it "should fetch the workbook" do
+        new_book = Book.new(@ole_workbook1)
+        new_book.should be_a Book
+        new_book.should be_alive
+        new_book.ole_workbook.should == @ole_workbook1
+        new_book.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd
+      end
+
+      it "should fetch a closed workbook" do
+        new_book = Book.new(@ole_workbook1)
+        new_book.close(:if_unsaved => :forget)
+        new_book.should_not be_alive
+        book2 = Book.open(@simple_file1)
+        book2.should === new_book
+        book2.should be_alive
+        book2.close
+      end
+
+      it "should force_excel with :reuse" do
+        book2 = Book.open(@different_file, :force => {:excel => :current})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd 
+      end
+
+      it "should force_excel with :reuse when reopening and the Excel is not alive even if :default_excel says sth. else" do
+        book1 = Book.open(@simple_file1, :if_unsaved => :forget)
+        excel2 = Excel.new(:reuse => false)
+        book1.excel.close(:if_unsaved => :forget)
+        sleep 1
+        book2 = Book.open(@simple_file1, :force => {:excel => :current}, :default => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.ole_excel.Hwnd.should == @ole_excel2.Hwnd
+      end
+
+      it "should reopen the closed book" do
+        book1 = Book.open(@simple_file1, :if_unsaved => :accept)
+        book1.should be_alive
+        book2 = book1
+        book1.close(:if_unsaved => :forget)
+        book1.should_not be_alive
+        book1.reopen
+        book1.should be_a Book
+        book1.should be_alive
+        book1.should === book2
+      end
+    end
+
+    context "with :if_unsaved" do
+
+      before do
+        @book = Book.open(@simple_file1, :if_unsaved => :accept)
+        sheet = @book.sheet(1)
+        @old_value = sheet[1,1].Value
+        sheet[1,1] = (sheet[1,1].value == "foo" ? "bar" : "foo")
+        @new_value = sheet[1,1].Value
+        @book.Saved.should be false
+      end
+
+      after do
+        @book.close(:if_unsaved => :forget)
+      end
+
+      it "should let the book open, if :if_unsaved is :accept" do
+        new_book = Book.open(@simple_file1, :if_unsaved => :accept)
+        @book.should be_alive
+        new_book.should be_alive
+        new_book.Saved.should be false      
+        @book.Saved.should be false  
+        new_book.sheet(1)[1,1].Value.should == @new_value
+        new_book.should == @book
+      end
+
+      it "should open book and close old book, if :if_unsaved is :forget" do
+        new_book = Book.open(@simple_file1, :if_unsaved => :forget)
+        @book.should_not be_alive
+        new_book.should be_alive
+        new_book.Saved.should be true
+      end
+    end
+
+    context "with :if_obstructed" do
+
+      it "should raise an error, if :if_obstructed is :raise" do
+        expect {
+          new_book = Book.open(@simple_file_other_path1)
+        }.to raise_error(WorkbookBlocked, /blocked by a workbook with the same name in a different path/)
+      end
+
+      it "should close the other book and open the new book, if :if_obstructed is :forget" do
+        new_book = Book.open(@simple_file_other_path1, :if_obstructed => :forget)
+        expect{
+          @ole_workbook1.Name
+        }.to raise_error 
+        new_book.should be_alive
+      end
+
+    end
+
+    context "with :force => {:excel}" do
+
+      it "should open in a provided Excel" do
+        book1 = Book.open(@simple_file1, :force => {:excel => :new})
+        book2 = Book.open(@simple_file1, :force => {:excel => :new})
+        book3 = Book.open(@simple_file1, :force => {:excel => book2.excel})
+        book3.should be_alive
+        book3.should be_a Book
+        book3.excel.should == book2.excel 
+        book3.Readonly.should be true
+      end 
+    end
   end
 
   describe "simple open" do
@@ -120,12 +259,11 @@ describe Book do
     context "with causing warning dead excel without window handle" do
 
       it "combined" do
-        Excel.kill_all
-        book1 = Book.open(@simple_file, :visible => true)
+        book1 = Book.open(@simple_file1)
         book2 = Book.open(@different_file)
         Excel.kill_all
-        #sleep 1
-        book3 = Book.open(@another_simple_file)
+        #sleep 1 #then no warning
+        Excel.current # or book3 = Book.open(@another_simple_file)
       end
 
     end
@@ -551,6 +689,162 @@ describe Book do
    
     end
 
+    context "with leaving out :force => {:excel}" do
+
+      before do
+        @book = Book.open(@simple_file1)
+      end
+
+      after do
+        @book.close rescue nil
+      end
+
+      it "should open in a given Excel provided as Excel, Book, or WIN32OLE representing an Excel or Workbook" do
+        book2 = Book.open(@another_simple_file)
+        book3 = Book.open(@different_file)
+        book3 = Book.open(@simple_file1, :excel => book2.excel)
+        book3.excel.should === book2.excel
+        book4 = Book.open(@simple_file1, :excel => @book) 
+        book4.excel.should === @book.excel
+        book3.close
+        book4.close
+        book5 = Book.open(@simple_file1, :excel => book2.ole_workbook)
+        book5.excel.should ===  book2.excel
+        win32ole_excel1 = WIN32OLE.connect(@book.ole_workbook.Fullname).Application
+        book6 = Book.open(@simple_file1, :excel => win32ole_excel1)
+        book6.excel.should === @book.excel
+      end
+
+      it "should open in a new Excel" do
+        book2 = Book.open(@simple_file1, :excel => :new)
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should_not == @book.excel 
+        book2.should_not == @book
+        @book.Readonly.should be false
+        book2.Readonly.should be true
+        book2.close
+      end
+
+      it "should open in a given Excel, not provide identity transparency, because old book readonly, new book writable" do
+        book2 = Book.open(@simple_file1, :excel => :new)
+        book2.excel.should_not == @book.excel
+        book3 = Book.open(@simple_file1, :excel => :new)
+        book3.excel.should_not == book2.excel
+        book3.excel.should_not == @book.excel
+        book2.close
+        book4 = Book.open(@simple_file1, :excel => book2.excel)
+        book4.should be_alive
+        book4.should be_a Book
+        book4.excel.should == book2.excel
+        #book4.Readonly.should == true
+        book4.should_not == book2 
+        book4.close
+        book5 = Book.open(@simple_file1, :excel => book2)
+        book5.should be_alive
+        book5.should be_a Book
+        book5.excel.should == book2.excel
+        #book5.Readonly.should == true
+        book5.should_not == book2 
+        book5.close
+        book3.close
+      end
+
+      it "should open in a given Excel, provide identity transparency, because book can be readonly, such that the old and the new book are readonly" do
+        book2 = Book.open(@simple_file1, :excel => :new)
+        book2.excel.should_not == @book.excel
+        book3 = Book.open(@simple_file1, :excel => :new)
+        book3.excel.should_not == book2.excel
+        book3.excel.should_not == @book.excel
+        book2.close
+        book3.close
+        @book.close
+        book4 = Book.open(@simple_file1, :excel => book2.excel, :read_only => true)
+        book4.should be_alive
+        book4.should be_a Book
+        book4.excel.should == book2.excel
+        book4.ReadOnly.should be true
+        book4.should == book2
+        book4.close
+        book5 = Book.open(@simple_file1, :excel => book2, :read_only => true)
+        book5.should be_alive
+        book5.should be_a Book
+        book5.excel.should == book2.excel
+        book5.ReadOnly.should be true
+        book5.should == book2
+        book5.close
+        book3.close
+      end
+
+      it "should open in a given Excel, provide identity transparency, because book can be readonly, such that the old and the new book are readonly" do
+        book2 = Book.open(@simple_file1, :excel => :new)
+        book2.excel.should_not == @book.excel
+        book2.close
+        @book.close
+        book4 = Book.open(@simple_file1, :excel => book2, :read_only => true)
+        book4.should be_alive
+        book4.should be_a Book
+        book4.excel.should == book2.excel
+        book4.ReadOnly.should be true
+        book4.should == book2
+        book4.close
+      end
+
+      it "should raise an error if no Excel or Book is given" do
+        expect{
+          Book.open(@simple_file1, :excel => :b)
+          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+      end
+
+      it "should do force_excel even if both force_ and default_excel is given" do
+        book2 = Book.open(@simple_file1, :default => {:excel => @book.excel}, :force => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should_not == @book.excel 
+        book2.should_not == @book
+      end
+
+      it "should do default_excel if force_excel is nil" do
+        book2 = Book.open(@another_simple_file, :excel => nil)
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should == @book.excel
+      end
+
+      it "should force_excel with :reuse" do
+        book2 = Book.open(@different_file, :excel => :current)
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should == @book.excel
+      end
+
+      it "should force_excel with :reuse even if :default_excel says sth. else" do
+        book2 = Book.open(@different_file, :excel => :current, :default => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should == @book.excel
+      end
+
+      it "should force_excel with :reuse when reopening and the Excel is not alive even if :default_excel says sth. else" do
+        excel2 = Excel.new(:reuse => false)
+        @book.excel.close
+        book2 = Book.open(@simple_file1, :excel => :current, :default => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Book
+        book2.excel.should === excel2
+      end
+
+      it "should force_excel with :reuse when reopening and the Excel is not alive even if :default_excel says sth. else" do
+        book2 = Book.open(@different_file1, :excel => :new)
+        book2.excel.close
+        book3 = Book.open(@different_file1, :excel => :current, :default => {:excel => :new})
+        book3.should be_alive
+        book3.should be_a Book
+        book3.excel.should == @book.excel
+      end
+   
+    end
+
 
     context "with :force_excel" do
 

data/spec/book_specs/book_sheet_spec.rb

@@ -31,7 +31,7 @@ describe Book do
 
   after do
     Excel.kill_all
-    #rm_tmp(@dir)
+    rm_tmp(@dir)
   end
 
   describe 'access sheet' do

data/spec/book_specs/book_unobtr_spec.rb

@@ -32,7 +32,7 @@ describe Book do
 
   after do
     Excel.kill_all
-    #rm_tmp(@dir)
+    rm_tmp(@dir)
   end
 
   
@@ -52,6 +52,249 @@ describe Book do
       expect{unobtrusively_ok?}.to_not raise_error
     end
 
+=begin
+    describe "with already open Excel instances and workbooks" do
+
+      before do
+        @ole_excel1 = WIN32OLE.new('Excel.Application')
+        @ole_excel2 = WIN32OLE.new('Excel.Application')
+      end
+
+      context "with open unsaved workbook" do
+
+        before do        
+          @book1 = Book.open(@simple_file1)
+          @book1.sheet(1)[1,1] = "foo"
+          #@ole_workbook1 = @ole_excel1.Workbooks.Open(@simple_file1, { 'ReadOnly' => false })
+          #@old_value = @ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value
+          #@ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value = 
+          #  @old_value == "foo" ? "bar" : "foo"
+        end
+
+        context "with writability" do
+
+          it "should open as read-write by default" do
+            Book.unobtrusively(@simple_file1) do |book|
+              book.Readonly.should be false
+              #book.filename.should == @ole_workbook1.Fullname.tr('\\','/')
+              #book.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd
+              book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo"
+            end
+            #@ole_workbook1.Saved.should be false
+            Excel.kill_all
+            sleep 1
+            book2 = Book.open(@simple_file1)
+            #book2.sheet(1)[1,1].Value.should == @old_value
+          end
+
+          it "should open not writable" do
+            Book.unobtrusively(@simple_file1, :writable => false) do |book|
+              book.ReadOnly.should be false
+              book.filename.should == @ole_workbook1.Fullname.tr('\\','/')
+              book.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd
+              book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo"
+            end
+            @book.Saved.should be false
+            @book.sheet(1)[1,1].Value.should_not == @old_value
+            Excel.kill_all
+            sleep 1
+            book2 = Book.open(@simple_file1)
+            book2.sheet(1)[1,1].Value.should_not == @old_value
+          end
+        end
+
+        context "further tests" do
+
+          it "should write in the outer and not in the inner block" do
+            Book.unobtrusively(@simple_file1) do |book|
+              @old_value = book.sheet(1)[1,1].Value
+              book.ReadOnly.should be false
+              book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
+              book.Saved.should be false
+              book.sheet(1)[1,1].Value.should_not == @old_value
+              Book.unobtrusively(@simple_file1, :writable => false) do |book2|
+                book2.should == book
+                book2.ReadOnly.should be false
+                book2.Saved.should be false
+                book2.sheet(1)[1,1].Value.should_not == @old_value
+                book2.sheet(1)[1,1] = book2.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
+                book2.sheet(1)[1,1].Value.should == @old_value
+              end
+              book.should be_alive
+              book.Saved.should be false
+              book.sheet(1)[1,1].Value.should == @old_value            
+            end
+            book = Book.open(@simple_file1)
+            book.sheet(1)[1,1].Value.should == @old_value
+          end
+
+          it "should use the excel of the book and keep open the book" do
+            @book = Book.open(@simple_file1)
+            excel = Excel.new(:reuse => false)
+            sheet = @book.sheet(1)
+            old_cell_value = sheet[1,1].value
+            @book.close
+            @book.should_not be_alive
+            Book.unobtrusively(@simple_file, :keep_open => true) do |book|
+              book.should be_a Book
+              book.excel.should == @book.excel
+              book.excel.should_not == excel
+              sheet = book.sheet(1)
+              cell = sheet[1,1]
+              sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
+              book.Saved.should be false
+            end
+            @book.should be_alive
+            @book.close
+            new_book = Book.open(@simple_file1)
+            sheet = new_book.sheet(1)
+            sheet[1,1].value.should_not == old_cell_value
+          end
+
+          it "should use the excel of the book and keep open the book" do
+            @book = Book.open(@simple_file1)
+            excel = Excel.new(:reuse => false)
+            sheet = @book.sheet(1)
+            old_cell_value = sheet[1,1].value
+            @book.close
+            @book.should_not be_alive
+            Book.unobtrusively(@simple_file, :if_closed => :new) do |book|
+              book.should be_a Book
+              book.should be_alive
+              book.excel.should_not == @book.excel
+              book.excel.should_not == excel
+              sheet = book.sheet(1)
+              cell = sheet[1,1]
+              sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
+              book.Saved.should be false
+            end
+            @book.should_not be_alive
+            new_book = Book.open(@simple_file1)
+            sheet = new_book.sheet(1)
+            sheet[1,1].value.should_not == old_cell_value
+          end
+
+          it "should use a given Excel" do
+            @book = Book.open(@simple_file1)
+            @book.close
+            new_excel = Excel.new(:reuse => false)
+            another_excel = Excel.new(:reuse => false)
+            Book.unobtrusively(@simple_file1, :if_closed => another_excel) do |book|
+              book.excel.should_not == @book.excel
+              book.excel.should_not == new_excel
+              book.excel.should == another_excel
+            end
+          end
+
+          it "should reuse Excel" do
+            new_excel = Excel.new(:reuse => false)
+            Book.unobtrusively(@simple_file1, :if_closed => :reuse) do |book|
+            book.excel.should == @book.excel
+            book.excel.should_not == new_excel
+          end
+
+          it "should open unobtrusively the closed book in the most recent Excel where it was open before" do      
+            @book1 = Book.open(@simple_file1)
+            @book2 = Book.open(@simple_file1, :force_excel => :new)
+            @book1.Readonly.should == false
+            @book2.Readonly.should == true
+            old_sheet = @book1.sheet(1)
+            @old_cell_value = old_sheet[1,1].value
+            @book1.close
+            @book2.close
+            @book1.should_not be_alive
+            @book2.should_not be_alive
+            Book.unobtrusively(@simple_file1) do |book| 
+              book.excel.should_not == @book2.excel
+              book.excel.should == @book1.excel
+              book.ReadOnly.should == false
+              sheet = book.sheet(1)
+              cell = sheet[1,1]
+              sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
+              book.Saved.should be false
+            end
+            new_book = Book.open(@simple_file1)
+            sheet = new_book.sheet(1)
+            sheet[1,1].value.should_not == @old_cell_value
+          end
+        end
+      end
+
+      context "with open unsaved read-only workbook" do
+
+        before do        
+          @ole_workbook1 = @ole_excel1.Workbooks.Open(@simple_file1, { 'ReadOnly' => true })
+          @old_value = @ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value
+          @ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value = 
+            @old_value == "foo" ? "bar" : "foo"
+        end
+
+        context "with writability" do
+
+          it "should open as read-only by default" do
+            Book.unobtrusively(@simple_file1) do |book|
+              book.Readonly.should be true
+              book.filename.should == @ole_workbook1.Fullname.tr('\\','/')
+              book.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd
+              book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo"
+            end
+            @ole_workbook1.Saved.should be false
+            @ole_workbook1.ReadOnly.should be true          
+            @ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value.should_not == @old_value
+            Excel.kill_all
+            sleep 1
+            book2 = Book.open(@simple_file1)
+            book2.sheet(1)[1,1].Value.should_not == @old_value
+          end
+
+          it "should open not writable" do
+            Book.unobtrusively(@simple_file1, :writable => false) do |book|
+              book.ReadOnly.should be true
+              book.filename.should == @ole_workbook1.Fullname.tr('\\','/')
+              book.excel.ole_excel.Hwnd.should == @ole_excel1.Hwnd
+              book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo"
+            end
+            @ole_workbook1.Saved.should be false
+            @ole_workbook1.ReadOnly.should be true          
+            @ole_workbook1.Worksheets.Item(1).Cells.Item(1, 1).Value.should_not == @old_value
+            Excel.kill_all
+            sleep 1
+            book2 = Book.open(@simple_file1)
+            book2.sheet(1)[1,1].Value.should == @old_value
+          end
+        end
+      end
+    end
+  end
+=end
+
+    describe "block transparency" do
+
+      it "should return correct value of the block" do
+        (Book.unobtrusively(@simple_file1) do |book| 
+          22
+         end).should == 22
+      end
+
+      it "should return value of the last block" do
+        (Book.unobtrusively(@simple_file1) do |book|
+          Book.unobtrusively(@different_file) do |book2|
+            11
+          end
+          22
+        end).should == 22
+      end
+
+      it "should return correct value in several blocks" do
+        (Book.unobtrusively(@simple_file1) do |book|
+          Book.unobtrusively(@different_file) do |book2|
+            22
+          end
+        end).should == 22
+      end
+
+    end
+
     describe "writability" do
 
       context "with no book" do
@@ -278,6 +521,21 @@ describe Book do
           @old_value = @book.sheet(1)[1,1].Value 
         end
 
+        it "should not write" do
+          Book.unobtrusively(@simple_file1, :writable => false) do |book|
+            book.Readonly.should be true
+            book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo"
+            book.sheet(1)[1,1].Value.should_not == @old_value
+          end
+          @book.close
+          Book.unobtrusively(@simple_file1, :writable => false) do |book|
+            book.sheet(1)[1,1].Value.should == @old_value
+          end
+          #@book.close
+          #book2 = Book.open(@simple_file1)
+          #book2.sheet(1)[1,1].Value.should == @old_value
+        end
+
         it "should not change the read_only mode" do
           Book.unobtrusively(@simple_file1) do |book|
             book.Readonly.should be true
@@ -490,7 +748,7 @@ describe Book do
           @book.sheet(1)[1,1].Value.should_not == @old_value
         end
 
-        it "should open as read-write" do          
+        it "should force to read-write" do          
           Book.unobtrusively(@simple_file1, :writable => true, :read_only => false) do |book|
             book.Readonly.should be false
             book.should == @book
@@ -514,36 +772,6 @@ describe Book do
           }.to raise_error(NotImplementedREOError)
         end
 
-        #it "should force to read-only (not implemented)" do
-        #  expect{
-        #    Book.unobtrusively(@simple_file1, :read_only => true) do |book|            
-        #      book.ReadOnly.should be true
-        #      book.should == @book
-        #      book.filename.should == @book.filename
-        #      book.excel.should == @book.excel
-        #      book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
-        #    end
-        #    @book.Saved.should be false
-        #    @book.sheet(1)[1,1].Value.should == @old_value
-        #  end
-        #  }.to raise_error(NotImplementedREOError)
-        #end
-
-        #it "should force to read-only" do
-        #  expect{
-        #    Book.unobtrusively(@simple_file1, :read_only => true, :writable => false) do |book|            
-        #      book.ReadOnly.should be true
-        #      book.should == @book
-        #      book.filename.should == @book.filename
-        #      book.excel.should == @book.excel
-        #      book.sheet(1)[1,1] = book.sheet(1)[1,1].Value == "foo" ? "bar" : "foo" 
-        #    end
-        #    @book.Saved.should be false
-        #    @book.sheet(1)[1,1].Value.should == @old_value
-        #  end
-        #  }.to raise_error(NotImplementedREOError)
-        #end
-
         it "should open not writable" do
           Book.unobtrusively(@simple_file1, :writable => false) do |book|
             book.ReadOnly.should be false
@@ -696,6 +924,19 @@ describe Book do
           end
         end
 
+        it "should not close the book in the outer block with writable false" do
+          Book.unobtrusively(@simple_file1, :writable => false) do |book|
+            Book.unobtrusively(@simple_file1, :writable => false) do |book2|
+              book2.should == book
+            end
+            book.should be_alive
+            #Book.unobtrusively(@simple_file1, :writable => false) do |book3|
+            #  book3.should == book
+            #end
+            #book.should be_alive
+          end
+        end
+
         it "should write in the outer and inner block" do
           Book.unobtrusively(@simple_file1) do |book|
             @old_value = book.sheet(1)[1,1].Value
@@ -808,10 +1049,10 @@ describe Book do
         it "should remain open" do
           book1 = Book.open(@simple_file1)
           Book.unobtrusively(@simple_file1) do |book|
-            #book.should be_a Book
+            book.should be_a Book
             book.should be_alive
           end
-          #book1.should be_alive
+          book1.should be_alive
         end
 
       end
@@ -1734,4 +1975,3 @@ describe Book do
   end
   
 end
-