robust_excel_ole 1.0 → 1.0.1

data/spec/book_specs/book_save_spec.rb

@@ -23,12 +23,14 @@ describe Book do
     @simple_save_file = @dir + '/workbook_save.xls'
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
+    @another_simple_file_other_path = @dir + '/more_data/another_workbook.xls'
     @another_simple_file = @dir + '/another_workbook.xls'
     @linked_file = @dir + '/workbook_linked.xlsm'
     @simple_file_xlsm = @dir + '/workbook.xls'
     @simple_file_xlsx = @dir + '/workbook.xlsx'
     @simple_file1 = @simple_file
     @simple_file_other_path1 = @simple_file_other_path
+    @another_simple_file_other_path1 = @another_simple_file_other_path
     @simple_save_file1 = @simple_save_file
   end
 
@@ -135,6 +137,23 @@ describe Book do
       end
     end
 
+    context "with saving with the same name in another directory" do
+
+      before do
+        @book = Book.open(@simple_file1)
+      end
+
+      it "should save with the same name in another directory" do
+        File.delete @simple_file_other_path1 rescue nil
+        File.open(@simple_file_other_path1,"w") do | file |
+          file.puts "garbage"
+        end
+        File.exist?(@simple_file_other_path1).should be_true
+        @book.save_as(@simple_file_other_path1, :if_exists => :overwrite, :if_obstructed => :forget)
+      end
+
+    end
+
     context "with blocked by another file" do
 
       before do

data/spec/book_specs/book_unobtr_spec.rb

@@ -120,20 +120,62 @@ describe Book do
         Book.unobtrusively(@simple_file, :visible => true) do |book|
           book.should be_a Book
           book.should be_alive
-          book.excel.visible.should be_true
+          book.excel.Visible.should be_true
+          book.Windows(book.Name).Visible.should be_true
         end
       end
 
-      it "should be visible" do
+      it "should be visible and displayalerts" do
         excel = Excel.new(:reuse => false, :displayalerts => true)
         Book.unobtrusively(@simple_file, :visible => true) do |book|
           book.should be_a Book
           book.should be_alive
-          book.excel.visible.should be_true
-          book.excel.displayalerts.should be_true
+          book.excel.Visible.should be_true
+          book.Windows(book.Name).Visible.should be_true
+          book.excel.DisplayAlerts.should be_true
+        end
+      end
+
+      it "should do default-visible" do
+        excel = Excel.new(:reuse => false, :visible => false)
+        Book.unobtrusively(@simple_file, :default => {:visible => true}) do |book|
+          book.should be_a Book
+          book.should be_alive
+          book.excel.Visible.should_not be_true
+          book.Windows(book.Name).Visible.should be_true
+        end
+      end
+
+      it "should do default-invisible" do
+        excel = Excel.new(:reuse => false, :visible => true)
+        Book.unobtrusively(@simple_file, :default => {:visible => false}) do |book|
+          book.should be_a Book
+          book.should be_alive
+          book.excel.Visible.should be_true
+          book.Windows(book.Name).Visible.should be_false
+        end
+      end      
+
+      it "should do force-visible" do
+        excel = Excel.new(:reuse => false, :visible => false)
+        Book.unobtrusively(@simple_file, :force => {:visible => true}) do |book|
+          book.should be_a Book
+          book.should be_alive
+          book.excel.Visible.should be_true
+          book.Windows(book.Name).Visible.should be_true
         end
       end
 
+      it "should do force-invisible" do
+        excel = Excel.new(:reuse => false, :visible => true)
+        Book.unobtrusively(@simple_file, :force => {:visible => false}) do |book|
+          book.should be_a Book
+          book.should be_alive
+          book.excel.Visible.should be_true
+          book.Windows(book.Name).Visible.should be_false
+        end
+      end      
+
     end
 
     context "with an open book" do

data/spec/excel_spec.rb

@@ -1277,61 +1277,128 @@ module RobustExcelOle
 
     end
 
+    context "with screen updating" do
+
+      it "should set screen updating" do
+        excel1 = Excel.new
+        excel1.ScreenUpdating.should be_true
+        excel2 = Excel.create(:screenupdating => false)
+        excel2.ScreenUpdating.should be_false
+        excel3 = Excel.new
+        excel3.ScreenUpdating.should be_true
+        excel4 = Excel.new(:screenupdating => false)
+        excel4.ScreenUpdating.should be_false
+      end
+
+    end
+
     context "with calculation" do
 
-      before do
-        @excel1 = Excel.new
+      it "should create and reuse Excel with calculation mode" do
+        excel1 = Excel.create(:calculation => :manual)
+        excel1.calculation.should == :manual
+        excel2 = Excel.create(:calculation => :automatic)
+        excel2.calculation.should == :automatic
+        excel3 = Excel.current
+        excel3.calculation.should == :manual
+        excel4 = Excel.current(:calculation => :automatic)
+        excel4.calculation.should == :automatic
+        excel5 = Excel.new(:reuse => false)
+        excel5.calculation.should == nil
+        excel6 = Excel.new(:reuse => false, :calculation => :manual)
+        excel6.calculation.should == :manual
       end
 
-      it "should not set calculation mode when no workbook is opened" do
+      it "should do with_calculation mode without workbooks" do
+        @excel1 = Excel.new
         old_calculation_mode = @excel1.Calculation
+        old_calculatebeforesave = @excel1.CalculateBeforeSave
         @excel1.with_calculation(:automatic) do
           @excel1.Calculation.should == old_calculation_mode
+          @excel1.CalculateBeforeSave.should == old_calculatebeforesave
         end
         @excel1.with_calculation(:manual) do
           @excel1.Calculation.should == old_calculation_mode
+          @excel1.CalculateBeforeSave.should == old_calculatebeforesave
         end
-        @excel1.set_calculation(:automatic)
-        @excel1.Calculation.should == old_calculation_mode
-        @excel1.set_calculation(:manual)
+      end
+
+      it "should set calculation mode without workbooks" do
+        @excel1 = Excel.new
+        old_calculation_mode = @excel1.Calculation
+        old_calculatebeforesave = @excel1.CalculateBeforeSave
+        @excel1.calculation = :automatic
+        @excel1.calculation.should == :automatic
+        @excel1.Calculation.should == old_calculation_mode 
+        @excel1.CalculateBeforeSave.should == old_calculatebeforesave
+        @excel1.calculation = :manual
+        @excel1.calculation.should == :manual
         @excel1.Calculation.should == old_calculation_mode
+        @excel1.CalculateBeforeSave.should == old_calculatebeforesave
       end
 
-      it "should set calculation mode to manual and reset to the previous value" do
-        b = Book.open(@simple_file)
-        calculation_mode_old = @excel1.Calculation
-        calculation_before_save_old = @excel1.CalculateBeforeSave
+      it "should do with_calculation with workbook" do
+        @excel1 = Excel.new
+        book = Book.open(@simple_file)
+        book.Windows(book.Name).Visible = true
+        old_calculation_mode = @excel1.Calculation
         @excel1.with_calculation(:manual) do
+          @excel1.calculation.should == :manual
           @excel1.Calculation.should == -4135
           @excel1.CalculateBeforeSave.should be_false
         end
-        @excel1.Calculation.should == calculation_mode_old
-        @excel1.CalculateBeforeSave.should == calculation_before_save_old
+        @excel1.Calculation.should == old_calculation_mode
+        @excel1.CalculateBeforeSave.should be_false
+        @excel1.with_calculation(:automatic) do
+          @excel1.calculation.should == :automatic
+          @excel1.Calculation.should == -4105
+          @excel1.CalculateBeforeSave.should be_false
+        end
+        @excel1.Calculation.should == old_calculation_mode
+        @excel1.CalculateBeforeSave.should be_false
       end
 
-      it "should set calculation mode to manual" do
-        b = Book.open(@simple_file)
-        calculation_mode_old = @excel1.Calculation
-        calculation_before_save_old = @excel1.CalculateBeforeSave
-        @excel1.set_calculation(:manual)
+      it "should set calculation mode to manual with workbook" do
+        @excel1 = Excel.new
+        book = Book.open(@simple_file)
+        book.Windows(book.Name).Visible = true
+        @excel1.calculation = :manual
+        @excel1.calculation.should == :manual
         @excel1.Calculation.should == -4135
         @excel1.CalculateBeforeSave.should be_false
       end
 
-      it "should set calculation mode automatic" do
+      it "should set calculation mode to automatic with workbook" do
+        @excel1 = Excel.new
+        book = Book.open(@simple_file)
+        book.Windows(book.Name).Visible = true
+        @excel1.calculation = :automatic
+        @excel1.calculation.should == :automatic
+        @excel1.Calculation.should == -4105
+        @excel1.CalculateBeforeSave.should be_false
+      end
+
+      it "should set Calculation without workbooks" do
+        @excel1 = Excel.new
+        expect{
+          @excel1.Calculation = -4135
+        }.to raise_error(WIN32OLERuntimeError)
+      end
+
+      it "should do Calculation to manual with workbook" do
+        @excel1 = Excel.new
         b = Book.open(@simple_file)
-        @excel1.with_calculation(:automatic) do
-          @excel1.Calculation.should == -4105
-          @excel1.CalculateBeforeSave.should be_true
-        end
+        @excel1.Calculation = -4135
+        @excel1.calculation.should == :manual
+        @excel1.Calculation.should == -4135
       end
 
-      it "should set calculation mode to automatic as default" do
+      it "should do Calculation to automatic with workbook" do
+        @excel1 = Excel.new
         b = Book.open(@simple_file)
-        @excel1.with_calculation do
-          @excel1.Calculation.should == -4105
-          @excel1.CalculateBeforeSave.should be_true
-        end
+        @excel1.Calculation = -4105
+        @excel1.calculation.should == :automatic
+        @excel1.Calculation.should == -4105
       end
 
     end
@@ -1359,8 +1426,9 @@ module RobustExcelOle
     context "with hwnd and hwnd2excel" do
       
       before do
-        @excel1 = Excel.new
-        @excel2 = Excel.new(:reuse => false)
+        Excel.kill_all
+        @excel1 = Excel.new(:visible => true)
+        @excel2 = Excel.new(:reuse => false, :visible => false)
       end
 
       it "should yield the correct hwnd" do
@@ -1374,8 +1442,42 @@ module RobustExcelOle
         excel4 = Excel.hwnd2excel(@excel2.hwnd)
         @excel1.should == excel3
         @excel2.should == excel4
-        excel3.should_not == excel4 
+        excel3.should_not == excel4
+      end
+
+=begin
+      # does not work yet
+      it "should not say 'probably recycled'" do
+        e1_hwnd = @excel1.hwnd
+        @excel1.close_workbooks
+        weak_xl = WeakRef.new(@excel1.ole_excel)
+        @excel1.Quit
+        @excel1 = nil
+        GC.start
+        sleep 2
+        process_id = Win32API.new("user32", "GetWindowThreadProcessId", ["I","P"], "I")
+        pid_puffer = " " * 32
+        process_id.call(e1_hwnd, pid_puffer)
+        pid = pid_puffer.unpack("L")[0]
+        begin
+          Process.kill("KILL", pid) 
+        rescue 
+          trace "kill_error: #{$!}"
+        end
+        if weak_xl.weakref_alive? then
+           #if WIN32OLE.ole_reference_count(weak_xlapp) > 0
+          begin
+            #weak_xl.ole_free
+          rescue
+            trace "weakref_probl_olefree"
+          end
+        end
+        excel5 = Excel.new(:reuse => false)
+        e1_again = Excel.hwnd2excel(e1_hwnd)
+        e1_again.Hwnd.should == e1_hwnd
+        e1_again.should == nil 
       end
+=end
     end
     
     describe "generate workbook" do
@@ -1447,6 +1549,7 @@ module RobustExcelOle
 
       before do
         @book1 = Book.open(@dir + '/another_workbook.xls')
+        @book1.Windows(@book1.Name).Visible = true
         @excel1 = @book1.excel
       end
 
@@ -1480,7 +1583,7 @@ module RobustExcelOle
           excel2.nameval("one")
         }.to raise_error(NameNotFound, /cannot find name "one"/)
         expect {
-          excel3 = Excel.create
+          excel3 = Excel.create(:visible => true)
           excel3["one"]
         }.to raise_error(NameNotFound, /cannot find name "one"/)
       end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: robust_excel_ole
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 21
   prerelease: false
   segments: 
   - 1
   - 0
-  version: "1.0"
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - traths
@@ -14,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2016-12-07 00:00:00 +01:00
+date: 2017-04-16 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -34,10 +35,10 @@ dependencies:
   type: :development
   version_requirements: *id001
 description: |-
-  RobustExcelOle automates modifying, reading and writing Excel files.
+  RobustExcelOle automates modifying, reading and writing Excel files in Windows by using the win32ole library.
                      It supports simultaneously running Excel instances and user interactions.
                      RobustExcelOle deals with various cases of Excel (and user) behaviour,
-                     supplies workarounds for some Excel bugs, and supports referenced libraries
+                     supplies workarounds for some Excel bugs, and supports referenced libraries.
 email: 
 - Thomas.Raths@gmx.net
 executables: []
@@ -55,6 +56,7 @@ files:
 - Guardfile
 - LICENSE
 - README.rdoc
+- README_detail.rdoc
 - Rakefile
 - TodoList.md
 - examples/edit_sheets/example_access_sheets_and_cells.rb
@@ -114,7 +116,6 @@ files:
 - spec/data/merge_cells.xls
 - spec/data/more_data/workbook.xls
 - spec/data/protected_sheet.xls
-- spec/data/refed_wb.xls
 - spec/data/reference_workbook.xls
 - spec/data/referencing_wb.xls
 - spec/data/workbook.xls