robust_excel_ole 1.0.2 → 1.0.3

data/Changelog

@@ -1,6 +1,8 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [1.0.3] - 2017-08-27
+
 ## [1.0.2] - 2017-07-26
 
 ### Added

data/README.rdoc

@@ -9,6 +9,7 @@ It supports Excel 2010.
 
 RobustExcelOle works by sending VBA methods via Win32OLE.
 Moreover, it implements a management system and keeps track of Excel files and Excel instances.
+The tool is optimised with help of rcov.
 
 == Requirements
 

data/README_detail.rdoc

@@ -9,6 +9,7 @@ It supports Excel 2010.
 
 RobustExcelOle works by sending VBA methods via Win32OLE.
 Moreover, it implements a management system and keeps track of Excel files and Excel instances.
+The tool is optimised with help of rcov.
 
 == Requirements
 

data/lib/robust_excel_ole/book.rb

@@ -126,8 +126,9 @@ module RobustExcelOle
             return book 
           end
         end
+      else
+        super
       end
-      super
     end
 
     # creates a new Book object, if a file name is given
@@ -343,7 +344,7 @@ module RobustExcelOle
             # for Excel2007: for option :if_unsaved => :alert and user cancels: this error appears?
             # if yes: distinguish these events
             #raise
-            trace "WIN32OLERuntimeError: #{msg.message}" 
+            # trace "WIN32OLERuntimeError: #{msg.message}" 
           end
           begin
             # workaround for bug in Excel 2010: workbook.Open does not always return the workbook when given file name
@@ -437,8 +438,8 @@ module RobustExcelOle
       else
         close_workbook
       end
-      trace "close: canceled by user" if alive? &&  
-        (opts[:if_unsaved] == :alert || opts[:if_unsaved] == :excel) && (not @ole_workbook.Saved)
+      #trace "close: canceled by user" if alive? &&  
+      #  (opts[:if_unsaved] == :alert || opts[:if_unsaved] == :excel) && (not @ole_workbook.Saved)
     end
 
   private
@@ -645,7 +646,7 @@ module RobustExcelOle
         bookstore.store(self)
       rescue WIN32OLERuntimeError => msg
         if msg.message =~ /SaveAs/ and msg.message =~ /Workbook/ then
-          trace "save: canceled by user" if options[:if_exists] == :alert || options[:if_exists] == :excel
+          # trace "save: canceled by user" if options[:if_exists] == :alert || options[:if_exists] == :excel
           # another possible semantics. raise WorkbookError, "could not save Workbook"
         else
           raise UnexpectedError, "unknown WIN32OELERuntimeError:\n#{msg.message}"
@@ -686,11 +687,7 @@ module RobustExcelOle
       after_or_before, base_sheet = opts.to_a.first || [:after, last_sheet]
       sheet.Copy({ after_or_before.to_s => base_sheet.worksheet })
       new_sheet = sheet_class.new(@excel.Activesheet)
-      begin
-        new_sheet.name = new_sheet_name if new_sheet_name
-      rescue WIN32OLERuntimeError => msg
-        msg.message =~ /800A03EC/ ? raise(NameAlreadyExists, "sheet name already exists") : raise(UnexpectedError)
-      end
+      new_sheet.name = new_sheet_name if new_sheet_name
       new_sheet
     end      
 
@@ -707,11 +704,7 @@ module RobustExcelOle
       after_or_before, base_sheet = opts.to_a.first || [:after, last_sheet]
       @ole_workbook.Worksheets.Add({ after_or_before.to_s => base_sheet.worksheet })
       new_sheet = sheet_class.new(@excel.Activesheet)
-      begin
-        new_sheet.name = new_sheet_name if new_sheet_name
-      rescue WIN32OLERuntimeError => msg
-        msg.message =~ /800A03EC/ ? raise(NameAlreadyExists, "sheet name already exists") : raise(UnexpectedError)
-      end
+      new_sheet.name = new_sheet_name if new_sheet_name
       new_sheet
     end    
 
@@ -909,10 +902,6 @@ module RobustExcelOle
       self.class.bookstore
     end   
 
-    def self.all_books   # :nodoc: #
-      bookstore.books
-    end
-
     def to_s    # :nodoc: #
       "#{self.filename}"
     end

data/lib/robust_excel_ole/bookstore.rb

@@ -100,6 +100,8 @@ module RobustExcelOle
       @hidden_excel_instance.__getobj__ if (@hidden_excel_instance &&  @hidden_excel_instance.weakref_alive? && @hidden_excel_instance.__getobj__.alive?)
     end
 
+  public
+
     # prints the book store
     def print             # :nodoc: #
       trace "@filename2books:"
@@ -113,7 +115,7 @@ module RobustExcelOle
             books.each do |book|
               if book.weakref_alive?
                 trace "#{book}"
-              else
+              else # this should never happen
                 trace "weakref not alive"
               end
             end

data/lib/robust_excel_ole/excel.rb

@@ -94,8 +94,6 @@ module RobustExcelOle
           result.calculation = options[:calculation] unless options[:calculation].nil?
           result.screenupdating = options[:screenupdating] unless options[:screenupdating].nil?
           result.created = !reused
-        rescue WIN32OLERuntimeError
-          raise ExcelError, "cannot access Excel"
         end
       end
       result
@@ -104,10 +102,6 @@ module RobustExcelOle
     def initialize(options= {}) # :nodoc: #
     end
 
-    def excel
-      self
-    end
-
     # reopens a closed Excel instance
     # @param [Hash] opts the options
     # @option opts [Boolean] :reopen_workbooks
@@ -177,15 +171,10 @@ module RobustExcelOle
     end
 
     def self.contains_unsaved_workbooks?
-      excel = begin
-        Excel.current
-      rescue
-        return false
-      end
-      not excel.unsaved_workbooks.empty?
+      not Excel.current.unsaved_workbooks.empty?
     end
 
-    # returns unsaved workbooks
+    # returns unsaved workbooks (win32ole objects)
     def unsaved_workbooks
       unsaved_workbooks = []   
       begin   
@@ -470,7 +459,7 @@ module RobustExcelOle
 
     
     # returns unsaved workbooks in known (not opened by user) Excel instances
-    def self.unsaved_known_workbooks    
+    def self.unsaved_known_workbooks  # :nodoc: #
       result = []
       @@hwnd2excel.each do |hwnd,wr_excel| 
         excel = wr_excel.__getobj__ if wr_excel.weakref_alive?
@@ -479,12 +468,12 @@ module RobustExcelOle
       result
     end
 
-    def print_workbooks
+    def print_workbooks   # :nodoc: #
       self.Workbooks.each {|w| trace "#{w.Name} #{w}"}
     end
 
     # generates, saves, and closes empty workbook
-    def generate_workbook file_name  
+    def generate_workbook file_name    # :nodoc: #
       raise FileNameNotGiven, "filename is nil" if file_name.nil?                
       self.Workbooks.Add                           
       empty_workbook = self.Workbooks.Item(self.Workbooks.Count)          

data/lib/robust_excel_ole/reo_common.rb

@@ -14,10 +14,6 @@ class REOCommon
     (self.methods - Object.methods).sort
   end
 
-  def trace(text)
-    self.class.trace(text)
-  end
-
   def self.tr1(text)
     puts :text
   end
@@ -39,10 +35,6 @@ class REOCommon
     end
   end
 
-  def puts_hash(hash)
-    self.class.puts_hash(hash)
-  end
-
   def self.puts_hash(hash)
     hash.each do |e|
       if e[1].is_a?(Hash)

data/lib/robust_excel_ole/sheet.rb

@@ -230,19 +230,11 @@ module RobustExcelOle
           self.Names.Add("Name" => name, "RefersToR1C1" => "=" + address)
         end
       rescue WIN32OLERuntimeError => msg
-        trace "WIN32OLERuntimeError: #{msg.message}"
+        #trace "WIN32OLERuntimeError: #{msg.message}"
         raise RangeNotEvaluatable, "cannot add name #{name.inspect} to cell with row #{row.inspect} and column #{column.inspect}"
       end
     end
 
-    def respond_to?(name, include_private = false)  # :nodoc: #    
-      super
-    end
-
-    def methods   # :nodoc: # 
-      super
-    end
-
     def self.book_class   # :nodoc: #
       @book_class ||= begin
         module_name = self.parent_name

data/lib/robust_excel_ole/version.rb

@@ -1,3 +1,3 @@
 module RobustExcelOle
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/book_specs/book_misc_spec.rb

@@ -47,6 +47,37 @@ describe Book do
     end
   end
 
+  describe "excel_of" do
+
+    before do
+      @book = Book.open(@simple_file)
+    end
+
+    after do
+      @book.close
+    end
+
+    it "should access the excel" do
+      workbook = @book.ole_workbook
+      excel = Book.excel_of(workbook)
+      excel.should be_a Excel
+      excel.should == @book.excel
+    end
+
+    it "should access the Excel of the ole_excel" do
+      excel = Book.excel_of(@book.excel.ole_excel)
+      excel.should be_a Excel
+      excel.should == @book.excel
+    end
+
+    it "should access the Excel of a Book" do
+      excel = Book.excel_of(@book)
+      excel.should be_a Excel
+      excel.should == @book.excel
+    end
+
+  end
+
   describe "with retain_saved" do
 
     before do

data/spec/book_specs/book_open_spec.rb

@@ -1364,6 +1364,12 @@ describe Book do
             old_book.close
           end
 
+          it "should close the old book and open the new book, if :if_obstructed is :close_if_saved" do
+            @book.close(:if_unsaved => :forget)
+            book = Book.open(@simple_file_other_path)
+            Book.open(@simple_file1, :if_obstructed => :close_if_saved)
+          end
+
           it "should open the book in a new excel instance, if :if_obstructed is :new_excel" do
             @new_book = Book.open(@simple_file1, :if_obstructed => :new_excel)
             @book.should be_alive
@@ -1630,6 +1636,12 @@ describe Book do
           book.should be_a Book
         end
       end
+      it 'block parameter should be instance of Book for new' do
+        Book.new(@simple_file) do |book|
+          book.should be_a Book
+        end
+      end
+
     end
 
     context "with WIN32OLE#GetAbsolutePathName" do

data/spec/bookstore_spec.rb

@@ -51,6 +51,8 @@ describe Bookstore do
     @simple_save_file = @dir + '/workbook_save.xls'
     @different_file = @dir + '/different_workbook.xls'
     @simple_file_other_path = @dir + '/more_data/workbook.xls'
+    @simple_file1 = @simple_file
+    @different_file1 = @different_file
   end
 
   after do
@@ -78,8 +80,8 @@ describe Bookstore do
 
   describe "Mock-Test" do
     it "should never store any book" do
-      b1 = Book.open(@simple_file)
-      b2 = Book.open(@simple_file)
+      b1 = Book.open(@simple_file1)
+      b2 = Book.open(@simple_file1)
       b2.object_id.should_not == b1.object_id
     end
   end
@@ -108,8 +110,8 @@ describe Bookstore do
 
       it "should fetch one book several times" do        
         @bookstore.store(@book)
-        book1 = @bookstore.fetch(@simple_file)
-        book2 = @bookstore.fetch(@simple_file)
+        book1 = @bookstore.fetch(@simple_file1)
+        book2 = @bookstore.fetch(@simple_file1)
         expect(book1).to be_a Book
         book1.should be_alive
         book1.should == @book
@@ -161,10 +163,10 @@ describe Bookstore do
       end
 
       it "should store and open two different books" do
-        @book2 = Book.open(@different_file)
+        @book2 = Book.open(@different_file1)
         @bookstore.store(@book2)
         new_book = @bookstore.fetch(@simple_file)
-        new_book2 = @bookstore.fetch(@different_file)
+        new_book2 = @bookstore.fetch(@different_file1)
         new_book.should be_a Book
         new_book.should be_alive
         new_book.should == @book
@@ -177,35 +179,35 @@ describe Bookstore do
       end
 
       it "should fetch the first, writable book" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_false
         @book2.ReadOnly.should be_true
-        new_book = @bookstore.fetch(@simple_file)
+        new_book = @bookstore.fetch(@simple_file1)
         new_book.should == @book
         new_book.should_not == @book2
         new_book.close
       end
 
       it "should fetch the last book with :prefer_writeable => false" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_false
         @book2.ReadOnly.should be_true
-        new_book = @bookstore.fetch(@simple_file, :prefer_writable => false)
+        new_book = @bookstore.fetch(@simple_file1, :prefer_writable => false)
         new_book.should_not == @book
         new_book.should == @book2
         new_book.close
       end
 
       it "should fetch the second, open book, if the first book is closed" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_false
         @book2.ReadOnly.should be_true
         @book.close
-        new_book = @bookstore.fetch(@simple_file, :prefer_writable => false)
-        new_book2 = @bookstore.fetch(@simple_file)
+        new_book = @bookstore.fetch(@simple_file1, :prefer_writable => false)
+        new_book2 = @bookstore.fetch(@simple_file1)
         new_book.should_not == @book
         new_book2.should_not == @book
         new_book.should == @book2
@@ -215,13 +217,13 @@ describe Bookstore do
       end
 
       it "should fetch the first, open book, if the second book is closed, even with :prefer_writeable => false" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_false
         @book2.ReadOnly.should be_true
         @book2.close
-        new_book = @bookstore.fetch(@simple_file, :prefer_writable => false)
-        new_book2 = @bookstore.fetch(@simple_file)
+        new_book = @bookstore.fetch(@simple_file1, :prefer_writable => false)
+        new_book2 = @bookstore.fetch(@simple_file1)
         new_book.should_not == @book2
         new_book2.should_not == @book2
         new_book.should == @book
@@ -245,13 +247,13 @@ describe Bookstore do
       end
 
       it "should fetch the second, writable book" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_true
         @book2.ReadOnly.should be_false
-        new_book = @bookstore.fetch(@simple_file)
-        new_book2 = @bookstore.fetch(@simple_file, :prefer_writable => true)
-        new_book3 = @bookstore.fetch(@simple_file, :prefer_writable => false)
+        new_book = @bookstore.fetch(@simple_file1)
+        new_book2 = @bookstore.fetch(@simple_file1, :prefer_writable => true)
+        new_book3 = @bookstore.fetch(@simple_file1, :prefer_writable => false)
         new_book.should == @book2
         new_book2.should == @book2
         new_book3.should == @book2
@@ -264,19 +266,19 @@ describe Bookstore do
       end
 
       it "should fetch the recent readonly book when there are only readonly books" do
-        @book2 = Book.open(@simple_file, :force_excel => :new, :read_only => true)
+        @book2 = Book.open(@simple_file1, :force_excel => :new, :read_only => true)
         @bookstore.store(@book2)
         @book.ReadOnly.should be_true
         @book2.ReadOnly.should be_true
-        new_book = @bookstore.fetch(@simple_file)
+        new_book = @bookstore.fetch(@simple_file1)
         new_book.should == @book2
         new_book.should_not == @book
         new_book.close
       end
 
       it "should fetch the second, writable book, if a writable, a readonly and an unsaved readonly book exist" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
-        @book3 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
+        @book3 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @bookstore.store(@book3)
         sheet = @book3.sheet(1)
@@ -285,8 +287,8 @@ describe Bookstore do
         @book2.ReadOnly.should be_false
         @book3.ReadOnly.should be_true
         @book3.Saved.should be_false
-        new_book = @bookstore.fetch(@simple_file)
-        new_book2 = @bookstore.fetch(@simple_file, :prefer_writable => false)
+        new_book = @bookstore.fetch(@simple_file1)
+        new_book2 = @bookstore.fetch(@simple_file1, :prefer_writable => false)
         new_book.should == @book2
         new_book2.should == @book3
         new_book.should_not == @book        
@@ -301,9 +303,10 @@ describe Bookstore do
     context "with several closed books" do
       
       before do
-        @book = Book.open(@simple_file)
+        @book = Book.open(@simple_file1)
+        @bookstore.store(@book)
         @bookstore.store(@book)
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)
         @book.close
         @book2.close
@@ -341,13 +344,12 @@ describe Bookstore do
       end
     end
 
-
     context "with given excel instance and fetching readonly" do
       
       before do
-        @book = Book.open(@simple_file)
+        @book = Book.open(@simple_file1)
         @bookstore.store(@book)
-        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book2 = Book.open(@simple_file1, :force_excel => :new)
         @bookstore.store(@book2)        
       end
 
@@ -391,23 +393,64 @@ describe Bookstore do
       end
 
       it "should have forgotten some books if they have no reference anymore" do
-        different_file1 = @different_file
-        simple_file1 = @simple_file
-        book_new = Book.open(different_file1)
+        book_new = Book.open(@different_file1)
         @bookstore.store(book_new)
         @book = nil
         @book = "Bla"
-        @book = Book.open(simple_file1)
+        @book = Book.open(@simple_file1)
         @bookstore.store(@book)
         @book = nil
         GC.start
         sleep 1
         #@bookstore.fetch(simple_file1).should == nil
-        @bookstore.fetch(different_file1).should == book_new
+        @bookstore.fetch(@different_file1).should == book_new
       end
     end
   end
 
+  describe "books" do
+
+    before do
+       @book = Book.open(@simple_file)
+       @bookstore.store(@book)
+       @book2 = Book.open(@different_file)
+       @bookstore.store(@book2)
+    end
+
+    after do
+      @book.close
+      @book2.close
+    end
+
+    it "should show books" do
+      expect{
+        @bookstore.books}.to_not raise_error
+    end
+
+  end
+
+  describe "print" do
+
+    before do
+       @book = Book.open(@simple_file)
+       @bookstore.store(@book)
+       @book2 = Book.open(@different_file)
+       @bookstore.store(@book2)
+    end
+
+    after do
+      @book.close
+      @book2.close
+    end
+
+    it "should print books" do
+      @bookstore.print
+    end
+
+  end
+
+
+
   describe "hidden_excel" do
     
     context "with some open book" do

data/spec/excel_spec.rb

@@ -839,6 +839,94 @@ module RobustExcelOle
       end
     end
 
+    describe "unsaved_known_workbooks" do
+
+      it "should return empty list" do
+        Excel.unsaved_known_workbooks.should be_empty
+      end
+
+      it "should return empty list for first Excel instance" do
+        book = Book.open(@simple_file)
+        Excel.unsaved_known_workbooks.should == [[]]
+        book.close
+      end
+       
+      it "should return one unsaved book" do
+        book = Book.open(@simple_file)
+        sheet = book.sheet(1)
+        sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
+        # Excel.unsaved_known_workbooks.should == [[book.ole_workbook]]
+        unsaved_known_wbs = Excel.unsaved_known_workbooks
+        unsaved_known_wbs.size.should == 1
+        unsaved_known_wbs.each do |ole_wb_list|
+          ole_wb_list.size.should == 1
+          ole_wb_list.each do |ole_workbook|
+            ole_workbook.Fullname.tr('\\','/').should == @simple_file  
+          end
+        end
+        book2 = Book.open(@another_simple_file)
+        # Excel.unsaved_known_workbooks.should == [[book.ole_workbook]]
+        unsaved_known_wbs = Excel.unsaved_known_workbooks
+        unsaved_known_wbs.size.should == 1
+        unsaved_known_wbs.each do |ole_wb_list|
+          ole_wb_list.size.should == 1
+          ole_wb_list.each do |ole_workbook|
+            ole_workbook.Fullname.tr('\\','/').should == @simple_file  
+          end
+        end        
+        book2.close
+        book.close(:if_unsaved => :forget)
+      end
+
+      it "should return two unsaved books" do
+        book = Book.open(@simple_file)
+        sheet = book.sheet(1)
+        sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
+        book2 = Book.open(@another_simple_file)
+        sheet2 = book2.sheet(1)
+        sheet2[1,1] = sheet2[1,1].value == "foo" ? "bar" : "foo"
+        #Excel.unsaved_known_workbooks.should == [[book.ole_workbook, book2.ole_workbook]]
+        unsaved_known_wbs = Excel.unsaved_known_workbooks
+        unsaved_known_wbs.size.should == 1
+        unsaved_known_wbs.each do |ole_wb_list|
+          ole_wb_list.size.should == 2
+          ole_workbook1, ole_workbook2 = ole_wb_list
+          ole_workbook1.Fullname.tr('\\','/').should == @simple_file  
+          ole_workbook2.Fullname.tr('\\','/').should == @another_simple_file  
+        end        
+        book2.close(:if_unsaved => :forget)
+        book.close(:if_unsaved => :forget)
+      end
+
+      it "should return two unsaved books" do
+        book = Book.open(@simple_file)
+        sheet = book.sheet(1)
+        sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
+        book2 = Book.open(@another_simple_file, :force_excel => :new)
+        sheet2 = book2.sheet(1)
+        sheet2[1,1] = sheet2[1,1].value == "foo" ? "bar" : "foo"
+        #Excel.unsaved_known_workbooks.should == [[book.ole_workbook], [book2.ole_workbook]]
+        unsaved_known_wbs = Excel.unsaved_known_workbooks
+        unsaved_known_wbs.size.should == 2
+        ole_wb_list1, ole_wb_list2 = unsaved_known_wbs
+        ole_wb_list1.each do |ole_wb_list|
+          ole_wb_list1.size.should == 1
+          ole_wb_list1.each do |ole_workbook|
+            ole_workbook.Fullname.tr('\\','/').should == @simple_file  
+          end
+        end
+        ole_wb_list2.each do |ole_wb_list|
+          ole_wb_list2.size.should == 1
+          ole_wb_list2.each do |ole_workbook|
+            ole_workbook.Fullname.tr('\\','/').should == @another_simple_file  
+          end
+        end
+        book2.close(:if_unsaved => :forget)
+        book.close(:if_unsaved => :forget)
+      end
+
+    end
+
     describe "alive" do
 
       it "should yield alive" do
@@ -1450,6 +1538,45 @@ module RobustExcelOle
 
     end
 
+    describe "set_options" do
+
+      before do
+        @excel = Excel.new(:reuse => false)
+      end
+
+      it "should set options" do
+        @excel.set_options(:displayalerts => true, :visible => true, :screenupdating => true, :calculaiton => :manual)
+        @excel.DisplayAlerts.should be_true
+        @excel.Visible.should be_true
+        @excel.ScreenUpdating.should be_true
+        book = Book.open(@simple_file)
+        @excel.Calculation.should == -4135
+        book.close
+      end
+
+    end
+
+    describe "excel_processes" do
+
+      it "should return empty list" do
+        Excel.excel_processes.should be_empty
+      end
+
+      it "should return list of one Excel process" do
+        excel = Excel.new
+        Excel.excel_processes.should == [excel]
+        excel.close
+      end
+
+      it "should return list of two Excel processes" do
+        excel1 = Excel.new
+        excel2 = Excel.current
+        excel3 = Excel.create
+        Excel.excel_processes.should == [excel1,excel3]
+      end
+
+    end
+
     context "with hwnd and hwnd2excel" do
       
       before do

data/spec/general_spec.rb

@@ -49,7 +49,13 @@ module RobustExcelOle
           ["ActiveCell", "ActiveSheet", "ActiveWorkbook", "Application",  "Calculate", "Cells", "Columns",
             "DisplayAlerts", "Evaluate", "Hwnd", "Name", "Names", "Quit", "Range", "Ready", "Save", 
             "Sheets", "UserName", "Value", "Visible", "Workbooks", "Worksheets"]
-        @excel_methods = ["alive?", "book_class", "close", "displayalerts", "recreate", "visible", "with_displayalerts"] 
+        @excel_methods = ["alive?", "book_class", "close", "displayalerts", "recreate", "visible", 
+          "with_displayalerts"] 
+        @ole_sheet_methods = []
+         # ["Activate", "Calculate", "Copy", "Name", "Select", "Evaluate", "Protect", "Unprotect"]
+        @sheet_methods = ["book_class", "col_range", "each", "each_column", "each_column_with_index",
+                          "each_row", "each_row_with_index", "nameval", "rangeval", 
+                          "set_rangeval", "row_range", "set_nameval"]
       end
 
       after do
@@ -84,6 +90,20 @@ module RobustExcelOle
         @excel_methods.each{|m| @book1.excel.respond_to?(m).should be_true}
       end
 
+      it "should do methods for sheet" do
+        ((@ole_sheet_methods + @sheet_methods) - @book1.sheet(1).methods).should be_empty
+        (Object.instance_methods.select{|m| m =~ /^(?!\_)/}  - @book1.sheet(1).methods).sort.should be_empty       
+      end
+
+      it "should do own_methods with popular ole_excel and excel methods" do
+        ((@ole_sheet_methods + @sheet_methods) - @book1.sheet(1).own_methods).should == [] #be_empty
+         (Object.instance_methods - @book1.sheet(1).own_methods).should == Object.instance_methods
+      end
+
+      it "should respond to popular sheet methods" do
+        @sheet_methods.each{|m| @book1.sheet(1).respond_to?(m).should be_true}
+      end
+
     end
 
     describe "#absolute_path" do
@@ -157,6 +177,20 @@ module RobustExcelOle
       end
     end
 
+    describe "path" do
+
+      it "should create a path" do
+        path1 = "this" / "is" / "a" / "path"
+        path1.should == "this/is/a/path"
+        path2 = "this" / "is" / "a" / "path" / 
+        #path2.should == "this/is/a/path/"
+        path3 = "this" / 
+        #path3.should == "this/"
+        path4 = "this" / nil
+        path4.should == "this"
+      end
+    end
+
     describe "Object methods" do
 
       before do

data/spec/reo_common_spec.rb

@@ -104,5 +104,27 @@ module RobustExcelOle
       end
 
     end
+
+    describe "misc" do
+
+      LOG_TO_STDOUT = true
+      REOCommon::trace "foo"
+
+      LOG_TO_STDOUT = false
+      REOCommon::trace "foo"
+
+      REO_LOG_DIR = ""
+      REOCommon::trace "foo"
+
+      REO_LOG_DIR = "C:"
+      REOCommon::trace "foo"
+
+      REOCommon::tr1 "foo"
+
+      h = {:a => {:c => 4}, :b => 2}
+      REOCommon::puts_hash(h)
+ 
+    end
+
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: robust_excel_ole
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: false
   segments: 
   - 1
   - 0
-  - 2
-  version: 1.0.2
+  - 3
+  version: 1.0.3
 platform: ruby
 authors: 
 - traths
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-07-26 00:00:00 +02:00
+date: 2017-08-27 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency