robust_excel_ole 0.6.1 → 0.6.2

data/spec/book_specs/book_misc_spec.rb

@@ -257,7 +257,21 @@ describe Book do
     it "should set visible and displayalerts if displayalerts => :if_visible" do
       book1 = Book.open(@simple_file)
       book1.excel.Visible.should be_false
-      book1.excel.displayalerts = :if_visible
+      book1.excel.displayalerts.should == :if_visible
+      book1.Windows(book1.Name).Visible.should be_true
+      book1.visible.should be_false
+      book2 = Book.open(@different_file)
+      book2.excel.Visible.should be_false
+      book2.Windows(book2.Name).Visible.should be_true
+      book2.visible.should be_false
+      book2.excel.visible.should be_false
+      book2.excel.displayalerts.should == :if_visible
+      book2.excel.DisplayAlerts.should be_false
+    end
+
+    it "should set visible and displayalerts if displayalerts => :if_visible" do
+      book1 = Book.open(@simple_file)
+      book1.excel.Visible.should be_false
       book1.excel.displayalerts.should == :if_visible
       book1.Windows(book1.Name).Visible.should be_true
       book1.visible.should be_false
@@ -266,7 +280,7 @@ describe Book do
       book2.Windows(book2.Name).Visible.should be_true
       book2.visible.should be_true
       book2.excel.visible.should be_true
-      book2.excel.displayalerts.should be_true
+      book2.excel.displayalerts.should == :if_visible
       book2.excel.DisplayAlerts.should be_true
     end
   end
@@ -428,7 +442,7 @@ describe Book do
     end
   end
 
-  describe "alive?, filename, ==, visible, activate, saved, check_compatibility" do
+  describe "alive?, filename, ==, visible, focus, saved, check_compatibility" do
 
     context "with alive?" do
 
@@ -671,13 +685,13 @@ describe Book do
 
     end
 
-    context "with activate" do
+    context "with focus" do
 
       before do
         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"        
         @book = Book.open(@simple_file, :visible => true)
         @book.excel.displayalerts = false
-        @book2 = Book.open(@another_simple_file, :force_excel => :new, :visible => true)
+        @book2 = Book.open(@another_simple_file, :visible => true)
         @book2.excel.displayalerts = false
       end
 
@@ -687,7 +701,7 @@ describe Book do
         @key_sender.close
       end
 
-      it "should activate a book" do
+      it "should bring a book to focus" do
         sheet = @book.sheet(2)
         sheet.Activate
         sheet[2,3].Activate
@@ -695,12 +709,12 @@ describe Book do
         sheet2.Activate
         sheet2[3,2].Activate
         Excel.current.should == @book.excel
-        @book2.activate
+        @book2.focus
         @key_sender.puts "{a}{enter}"
         sleep 1
         sheet2[3,2].Value.should == "a"
         #Excel.current.should == @book2.excel
-        @book.activate
+        @book.focus
         @key_sender.puts "{a}{enter}"
         sleep 1
         sheet[2,3].Value.should == "a"

data/spec/book_specs/book_open_spec.rb

@@ -1039,7 +1039,7 @@ describe Book do
         File.delete @simple_save_file rescue nil
         expect {
           Book.open(@simple_save_file, :if_absent => :raise)
-        }.to raise_error(FileNotFound, "file \"#{@simple_save_file}\" not found")
+        }.to raise_error(FileNotFound, "file #{General::absolute_path(@simple_save_file).gsub("/","\\").inspect} not found")
       end
 
       it "should create a workbook" do
@@ -1054,7 +1054,7 @@ describe Book do
         File.delete @simple_save_file rescue nil
         expect {
           Book.open(@simple_save_file)
-        }.to raise_error(FileNotFound, "file \"#{@simple_save_file}\" not found")
+        }.to raise_error(FileNotFound, "file #{General::absolute_path(@simple_save_file).gsub("/","\\").inspect} not found")
       end
 
     end
@@ -1237,7 +1237,7 @@ describe Book do
         expected_path = Regexp.new(File.expand_path(path).gsub(/\//, "."))
         expect {
           Book.open(path)
-        }.to raise_error(FileNotFound, "file \"#{path}\" not found")
+        }.to raise_error(FileNotFound, "file #{General::absolute_path(path).gsub("/","\\").inspect} not found")
       end
     end
   end

data/spec/book_specs/book_save_spec.rb

@@ -144,7 +144,7 @@ describe Book do
 
       after do
         @book.close(:if_unsaved => :forget)
-        @book2.close
+        @book2.close(:if_unsaved => :forget)
       end
 
       it "should raise an error with :obstructed => :raise" do

data/spec/book_specs/book_sheet_spec.rb

@@ -172,11 +172,13 @@ describe Book do
       end
     
       it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-        @book.add_sheet(@sheet, :after => @sheet, :before => @book.sheet(3)).name.should eq @book.sheet(3).name
+        @book.add_sheet(@sheet, :after => @sheet, :before => @book.sheet(3))
+        @book.Worksheets.Count.should == 4
       end
 
       it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-        @book.add_sheet(@sheet, :before => @book.sheet(3), :after => @sheet).name.should eq @book.sheet(3).name
+        @book.add_sheet(@sheet, :before => @book.sheet(3), :after => @sheet)
+        @book.Worksheets.Count.should == 4
       end
         
       it "should raise error with giving a name that already exists" do
@@ -270,11 +272,13 @@ describe Book do
     end
   
     it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-      @book.copy_sheet(@sheet, :after => @sheet, :before => @book.sheet(3)).name.should eq @book.sheet(3).name
+      @book.copy_sheet(@sheet, :after => @sheet, :before => @book.sheet(3))
+      @book.Worksheets.Count.should == 4
     end
 
     it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-      @book.copy_sheet(@sheet, :before => @book.sheet(3), :after => @sheet).name.should eq @book.sheet(3).name
+      @book.copy_sheet(@sheet, :before => @book.sheet(3), :after => @sheet)
+      @book.Worksheets.Count.should == 4
     end
       
     it "should raise error with giving a name that already exists" do
@@ -370,11 +374,13 @@ describe Book do
       end
     
       it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-        @book.add_or_copy_sheet(@sheet, :after => @sheet, :before => @book.sheet(3)).name.should eq @book.sheet(3).name
+        @book.add_or_copy_sheet(@sheet, :after => @sheet, :before => @book.sheet(3))
+        @book.Worksheets.Count.should == 4
       end
 
       it "should copy the first sheet before the third sheet and give 'before' the highest priority" do
-        @book.add_or_copy_sheet(@sheet, :before => @book.sheet(3), :after => @sheet).name.should eq @book.sheet(3).name
+        @book.add_or_copy_sheet(@sheet, :before => @book.sheet(3), :after => @sheet)
+        @book.Worksheets.Count.should == 4
       end
         
       it "should raise error with giving a name that already exists" do

data/spec/book_specs/book_unobtr_spec.rb

@@ -32,7 +32,7 @@ describe Book do
 
   after do
     Excel.kill_all
-    rm_tmp(@dir)
+    #rm_tmp(@dir)
   end
 
   
@@ -238,29 +238,23 @@ describe Book do
       end    
 
       it "should set checkcompatibilty to true" do
+        @book.CheckCompatibility.should be_false
         Book.unobtrusively(@simple_file, :check_compatibility => true) do |book|
           book.should be_a Book
           book.CheckCompatibility.should be_true
         end
-        @book.CheckCompatibility.should be_true
+        @book.CheckCompatibility.should be_false
       end
 
       it "should set the checkcompatibilty to false" do
+        @book.CheckCompatibility.should be_false
         Book.unobtrusively(@simple_file, :check_compatibility => false) do |book|
           book.should be_a Book
           book.CheckCompatibility.should be_false
         end
-        @book.CheckCompatibility.should be_true
-      end
-
-      it "should set the checkcompatibilty to false" do
-        @book.CheckCompatibility = false
-        Book.unobtrusively(@simple_file, :check_compatibility => true) do |book|
-          book.should be_a Book
-          book.CheckCompatibility.should be_true
-        end
         @book.CheckCompatibility.should be_false
       end
+
     end
     
     context "with a closed book" do

data/spec/excel_spec.rb

@@ -12,6 +12,7 @@ module RobustExcelOle
 
     before(:all) do
       Excel.kill_all
+      sleep 0.2
     end
 
     before do
@@ -161,6 +162,7 @@ module RobustExcelOle
       it "should create a new Excel if there is no Excel to connect with" do
         excel1 = Excel.create
         excel1.close
+        sleep 0.2
         excel2 = Excel.current
         excel1.should_not be_alive
         excel2.should be_alive
@@ -171,6 +173,7 @@ module RobustExcelOle
         excel1 = Excel.create
         excel2 = Excel.current
         excel1.close
+        sleep 0.2
         excel1.should_not be_alive
         excel2.should_not be_alive
         sleep 0.2
@@ -181,6 +184,7 @@ module RobustExcelOle
         excel1 = Excel.create
         excel2 = Excel.create
         excel2.close
+        sleep 0.2
         excel3 = Excel.current
         excel3.should === excel1
       end
@@ -198,12 +202,14 @@ module RobustExcelOle
 
     context "excels_number" do
         
-      it "should return right number of excel instances" do        
-        Excel.excels_number.should == 0
+      it "should return right number of excel instances" do
+        Excel.kill_all
+        sleep 0.2
+        n1 = Excel.excels_number
         e1 = Excel.create
-        Excel.excels_number.should == 1
+        Excel.excels_number.should == n1 + 1
         e2 = Excel.create
-        Excel.excels_number.should == 2
+        Excel.excels_number.should == n1 + 2
       end
     end
 
@@ -302,8 +308,9 @@ module RobustExcelOle
         end
 
         it "should recreate several Excel instances" do  
-          @excel1.close
+          @excel1.close(:if_unsaved => :forget)
           @excel3.close
+          sleep 0.2
           @excel1.should_not be_alive
           @excel3.should_not be_alive
           @excel1.recreate(:reopen_workbooks => true, :displayalerts => true)
@@ -321,9 +328,11 @@ module RobustExcelOle
           @book3.reopen
           @book3.should be_alive
           @book3.excel.should == @excel3
-          @excel1.close
+          @excel1.close(:if_unsaved => :forget)
+          sleep 0.2
           @excel1.should_not be_alive
           @excel3.close
+          sleep 0.2
           @excel3.should_not be_alive
         end
       end    
@@ -363,6 +372,7 @@ module RobustExcelOle
         it "should close one Excel instance" do
           excel1 = Excel.create
           Excel.close_all
+          sleep 0.2
           excel1.should_not be_alive
           Excel.excels_number.should == 0
         end
@@ -371,99 +381,162 @@ module RobustExcelOle
           excel1 = Excel.create
           excel2 = Excel.create
           Excel.close_all
+          sleep 0.2
           excel1.should_not be_alive
           excel2.should_not be_alive
           Excel.excels_number.should == 0
         end
       end
 
-      context "with unsaved_workbooks" do
-        
-        before do          
-          book1 = Book.open(@simple_file1, :force_excel => :new)
-          book2 = Book.open(@different_file, :force_excel => :new)          
-          @excel1 = book1.excel
-          sheet1 = book1.sheet(1)
-          @old_cell_value1 = sheet1[1,1].value
-          sheet1[1,1] = sheet1[1,1].value == "foo" ? "bar" : "foo"
-          @excel2 = book2.excel
-          sheet2 = book2.sheet(1)
-          @old_cell_value2 = sheet2[1,1].value
-          sheet2[1,1] = sheet2[1,1].value == "foo" ? "bar" : "foo"
-        end
+      context "with unsaved workbooks" do
 
-        it "should close the first Excel without unsaved workbooks and then raise an error" do
-          expect{
-            Excel.close_all(:if_unsaved => :raise)
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
-          @excel1.should be_alive
-          @excel2.should be_alive
-        end
+        context "with three Excel instances" do
 
-        it "should close the first Excel without unsaved workbooks and then raise an error per default" do
-          expect{
-            Excel.close_all
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
-          @excel1.should be_alive
-          @excel2.should be_alive
-        end
+         before do          
+            @book1 = Book.open(@simple_file1, :force_excel => :new)
+            @book2 = Book.open(@another_simple_file, :force_excel => :new) 
+            @book3 = Book.open(@different_file, :force_excel => :new)                 
+          end
 
-        it "should close the Excel instances with saving the unsaved workbooks" do
-          Excel.close_all(:if_unsaved => :save)
-          @excel1.should_not be_alive
-          @excel2.should_not be_alive
-          new_book1 = Book.open(@simple_file1)
-          new_sheet1 = new_book1.sheet(1)
-          new_sheet1[1,1].value.should_not == @old_cell_value1
-          new_book1.close   
-          new_book2 = Book.open(@different_file1)
-          new_sheet2 = new_book2.sheet(1)
-          new_sheet2[1,1].value.should_not == @old_cell_value2
-          new_book2.close
-        end
+          it "should close the 2nd and 3rd Excel instances that have saved workbooks" do
+            old_cell_value1 = @book1.sheet(1)[1,1].value
+            @book1.sheet(1)[1,1] = old_cell_value1 == "foo" ? "bar" : "foo"
+            expect{
+              Excel.close_all(:if_unsaved => :raise)
+            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
+            sleep 0.2
+            @book1.excel.should be_alive
+            @book2.excel.should_not be_alive
+            @book3.excel.should_not be_alive
+            @book1.should be_alive
+            @book2.should_not be_alive
+            @book3.should_not be_alive            
+          end
 
-        it "should close the Excel instances without saving the unsaved workbooks" do          
-          Excel.close_all(:if_unsaved => :forget)
-          @excel1.should_not be_alive
-          @excel2.should_not be_alive
-          new_book1 = Book.open(@simple_file1)
-          new_sheet1 = new_book1.sheet(1)
-          new_sheet1[1,1].value.should == @old_cell_value1
-          new_book1.close   
-          new_book2 = Book.open(@different_file1)
-          new_sheet2 = new_book2.sheet(1)
-          new_sheet2[1,1].value.should == @old_cell_value2
-          new_book2.close   
-        end       
+          it "should close the 1st and 3rd Excel instances that have saved workbooks" do
+            old_cell_value2 = @book2.sheet(1)[1,1].value
+            @book2.sheet(1)[1,1] = old_cell_value2 == "foo" ? "bar" : "foo"
+            expect{
+              Excel.close_all(:if_unsaved => :raise)
+            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
+            sleep 0.2
+            @book2.excel.should be_alive
+            @book1.excel.should_not be_alive
+            @book3.excel.should_not be_alive
+            @book2.should be_alive
+            @book1.should_not be_alive
+            @book3.should_not be_alive            
+          end
+
+          it "should close the 2nd and 3rd Excel instances that have saved workbooks" do
+            old_cell_value3 = @book3.sheet(1)[1,1].value
+            @book3.sheet(1)[1,1] = old_cell_value3 == "foo" ? "bar" : "foo"
+            expect{
+              Excel.close_all(:if_unsaved => :raise)
+            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
+            sleep 0.2
+            @book3.excel.should be_alive
+            @book1.excel.should_not be_alive
+            @book2.excel.should_not be_alive
+            @book3.should be_alive
+            @book1.should_not be_alive
+            @book2.should_not be_alive            
+          end
 
-        it "should raise an error for invalid option" do
-          expect {
-            Excel.close_all(:if_unsaved => :invalid_option)
-          }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option") 
         end
 
-      end
+        context "with two Excel instances" do
+          
+          before do          
+            book1 = Book.open(@simple_file1, :force_excel => :new)
+            book2 = Book.open(@different_file, :force_excel => :new)          
+            @excel1 = book1.excel
+            sheet1 = book1.sheet(1)
+            @old_cell_value1 = sheet1[1,1].value
+            sheet1[1,1] = sheet1[1,1].value == "foo" ? "bar" : "foo"
+            @excel2 = book2.excel
+            sheet2 = book2.sheet(1)
+            @old_cell_value2 = sheet2[1,1].value
+            sheet2[1,1] = sheet2[1,1].value == "foo" ? "bar" : "foo"
+          end
+
+          it "should close the first Excel without unsaved workbooks and then raise an error" do
+            expect{
+              Excel.close_all(:if_unsaved => :raise)
+            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
+            sleep 0.2
+            @excel1.should be_alive
+            @excel2.should be_alive
+          end
 
-      context "with unsaved workbooks simple" do
+          it "should close the first Excel without unsaved workbooks and then raise an error per default" do
+            expect{
+              Excel.close_all
+            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks")
+            sleep 0.2
+            @excel1.should be_alive
+            @excel2.should be_alive
+          end
 
-        it "should save the unsaved workbook" do
-          book1 = Book.open(@simple_file, :visible => true)
-          book1.sheet(1)[1,1] = "bar"
-          book1.Saved.should be_false
-          Excel.close_all(:if_unsaved => :save)
-        end
+          it "should close the Excel instances with saving the unsaved workbooks" do
+            Excel.close_all(:if_unsaved => :save)
+            sleep 0.2
+            @excel1.should_not be_alive
+            @excel2.should_not be_alive
+            new_book1 = Book.open(@simple_file1)
+            new_sheet1 = new_book1.sheet(1)
+            new_sheet1[1,1].value.should_not == @old_cell_value1
+            new_book1.close   
+            new_book2 = Book.open(@different_file1)
+            new_sheet2 = new_book2.sheet(1)
+            new_sheet2[1,1].value.should_not == @old_cell_value2
+            new_book2.close
+          end
+
+          it "should close the Excel instances without saving the unsaved workbooks" do          
+            Excel.close_all(:if_unsaved => :forget)
+            sleep 0.2
+            @excel1.should_not be_alive
+            @excel2.should_not be_alive
+            new_book1 = Book.open(@simple_file1)
+            new_sheet1 = new_book1.sheet(1)
+            new_sheet1[1,1].value.should == @old_cell_value1
+            new_book1.close   
+            new_book2 = Book.open(@different_file1)
+            new_sheet2 = new_book2.sheet(1)
+            new_sheet2[1,1].value.should == @old_cell_value2
+            new_book2.close   
+          end       
+
+          it "should raise an error for invalid option" do
+            expect {
+              Excel.close_all(:if_unsaved => :invalid_option)
+            }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option") 
+          end
 
-        it "should forget the unsaved workbook" do
-          book1 = Book.open(@simple_file, :visible => true)
-          excel1 = book1.excel
-          excel1.displayalerts = false
-          sheet1 = book1.sheet(1)
-          old_cell_value1 = sheet1[1,1].value
-          sheet1[1,1] = sheet1[1,1].value == "foo" ? "bar" : "foo"
-          book1.Saved.should be_false
-          Excel.close_all(:if_unsaved => :forget)
         end
-      end        
+
+        context "with one Excel instance" do
+
+          it "should save the unsaved workbook" do
+            book1 = Book.open(@simple_file, :visible => true)
+            book1.sheet(1)[1,1] = "bar"
+            book1.Saved.should be_false
+            Excel.close_all(:if_unsaved => :save)
+          end
+
+          it "should forget the unsaved workbook" do
+            book1 = Book.open(@simple_file, :visible => true)
+            excel1 = book1.excel
+            excel1.displayalerts = false
+            sheet1 = book1.sheet(1)
+            old_cell_value1 = sheet1[1,1].value
+            sheet1[1,1] = sheet1[1,1].value == "foo" ? "bar" : "foo"
+            book1.Saved.should be_false
+            Excel.close_all(:if_unsaved => :forget)
+          end
+        end        
+      end
     end
 
 =begin
@@ -530,6 +603,7 @@ module RobustExcelOle
           @excel.should be_alive
           @book.should be_alive
           @excel.close
+          sleep 0.2
           @excel.should_not be_alive
           @book.should_not be_alive
         end
@@ -538,6 +612,7 @@ module RobustExcelOle
           @excel.should be_alive
           @book.should be_alive
           @excel.close(:hard => true)
+          sleep 0.2
           @excel.should_not be_alive
           @book.should_not be_alive
         end
@@ -546,6 +621,7 @@ module RobustExcelOle
           @excel.should be_alive
           excel2 = Excel.create
           @excel.close
+          sleep 0.2
           @excel.should_not be_alive
           excel2.should be_alive
         end
@@ -554,6 +630,7 @@ module RobustExcelOle
           @excel.should be_alive
           excel2 = Excel.create
           @excel.close(:hard => true)
+          sleep 0.2
           @excel.should_not be_alive
           excel2.should be_alive
         end
@@ -589,6 +666,7 @@ module RobustExcelOle
           @excel.should be_alive
           @excel.displayalerts = true
           @excel.close(:if_unsaved => :forget)
+          sleep 0.2
           @excel.should_not be_alive
           new_book = Book.open(@simple_file)
           new_sheet = new_book.sheet(1)
@@ -597,7 +675,7 @@ module RobustExcelOle
           new_book2 = Book.open(@another_simple_file)
           new_sheet2 = new_book2.sheet(1)
           new_sheet2[1,1].value.should == @old_cell_value2
-          new_book2.close 
+          new_book2.close(:if_unsaved => :forget)
         end
 
         it "should close the Excel without saving the workbook" do
@@ -605,6 +683,7 @@ module RobustExcelOle
           @excel.should be_alive
           @excel.displayalerts = false
           @excel.close(:if_unsaved => :forget)
+          sleep 0.2
           @excel.should_not be_alive
           new_book = Book.open(@simple_file)
           new_sheet = new_book.sheet(1)
@@ -613,12 +692,13 @@ module RobustExcelOle
           new_book2 = Book.open(@another_simple_file)
           new_sheet2 = new_book2.sheet(1)
           new_sheet2[1,1].value.should == @old_cell_value2
-          new_book2.close 
+          new_book2.close(:if_unsaved => :forget)
         end
 
         it "should close the Excel with saving the workbook" do
           @excel.should be_alive
           @excel.close(:if_unsaved => :save)
+          sleep 0.2
           @excel.should_not be_alive
           new_book = Book.open(@simple_file)
           new_sheet = new_book.sheet(1)
@@ -633,6 +713,7 @@ module RobustExcelOle
         it "should close the Excel with saving the workbook" do
           @excel.should be_alive
           @excel.close(:if_unsaved => :keep_open)
+          sleep 0.2
           @excel.should be_alive
           @excel.close(:if_unsaved => :forget)
         end
@@ -655,6 +736,7 @@ module RobustExcelOle
           @book.should be_alive
           @book.saved.should be_false
           @excel.close(:if_unsaved => :forget, :hard => true)
+          sleep 0.2
           @excel.should_not be_alive
           @book.should_not be_alive
           new_book = Book.open(@simple_file)
@@ -662,6 +744,7 @@ module RobustExcelOle
           new_sheet[1,1].value.should == @old_cell_value
           new_book.close    
           new_book.excel.close(:hard => true)
+          sleep 0.2
           procs = WIN32OLE.connect("winmgmts:\\\\.")
           processes = procs.InstancesOf("win32_process")     
           result = []
@@ -777,6 +860,16 @@ module RobustExcelOle
 
     end
 
+    describe "focus" do
+
+      it "should focus" do
+        excel = Excel.create
+        excel.focus
+        excel.Visible.should be_true
+      end
+
+    end
+
     context "workbooks_visible" do
 
       it "should not raise an error for an empty Excel instance" do
@@ -826,21 +919,62 @@ module RobustExcelOle
 
     end
 
-    context "with Visible and DisplayAlerts, foremost_window" do
+    context "with Visible and DisplayAlerts, focus" do
 
-      it "should set Excel in foremost window" do
+      it "should bring Excel in focus" do
         excel1 = Excel.create
         excel2 = Excel.create
-        excel1.foremost_window
+        excel1.focus
         excel1.Visible.should be_true
         excel1.visible.should be_true
       end
 
+      it "should set default values" do
+        excel1 = Excel.new
+        excel1.Visible.should be_false
+        excel1.DisplayAlerts.should be_false
+        excel1.visible.should be_false
+        excel1.displayalerts.should == :if_visible
+      end
+
+      it "should set visible true" do
+        excel1 = Excel.new(:visible => true)
+        excel1.Visible.should be_true
+        excel1.DisplayAlerts.should be_true
+        excel1.visible.should be_true
+        excel1.displayalerts.should == :if_visible
+      end
+
+      it "should set visible false" do
+        excel1 = Excel.new(:visible => false)
+        excel1.Visible.should be_false
+        excel1.DisplayAlerts.should be_false
+        excel1.visible.should be_false
+        excel1.displayalerts.should == :if_visible
+      end
+
+      it "should set displayalerts true" do
+        excel1 = Excel.new(:displayalerts => true)
+        excel1.Visible.should be_false
+        excel1.DisplayAlerts.should be_true
+        excel1.visible.should be_false
+        excel1.displayalerts.should be_true
+      end
+
+      it "should set displayalerts false" do
+        excel1 = Excel.new(:displayalerts => false)
+        excel1.Visible.should be_false
+        excel1.DisplayAlerts.should be_false
+        excel1.visible.should be_false
+        excel1.displayalerts.should be_false
+      end
 
       it "should use values of the current Excel when reusing" do
         excel1 = Excel.create
         excel1.Visible.should be_false
         excel1.DisplayAlerts.should be_false
+        excel1.visible.should be_false
+        excel1.displayalerts.should == :if_visible
         excel1.Visible = true
         excel1.DisplayAlerts = true
         excel1.Visible.should be_true
@@ -850,13 +984,22 @@ module RobustExcelOle
         excel2.DisplayAlerts.should be_true
       end
 
-      it "should set Excel visible and invisible with current" do
+      it "should take visible and displayalerts from Visible and DisplayAlerts of the connected Excel" do
+        excel1 = Excel.create
+        excel2 = Excel.current
+        excel2.Visible.should be_false
+        excel2.visible.should be_false
+        excel2.DisplayAlerts.should be_false
+        excel2.displayalerts.should == false
+      end
+
+      it "should take Visible and DisplayAlerts from the connected Excel" do
         excel1 = Excel.create
         excel2 = Excel.current(:visible => true)
         excel2.Visible.should be_true
         excel2.visible.should be_true
-        excel2.DisplayAlerts.should be_true
-        excel2.displayalerts.should == :if_visible
+        excel2.DisplayAlerts.should be_false
+        excel2.displayalerts.should be_false
       end
 
       it "should set Excel visible and invisible with current" do
@@ -873,8 +1016,8 @@ module RobustExcelOle
         excel2 = Excel.current(:visible => true)
         excel2.Visible.should be_true
         excel2.visible.should be_true
-        excel2.displayalerts.should == :if_visible
-        excel2.DisplayAlerts.should be_true
+        excel2.displayalerts.should be_false
+        excel2.DisplayAlerts.should be_false
       end
 
       it "should set Excel visible and invisible" do
@@ -883,9 +1026,6 @@ module RobustExcelOle
         excel.visible.should be_true
         excel.DisplayAlerts.should be_true
         excel.displayalerts.should == :if_visible
-        excel6 = Excel.current
-        excel6.should === excel
-        excel6.Visible.should be_true
         excel.visible = false
         excel.Visible.should be_false
         excel.visible.should be_false
@@ -911,19 +1051,19 @@ module RobustExcelOle
         excel3.Visible.should be_false
         excel3.visible.should be_false
         excel3.DisplayAlerts.should be_false
-        excel3.displayalerts.should == :if_visible
+        excel3.displayalerts.should be_false
         excel4 = Excel.current(:visible => true)
         excel4.should === excel
         excel4.Visible.should be_true
         excel4.visible.should be_true
-        excel4.DisplayAlerts.should be_true
-        excel4.displayalerts.should == :if_visible
+        excel4.DisplayAlerts.should be_false
+        excel4.displayalerts.should be_false
         excel5 = Excel.current(:visible => false)
         excel5.should === excel
         excel5.Visible.should be_false
         excel5.visible.should be_false
         excel5.DisplayAlerts.should be_false
-        excel5.displayalerts.should == :if_visible
+        excel5.displayalerts.should be_false
       end
 
       it "should enable or disable Excel DispayAlerts" do        
@@ -1328,11 +1468,16 @@ module RobustExcelOle
           workbooks.Count.should == 2
         end
 
-        it "should raise error when book cannot be saved" do
+        it "should raise error if filename is with wrong path" do
           expect{
             workbook = @excel1.generate_workbook(@invalid_name_file)
-          # not always Unknown ???? ToDo #*#
-          }.to raise_error(UnexpectedError)
+          }.to raise_error(FileNotFound, /could not save workbook with filename/)
+        end
+
+        it "should raise error if filename is nil" do
+          expect{
+            workbook = @excel1.generate_workbook(@nil)
+          }.to raise_error(FileNameNotGiven, "filename is nil")
         end
 
       end