robust_excel_ole 0.4 → 0.5

data/lib/robust_excel_ole/version.rb

@@ -1,3 +1,3 @@
 module RobustExcelOle
-  VERSION = "0.4"
+  VERSION = "0.5"
 end

data/spec/book_spec.rb

@@ -261,7 +261,7 @@ describe Book do
 
       before do
         @book = Book.open(@simple_file)
-        @sheet = @book[0]
+        @sheet = @book.sheet(1)
         @book.add_sheet(@sheet, :as => 'a_name')
       end
 
@@ -285,7 +285,7 @@ describe Book do
         @new_book.should == @book
       end
 
-      context "with :if_unsaved => :alert" do
+      context "with :if_unsaved => :alert or :if_unsaved => :excel" do
         before do
          @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"
         end
@@ -315,6 +315,29 @@ describe Book do
             }.to raise_error(ExcelErrorOpen, "open: user canceled or open error")
           @book.should be_alive
         end
+
+        it "should open the new book and close the unsaved book, if user answers 'yes'" do
+          # "Yes" is the  default. --> language independent
+          @key_sender.puts "{enter}"
+          @new_book = Book.open(@simple_file, :if_unsaved => :excel)
+          @new_book.should be_alive
+          @new_book.filename.downcase.should == @simple_file.downcase
+          @book.should_not be_alive
+        end
+
+        it "should not open the new book and not close the unsaved book, if user answers 'no'" do
+          # "No" is right to "Yes" (the  default). --> language independent
+          # strangely, in the "no" case, the question will sometimes be repeated three times
+          #@book.excel.Visible = true
+          @key_sender.puts "{right}{enter}"
+          @key_sender.puts "{right}{enter}"
+          @key_sender.puts "{right}{enter}"
+          expect{
+            Book.open(@simple_file, :if_unsaved => :excel)
+            }.to raise_error(ExcelErrorOpen, "open: user canceled or open error")
+          @book.should be_alive
+        end
+
       end
     end
 
@@ -324,14 +347,14 @@ describe Book do
 
         context "with and without reopen" do
 
-          before do        
+          before do   
             if i == 1 then 
               book_before = Book.open(@simple_file)
               book_before.close
             end
             @book = Book.open(@simple_file_other_path)
             @sheet_count = @book.ole_workbook.Worksheets.Count
-            @sheet = @book[0]
+            @sheet = @book.sheet(1)
             @book.add_sheet(@sheet, :as => 'a_name')
           end
 
@@ -354,7 +377,7 @@ describe Book do
               if :if_obstructed is :close_if_saved" do
             expect{
               @new_book = Book.open(@simple_file, :if_obstructed => :close_if_saved)
-            }.to raise_error(ExcelErrorOpen, /workbook with the same name in a different path is unsaved: "workbook.xls"/)
+            }.to raise_error(ExcelErrorOpen, /workbook with the same name in a different path is unsaved/)
             @book.save
             @new_book = Book.open(@simple_file, :if_obstructed => :close_if_saved)
             @book.should_not be_alive
@@ -392,7 +415,7 @@ describe Book do
         book = Book.open(@simple_file, :read_only => true)
         book.ReadOnly.should be_true
         book.should be_alive
-        sheet = book[0]
+        sheet = book.sheet(1)
         old_cell_value = sheet[1,1].value
         sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
         book.Saved.should be_false
@@ -401,7 +424,7 @@ describe Book do
         new_book.should be_alive
         book.should be_alive   
         new_book.should == book 
-        new_sheet = new_book[0]
+        new_sheet = new_book.sheet(1)
         new_cell_value = new_sheet[1,1].value
         new_cell_value.should == old_cell_value
       end
@@ -467,7 +490,7 @@ describe Book do
     def unobtrusively_ok? # :nodoc: #
       Book.unobtrusively(@simple_file) do |book|
         book.should be_a Book
-        sheet = book[0]
+        sheet = book.sheet(1)
         sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
         book.should be_alive
         book.Saved.should be_false
@@ -548,17 +571,17 @@ describe Book do
       it "should let a saved book saved" do
         @book.Saved.should be_true
         @book.should be_alive
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         old_cell_value = sheet[1,1].value
         unobtrusively_ok?
         @book.Saved.should be_true
         @book.should be_alive
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         sheet[1,1].value.should_not == old_cell_value
       end
 
      it "should let the unsaved book unsaved" do
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
         old_cell_value = sheet[1,1].value
         @book.Saved.should be_false
@@ -567,7 +590,7 @@ describe Book do
         @book.Saved.should be_false
         @book.close(:if_unsaved => :forget)
         @book2 = Book.open(@simple_file)
-        sheet2 = @book2[0]
+        sheet2 = @book2.sheet(1)
         sheet2[1,1].value.should_not == old_cell_value
       end
     end
@@ -583,21 +606,21 @@ describe Book do
       end
 
       it "should let the closed book closed by default" do
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         old_cell_value = sheet[1,1].value
         @book.close
         @book.should_not be_alive
         unobtrusively_ok?
         @book.should_not be_alive
         @book = Book.open(@simple_file)
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         sheet[1,1].Value.should_not == old_cell_value
       end
 
       # The bold reanimation of the @book
       it "should use the excel of the book and keep open the book" do
         excel = Excel.new(:reuse => false)
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         old_cell_value = sheet[1,1].value
         @book.close
         @book.should_not be_alive
@@ -605,7 +628,7 @@ describe Book do
           book.should be_a Book
           book.excel.should == @book.excel
           book.excel.should_not == excel
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.Saved.should be_false
@@ -613,14 +636,14 @@ describe Book do
         @book.should be_alive
         @book.close
         new_book = Book.open(@simple_file)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].value.should_not == old_cell_value
       end
 
       # book shall be reanimated even with :hidden
       it "should use the excel of the book and keep open the book" do
         excel = Excel.new(:reuse => false)
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         old_cell_value = sheet[1,1].value
         @book.close
         @book.should_not be_alive
@@ -629,14 +652,14 @@ describe Book do
           book.should be_alive
           book.excel.should_not == @book.excel
           book.excel.should_not == excel
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.Saved.should be_false
         end
         @book.should_not be_alive
         new_book = Book.open(@simple_file)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].value.should_not == old_cell_value
       end
     end
@@ -679,13 +702,13 @@ describe Book do
         book2 = Book.open(@simple_file, :force_excel => :new, :read_only => true)
         @book.ReadOnly.should be_true
         book2.Readonly.should be_true
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         cell_value = sheet[1,1].value
         Book.unobtrusively(@simple_file, :hidden) do |book|
           book.should be_a Book
           book.excel.should_not == book2.excel
           book.excel.should_not == @book.excel
-          sheet = book[0]
+          sheet = book.sheet(1)
           sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
           book.should be_alive
           book.Saved.should be_false          
@@ -695,7 +718,7 @@ describe Book do
         @book.close
         book2.close
         book3 = Book.open(@simple_file)
-        new_sheet = book3[0]
+        new_sheet = book3.sheet(1)
         new_sheet[1,1].value.should_not == cell_value
         book3.close
       end
@@ -749,7 +772,7 @@ describe Book do
         @book2 = Book.open(@simple_file, :force_excel => :new)
         @book1.Readonly.should == false
         @book2.Readonly.should == true
-        old_sheet = @book1[0]
+        old_sheet = @book1.sheet(1)
         @old_cell_value = old_sheet[1,1].value
         @book1.close
         @book2.close
@@ -762,13 +785,13 @@ describe Book do
           book.excel.should == @book2.excel
           book.excel.should_not == @book1.excel
           book.ReadOnly.should == false
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.Saved.should be_false
         end
         new_book = Book.open(@simple_file)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].value.should_not == @old_cell_value
       end
 
@@ -777,13 +800,13 @@ describe Book do
           book.excel.should_not == @book2.excel
           book.excel.should_not == @book1.excel
           book.ReadOnly.should == false
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.Saved.should be_false
         end
         new_book = Book.open(@simple_file)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].Value.should_not == @old_cell_value
       end
     end
@@ -821,7 +844,7 @@ describe Book do
 
       before do
         @book = Book.open(@simple_file)
-        sheet = @book[0]
+        sheet = @book.sheet(1)
         @old_cell_value = sheet[1,1].value
         @book.close
       end
@@ -831,21 +854,21 @@ describe Book do
           book.should be_a Book
           book.should be_alive
           book.Saved.should be_true  
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.Saved.should be_false
           book.excel.should == @book.excel
         end
         new_book = Book.open(@simple_file, :visible => true)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].Value.should == @old_cell_value
       end
 
       it "should not change the value and use the hidden Excel instance" do
         new_excel = Excel.new(:reuse => false)
         Book.for_reading(@simple_file, :hidden) do |book|
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.excel.should_not == @book.excel
@@ -854,19 +877,19 @@ describe Book do
           book.excel.displayalerts.should be_false
         end
         new_book = Book.open(@simple_file, :visible => true)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].Value.should == @old_cell_value
       end
 
       it "should change the value" do
         Book.for_modifying(@simple_file) do |book|
-          sheet = book[0]
+          sheet = book.sheet(1)
           cell = sheet[1,1]
           sheet[1,1] = cell.value == "foo" ? "bar" : "foo"
           book.excel.should == @book.excel
         end
         new_book = Book.open(@simple_file, :visible => true)
-        sheet = new_book[0]
+        sheet = new_book.sheet(1)
         sheet[1,1].Value.should_not == @old_cell_value
       end
     end
@@ -889,49 +912,56 @@ describe Book do
     end
   end
 
-  describe "nvalue, set_nvalue, rename_range" do
-    
-    context "nvalue, book[<name>]" do
-    
-      before do
-        @book1 = Book.open(@another_simple_file)
-      end
+  describe "nameval, set_nameval, [], []=" do
+  
+    before do
+      @book1 = Book.open(@another_simple_file)
+    end
 
-      after do
-        @book1.close(:if_unsaved => :forget)
-      end   
-
-      it "should return value of a range" do
-        @book1.nvalue("new").should == "foo"
-        @book1.nvalue("one").should == 1
-        @book1.nvalue("firstrow").should == [[1,2]]        
-        @book1.nvalue("four").should == [[1,2],[3,4]]
-        @book1.nvalue("firstrow").should_not == "12"
-        @book1.nvalue("firstcell").should == "foo"
-        @book1["new"].should == "foo"
-        @book1["one"].should == 1
-        @book1["firstrow"].should == [[1,2]]        
-        @book1["four"].should == [[1,2],[3,4]]        
-        @book1["firstcell"].should == "foo"
-      end
+    after do
+      @book1.close(:if_unsaved => :forget)
+    end   
+
+    it "should return value of a range" do
+      @book1.nameval("new").should == "foo"
+      @book1.nameval("one").should == 1
+      @book1.nameval("firstrow").should == [[1,2]]        
+      @book1.nameval("four").should == [[1,2],[3,4]]
+      @book1.nameval("firstrow").should_not == "12"
+      @book1.nameval("firstcell").should == "foo"        
     end
 
-    context "set_nvalue, book[<name>]=" do
-    
-      before do
-        @book1 = Book.open(@another_simple_file)
-      end
+    it "should return value of a range via []" do
+      @book1["new"].should == "foo"
+      @book1["one"].should == 1
+      @book1["firstrow"] == [[1,2]]        
+      @book1["four"].should == [[1,2],[3,4]]
+      @book1["firstrow"].should_not == "12"
+      @book1["firstcell"].should == "foo"        
+    end
 
-      after do
-        @book1.close(:if_unsaved => :forget)
-      end   
+    it "should set value of a range" do
+      @book1.set_nameval("new", "bar")
+      @book1.nameval("new").should == "bar"
+    end
 
-      it "should set value of a range" do
-        @book1.nvalue("new").should == "foo"
-        @book1["new"] = "bar"
-        @book1.nvalue("new").should == "bar"
-      end
+    it "should set value of a range via []=" do
+      @book1["new"] = "bar"
+      @book1.nameval("new").should == "bar"
+    end
+
+    it "should evaluate a formula" do
+      @book1.nameval("named_formula").should == 4      
     end
+
+    it "should evaluate a formula via []" do
+      @book1["named_formula"].should == 4      
+    end
+
+    it "should return default value if name not defined" do
+      @book1.nameval("foo", :default => 2).should == 2
+    end
+
   end
 
   describe "close" do
@@ -958,7 +988,7 @@ describe Book do
         @book = Book.open(@simple_file)
         @sheet_count = @book.ole_workbook.Worksheets.Count
         @book.add_sheet(@sheet, :as => 'a_name')
-        @sheet = @book[0]
+        @sheet = @book.sheet(1)
       end
 
       after do
@@ -1091,7 +1121,7 @@ describe Book do
       end
 
       it "should activate a book" do
-        sheet = @book[1]
+        sheet = @book.sheet(2)
         sheet.Activate
         sheet[2,3].Activate
         sheet2 = @book2[2]
@@ -1115,7 +1145,7 @@ describe Book do
   describe "#add_sheet" do
     before do
       @book = Book.open(@simple_file)
-      @sheet = @book[0]
+      @sheet = @book.sheet(1)
     end
 
     after do
@@ -1139,9 +1169,9 @@ describe Book do
 
     context "with first argument" do
 
-      context "with second argument is {:before => @book[2], :after => @sheet}" do
+      context "with second argument is {:before => @book.sheet(3), :after => @sheet}" do
         it "should arguments in the first is given priority" do
-          @book.add_sheet(@sheet, :before => @book[2], :after => @sheet).name.should eq @book[2].name
+          @book.add_sheet(@sheet, :before => @book.sheet(3), :after => @sheet).name.should eq @book.sheet(3).name
         end
       end
     end
@@ -1155,13 +1185,13 @@ describe Book do
 
       context "second argument is {:before => @sheet}" do
         it "should add the first sheet" do
-          @book.add_sheet(:before => @sheet).name.should eq @book[0].name
+          @book.add_sheet(:before => @sheet).name.should eq @book.sheet(1).name
         end
       end
 
       context "second argument is {:after => @sheet}" do
         it "should add the second sheet" do
-          @book.add_sheet(:after => @sheet).name.should eq @book[1].name
+          @book.add_sheet(:after => @sheet).name.should eq @book.sheet(2).name
         end
       end
     end
@@ -1188,11 +1218,11 @@ describe Book do
     context "standard" do
 
       it 'with sheet name' do
-        @book['Sheet1'].should be_kind_of Sheet
+        @book.sheet('Sheet1').should be_kind_of Sheet
       end
 
       it 'with integer' do
-        @book[0].should be_kind_of Sheet
+        @book.sheet(1).should be_kind_of Sheet
       end
 
       it 'with block' do
@@ -1205,7 +1235,7 @@ describe Book do
     context 'open with block' do
       it {
         Book.open(@simple_file) do |book|
-          book['Sheet1'].should be_a Sheet
+          book.sheet('Sheet1').should be_a Sheet
         end
       }
     end