robust_excel_ole 0.3.4 → 0.3.5

data/spec/{book_store_spec.rb → bookstore_spec.rb}

@@ -35,7 +35,7 @@ class Book
 end
 
 
-describe BookStore do
+describe Bookstore do
 
   before(:all) do
     excel = Excel.new(:reuse => true)
@@ -45,7 +45,7 @@ describe BookStore do
   end
 
   before do
-    @bookstore = BookStore.new
+    @bookstore = Bookstore.new
     @dir = create_tmpdir
     @simple_file = @dir + '/workbook.xls'
     @simple_save_file = @dir + '/workbook_save.xls'
@@ -62,9 +62,9 @@ describe BookStore do
     context "with standard" do
       it "should create book store" do
         expect {
-          @book_store = BookStore.new
+          @book_store = Bookstore.new
         }.to_not raise_error
-        @book_store.should be_a BookStore
+        @book_store.should be_a Bookstore
       end
     end
   end
@@ -273,7 +273,7 @@ describe BookStore do
         @bookstore.store(@book2)
         @bookstore.store(@book3)
         sheet = @book3[0]
-        sheet[0,0] = sheet[0,0].Value == "simple" ? "complex" : "simple"
+        sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
         @book.ReadOnly.should be_true
         @book2.ReadOnly.should be_false
         @book3.ReadOnly.should be_true

data/spec/cell_spec.rb

@@ -22,7 +22,7 @@ describe RobustExcelOle::Cell do
     before do
       @book = RobustExcelOle::Book.open(@dir + '/workbook.xls', :read_only => true)
       @sheet = @book[1]
-      @cell = @sheet[0, 0]
+      @cell = @sheet[1, 1]
     end
 
     after do
@@ -61,14 +61,14 @@ describe RobustExcelOle::Cell do
     end
 
     it "merged cell get same value" do
-      @sheet[0, 0].value.should be_nil
-      @sheet[1, 0].value.should eq 'first merged'
+      @sheet[1, 1].value.should be_nil
+      @sheet[2, 1].value.should eq 'first merged'
     end
 
     it "set merged cell" do
-      @sheet[1, 0].value = "set merge cell"
-      @sheet[1, 0].value.should eq "set merge cell"
-      @sheet[1, 1].value.should eq "set merge cell"
+      @sheet[2, 1].value = "set merge cell"
+      @sheet[2, 1].value.should eq "set merge cell"
+      @sheet[2, 2].value.should eq "set merge cell"
     end
   end
 end

data/spec/excel_spec.rb

@@ -14,8 +14,11 @@ module RobustExcelOle
 
     before do
       @dir = create_tmpdir
-      @simple_file = @dir + '/simple.xls'
-      @invalid_name_file = 'b/simple.xls'
+      #print "tmpdir: "; p @dir
+      @simple_file = @dir + '/workbook.xls'
+      @another_simple_file = @dir + '/another_workbook.xls'
+      @different_file = @dir + '/different_workbook.xls'
+      @invalid_name_file = 'b/workbook.xls'
     end
 
     after do
@@ -32,6 +35,12 @@ module RobustExcelOle
         @excel.Name.should == "Microsoft Excel"
       end
 
+      it "should access excel.excel" do
+        excel = Excel.new(:reuse => false)
+        excel.excel.should == excel
+        excel.excel.should be_a Excel
+      end
+
       it "should work with 'new' " do
         @excel = Excel.new
         creation_ok?
@@ -93,6 +102,156 @@ module RobustExcelOle
       end
     end
 
+=begin
+      # testing private methods
+      context "close_excel" do
+
+        before do
+          @book = Book.open(@simple_file, :visible => true)
+          @excel = @book.excel
+          @book2 = Book.open(@simple_file, :force_excel => :new, :visible => true)
+          @excel2 = @book2.excel
+        end
+
+        it "should close one Excel" do
+          @excel.should be_alive
+          @excel2.should be_alive
+          @book.should be_alive
+          @book2.should be_alive
+          @excel.close_excel(:hard => false)
+          @excel.should_not be_alive
+          @book.should_not be_alive
+          @excel2.should be_alive
+          @book2.should be_alive
+        end
+      end
+
+=end
+
+    describe "close_all" do
+
+      context "with saved workbooks" do
+
+        before do
+          book = Book.open(@simple_file, :visible => true)
+          book2 = Book.open(@simple_file, :force_excel => :new, :visible => true)
+          @excel = book.excel
+          @excel2 = book2.excel
+        end
+
+        it "should close the Excel instances" do
+          @excel.should be_alive
+          @excel2.should be_alive
+          Excel.close_all
+          @excel.should_not be_alive
+          @excel2.should_not be_alive
+        end
+      end
+    end
+
+    describe "close" do
+
+      context "with a saved workbook" do
+
+        before do
+          @excel = Excel.create
+          @book = Book.open(@simple_file)
+        end
+
+        it "should close the Excel" do
+          @excel.should be_alive
+          @book.should be_alive
+          @excel.close
+          @excel.should_not be_alive
+          @book.should_not be_alive
+        end
+      end
+
+      context "with an unsaved workbook" do
+
+        before do
+          @excel = Excel.create
+          @book = Book.open(@simple_file)
+          sheet = @book[0]
+          @old_cell_value = sheet[1,1].value
+          sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
+        end
+
+        it "should raise an error" do
+          @excel.should be_alive
+          @book.should be_alive
+          @book.saved.should be_false
+          expect{
+            @excel.close(:if_unsaved => :raise)
+          }.to raise_error(ExcelErrorClose, "Excel contains unsaved workbooks")
+          @excel.should be_alive
+          @book.should be_alive
+        end
+
+        it "should close the Excel without saving the workbook" do
+          @excel.should be_alive
+          @book.should be_alive
+          @book.saved.should be_false
+          @excel.close(:if_unsaved => :forget)
+          @excel.should_not be_alive
+          @book.should_not be_alive
+          new_book = Book.open(@simple_file)
+          new_sheet = new_book[0]
+          new_sheet[1,1].value.should == @old_cell_value
+          new_book.close          
+        end
+
+        it "should close the Excel with saving the workbook" do
+          @excel.should be_alive
+          @book.should be_alive
+          @book.saved.should be_false
+          @excel.close(:if_unsaved => :save)
+          @excel.should_not be_alive
+          @book.should_not be_alive
+          new_book = Book.open(@simple_file)
+          new_sheet = new_book[0]
+          new_sheet[1,1].value.should_not == @old_cell_value
+          new_book.close          
+        end
+
+        it "should raise an error for invalid option" do
+          expect {
+            @excel.close(:if_unsaved => :invalid_option)
+          }.to raise_error(ExcelErrorClose, ":if_unsaved: invalid option: invalid_option") 
+        end
+
+        it "should raise an error by default" do
+          @excel.should be_alive
+          @book.should be_alive
+          @book.saved.should be_false
+          expect{
+            @excel.close
+          }.to raise_error(ExcelErrorClose, "Excel contains unsaved workbooks")
+          @excel.should be_alive
+          @book.should be_alive
+        end
+      end
+    end
+
+#        context "with :if_unsaved => :alert" do
+#          before do
+#            @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
+#          end
+#
+#          after do
+#            @key_sender.close
+#          end
+#
+#         possible_answers = [:yes, :no, :cancel]
+#          possible_answers.each_with_index do |answer, position|
+#            it "should" + (answer == :yes ? "" : " not") + " the unsaved book and" + (answer == :cancel ? " not" : "") + " close it" + "if user answers '#{answer}'" do
+#            # "Yes" is the  default. "No" is right of "Yes", "Cancel" is right of "No" --> language independent
+#            @key_sender.puts  "{right}" * position + "{enter}"
+#          end
+#        end
+#      end
+
+
     describe "==" do
       before do
         @excel1 = Excel.create
@@ -236,6 +395,35 @@ module RobustExcelOle
       end
     end
 
+    describe "unsaved_workbooks" do
+
+      context "with standard" do
+        
+        before do
+          @book = Book.open(@simple_file)
+          @book2 = Book.open(@another_simple_file)
+          @book3 = Book.open(@different_file, :read_only => true)
+          sheet = @book[0]
+          sheet[1,1] = sheet[1,1].value == "foo" ? "bar" : "foo"
+          sheet3 = @book3[0]
+          sheet3[1,1] = sheet3[1,1].value == "foo" ? "bar" : "foo"
+        end
+
+        it "should list unsaved workbooks" do
+          @book.Saved.should be_false
+          @book2.Save
+          @book2.Saved.should be_true
+          @book3.Saved.should be_false
+          excel = @book.excel
+          # unsaved_workbooks yields different WIN32OLE objects than book.workbook
+          uw_names = []
+          excel.unsaved_workbooks.each {|uw| uw_names << uw.Name}
+          uw_names.should == [@book.workbook.Name]
+        end
+
+      end
+    end
+
     describe "generate workbook" do
 
       context "with standard" do
@@ -289,7 +477,9 @@ module RobustExcelOle
         it "should raise error when book cannot be saved" do
           expect{
             workbook = @excel1.generate_workbook(@invalid_name_file)
-          }.to raise_error(ExcelErrorSaveUnknown)
+          # not always Unknown ???? ToDo #*#
+          #}.to raise_error(ExcelErrorSaveUnknown)
+          }.to raise_error(ExcelErrorSave)
         end
 
       end
@@ -298,11 +488,20 @@ module RobustExcelOle
 
   describe "RobustExcelOle" do
     context "#absolute_path" do
+      before do
+        @previous_dir = Dir.getwd
+      end
+      
+      after do
+        Dir.chdir @previous_dir
+      end
+
       it "should work" do
         RobustExcelOle::absolute_path("C:/abc").should == "C:\\abc"
         RobustExcelOle::absolute_path("C:\\abc").should == "C:\\abc"
-        RobustExcelOle::absolute_path("C:abc").should == Dir.pwd.gsub("/","\\") + "\\abc"
-        RobustExcelOle::absolute_path("C:abc").should == File.expand_path("abc").gsub("/","\\")
+        Dir.chdir "C:/windows"
+        RobustExcelOle::absolute_path("C:abc").downcase.should == Dir.pwd.gsub("/","\\").downcase + "\\abc"
+        RobustExcelOle::absolute_path("C:abc").upcase.should   == File.expand_path("abc").gsub("/","\\").upcase
       end
 
       it "should return right absolute path name" do

data/spec/range_spec.rb

@@ -14,7 +14,7 @@ describe RobustExcelOle::Range do
     @dir = create_tmpdir
     @book = RobustExcelOle::Book.open(@dir + '/workbook.xls')
     @sheet = @book[1]
-    @range = RobustExcelOle::Range.new(@sheet.sheet.UsedRange.Rows(1))
+    @range = RobustExcelOle::Range.new(@sheet.worksheet.UsedRange.Rows(1))
   end
 
   after do
@@ -50,9 +50,9 @@ describe RobustExcelOle::Range do
     context "when instance is column range" do
       before do
         @sheet = @book[0]
-        @range = RobustExcelOle::Range.new(@sheet.sheet.UsedRange.Columns(1))
+        @range = RobustExcelOle::Range.new(@sheet.worksheet.UsedRange.Columns(1))
       end
-      it { @range.values.should eq ['simple', 'foo', 'matz'] }
+      it { @range.values.should eq ['foo', 'foo', 'matz'] }
     end
 
     context "read 'merge_cells.xls'" do
@@ -67,7 +67,7 @@ describe RobustExcelOle::Range do
 
       context "only merged_cell" do
         before do
-          @only_merged_range = @merge_cells_sheet.row_range(3)
+          @only_merged_range = @merge_cells_sheet.row_range(4)
         end
 
         context "without argument" do
@@ -75,14 +75,14 @@ describe RobustExcelOle::Range do
         end
 
         context "with (1..2)" do
-          it { @only_merged_range.values(1..2).should eq ['merged', 'merged'] }
+          it { @only_merged_range.values(2..3).should eq ['merged', 'merged'] }
         end
 
       end
 
       context "mix merged cell and no merge cell" do
         before do
-          @mix_merged_no_merged_range = @merge_cells_sheet.row_range(1)
+          @mix_merged_no_merged_range = @merge_cells_sheet.row_range(2)
         end
 
         context "without argument" do

data/spec/sheet_spec.rb

@@ -35,7 +35,7 @@ describe RobustExcelOle::Sheet do
       end
 
       it "protected sheet can't be write" do
-        expect { @protected_sheet[0,0] = 'write' }.to raise_error
+        expect { @protected_sheet[1,1] = 'write' }.to raise_error
       end
     end
 
@@ -60,32 +60,58 @@ describe RobustExcelOle::Sheet do
     end
 
     describe "#name=" do
+      
       it 'change sheet1 name to foo' do
         @sheet.name = 'foo'
         @sheet.name.should eq 'foo'
       end
+
+      it "should raise error when adding the same name" do
+        @sheet.name = 'foo'
+        @sheet.name.should eq 'foo'
+        new_sheet = @book.add_sheet @sheet
+        expect{
+          new_sheet.name = 'foo'
+        }.to raise_error(ExcelErrorSheet, "sheet name already exists")
+      end
     end
   end
 
   describe 'access cell' do
-    describe "#[]" do
-      context "access [0,0]" do
-        it { @sheet[0, 0].should be_kind_of RobustExcelOle::Cell }
-        it { @sheet[0, 0].value.should eq 'simple' }
+
+    describe "#[]" do      
+
+      context "access [1,1]" do
+
+        it { @sheet[1, 1].should be_kind_of RobustExcelOle::Cell }
+        it { @sheet[1, 1].value.should eq 'foo' }
       end
 
-      context "access [0, 0], [0, 1], [2, 0]" do
+      context "access [1, 1], [1, 2], [3, 1]" do
         it "should get every values" do
-          @sheet[0, 0].value.should eq 'simple'
-          @sheet[0, 1].value.should eq 'workbook'
-          @sheet[2, 0].value.should eq 'matz'
+          @sheet[1, 1].value.should eq 'foo'
+          @sheet[1, 2].value.should eq 'workbook'
+          @sheet[3, 1].value.should eq 'matz'
         end
       end
+
+      context "supplying nil as parameter" do
+        it "should access [1,1]" do
+          @sheet[1, nil].value.should eq 'foo'
+          @sheet[nil, 1].value.should eq 'foo'
+        end
+      end
+
+    end
+
+    it "change a cell to 'bar'" do
+      @sheet[1, 1] = 'bar'
+      @sheet[1, 1].value.should eq 'bar'
     end
 
-    it "change a cell to 'foo'" do
-      @sheet[0, 0] = 'foo'
-      @sheet[0, 0].value.should eq 'foo'
+    it "should change a cell to nil" do
+      @sheet[1, 1] = nil
+      @sheet[1, 1].value.should eq nil
     end
 
     describe '#each' do
@@ -93,7 +119,7 @@ describe RobustExcelOle::Sheet do
         @sheet.each_with_index do |cell, i|
           case i
           when 0
-            cell.value.should eq 'simple'
+            cell.value.should eq 'foo'
           when 1
             cell.value.should eq 'workbook'
           when 2
@@ -179,7 +205,7 @@ describe RobustExcelOle::Sheet do
         @sheet.each_row_with_index do |rows, idx|
           case idx
           when 0
-            rows.values.should eq ['simple', 'workbook', 'sheet1']
+            rows.values.should eq ['foo', 'workbook', 'sheet1']
           when 1
             rows.values.should eq ['foo', nil, 'foobaaa']
           when 2
@@ -266,9 +292,7 @@ describe RobustExcelOle::Sheet do
                                 [nil, nil, 'third', 'merged']
                            ]
         end
-
       end
-
     end
 
     describe "#each_column_with_index" do
@@ -276,7 +300,7 @@ describe RobustExcelOle::Sheet do
         @sheet.each_column_with_index do |columns, idx|
           case idx
           when 0
-            columns.values.should eq ['simple', 'foo', 'matz']
+            columns.values.should eq ['foo', 'foo', 'matz']
           when 1
             columns.values.should eq ['workbook', nil, 'is']
           when 2
@@ -302,7 +326,7 @@ describe RobustExcelOle::Sheet do
     describe "#row_range" do
       context "with second argument" do
         before do
-          @row_range = @sheet.row_range(0, 1..2)
+          @row_range = @sheet.row_range(1, 2..3)
         end
 
         it { @row_range.should be_kind_of RobustExcelOle::Range }
@@ -314,7 +338,7 @@ describe RobustExcelOle::Sheet do
 
       context "without second argument" do
         before do
-          @row_range = @sheet.row_range(2)
+          @row_range = @sheet.row_range(3)
         end
 
         it "should get all cells" do
@@ -327,7 +351,7 @@ describe RobustExcelOle::Sheet do
     describe "#col_range" do
       context "with second argument" do
         before do
-          @col_range = @sheet.col_range(0, 1..2)
+          @col_range = @sheet.col_range(1, 2..3)
         end
 
         it { @col_range.should be_kind_of RobustExcelOle::Range }
@@ -339,7 +363,7 @@ describe RobustExcelOle::Sheet do
 
       context "without second argument" do
         before do
-          @col_range = @sheet.col_range(1)
+          @col_range = @sheet.col_range(2)
         end
 
         it "should get all cells" do
@@ -349,9 +373,11 @@ describe RobustExcelOle::Sheet do
     end
 
     describe "nvalue" do
-      context "with standard" do
+
+      context "returning the value of a range" do
+      
         before do
-          @book1 = RobustExcelOle::Book.open(@dir + '/more_workbook.xls', :read_only => true)
+          @book1 = RobustExcelOle::Book.open(@dir + '/another_workbook.xls', :read_only => true)
           @sheet1 = @book1[0]
         end
 
@@ -359,28 +385,90 @@ describe RobustExcelOle::Sheet do
           @book1.close
         end   
 
-        it "should return value of a range" do
-          @sheet1.nvalue("Sheet1!firstcell").should == "simple"
+        it "should return value of a range with nvalue and brackets operator" do
+          @sheet1.nvalue("firstcell").should == "foo"
+          @sheet1["firstcell"].should == "foo"
         end
 
         it "should raise an error if name not defined" do
           expect {
-            value = @sheet1.nvalue("Sheet1!foo")
-          }.to raise_error(SheetErrorNValue, "name Sheet1!foo not in sheet")
+            value = @sheet1.nvalue("foo")
+          }.to raise_error(SheetError, "name foo not in sheet")
+          expect {
+            @sheet1["foo"]
+          }.to raise_error(SheetError, "name foo not in sheet")
+        end
+
+        it "should return default value if name not defined" do
+          @sheet1.nvalue("foo", :default => 2).should == 2
         end
+      end
+    end
 
-        # fails
-        #it "should raise an error if name was defined but contents is calcuated" do
-        #  expect {
-        #    value = @sheet1.nvalue("Sheet1!named_formula")
-        #  }.to raise_error(SheetErrorNValue, "range error in sheet")
-        #end
+    describe "set_nvalue" do
+
+      context "setting the value of a range" do
+      
+        before do
+          @book1 = RobustExcelOle::Book.open(@dir + '/another_workbook.xls', :read_only => true)
+          @sheet1 = @book1[0]
+        end
+
+        after do
+          @book1.close
+        end   
+
+        it "should set a range to a value" do
+          @sheet1.nvalue("firstcell").should == "foo"
+          @sheet1[1,1].Value.should == "foo"
+          @sheet1.set_nvalue("firstcell","foo")
+          @sheet1.nvalue("firstcell").should == "foo"
+          @sheet1[1,1].Value.should == "foo"
+          @sheet1["firstcell"] = "bar"
+          @sheet1.nvalue("firstcell").should == "bar"
+          @sheet1[1,1].Value.should == "bar"
+        end
+      end
+    end
+
+    describe "set_name" do
+
+      context "setting the name of a range" do
+
+         before do
+          @book1 = RobustExcelOle::Book.open(@dir + '/another_workbook.xls', :read_only => true, :visible => true)
+          @sheet1 = @book1[0]
+        end
+
+        after do
+          @book1.close
+        end   
+
+        it "should name an unnamed range with a giving address" do
+          expect{
+            @sheet1[1,2].Name.Name
+          }.to raise_error          
+          @sheet1.set_name("foo",1,2)
+          @sheet1[1,2].Name.Name.should == "Sheet1!foo"
+        end
+
+        it "should rename an already named range with a giving address" do
+          @sheet1[1,1].Name.Name.should == "Sheet1!firstcell"
+          @sheet1.set_name("foo",1,1)
+          @sheet1[1,1].Name.Name.should == "Sheet1!foo"
+        end
+
+        it "should raise an error" do
+          expect{
+            @sheet1.set_name("foo",-2,1)
+          }.to raise_error(SheetError, "cannot add name foo to cell with row -2 and column 1")
+        end
       end
     end
 
     describe "#method_missing" do
       it "can access COM method" do
-        @sheet.Cells(1,1).Value.should eq 'simple'
+        @sheet.Cells(1,1).Value.should eq 'foo'
       end
 
       context "unknown method" do