robust_excel_ole 0.3.0 → 0.3.1

data/spec/book_spec.rb

@@ -83,7 +83,7 @@ describe Book do
 
       it "should open unobtrusively" do
         book = Book.open(@simple_file, :if_locked => :take_writable, 
-                                      :if_unsaved => :accept, :if_obstructed => :reuse_excel)
+                                      :if_unsaved => :accept, :if_obstructed => :new_excel)
         book.close
       end
 
@@ -152,6 +152,55 @@ describe Book do
         book2.should be_alive
         book2.close
       end
+
+      it "should yield identical Book objects when reopening and the Excel is closed" do
+        @book.should be_alive
+        @book.close
+        Excel.close_all
+        book2 = Book.open(@simple_file)
+        book2.should be_alive
+        book2.should == @book
+        book2.close
+      end
+
+      it "should yield different Book objects when reopening in a new Excel" do
+        @book.should be_alive
+        old_excel = @book.excel
+        @book.close
+        @book.should_not be_alive
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book2.should_not == @book
+        book2.should be_alive
+        book2.excel.should_not == old_excel
+        book2.close
+      end
+
+      it "should yield different Book objects when reopening in a new given Excel instance" do
+        old_excel = @book.excel
+        new_excel = Excel.new(:reuse => false)
+        @book.close
+        @book.should_not be_alive
+        book2 = Book.open(@simple_file, :force_excel => new_excel)
+        book2.should_not == @book
+        book2.should be_alive
+        book2.excel.should == new_excel
+        book2.excel.should_not == old_excel
+        book2.close
+      end
+
+      it "should yield identical Book objects when reopening in the old excel" do
+        old_excel = @book.excel
+        new_excel = Excel.new(:reuse => false)
+        @book.close
+        @book.should_not be_alive
+        book2 = Book.open(@simple_file, :force_excel => old_excel)
+        book2.should == @book
+        book2.should be_alive
+        book2.excel.should == old_excel
+        @book.should be_alive
+        book2.close
+      end
+
     end
 
     context "with :force_excel" do
@@ -161,7 +210,7 @@ describe Book do
       end
 
       after do
-        @book.close
+        @book.close rescue nil
       end
 
       it "should open in a new Excel" do
@@ -172,9 +221,11 @@ describe Book do
         book2.should_not == @book
         @book.Readonly.should be_false
         book2.Readonly.should be_true
+        book2.close
       end
 
-      it "should open in a given Excel" do
+ 
+      it "should open in a given Excel, not provide identity transparency, because old book readonly, new book writable" do
         book2 = Book.open(@simple_file, :force_excel => :new)
         book2.excel.should_not == @book.excel
         book3 = Book.open(@simple_file, :force_excel => :new)
@@ -185,6 +236,27 @@ describe Book do
         book4.should be_alive
         book4.should be_a Book
         book4.excel.should == book2.excel
+        book4.Readonly.should == true
+        book4.should_not == book2 
+        book4.close
+        book3.close
+      end
+
+      it "should open in a given Excel, provide identity transparency, because book can be readonly, such that the old and the new book are readonly" do
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book2.excel.should_not == @book.excel
+        book3 = Book.open(@simple_file, :force_excel => :new)
+        book3.excel.should_not == book2.excel
+        book3.excel.should_not == @book.excel
+        book2.close
+        book3.close
+        @book.close
+        book4 = Book.open(@simple_file, :force_excel => book2.excel, :read_only => true)
+        book4.should be_alive
+        book4.should be_a Book
+        book4.excel.should == book2.excel
+        book4.ReadOnly.should be_true
+        book4.should == book2
         book4.close
         book3.close
       end
@@ -201,6 +273,7 @@ describe Book do
     context "with :default_excel" do
 
       before do
+        excel = Excel.new(:reuse => false)
         @book = Book.open(@simple_file)
       end
 
@@ -208,7 +281,7 @@ describe Book do
         @book.close rescue nil
       end
 
-      it "should reuse an open book" do
+      it "should use the open book" do
         book2 = Book.open(@simple_file, :default_excel => :reuse)
         book2.excel.should == @book.excel
         book2.should be_alive
@@ -217,19 +290,52 @@ describe Book do
         book2.close
       end
 
-      it "should reopen a book" do
+      it "should reopen the book in the excel instance where it was opened before" do
+        excel = Excel.new(:reuse => false)
         @book.close
-        book2 = Book.open(@simple_file, :default_excel => :reuse)
+        book2 = Book.open(@simple_file)
         book2.should be_alive
         book2.should be_a Book
         book2.excel.should == @book.excel
+        book2.excel.should_not == excel
         book2.filename.should == @book.filename
         @book.should be_alive
         book2.should == @book
         book2.close
       end
 
-      it "should connect to the first opened excel, if the book cannot be reopened" do
+      it "should reopen a book in a new Excel if all Excel instances are closed" do
+        excel = Excel.new(:reuse => false)
+        excel2 = @book.excel
+        fn = @book.filename
+        @book.close
+        Excel.close_all
+        book2 = Book.open(@simple_file, :default_excel => :reuse)
+        book2.should be_alive
+        book2.should be_a Book
+        book2.filename.should == fn
+        @book.should be_alive
+        book2.should == @book
+        book2.close
+      end
+
+      it "should reopen a book in the first opened Excel if the old Excel is closed" do
+        excel = @book.excel
+        Excel.close_all
+        new_excel = Excel.new(:reuse => false)
+        new_excel2 = Excel.new(:reuse => false)
+        book2 = Book.open(@simple_file, :default_excel => :reuse)
+        book2.should be_alive
+        book2.should be_a Book
+        #book2.excel.should_not == excel
+        #book2.excel.should_not == new_excel2
+        #book2.excel.should == new_excel
+        @book.should be_alive
+        book2.should == @book
+        book2.close
+      end
+
+      it "should reopen a book in the first opened excel, if the book cannot be reopened" do
         @book.close
         Excel.close_all
         excel1 = Excel.new(:reuse => false)
@@ -242,6 +348,19 @@ describe Book do
         book2.close
       end
 
+      it "should reopen a book in the excel instance where it was opened most recently" do
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        @book.close
+        book2.close
+        book3 = Book.open(@simple_file)
+        book2.should be_alive
+        book2.should be_a Book
+        book3.excel.should == book2.excel
+        book3.excel.should_not == @book.excel
+        book3.should == book2
+        book3.should_not == @book
+      end
+
       it "should open a new excel, if the book cannot be reopened" do
         @book.close
         new_excel = Excel.new(:reuse => false)
@@ -493,10 +612,13 @@ describe Book do
         @new_book.close
       end
 
-      it "should raise an error, if :if_unsaved is default" do
-        expect {
-          @new_book = Book.open(@simple_file)
-        }.to raise_error(ExcelErrorOpen, "book is already open but not saved (#{File.basename(@simple_file)})")
+     it "should open the book in a new excel instance, if :if_unsaved is default" do
+        @new_book = Book.open(@simple_file)
+        @book.should be_alive
+        @new_book.should be_alive
+        @new_book.filename.should == @book.filename
+        @new_book.excel.should_not == @book.excel       
+        @new_book.close
       end
 
       it "should raise an error, if :if_unsaved is invalid option" do
@@ -574,11 +696,14 @@ describe Book do
             @new_book.excel.should_not == @book.excel
           end
 
-          it "should raise an error, if :if_obstructed is default" do
-            expect {
-              @new_book = Book.open(@simple_file)
-            }.to raise_error(ExcelErrorOpen, "blocked by a book with the same name in a different path")
+          it "should open the book in a new excel instance, if :if_obstructed is default" do
+            @new_book = Book.open(@simple_file)
+            @book.should be_alive
+            @new_book.should be_alive
+            @new_book.filename.should_not == @book.filename
+            @new_book.excel.should_not == @book.excel
           end
+         
 
           it "should raise an error, if :if_obstructed is invalid option" do
             expect {
@@ -647,6 +772,79 @@ describe Book do
 
     context "with :read_only" do
       
+      it "should reopen the book with writable (unsaved changes from readonly are not saved)" do
+        book = Book.open(@simple_file, :read_only => true)
+        book.ReadOnly.should be_true
+        book.should be_alive
+        sheet = book[0]
+        old_cell_value = sheet[0,0].value
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+        book.Saved.should be_false
+        new_book = Book.open(@simple_file, :read_only => false, :if_unsaved => :accept)
+        new_book.ReadOnly.should be_false 
+        new_book.should be_alive
+        book.should be_alive   
+        new_book.should == book 
+        new_sheet = new_book[0]
+        new_cell_value = new_sheet[0,0].value
+        new_cell_value.should == old_cell_value
+      end
+
+      it "should reopen the book with readonly (unsaved changes of the writable should be saved)" do
+        book = Book.open(@simple_file, :read_only => false)
+        book.ReadOnly.should be_false
+        book.should be_alive
+        sheet = book[0]
+        old_cell_value = sheet[0,0].value        
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+        book.Saved.should be_false
+        new_book = Book.open(@simple_file, :read_only => true, :if_unsaved => :accept)
+        new_book.ReadOnly.should be_true
+        new_book.should be_alive
+        book.should be_alive   
+        new_book.should == book 
+        new_sheet = new_book[0]
+        new_cell_value = new_sheet[0,0].value
+        new_cell_value.should_not == old_cell_value
+      end
+
+      it "should reopen the book with writable (unsaved changes from readonly are not saved)" do
+        book = Book.open(@simple_file, :force_excel => :new, :read_only => true)
+        book.ReadOnly.should be_true
+        book.should be_alive
+        sheet = book[0]
+        old_cell_value = sheet[0,0].value
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+        book.Saved.should be_false
+        new_book = Book.open(@simple_file, :force_excel => book.excel, :read_only => false, :if_unsaved => :accept)
+        new_book.ReadOnly.should be_false 
+        new_book.should be_alive
+        book.should be_alive   
+        new_book.should == book 
+        new_sheet = new_book[0]
+        new_cell_value = new_sheet[0,0].value
+        new_cell_value.should == old_cell_value
+      end
+
+      it "should reopen the book with readonly (unsaved changes of the writable should be saved)" do
+        book = Book.open(@simple_file, :force_excel => :new, :read_only => false)
+        book.ReadOnly.should be_false
+        book.should be_alive
+        sheet = book[0]
+        old_cell_value = sheet[0,0].value        
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+        book.Saved.should be_false
+        new_book = Book.open(@simple_file, :force_excel => book.excel, :read_only => true, :if_unsaved => :accept)
+        new_book.ReadOnly.should be_true
+        new_book.should be_alive
+        book.should be_alive   
+        new_book.should == book 
+        new_sheet = new_book[0]
+        new_cell_value = new_sheet[0,0].value
+        new_cell_value.should_not == old_cell_value
+      end
+
+
       it "should open the second book in another Excel as writable" do
         book = Book.open(@simple_file, :read_only => true)
         book.ReadOnly.should be_true
@@ -665,7 +863,7 @@ describe Book do
         book.close
       end
 
-      it "should be able to save, if :read_only is set to default value" do
+      it "should be able to save, if :read_only is default" do
         book = Book.open(@simple_file)
         book.should be_a Book
         expect {
@@ -736,6 +934,24 @@ describe Book do
       end
     end
 
+    context "with no open book" do
+
+      it "should open unobtrusively in a new Excel" do
+        expect{ unobtrusively_ok? }.to_not raise_error
+      end
+
+      it "should open unobtrusively in the first opened Excel" do
+        excel = Excel.new(:reuse => false)
+        new_excel = Excel.new(:reuse => false)
+        Book.unobtrusively(@simple_file) do |book|
+          book.should be_a Book
+          book.should be_alive
+          book.excel.should == excel
+          book.excel.should_not == new_excel
+        end
+      end
+    end
+
     context "with an open book" do
 
       before do
@@ -744,6 +960,7 @@ describe Book do
 
       after do
         @book.close(:if_unsaved => :forget)
+        @book2.close(:if_unsaved => :forget) rescue nil
       end
 
       it "should let a saved book saved" do
@@ -758,18 +975,36 @@ describe Book do
         sheet[0,0].value.should_not == old_cell_value
       end
 
-      it "should let an unsaved book unsaved" do
+     it "should let the unsaved book unsaved" do
         sheet = @book[0]
-        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple" 
-        @book.Saved.should be_false
-        @book.should be_alive
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
         old_cell_value = sheet[0,0].value
-        unobtrusively_ok?
         @book.Saved.should be_false
+        unobtrusively_ok?
         @book.should be_alive
-        sheet = @book[0]
-        sheet[0,0].value.should_not == old_cell_value
+        @book.Saved.should be_false
+        @book.close(:if_unsaved => :forget)
+        @book2 = Book.open(@simple_file)
+        sheet2 = @book2[0]
+        sheet2[0,0].value.should_not == old_cell_value
       end
+
+      it "should modify unobtrusively the second, writable book" do
+        @book2 = Book.open(@simple_file, :force_excel => :new)
+        @book.ReadOnly.should be_false
+        @book2.ReadOnly.should be_true
+        sheet = @book2[0]
+        old_cell_value = sheet[0,0].value
+        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+        unobtrusively_ok?
+        @book2.should be_alive
+        @book2.Saved.should be_false
+        @book2.close(:if_unsaved => :forget)
+        @book.close
+        @book = Book.open(@simple_file)
+        sheet2 = @book[0]
+        sheet2[0,0].value.should_not == old_cell_value
+      end    
     end
     
     context "with a closed book" do
@@ -779,8 +1014,7 @@ describe Book do
       end
 
       after do
-        @book.close(:if_unsaved => :forget) 
-        Excel.close_all
+        @book.close(:if_unsaved => :forget)
       end
 
       it "should let the closed book closed by default" do
@@ -810,57 +1044,13 @@ describe Book do
         end
         @book.should be_alive
         @book.close
-        @book = Book.open(@simple_file)
-        sheet = @book[0]
+        new_book = Book.open(@simple_file)
+        sheet = new_book[0]
         sheet[0,0].value.should_not == old_cell_value
       end
     end
 
-    context "with two books" do
-
-      before do
-        @book = Book.open(@simple_file)
-      end
-
-      after do
-        @book.close(:if_unsaved => :forget)
-        @book2.close(:if_unsaved => :forget)
-      end
-
-      it "should let the unsaved book unsaved" do
-        sheet = @book[0]
-        old_cell_value = sheet[0,0].value
-        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
-        old_cell_value = sheet[0,0].value
-        @book.Saved.should be_false
-        unobtrusively_ok?
-        @book.should be_alive
-        @book.Saved.should be_false
-        @book.close(:if_unsaved => :forget)
-        @book2 = Book.open(@simple_file)
-        sheet2 = @book2[0]
-        sheet2[0,0].value.should_not == old_cell_value
-      end
-
-      it "should modify unobtrusively the second, writable book" do
-        @book2 = Book.open(@simple_file, :force_excel => :new)
-        @book.ReadOnly.should be_false
-        @book2.ReadOnly.should be_true
-        sheet = @book2[0]
-        old_cell_value = sheet[0,0].value
-        sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
-        unobtrusively_ok?
-        @book2.should be_alive
-        @book2.Saved.should be_false
-        @book2.close(:if_unsaved => :forget)
-        @book.close
-        @book = Book.open(@simple_file)
-        sheet2 = @book[0]
-        sheet2[0,0].value.should_not == old_cell_value
-      end
-    end    
-
-    context "with read_only book" do
+    context "with a read_only book" do
 
       before do
         @book = Book.open(@simple_file, :read_only => true)
@@ -902,6 +1092,29 @@ describe Book do
         # modifies unobtrusively the saved version, not the unsaved version
         sheet2[0,0].value.should == cell_value        
       end
+
+      it "should modify one of the unobtrusively books" do
+        book2 = Book.open(@simple_file, :force_excel => :new, :read_only => true)
+        @book.ReadOnly.should be_true
+        book2.Readonly.should be_true
+        sheet = @book[0]
+        cell_value = sheet[0,0].value
+        Book.unobtrusively(@simple_file) do |book|
+          book.should be_a Book
+          sheet = book[0]
+          sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple"
+          book.should be_alive
+          book.Saved.should be_false          
+        end  
+        @book.Saved.should be_true
+        @book.ReadOnly.should be_true
+        @book.close
+        book2.close
+        book3 = Book.open(@simple_file)
+        new_sheet = book3[0]
+        new_sheet[0,0].value.should_not == cell_value
+        book3.close
+      end
     end
 
     context "with a virgin Book class" do
@@ -953,7 +1166,7 @@ describe Book do
         m_time2.should_not == m_time
       end      
 
-      it "should not save the book was not modified during unobtrusively" do
+      it "should not save the book if it was not modified during unobtrusively" do
         m_time = File.mtime(@book1.stored_filename)
         Book.unobtrusively(@simple_file) do |book|
           @book1.Saved.should be_true
@@ -1024,7 +1237,7 @@ describe Book do
         @book1.close(:if_unsaved => :forget)
       end    
 
-      it "should unobtrusively use a book invisibe" do
+      it "should unobtrusively use a book invisible" do
         @book1.excel.Visible.should be_false
         Book.unobtrusively(@simple_file, :visible => false) do |book| 
           @book1.excel.Visible.should be_false
@@ -1037,7 +1250,7 @@ describe Book do
         @book1.excel.Visible.should be_false
       end
       
-      it "should unobtrusively use a book visibe" do
+      it "should unobtrusively use a book visible" do
         @book1.excel.Visible.should be_false
         Book.unobtrusively(@simple_file, :visible => true) do |book| 
           @book1.excel.Visible.should be_true
@@ -1063,6 +1276,96 @@ describe Book do
         @book1.excel.Visible.should be_false
       end
     end
+
+    context "with several Excel instances" do
+
+      it "should open unobtrusively the closed book in the most recent Excel" do
+        book1 = Book.open(@simple_file)
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book1.Readonly.should == false
+        book2.Readonly.should == true
+        book1.close
+        book2.close
+        Book.unobtrusively(@simple_file) do |book| 
+          book.excel.should == book2.excel
+          book.excel.should_not == book1.excel
+          book.Readonly.should == false
+        end
+      end
+
+      it "should open unobtrusively the closed book in the most recent Excel where it was open before" do
+        book1 = Book.open(@simple_file)
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book2.Readonly.should == true
+        old_sheet = book1[0]
+        old_cell_value = old_sheet[0,0].value
+        book1.close
+        book2.close
+        book1.should_not be_alive
+        book2.should_not be_alive
+        Book.unobtrusively(@simple_file) do |book| 
+          book.excel.should == book2.excel
+          book.excel.should_not == book1.excel
+          book.ReadOnly.should == false
+          sheet = book[0]
+          cell = sheet[0,0]
+          sheet[0,0] = cell.value == "simple" ? "complex" : "simple"
+          book.Saved.should be_false
+        end
+        new_book = Book.open(@simple_file)
+        sheet = new_book[0]
+        sheet[0,0].value.should_not == old_cell_value
+      end
+
+      it "should open unobtrusively the closed book in a new Excel if the Excel is not alive anymore" do
+        book1 = Book.open(@simple_file)
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book2.Readonly.should == true
+        old_sheet = book1[0]
+        old_cell_value = old_sheet[0,0].value
+        book1.close
+        book2.close
+        book1.should_not be_alive
+        book2.should_not be_alive
+        Excel.close_all
+        Book.unobtrusively(@simple_file) do |book| 
+          book.ReadOnly.should == false
+          #book.excel.should_not == book1.excel
+          #book.excel.should_not == book2.excel
+          sheet = book[0]
+          cell = sheet[0,0]
+          sheet[0,0] = cell.value == "simple" ? "complex" : "simple"
+          book.Saved.should be_false
+        end
+        new_book = Book.open(@simple_file)
+        sheet = new_book[0]
+        sheet[0,0].value.should_not == old_cell_value
+      end
+
+      it "should open unobtrusively the once opened book in a new Excel if the Excel is not alive anymore" do
+        book1 = Book.open(@simple_file)
+        book2 = Book.open(@simple_file, :force_excel => :new)
+        book2.Readonly.should == true
+        old_sheet = book1[0]
+        old_cell_value = old_sheet[0,0].value
+        book1.should be_alive
+        book2.should be_alive
+        Excel.close_all
+        Book.unobtrusively(@simple_file) do |book| 
+          book.ReadOnly.should == false
+          #book.excel.should_not == book1.excel
+          #book.excel.should_not == book2.excel
+          sheet = book[0]
+          cell = sheet[0,0]
+          sheet[0,0] = cell.value == "simple" ? "complex" : "simple"
+          book.Saved.should be_false
+        end
+        new_book = Book.open(@simple_file)
+        sheet = new_book[0]
+        sheet[0,0].value.should_not == old_cell_value
+      end
+
+    end
   end
 
   describe "nvalue" do
@@ -1228,18 +1531,6 @@ describe Book do
           end
         end
       end
-
-      it "should raise error for default" do
-        expect{
-          @book.close
-        }.to raise_error(ExcelErrorClose, "book is unsaved (#{File.basename(@simple_file)})")
-      end
-
-      it "should raise error for invalid option" do
-        expect{
-          @book.close(:if_unsaved => :invalid)
-        }.to raise_error(ExcelErrorClose, ":if_unsaved: invalid option")
-      end
     end
   end
 
@@ -1555,21 +1846,17 @@ describe Book do
       end
 
       it "should make Excel visible" do
-        @book.visible = false
+        @book.excel.visible = false
         @book.excel.visible.should be_false
-        @book.visible.should be_false
-        @book.visible = true
+        @book.excel.visible = true
         @book.excel.visible.should be_true
-        @book.visible.should be_true
       end
 
       it "should enable DisplayAlerts in Excel" do
-        @book.displayalerts = false
+        @book.excel.displayalerts = false
         @book.excel.displayalerts.should be_false
-        @book.displayalerts.should be_false
-        @book.displayalerts = true
+        @book.excel.displayalerts = true
         @book.excel.displayalerts.should be_true
-        @book.displayalerts.should be_true
       end
 
     end