robotoy 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a1c9bb9fae174ab82babcfe29b7387d2fc8aa9d
-  data.tar.gz: 3537d4475db971f91c00385b5800cf2d820cd389
+  metadata.gz: c60b7489b010f57365859629723e0019d4dbe738
+  data.tar.gz: d862f6f91f4585c58e669de14da32777c58b781f
 SHA512:
-  metadata.gz: 5d6662c098a0172e1e1d0a66c7ca0991c201781e8bc93e1bd8ca317b99c04eebab3510b1db09641c72e28bb434e75c8e8069769b61a497523cf1cdac44fcb207
-  data.tar.gz: 693ef65396d6b25a066bdfe82571220f16122b8175b0e5332e84d7e1ef46ae847bd428fd04533a18ed1599e98cd51fc549299c934c2294ee09a79fb717ace1fb
+  metadata.gz: b5529734b3e6eae9cd87bdc74459fc1b701cc7d8253c9ce28aad941f68729468760debf157228f7438ae0952a349a670f14587d2cd2129999a973abc20a6a548
+  data.tar.gz: 048de6b5917fe2958ea34bc42673472a204c67ec41167131580f6cd6a356c3ad829172780ae4d45091f3fae0454ca5f96703e8d2931110463032a513926b6891

data/README.md

@@ -1,5 +1,7 @@
 [![Build Status](https://travis-ci.org/hosseintoussi/robotoy.svg?branch=master)](https://travis-ci.org/hosseintoussi/robotoy)
 [![Gem Version](https://badge.fury.io/rb/robotoy.svg)](https://badge.fury.io/rb/robotoy)
+[![Code Climate](https://codeclimate.com/github/hosseintoussi/robotoy/badges/gpa.svg)](https://codeclimate.com/github/hosseintoussi/robotoy)
+[![Test Coverage](https://codeclimate.com/github/hosseintoussi/robotoy/badges/coverage.svg)](https://codeclimate.com/github/hosseintoussi/robotoy/coverage)
 # Robotoy
 - The application is a simulation of a toy robot moving on a square tabletop, of dimensions 5 units x 5 units.
 - There are no other obstructions on the table surface.

data/commands.txt

@@ -2,7 +2,8 @@ move
 tests
 PLACE 0,0,NORTH
 MOVE
-MOVE
+report
+MOVE 2
 REPORT
 RIGHT
 MOVE

data/lib/robotoy/command_parser.rb

@@ -12,8 +12,8 @@ module Robotoy
           puts command
           set_params(command)
           @game.perform(@method, @args)
-        rescue
-          puts "Something went wrong"
+        rescue Errors => e
+          puts e.message
         end
       end
     end
@@ -23,7 +23,7 @@ module Robotoy
     def set_params(command)
       splitted = command.split(/\s+/)
       @method = splitted[0].strip
-      @args = splitted[1].split(',').map(&:strip) if splitted[1]
+      @args = splitted[1] ? splitted[1].split(',').map(&:strip) : []
     end
   end
 end

data/lib/robotoy/errors.rb

@@ -1,7 +1,31 @@
 module Robotoy
-  class Errors < StandardError; end
-  class NotValidOrientationError < Errors; end
-  class NotValidMoveError < Errors; end
-  class NotPlacedError < Errors; end
-  class NotValidMethodError < Errors; end
+  class Errors < StandardError
+    def message
+      "hmm.. Not sure what happened there!"
+    end
+  end
+
+  class NotValidOrientationError < Errors
+    def message
+      "It looks like your Robot did not know there's such oriencation!"
+    end
+  end
+
+  class NotValidMoveError < Errors
+    def message
+      "It wasn't a valid move, unfortunately!"
+    end
+  end
+
+  class NotPlacedError < Errors
+    def message
+      "Your Robot is not placed yet!"
+    end
+  end
+
+  class NotValidMethodError < Errors
+    def message
+      "I don't understand what you want me to do! :("
+    end
+  end
 end

data/lib/robotoy/game.rb

@@ -11,40 +11,31 @@ module Robotoy
 
     def perform(method, *args)
       send(method.downcase, *args.flatten)
-      @action.perform
-    rescue NotValidMoveError
-      puts "Not a valid place unfortunately"
-    rescue NotValidOrientationError
-      puts "Not a valid orientation unfortunately"
-    rescue NotPlacedError
-      puts "Not placed yet"
-    rescue NotValidMethodError
-      puts "Not a valid method"
     end
 
     private
 
     def place(x, y, orient)
-      @action = @place.new(robot: @robot, table: @table, x: x, y: y, orient: orient)
+      @place.new(robot: @robot, table: @table, x: x, y: y, orient: orient).perform
     end
 
-    def move(*_args)
-      @action = @move.new(robot: @robot, table: @table)
+    def move(range = 1)
+      @move.new(robot: @robot, table: @table, range: range).perform
     end
 
-    def left(*_args)
-      @action = @orientation.new(robot: @robot, side: :left)
+    def left
+      @orientation.new(robot: @robot, side: :left).perform
     end
 
-    def right(*_args)
-      @action = @orientation.new(robot: @robot, side: :right)
+    def right
+      @orientation.new(robot: @robot, side: :right).perform
     end
 
-    def report(*_args)
-      @action = @report.new(robot: @robot)
+    def report(type = :console)
+      @report.new(robot: @robot, type: type).perform
     end
 
-    def method_missing(name, *args)
+    def method_missing(_name, *_args)
       raise Robotoy::NotValidMethodError
     end
   end

data/lib/robotoy/services/move.rb

@@ -1,11 +1,10 @@
 module Robotoy
   module Services
     class Move
-      def initialize(robot:, table:, x_range: 1, y_range: 1)
+      def initialize(robot:, table:, range:)
         @robot = robot
         @table = table
-        @x_range = x_range
-        @y_range = y_range
+        @range = range.to_i
       end
 
       def perform
@@ -16,26 +15,26 @@ module Robotoy
       private
 
       def north
-        @table.validate_next_position(y: @robot.y + @y_range)
-        @robot.y += @y_range
+        @table.validate_next_position(y: @robot.y + @range)
+        @robot.y += @range
       end
 
       def south
-        @table.validate_next_position(y: @robot.y - @y_range)
-        @robot.y -= @y_range
+        @table.validate_next_position(y: @robot.y - @range)
+        @robot.y -= @range
       end
 
       def east
-        @table.validate_next_position(x: @robot.x + @x_range)
-        @robot.x += @x_range
+        @table.validate_next_position(x: @robot.x + @range)
+        @robot.x += @range
       end
 
       def west
-        @table.validate_next_position(x: @robot.x - @x_range)
-        @robot.x -= @x_range
+        @table.validate_next_position(x: @robot.x - @range)
+        @robot.x -= @range
       end
 
-      def method_missing(name, *args)
+      def method_missing(_name, *_args)
         raise Robotoy::NotValidMethodError
       end
     end

data/lib/robotoy/services/report.rb

@@ -1,19 +1,28 @@
 module Robotoy
   module Services
     class Report
-      def initialize(robot:)
+      def initialize(robot:, type:)
         @robot = robot
+        @type = type
       end
 
-      def perform(type: :string)
+      def perform
         @robot.validate_if_placed
-        send(type)
+        send(@type)
       end
 
       private
 
+      def console
+        puts "Output: #{string}"
+      end
+
       def string
-        puts "Output: #{@robot.x},#{@robot.y},#{@robot.orientation.upcase}"
+        "#{@robot.x},#{@robot.y},#{@robot.orientation.upcase}"
+      end
+
+      def method_missing(_name, *_args)
+        raise Robotoy::NotValidMethodError
       end
     end
   end

data/lib/robotoy/version.rb

@@ -1,3 +1,3 @@
 module Robotoy
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: robotoy
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - hosseintoussi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-31 00:00:00.000000000 Z
+date: 2016-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -118,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Toy Robot Ruby