roast-ai 0.4.3 → 0.4.5

data/lib/roast/helpers/timeout_handler.rb

@@ -1,8 +1,6 @@
+# typed: true
 # frozen_string_literal: true
 
-require "timeout"
-require "open3"
-
 module Roast
   module Helpers
     # Shared timeout handling logic for command-based tools
@@ -29,8 +27,8 @@ module Roast
         def call(command, timeout: DEFAULT_TIMEOUT, working_directory: Dir.pwd)
           timeout = validate_timeout(timeout)
           output = ""
-          exit_status = nil
-          wait_thr = nil
+          exit_status = nil #: Integer?
+          wait_thr = nil #: Process::Waiter?
 
           begin
             Timeout.timeout(timeout) do

data/lib/roast/initializers.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/resources/api_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -57,7 +58,7 @@ module Roast
         http.use_ssl = (uri.scheme == "https")
 
         # Use HEAD request to check existence
-        request = Net::HTTP::Head.new(uri.path.empty? ? "/" : uri.path)
+        request = Net::HTTP::Head.new(uri.path&.empty? ? "/" : uri.path)
 
         # Add headers if present in options
         if options["headers"].is_a?(Hash)
@@ -124,8 +125,8 @@ module Roast
       # Replace environment variables in the format ${VAR_NAME}
       def process_env_vars(text)
         text.gsub(/\${([^}]+)}/) do |_match|
-          var_name = ::Regexp.last_match(1).strip
-          ENV.fetch(var_name, "${#{var_name}}")
+          var_name = ::Regexp.last_match(1)&.strip
+          ENV.fetch(var_name, "${#{var_name}}") unless var_name.nil?
         end
       end
     end

data/lib/roast/resources/base_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/resources/directory_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/resources/file_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/resources/none_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/resources/url_resource.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -18,7 +19,7 @@ module Roast
           http.use_ssl = (uri.scheme == "https")
 
           # Just check the head to see if the resource exists
-          response = http.request_head(uri.path.empty? ? "/" : uri.path)
+          response = http.request_head(uri.path&.empty? ? "/" : uri.path)
 
           # Consider 2xx and 3xx as success
           response.code.to_i < 400

data/lib/roast/resources.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -21,8 +22,6 @@ module Roast
         UrlResource.new(target)
       when :api
         ApiResource.new(target)
-      when :command
-        CommandResource.new(target)
       when :none
         NoneResource.new(target)
       else

data/lib/roast/services/context_threshold_checker.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/services/token_counting_service.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/apply_diff.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cli/ui"

data/lib/roast/tools/ask_user.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/bash.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "English"

data/lib/roast/tools/cmd.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "English"

data/lib/roast/tools/coding_agent.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/context_summarizer.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/grep.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/helpers/coding_agent_message_formatter.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/read_file.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/search_file.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/swarm.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "shellwords"

data/lib/roast/tools/update_files.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools/write_file.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/tools.rb

@@ -1,6 +1,8 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
+  # @requires_ancestor: Kernel
   module Tools
     extend self
 

data/lib/roast/value_objects/api_token.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/value_objects/step_name.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/value_objects/uri_base.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/value_objects/workflow_path.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/value_objects.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/version.rb

@@ -1,5 +1,6 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
-  VERSION = "0.4.3"
+  VERSION = "0.4.5"
 end

data/lib/roast/workflow/agent_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/api_configuration.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/base_iteration_step.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/base_step.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/base_workflow.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/case_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/case_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/command_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/conditional_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/conditional_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/configuration.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -87,6 +88,14 @@ module Roast
         @tool_configs[tool_name.to_s] || {}
       end
 
+      def pre_processing?
+        pre_processing.any?
+      end
+
+      def post_processing?
+        post_processing.any?
+      end
+
       private
 
       attr_reader :api_configuration

data/lib/roast/workflow/configuration_loader.rb

@@ -1,9 +1,12 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
   module Workflow
     # Handles loading and parsing of workflow configuration files
     class ConfigurationLoader
+      class ValidationError < StandardError; end
+
       class << self
         # Load configuration from a YAML file
         # @param workflow_path [String] Path to the workflow YAML file
@@ -187,7 +190,7 @@ module Roast
             message
           end.join("\n")
 
-          raise CLI::Kit::Abort, <<~ERROR
+          raise ValidationError, <<~ERROR
             Workflow validation failed with #{validator.errors.size} error(s):
 
             #{error_messages}

data/lib/roast/workflow/context_manager.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/context_path_resolver.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/dot_access_hash.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/each_step.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/error_handler.rb

@@ -1,10 +1,12 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
   module Workflow
     # Handles error logging and instrumentation for workflow execution
     class ErrorHandler
-      def initialize
+      def initialize(workflow = nil)
+        @workflow = workflow
         # Use the Roast logger singleton
       end
 
@@ -14,6 +16,7 @@ module Roast
         ActiveSupport::Notifications.instrument("roast.step.start", {
           step_name: step_name,
           resource_type: resource_type,
+          workflow_name: @workflow&.name,
         })
 
         result = yield
@@ -23,6 +26,7 @@ module Roast
         ActiveSupport::Notifications.instrument("roast.step.complete", {
           step_name: step_name,
           resource_type: resource_type,
+          workflow_name: @workflow&.name,
           success: true,
           execution_time: execution_time,
           result_size: result.to_s.length,
@@ -64,6 +68,7 @@ module Roast
         ActiveSupport::Notifications.instrument("roast.step.error", {
           step_name: step_name,
           resource_type: resource_type,
+          workflow_name: @workflow&.name,
           error: error.class.name,
           message: error.message,
           execution_time: execution_time,
@@ -76,6 +81,7 @@ module Roast
         ActiveSupport::Notifications.instrument("roast.step.error", {
           step_name: step_name,
           resource_type: resource_type,
+          workflow_name: @workflow&.name,
           error: error.class.name,
           message: error.message,
           execution_time: execution_time,

data/lib/roast/workflow/expression_evaluator.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/expression_utils.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/file_state_repository.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -53,7 +54,7 @@ module Roast
         state_data = load_state_file(state_file)
 
         # Extract the loaded step name for diagnostics
-        loaded_step = File.basename(state_file).split("_", 3)[2].sub(/\.json$/, "")
+        loaded_step = File.basename(state_file).split("_", 3)[2].to_s.sub(/\.json$/, "")
         $stderr.puts "Found state from step: #{loaded_step} (will replay from here to #{step_name})"
 
         # If no timestamp provided and workflow has no session, copy states to new session

data/lib/roast/workflow/input_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/input_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "timeout"

data/lib/roast/workflow/interpolator.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -16,7 +17,7 @@ module Roast
 
         # Replace all {{expression}} with their evaluated values
         text.gsub(/\{\{([^}]+)\}\}/) do |match|
-          expression = Regexp.last_match(1).strip
+          expression = Regexp.last_match(1).to_s.strip
           begin
             # Evaluate the expression in the context
             result = @context.instance_eval(expression).to_s

data/lib/roast/workflow/iteration_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/llm_boolean_coercer.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/metadata_manager.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/output_handler.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/output_manager.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/parallel_executor.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/prompt_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/repeat_step.rb

@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/replay_handler.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/resource_resolver.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -51,12 +52,7 @@ module Roast
         def process_shell_command(command)
           # If it's a bash command with the $(command) syntax
           if command =~ /^\$\((.*)\)$/
-            return Open3.capture2e({}, ::Regexp.last_match(1)).first.strip
-          end
-
-          # Legacy % prefix for backward compatibility
-          if command.start_with?("% ")
-            return Open3.capture2e({}, *command.split(" ")[1..-1]).first.strip
+            return Open3.capture2e({}, ::Regexp.last_match(1).to_s).first.strip
           end
 
           # Not a shell command, return as is

data/lib/roast/workflow/session_manager.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/shell_script_step.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/sqlite_state_repository.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "json"

data/lib/roast/workflow/state_manager.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/state_repository.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/state_repository_factory.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -22,9 +23,10 @@ module Roast
         private
 
         def default_type
+          state_storage = ENV["ROAST_STATE_STORAGE"]
           # Check environment variable first (for backwards compatibility)
-          if ENV["ROAST_STATE_STORAGE"]
-            ENV["ROAST_STATE_STORAGE"].downcase
+          if state_storage
+            state_storage.downcase
           else
             # Default to SQLite for better functionality
             "sqlite"

data/lib/roast/workflow/step_completion_reporter.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast

data/lib/roast/workflow/step_executor_coordinator.rb

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Roast
@@ -145,9 +146,11 @@ module Roast
       def execute_command_step(step, options)
         exit_on_error = options.fetch(:exit_on_error, true)
         resource_type = @context.resource_type
+        step_key = options[:step_key]
+        display_name = step_key || step
 
-        error_handler.with_error_handling(step, resource_type: resource_type) do
-          $stderr.puts "Executing: #{step} (Resource type: #{resource_type || "unknown"})"
+        error_handler.with_error_handling(display_name, resource_type: resource_type) do
+          $stderr.puts "Executing: #{display_name} (Resource type: #{resource_type || "unknown"})"
 
           begin
             output = command_executor.execute(step, exit_on_error: exit_on_error)
@@ -169,7 +172,7 @@ module Roast
             output
           rescue CommandExecutor::CommandExecutionError => e
             # Print user-friendly error message
-            $stderr.puts "\n❌ Command failed: #{step}"
+            $stderr.puts "\n❌ Command failed: #{display_name}"
             $stderr.puts "   Exit status: #{e.exit_status}" if e.exit_status
 
             # Show command output if available
@@ -257,9 +260,10 @@ module Roast
         interpolated_step = interpolator.interpolate(step)
 
         if StepTypeResolver.command_step?(interpolated_step)
-          # Command step - execute directly, preserving any passed options
+          # Command step - execute directly, preserving any passed options including step_key
           exit_on_error = options.fetch(:exit_on_error, true)
-          execute_command_step(interpolated_step, { exit_on_error: })
+          step_key = options[:step_key]
+          execute_command_step(interpolated_step, { exit_on_error:, step_key: })
         else
           exit_on_error = options.fetch(:exit_on_error, context.exit_on_error?(step))
           execute_standard_step(interpolated_step, options.merge(exit_on_error:))