roadie 4.0.0 → 5.0.0

data/spec/lib/roadie/test_provider_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-require 'roadie/rspec'
+require "spec_helper"
+require "roadie/rspec"
 
 describe TestProvider do
   subject(:provider) { TestProvider.new }
@@ -13,7 +13,7 @@ describe TestProvider do
   it "finds styles from a predefined hash" do
     provider = TestProvider.new({
       "foo.css" => "a { color: red; }",
-      "bar.css" => "body { color: green; }",
+      "bar.css" => "body { color: green; }"
     })
     expect(provider.find_stylesheet("foo.css").to_s).not_to include("body")
     expect(provider.find_stylesheet("bar.css").to_s).to include("body")
@@ -23,7 +23,7 @@ describe TestProvider do
   it "can have a default for missing entries" do
     provider = TestProvider.new({
       "foo.css" => "a { color: red; }",
-      :default  => "body { color: green; }",
+      :default => "body { color: green; }"
     })
     expect(provider.find_stylesheet("foo.css").to_s).not_to include("body")
     expect(provider.find_stylesheet("bar.css").to_s).to include("body")

data/spec/lib/roadie/url_generator_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 module Roadie
   describe UrlGenerator do

data/spec/lib/roadie/url_rewriter_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-require 'shared_examples/url_rewriter'
+require "spec_helper"
+require "shared_examples/url_rewriter"
 
 module Roadie
   describe UrlRewriter do
@@ -11,7 +11,9 @@ module Roadie
     it_behaves_like "url rewriter"
 
     describe "transforming DOM trees" do
-      def dom_document(html); Nokogiri::HTML.parse html; end
+      def dom_document(html)
+        Nokogiri::HTML.parse html
+      end
 
       it "rewrites all a[href]" do
         expect(generator).to receive(:generate_url).with("some/path").and_return "http://foo.com/"
@@ -89,7 +91,7 @@ module Roadie
 
       it "correctly identifies URLs with parenthesis inside them" do
         expect(generator).to receive(:generate_url).with("images/map_(large_(extra)).png").and_return "x"
-        rewriter.transform_css 'url(images/map_(large_(extra)).png)'
+        rewriter.transform_css "url(images/map_(large_(extra)).png)"
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-require 'rspec/collection_matchers'
-require 'webmock/rspec'
+require "rspec/collection_matchers"
+require "webmock/rspec"
 
-if ENV['CI']
-  require 'simplecov'
+if ENV["CI"]
+  require "simplecov"
   SimpleCov.start
 
-  require 'codecov'
+  require "codecov"
   SimpleCov.formatter = SimpleCov::Formatter::Codecov
 end
 
-$: << File.dirname(__FILE__) + '/../lib'
-require 'roadie'
+$: << File.dirname(__FILE__) + "/../lib"
+require "roadie"
 
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
 end
 
-Dir['./spec/support/**/*.rb'].each { |file| require file }
+Dir["./spec/support/**/*.rb"].sort.each { |file| require file }

data/spec/support/have_attribute_matcher.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec::Matchers.define :have_attribute do |attribute|
-  @selector = 'body > *:first'
+  @selector = "body > *:first"
 
   chain :at_selector do |selector|
     @selector = selector
@@ -27,4 +27,3 @@ RSpec::Matchers.define :have_attribute do |attribute|
     node && node[attribute_name]
   end
 end
-

data/spec/support/have_node_matcher.rb

@@ -11,11 +11,11 @@ RSpec::Matchers.define :have_node do |selector|
     end
   end
 
-  failure_message { "expected document to #{name_to_sentence}#{expected_to_sentence}"}
-  failure_message_when_negated { "expected document to not #{name_to_sentence}#{expected_to_sentence}"}
+  failure_message { "expected document to #{name_to_sentence}#{expected_to_sentence}" }
+  failure_message_when_negated { "expected document to not #{name_to_sentence}#{expected_to_sentence}" }
 
   def match_attributes(node_attributes)
-    attributes = Hash[node_attributes.map { |name, attribute| [name, attribute.value] }]
+    attributes = node_attributes.map { |name, attribute| [name, attribute.value] }.to_h
     @attributes == attributes
   end
 end

data/spec/support/have_selector_matcher.rb

@@ -2,7 +2,6 @@
 
 RSpec::Matchers.define :have_selector do |selector|
   match { |document| !document.css(selector).empty? }
-  failure_message { "expected document to have selector #{selector.inspect}"}
-  failure_message_when_negated { "expected document to not have selector #{selector.inspect}"}
+  failure_message { "expected document to have selector #{selector.inspect}" }
+  failure_message_when_negated { "expected document to not have selector #{selector.inspect}" }
 end
-

data/spec/support/have_styling_matcher.rb

@@ -5,7 +5,7 @@ RSpec::Matchers.define :have_styling do |rules|
 
   chain(:at_selector) { |selector| @selector = selector }
   match { |document|
-    @selector ||= 'body > *:first'
+    @selector ||= "body > *:first"
     normalized_rules == styles_at_selector(document)
   }
 
@@ -23,7 +23,7 @@ RSpec::Matchers.define :have_styling do |rules|
 
   def styles_at_selector(document)
     expect(document).to have_selector(@selector)
-    StylingExpectation.new document.at_css(@selector)['style']
+    StylingExpectation.new document.at_css(@selector)["style"]
   end
 end
 
@@ -42,23 +42,22 @@ class StylingExpectation
     rules == other.rules
   end
 
-  def to_s() rules.to_s end
+  def to_s
+    rules.to_s
+  end
 
   protected
+
   attr_reader :rules
 
   private
+
   def parse_rules(css)
-    css.split(';').map { |property| parse_property(property) }
+    css.split(";").map { |property| parse_property(property) }
   end
 
   def parse_property(property)
-    rule, value = property.split(':', 2).map(&:strip)
-    [rule, normalize_quotes(value)]
-  end
-
-  # JRuby's Nokogiri encodes quotes
-  def normalize_quotes(string)
-    string.gsub '%22', '"'
+    rule, value = property.split(":", 2).map(&:strip)
+    [rule, value]
   end
 end

data/spec/support/have_xpath_matcher.rb

@@ -2,7 +2,6 @@
 
 RSpec::Matchers.define :have_xpath do |xpath|
   match { |document| !document.xpath(xpath).empty? }
-  failure_message { "expected document to have xpath #{xpath.inspect}"}
-  failure_message_when_negated { "expected document to not have xpath #{xpath.inspect}"}
+  failure_message { "expected document to have xpath #{xpath.inspect}" }
+  failure_message_when_negated { "expected document to not have xpath #{xpath.inspect}" }
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roadie
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Magnus Bergmark
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-13 00:00:00.000000000 Z
+date: 2022-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -39,47 +39,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.0
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -105,9 +105,10 @@ extra_rdoc_files:
 - Changelog.md
 files:
 - ".autotest"
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".solargraph.yml"
 - ".yardopts"
 - Changelog.md
 - Gemfile
@@ -181,7 +182,7 @@ homepage: http://github.com/Mange/roadie
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -189,15 +190,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Making HTML emails comfortable for the Ruby rockstars
 test_files:

data/.travis.yml

@@ -1,20 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.4
-  - 2.5
-  - 2.6
-  - jruby
-  - rbx
-before_install:
-  - gem install bundler -v '1.17.3'
-matrix:
-  allow_failures:
-    # Rubinius and JRuby have a lot of trouble and no large following, so I'm going to
-    # allow failures on it until it gets more stable on Travis / Real Life(tm).
-    # Let me know if you need it. Patches are welcome!
-    - rvm: jruby
-    - rvm: rbx
-  fast_finish: true
-cache: bundler
-script: "rake"