ro 4.4.0 → 5.0.0

data/test/test_helper.rb

@@ -0,0 +1,149 @@
+# Test Helper for ro gem v5.0 tests
+#
+# Common setup, assertions, and utilities for unit and integration tests
+
+require 'pathname'
+require 'fileutils'
+require 'yaml'
+require 'json'
+
+# Load the ro gem
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
+require 'ro'
+
+module TestHelper
+  # Get path to test fixtures directory
+  def fixtures_path
+    Pathname.new(File.expand_path('../fixtures', __FILE__))
+  end
+
+  # Get path to old structure fixtures
+  def old_structure_path
+    fixtures_path / 'old_structure'
+  end
+
+  # Get path to new structure fixtures
+  def new_structure_path
+    fixtures_path / 'new_structure'
+  end
+
+  # Create a temporary test directory
+  def create_temp_dir(name = 'test')
+    dir = Pathname.new(File.expand_path("../tmp/#{name}_#{Time.now.to_i}", __FILE__))
+    FileUtils.mkdir_p(dir)
+    dir
+  end
+
+  # Clean up temporary directory
+  def cleanup_temp_dir(dir)
+    FileUtils.rm_rf(dir) if dir && dir.exist?
+  end
+
+  # Assert that a path exists
+  def assert_path_exists(path, message = nil)
+    assert Pathname.new(path).exist?, message || "Expected path to exist: #{path}"
+  end
+
+  # Assert that a file contains specific content
+  def assert_file_contains(path, content, message = nil)
+    actual = File.read(path)
+    assert actual.include?(content), message || "Expected file #{path} to contain: #{content}"
+  end
+
+  # Assert that a YAML file has a specific key/value
+  def assert_yaml_has(path, key, value = nil, message = nil)
+    data = YAML.load_file(path)
+    assert data.key?(key.to_s) || data.key?(key.to_sym), message || "Expected YAML to have key: #{key}"
+    if value
+      actual_value = data[key.to_s] || data[key.to_sym]
+      assert_equal value, actual_value, message || "Expected #{key} to equal #{value}, got #{actual_value}"
+    end
+  end
+
+  # Create a test node in old structure format
+  def create_old_structure_node(collection_path, node_id, attributes = {}, assets = [])
+    node_dir = collection_path / node_id
+    FileUtils.mkdir_p(node_dir)
+    FileUtils.mkdir_p(node_dir / 'assets')
+
+    # Write attributes.yml
+    File.write(node_dir / 'attributes.yml', attributes.to_yaml)
+
+    # Create asset files
+    assets.each do |asset_file|
+      asset_path = node_dir / 'assets' / asset_file
+      FileUtils.mkdir_p(asset_path.dirname)
+      File.write(asset_path, "test content for #{asset_file}")
+    end
+
+    node_dir
+  end
+
+  # Create a test node in new structure format
+  def create_new_structure_node(collection_path, node_id, attributes = {}, assets = [])
+    FileUtils.mkdir_p(collection_path)
+
+    # Write metadata file (identifier.yml)
+    File.write(collection_path / "#{node_id}.yml", attributes.to_yaml)
+
+    # Create asset directory and files
+    if assets.any?
+      node_dir = collection_path / node_id
+      FileUtils.mkdir_p(node_dir)
+
+      assets.each do |asset_file|
+        asset_path = node_dir / asset_file
+        FileUtils.mkdir_p(asset_path.dirname)
+        File.write(asset_path, "test content for #{asset_file}")
+      end
+    end
+
+    collection_path / "#{node_id}.yml"
+  end
+end
+
+# Base test class
+class RoTestCase
+  include TestHelper
+
+  def setup
+    # Override in subclasses
+  end
+
+  def teardown
+    # Override in subclasses
+  end
+
+  # Simple assertion methods (compatible with custom test runner)
+  def assert(condition, message = "Assertion failed")
+    raise AssertionError, message unless condition
+  end
+
+  def assert_equal(expected, actual, message = nil)
+    msg = message || "Expected #{expected.inspect}, got #{actual.inspect}"
+    assert expected == actual, msg
+  end
+
+  def assert_nil(actual, message = nil)
+    msg = message || "Expected nil, got #{actual.inspect}"
+    assert actual.nil?, msg
+  end
+
+  def assert_not_nil(actual, message = nil)
+    msg = message || "Expected non-nil value"
+    assert !actual.nil?, msg
+  end
+
+  def assert_raises(exception_class, message = nil)
+    begin
+      yield
+      assert false, message || "Expected #{exception_class} to be raised"
+    rescue exception_class
+      # Expected
+    end
+  end
+
+  class AssertionError < StandardError; end
+end
+
+puts "Test helper loaded successfully"

data/test/tmp/migration_test_1760746513.backup.20251018001513/migration_test_1760746513/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760746513.backup.20251018001513/migration_test_1760746513/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760746513.backup.20251018001513/migration_test_1760746513/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760746513.backup.20251018001513/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760746513.backup.20251018001513/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760746513.backup.20251018001513/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760746556.backup.20251018001556/migration_test_1760746556/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760746556.backup.20251018001556/migration_test_1760746556/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760746556.backup.20251018001556/migration_test_1760746556/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760746556.backup.20251018001556/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760746556.backup.20251018001556/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760746556.backup.20251018001556/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760755248.backup.20251018024048/migration_test_1760755248/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760755248.backup.20251018024048/migration_test_1760755248/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760755248.backup.20251018024048/migration_test_1760755248/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760755248.backup.20251018024048/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760755248.backup.20251018024048/posts/sample-post/attributes.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760755248.backup.20251018024048/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758803.backup.20251018034003/migration_test_1760758803/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758803.backup.20251018034003/migration_test_1760758803/posts/sample-post/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758803.backup.20251018034003/migration_test_1760758803/posts/sample-post.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760758803.backup.20251018034003/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758803.backup.20251018034003/posts/sample-post/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758803.backup.20251018034003/posts/sample-post.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (Old Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - old-structure
+description: "This is a test fixture in the old structure format"

data/test/tmp/migration_test_1760758869.backup.20251018034109/migration_test_1760758869/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758869.backup.20251018034109/migration_test_1760758869/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758869.backup.20251018034109/migration_test_1760758869/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760758869.backup.20251018034109/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758869.backup.20251018034109/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758869.backup.20251018034109/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760758920.backup.20251018034200/migration_test_1760758920/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758920.backup.20251018034200/migration_test_1760758920/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758920.backup.20251018034200/migration_test_1760758920/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760758920.backup.20251018034200/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760758920.backup.20251018034200/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760758920.backup.20251018034200/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760824728.backup.20251018215848/migration_test_1760824728/posts/assets-only/assets/test.txt

@@ -0,0 +1 @@
+test asset

data/test/tmp/migration_test_1760824728.backup.20251018215848/migration_test_1760824728/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760824728.backup.20251018215848/migration_test_1760824728/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760824728.backup.20251018215848/migration_test_1760824728/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760824728.backup.20251018215848/posts/assets-only/assets/test.txt

@@ -0,0 +1 @@
+test asset

data/test/tmp/migration_test_1760824728.backup.20251018215848/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760824728.backup.20251018215848/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760824728.backup.20251018215848/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760844153.backup.20251019032233/migration_test_1760844153/posts/assets-only/assets/test.txt

@@ -0,0 +1 @@
+test asset

data/test/tmp/migration_test_1760844153.backup.20251019032233/migration_test_1760844153/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760844153.backup.20251019032233/migration_test_1760844153/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760844153.backup.20251019032233/migration_test_1760844153/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/migration_test_1760844153.backup.20251019032233/posts/assets-only/assets/test.txt

@@ -0,0 +1 @@
+test asset

data/test/tmp/migration_test_1760844153.backup.20251019032233/posts/sample-post/assets/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the old structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/migration_test_1760844153.backup.20251019032233/posts/sample-post/assets/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the old structure.

data/test/tmp/migration_test_1760844153.backup.20251019032233/posts/sample-post/attributes.yml

@@ -0,0 +1,2 @@
+title: Sample Post (Old Structure)
+author: Test Author

data/test/tmp/new_structure_test_1760746452/mixed/test-json.json

@@ -0,0 +1,5 @@
+{
+  "title": "JSON Format Test",
+  "format": "json",
+  "extension": "json"
+}

data/test/tmp/new_structure_test_1760746452/mixed/test-yaml.yml

@@ -0,0 +1,3 @@
+title: "YAML Format Test"
+format: "yaml"
+extension: "yml"

data/test/tmp/new_structure_test_1760746452/posts/metadata-only.yml

@@ -0,0 +1,7 @@
+title: "Metadata Only Node"
+author: "Test Author"
+published_at: "2025-01-02"
+tags:
+  - test
+  - metadata-only
+description: "This node has no asset directory - testing FR-007"

data/test/tmp/new_structure_test_1760746452/posts/nested-test/subdirectory/image.png

@@ -0,0 +1,2 @@
+FAKE_PNG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file in a nested subdirectory.

data/test/tmp/new_structure_test_1760746452/posts/nested-test.yml

@@ -0,0 +1,7 @@
+title: "Nested Assets Test"
+author: "Test Author"
+published_at: "2025-01-03"
+tags:
+  - test
+  - nested-assets
+description: "This node has nested subdirectories with assets"

data/test/tmp/new_structure_test_1760746452/posts/sample-post/body.md

@@ -0,0 +1,5 @@
+# Sample Post
+
+This is the body content of the sample post in the new structure.
+
+It has multiple paragraphs and should be treated as content, not an asset.

data/test/tmp/new_structure_test_1760746452/posts/sample-post/image.jpg

@@ -0,0 +1,2 @@
+FAKE_JPEG_DATA_FOR_TESTING_PURPOSES_ONLY
+This is a test file representing an image asset in the new structure (no assets/ subdirectory).

data/test/tmp/new_structure_test_1760746452/posts/sample-post.yml

@@ -0,0 +1,7 @@
+title: "Sample Post (New Structure)"
+author: "Test Author"
+published_at: "2025-01-01"
+tags:
+  - test
+  - new-structure
+description: "This is a test fixture in the new structure format"

data/test/unit/asset_test.rb

@@ -0,0 +1,90 @@
+#!/usr/bin/env ruby
+# Unit tests for Ro::Asset with new structure support
+
+require_relative '../test_helper'
+
+class AssetTest < RoTestCase
+  def setup
+    @root = Ro::Root.new(new_structure_path)
+    @collection = Ro::Collection.new(new_structure_path.join('posts'))
+    @metadata_file = new_structure_path.join('posts', 'sample-post.yml')
+    @node = Ro::Node.new(@collection, @metadata_file)
+  end
+
+  # T017: Test Asset path resolution with assets/ subdirectory
+  def test_asset_path_with_assets_subdirectory
+    asset_path = new_structure_path / 'posts' / 'sample-post' / 'assets' / 'image.jpg'
+
+    # Both old and new structure use assets/ subdirectory
+    assert asset_path.to_s.include?('/assets/'), "Asset path should contain /assets/ subdirectory"
+  end
+
+  def test_asset_relative_path_calculation
+    asset_path = new_structure_path / 'posts' / 'sample-post' / 'assets' / 'image.jpg'
+    asset = Ro::Asset.new(asset_path)
+
+    # Relative path should be calculated correctly (relative to asset_dir which is node/assets/)
+    relative = asset.relative_path
+
+    assert_not_nil relative, "Relative path should not be nil"
+    # Relative path is relative to asset_dir (node/assets/), so just the filename
+    assert_equal 'image.jpg', relative.to_s, "Relative path should be image.jpg"
+  end
+
+  def test_nested_asset_path
+    # Test with nested subdirectory structure
+    asset_path = new_structure_path / 'posts' / 'nested-test' / 'assets' / 'subdirectory' / 'image.png'
+    asset = Ro::Asset.new(asset_path)
+
+    relative = asset.relative_path
+
+    # Should preserve subdirectory structure (relative to assets/)
+    assert_equal 'subdirectory/image.png', relative.to_s, "Nested asset should preserve directory structure"
+  end
+
+  def test_asset_url_generation
+    asset_path = new_structure_path / 'posts' / 'sample-post' / 'image.jpg'
+    asset = Ro::Asset.new(asset_path)
+
+    # Asset should be able to generate URL
+    # (Exact URL format depends on node.url_for implementation)
+    assert_not_nil asset, "Asset should be created successfully"
+  end
+
+  def test_asset_belongs_to_node
+    asset_paths = @node.asset_paths
+
+    assert asset_paths.any?, "Node should have asset paths"
+
+    # All asset paths should be within node directory
+    asset_paths.each do |path|
+      assert path.to_s.start_with?(@node.asset_dir.to_s), "Asset path should be within node directory"
+    end
+  end
+end
+
+# Run the tests
+if __FILE__ == $0
+  test = AssetTest.new
+
+  puts "Running Asset unit tests..."
+
+  tests = [
+    :test_asset_path_with_assets_subdirectory,
+    :test_asset_relative_path_calculation,
+    :test_nested_asset_path,
+    :test_asset_url_generation,
+    :test_asset_belongs_to_node
+  ]
+
+  tests.each do |test_method|
+    begin
+      test.setup
+      test.send(test_method)
+      puts "✓ #{test_method}"
+    rescue => e
+      puts "✗ #{test_method}: #{e.message}"
+      puts "  #{e.backtrace.first}"
+    end
+  end
+end