rms_web_service 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bea5a6cfaeb3326135eba7ff31a0de5f29db01de
-  data.tar.gz: 38abe79fa798d3b18b02557f0bbed6c35ed23543
+  metadata.gz: 5e4456d8e87be3c43e71ff4c8dcdaa64ae6f0737
+  data.tar.gz: bdb5461405ef0f45c0d67d5531079706bb5b5ec3
 SHA512:
-  metadata.gz: eaf09a19cdb735e4ced433208f1a9fdd4874e702849d15ebf165ce9501052c75fac60f37329afcdde0095b98c79fd4a9bfbd9a8573e742a480e267d006e72383
-  data.tar.gz: 5d16a89e1bdf89fe84dc3d2e875cfbf0df2707b29245015b8905a93377dba70d65ecfb1490348bf3b0822f110cb49f6f78eb051028cd1e348d8412d1ae8ba3bc
+  metadata.gz: df03d83ad6a75e22409231907ac76793c8da2ebc28137ce7c3bf5db96f103cb2312b3d6307299eef595f32641a921e65e3f1126488b60ed4705cacbdd9fe949d
+  data.tar.gz: 37f4d4611fc5f8fb063303c94a08701ae0155d8f0dcbaeb18aa82968ef5a058e513c8231f956e85ccb125ebc239850ccc06f7df403ec4e79f810545070575c01

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
 rvm:
+  - 2.1.2
   - 2.0.0
   - 1.9.3

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rms_web_service.gemspec
 gemspec
+
+gem "coveralls", require: false

data/README.md

@@ -4,12 +4,14 @@ RMS Webservice APIのRubyラッパーです。
 
 [![Gem Version](https://badge.fury.io/rb/rms_web_service.svg)](http://badge.fury.io/rb/rms_web_service)
 [![Build Status](https://travis-ci.org/kamiya54/rms_web_service.svg)](https://travis-ci.org/kamiya54/rms_web_service)
+[![Coverage Status](https://coveralls.io/repos/kamiya54/rms_web_service/badge.png)](https://coveralls.io/r/kamiya54/rms_web_service)
+[![Code Climate](https://codeclimate.com/github/kamiya54/rms_web_service/badges/gpa.svg)](https://codeclimate.com/github/kamiya54/rms_web_service)
 
 #### ご注意
 
-* 楽天市場出品者用APIです。
+* 楽天市場出店者のみが利用できるAPIです。
 * 現在一部機能のみサポートしています。
-* 公式のものではありません。個人が作っているものですので、ご利用は自己責任でお願いします。
+* 非公式です。
 
 ## Installation
 

data/lib/rms_web_service/response/item/error.rb

@@ -1,9 +1,18 @@
+#encoding: utf-8
 module RmsWebService
   module Response
     module Item
-      class Error < Parser
-        def initialize(xml)
-          set_attributes Nokogiri::XML.parse(xml).xpath("//errorMessage").children
+      class Error
+        require 'rms_web_service/response/item/error/const'
+        def self.parse(xml)
+          raise ArgumentError, "Argument must be a String class. but argument is #{xml.class}." unless xml.class == String
+          hash = Hash.new
+          Nokogiri::XML.parse(xml).xpath("//errorMessage").children.each {|att| hash.store(att.name.underscore, att.content)}
+          if hash['field_id'] && ::FIELDID_LIST["#{hash['field_id']}"].present?
+            hash.store("field", ::FIELDID_LIST["#{hash['field_id']}"][0].underscore)
+            hash.store("field_name", ::FIELDID_LIST["#{hash['field_id']}"][1].underscore)
+          end
+          return hash
         end
       end
     end

data/lib/rms_web_service/response/item/error/const.rb

@@ -0,0 +1,64 @@
+#encoding: utf-8
+FIELDID_LIST = {
+"501" => ['itemUrl', '商品管理番号'],
+"502" => ['itemName', '商品名'],
+"503" => ['itemPrice', '販売価格'],
+"504" => ['genreId', '全商品ディレクトリID'],
+"505" => ['itemLayout','商品情報レイアウト'],
+"506" => ['isIncludedTax', '消費税'],
+"507" => ['isIncludedPostage', '送料'],
+"508" => ['isIncludedCashOnDeliveryPostage', '代引き手数料'],
+"509" => ['inventoryType', '在庫タイプ'],
+"510" => ['orderLimit ', '注文受付数'],
+"511" => ['isDepot', '倉庫指定'],
+"512" => ['isSaleButton', '注文ボタン'],
+"513" => ['isDocumentButton', '資料請求ボタン'],
+"514" => ['isInquiryButton', '商品問い合わせボタン'],
+"515" => ['isAvailableForMobile', 'モバイル表示'],
+"516" => ['isNoshiEnable', 'のし対応'],
+"517" => ['pointRate', 'ポイント変倍率'],
+"518" => ['pointRateStart', 'ポイント変倍適応期間(開始)'],
+"518" => ['pointRateEnd', 'ポイント変倍適応期間(終了)'],
+"519" => ['imageAlt', '商品画像名（ALT）'],
+"520" => ['itemNumber', '商品番号'],
+"521" => ['descriptionForPC', 'PC用商品説明文'],
+"522" => ['descriptionForMobile', 'モバイル用商品説明文'],
+"523" => ['displayPrice', '表示価格'],
+"524" => ['imageUrl', '商品画像URL'],
+"525" => ['movieUrl', '動画URL'],
+"526" => ['catchCopyForPC', 'PC用キャッチコピー'],
+"527" => ['catchCopyForMobile', 'モバイル用キャッチコピー'],
+"528" => ['descriptionBySalesMethod', 'PC用販売説明文'],
+"529" => ['postage', '個別送料'],
+"530" => ['postageSegment1', '送料区分１'],
+"531" => ['postageSegment2', '送料区分２'],
+"532" => ['isTimeSale', '期間限定販売フラグ'],
+"532" => ['timeSaleStartDateTime', '期間限定販売開始日'],
+"532" => ['timeSaleEndDateTime', '期間限定販売終了日'],
+"534" => ['inventoryQuantityFlag', '在庫数表示'],
+"535" => ['horizontalName', '項目選択肢別在庫用縦軸選択肢項目名'],
+"536" => ['verticalName', '項目選択肢別在庫用横軸選択肢項目名'],
+"537" => ['inventoryDisplayFlag', '項目選択肢別在庫用残り表示閾値'],
+"540" => ['catalogId', 'カタログID'],
+"542" => ['isBackorder', '在庫切れ時の注文受付'],
+"543" => ['normalDeliveryDateId', '在庫あり時納期管理番号'],
+"544" => ['backorderDeliveryDateId', '在庫切れ時納期管理番号'],
+"552" => ['tagId', 'タグID'],
+"553" => ['reviewDisp', 'レビュー表示'],
+"554" => ['asurakuDeliveryId', 'あす楽配送管理番号'],
+"556" => ['sizeChartLinkCode', 'サイズ表リンクコード'],
+"557" => ['isStockNoticeButton', '再入荷のお知らせボタン'],
+"565" => ['isUnavailableForSearch', 'サーチ非表示'],
+"568" => ['displayPriceId ', '二重価格文言ID'],
+"570" => ['descriptionForSmartPhone', 'スマートフォン用商品説明文'],
+"702" => ['optionStyle', '選択肢スタイル'],
+"703" => ['optionName', 'Select/Checkbox用項目名'],
+"704" => ['value', 'Select/Checkbox用選択肢'],
+"705" => ['optionNameHorizontal', '項目選択肢別在庫用横軸選択肢'],
+"706" => ['childNoHorizontal', '項目選択肢別在庫用横軸選択肢子番号'],
+"707" => ['optionNameVertical', '項目選択肢別在庫用縦軸選択肢'],
+"708" => ['childNoVertical', '項目選択肢別在庫用縦軸選択肢子番号'],
+"709" => ['isBackorderAvailable', '項目選択肢別在庫用取り寄せ可能表示'],
+"710" => ['inventoryCount', '在庫数'],
+"711" => ['isRestoreInventoryFlag', '在庫戻し設定']
+}

data/lib/rms_web_service/response/item/parser.rb

@@ -8,7 +8,7 @@ module RmsWebService
           @status = Item::Status.new(xml)
           @code = @parsed_xml.xpath("//code").first.content if @parsed_xml.xpath("//code").present?
           @errors = []
-          @parsed_xml.xpath("//errorMessages").each {|error| @errors << Error.new(error)} if @parsed_xml.xpath("//errorMessages").present?
+          @parsed_xml.xpath("//errorMessages").children.each {|error| @errors << Error.parse(error.to_s)} if @parsed_xml.xpath("//errorMessages").present?
         end
 
         def set_attributes(args)
@@ -16,8 +16,7 @@ module RmsWebService
         end
 
         def set_attribute(name, content)
-          att = name.gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').gsub(/([a-z\d])([A-Z])/,'\1_\2').tr("-", "_").downcase
-          self.define_singleton_method(att) {content}
+          self.define_singleton_method(name.underscore) {content}
         end
       end
     end

data/lib/rms_web_service/version.rb

@@ -1,3 +1,3 @@
 module RmsWebService
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/spec/fixtures/update.xml

@@ -9,7 +9,7 @@
   </status>
   <itemUpdateResult>
     <code>code</code>
-    <errorMessages><errorMessage><errorId>errorId</errorId><fieldId>fieldId</fieldId><msg>error message</msg><listIndex>1</listIndex><listIndex2>2</listIndex2></errorMessage></errorMessages>
+    <errorMessages><errorMessage><errorId>errorId</errorId><fieldId>503</fieldId><msg>error message</msg><listIndex>1</listIndex><listIndex2>2</listIndex2></errorMessage></errorMessages>
     <item>
       <itemUrl>yyy</itemUrl>
     </item>

data/spec/rms_web_service/response/item/delete_spec.rb

@@ -2,6 +2,24 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::Delete do
-  subject {described_class.new(fixture('delete.xml'))}
-  it {is_expected.to respond_to(:status, :code, :success?, :errors, :item_url)}
+  let(:api) {described_class.new(fixture('delete.xml'))}
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+  
+    it 'should respond to ItemDeleteResult' do
+      expect(api).to respond_to :code
+      expect(api).to respond_to :success?
+    end
+  
+    it 'should respond to Item' do
+      expect(api).to respond_to :item_url
+    end
+  
+    it 'should respond to ErrorMessage' do
+      expect(api).to respond_to :errors
+    end
+  end
 end

data/spec/rms_web_service/response/item/error_spec.rb

@@ -1,8 +1,20 @@
+#encoding: utf-8
 require 'spec_helper'
 require 'rms_web_service'
 
 describe RWS::Response::Item::Error do
-  subject(:error) {described_class.new(fixture('update.xml'))}
-  it {is_expected.to be_a RWS::Response::Item::Error}
-  it {is_expected.to respond_to(:field_id)}
+  let(:res) {{"error_id"=>"errorId", "field_id"=>"503", "msg"=>"error message", "list_index"=>"1", "list_index2"=>"2", "field"=>"item_price", "field_name"=>"販売価格"}}
+  subject {described_class.parse(fixture('update.xml').read)}
+  it("should return formatted error") {is_expected.to eq res}
+
+  describe 'optional attributes' do
+    it {is_expected.to include("field")}
+    it {is_expected.to include("field_name")}
+  end
+
+  describe 'invalid argument' do
+    it "" do
+      expect{described_class.parse(Array.new)}.to raise_error ArgumentError
+    end
+  end
 end

data/spec/rms_web_service/response/item/get_spec.rb

@@ -2,7 +2,26 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::Get do
-  subject {described_class.new(fixture('get.xml'))}
-  it {is_expected.to respond_to(:status, :code, :success?, :item_url, :item_name, :item_price)}
-  it {is_expected.not_to respond_to(:errors)}
+  let(:api) {described_class.new(fixture('get.xml'))}
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+  
+    it 'should respond to ItemGetResult' do
+      expect(api).to respond_to :code
+      expect(api).to respond_to :success?
+    end
+  
+    it 'should respond to Item' do
+      expect(api).to respond_to :item_url
+      expect(api).to respond_to :item_name
+      expect(api).to respond_to :item_price
+    end
+  
+    it 'should not respond to ErrorMessage' do
+      expect(api).not_to respond_to :errors
+    end
+  end
 end

data/spec/rms_web_service/response/item/insert_spec.rb

@@ -2,6 +2,24 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::Insert do
-  subject {described_class.new(fixture('insert.xml'))}
-  it {is_expected.to respond_to(:status, :code, :success?, :errors, :item_url)}
+  let(:api) {described_class.new(fixture('insert.xml'))}
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+  
+    it 'should respond to ItemDeleteResult' do
+      expect(api).to respond_to :code
+      expect(api).to respond_to :success?
+    end
+  
+    it 'should respond to Item' do
+      expect(api).to respond_to :item_url
+    end
+  
+    it 'should respond to ErrorMessage' do
+      expect(api).to respond_to :errors
+    end
+  end
 end

data/spec/rms_web_service/response/item/items_update_spec.rb

@@ -2,10 +2,27 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::ItemsUpdate do
-  subject(:res) {described_class.new(fixture('items_update.xml'))}
-  it {is_expected.to respond_to(:status)}
-  it {is_expected.to_not respond_to(:code, :success?, :errors, :item_url)}
+  subject(:api) {described_class.new(fixture('items_update.xml'))}
   it 'should be an array of RWS::Response::Item::Update' do
-    expect(res[0]).to be_a RWS::Response::Item::Update
+    expect(api[0]).to be_a RWS::Response::Item::Update
+  end
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+  
+    it 'should not respond to ItemsUpdateResult' do
+      expect(api).not_to respond_to :code
+      expect(api).not_to respond_to :success?
+    end
+  
+    it 'should not respond to Item' do
+      expect(api).not_to respond_to :item_url
+    end
+  
+    it 'should not respond to ErrorMessage' do
+      expect(api).not_to respond_to :errors
+    end
   end
 end

data/spec/rms_web_service/response/item/parser_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe RmsWebService::Response::Item::Parser do
+  describe "initialize" do
+    subject {::RWS::Response::Item::Update.new(fixture('update.xml'))}
+    it {is_expected.to be_a ::RWS::Response::Item::Parser}
+  end
+
+  describe "#errors" do
+    let(:api) {::RWS::Response::Item::Update.new(fixture('update.xml'))}
+    it "" do
+      expect(api.errors).to be_a Array
+    end
+  end
+end

data/spec/rms_web_service/response/item/search_spec.rb

@@ -2,10 +2,27 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::Search do
-  subject(:res) {described_class.new(fixture('search.xml'))}
-  it {is_expected.to respond_to(:status, :success?, :code)}
-  it {is_expected.to_not respond_to(:item_url, :errors)}
+  subject(:api) {described_class.new(fixture('search.xml'))}
   it 'should be an array of RWS::Response::Item::Get' do
-    expect(res[0]).to be_a RWS::Response::Item::Get
+    expect(api[0]).to be_a RWS::Response::Item::Get
+  end
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+  
+    it 'should respond to ItemSearchResult' do
+      expect(api).to respond_to :code
+      expect(api).to respond_to :success?
+    end
+  
+    it 'should not respond to Item' do
+      expect(api).not_to respond_to :item_url
+    end
+  
+    it 'should not respond to ErrorMessage' do
+      expect(api).not_to respond_to :errors
+    end
   end
 end

data/spec/rms_web_service/response/item/update_spec.rb

@@ -2,6 +2,24 @@ require 'spec_helper'
 require 'rms_web_service'
 
 describe RmsWebService::Response::Item::Update do
-  subject {described_class.new(fixture('update.xml'))}
-  it {is_expected.to respond_to(:status, :code, :success?, :errors, :item_url)}
+  let(:api) {described_class.new(fixture('update.xml'))}
+
+  describe 'attributes' do
+    it 'should respond to SystemResult' do
+      expect(api).to respond_to :status
+    end
+
+    it 'should respond to ItemDeleteResult' do
+      expect(api).to respond_to :code
+      expect(api).to respond_to :success?
+    end
+
+    it 'should respond to Item' do
+      expect(api).to respond_to :item_url
+    end
+
+    it 'should respond to ErrorMessage' do
+      expect(api).to respond_to :errors
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -9,3 +9,6 @@ end
 def fixture(file)
   File.new(File.join(fixture_path, file))
 end
+
+require 'coveralls'
+Coveralls.wear!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rms_web_service
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - kamiya54
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-16 00:00:00.000000000 Z
+date: 2014-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -129,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
 - .rspec
 - .travis.yml
@@ -145,6 +146,7 @@ files:
 - lib/rms_web_service/response/item.rb
 - lib/rms_web_service/response/item/delete.rb
 - lib/rms_web_service/response/item/error.rb
+- lib/rms_web_service/response/item/error/const.rb
 - lib/rms_web_service/response/item/get.rb
 - lib/rms_web_service/response/item/insert.rb
 - lib/rms_web_service/response/item/items_update.rb
@@ -168,6 +170,7 @@ files:
 - spec/rms_web_service/response/item/get_spec.rb
 - spec/rms_web_service/response/item/insert_spec.rb
 - spec/rms_web_service/response/item/items_update_spec.rb
+- spec/rms_web_service/response/item/parser_spec.rb
 - spec/rms_web_service/response/item/search_spec.rb
 - spec/rms_web_service/response/item/status_spec.rb
 - spec/rms_web_service/response/item/update_spec.rb
@@ -212,6 +215,7 @@ test_files:
 - spec/rms_web_service/response/item/get_spec.rb
 - spec/rms_web_service/response/item/insert_spec.rb
 - spec/rms_web_service/response/item/items_update_spec.rb
+- spec/rms_web_service/response/item/parser_spec.rb
 - spec/rms_web_service/response/item/search_spec.rb
 - spec/rms_web_service/response/item/status_spec.rb
 - spec/rms_web_service/response/item/update_spec.rb