rms_web_service 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd03378f6428937283c1abf606036b9abf6b05f1
-  data.tar.gz: 6908ae4a258b178e9de8f299c14a46e9deb957d7
+  metadata.gz: bea5a6cfaeb3326135eba7ff31a0de5f29db01de
+  data.tar.gz: 38abe79fa798d3b18b02557f0bbed6c35ed23543
 SHA512:
-  metadata.gz: a244fcf7b47080a365a602e55a0ca661a159f3d171e4db5764b763868e1e3b76dc983361fb4631a645866da6898bfdeb765f54c372d4314d36dd90a0430e5fbd
-  data.tar.gz: d26ac747de65732ff23bc19e2177f021d8bb8ed0ace736ff563b657a3027cff7af60da56e51534438a7ee9611ee45ef39d79a702aa9848d9f0608bd55ee21a8e
+  metadata.gz: eaf09a19cdb735e4ced433208f1a9fdd4874e702849d15ebf165ce9501052c75fac60f37329afcdde0095b98c79fd4a9bfbd9a8573e742a480e267d006e72383
+  data.tar.gz: 5d16a89e1bdf89fe84dc3d2e875cfbf0df2707b29245015b8905a93377dba70d65ecfb1490348bf3b0822f110cb49f6f78eb051028cd1e348d8412d1ae8ba3bc

data/README.md

@@ -39,18 +39,18 @@ client = RmsWebService::Client::Item.new(service_secret: "dummy_service_secret",
 
 ### RmsWebService::Client::Item
 
-RmsWebService::Client::ItemのインスタンスがAPIの各メソッドを持っています。パラメータを渡す場合はハッシュ、複数のItemを渡す場合は配列を使用します。
+RmsWebService::Client::ItemのインスタンスがAPIの各メソッドを持っています。各メソッドへのパラメータの渡し方は下記の通りです。
 
 ```ruby
-# item.get
-item = client.get(:item_url => "ed-60c-w")
+item = client.get("ed-60c-w")
 # '.item_name'、'.item_price'等のメソッドを持ちます。属性については公式ドキュメントを見てください。
 
-# item.update
+item = client.delete("test001")
+# '.success?'で成功したかどうかを判別できます。'.errors'でエラー内容を確認できます。
+
 item = client.update({:item_url => "ed-60c-w", :item_price => 43800})
 # '.success?'で成功したかどうかを判別できます。'.errors'でエラー内容を確認できます。
 
-# item.insert
 item = client.insert({
   :item_url => "test001",
   :item_name => "test001",
@@ -59,15 +59,9 @@ item = client.insert({
 })
 # '.success?'で成功したかどうかを判別できます。'.errors'でエラー内容を確認できます。
 
-# item.delete
-item = client.delete(:item_url => "test001")
-# '.success?'で成功したかどうかを判別できます。'.errors'でエラー内容を確認できます。
-
-# item.search
 items = client.search(:item_name => "空気清浄機")
 # item.getと同じ性質のインスタンスを要素として持つ配列を返します
 
-# items.update
 items = client.items_update([
   {:item_url => "ed-60c-w", :item_price => 43800},
   {:item_url => "noexist", :item_price => 10800}

data/lib/rms_web_service/client/item.rb

@@ -11,6 +11,7 @@ module RmsWebService
 
       def initialize(args={})
         @configuration = ::RmsWebService::Configuration.new(args)
+        @endpoint = args[:endpoint]
       end
 
       def connection(method)
@@ -21,11 +22,11 @@ module RmsWebService
       end
 
       def endpoint(method)
-        return Endpoint + method
+        @endpoint || Endpoint + method
       end
 
-      def get(args)
-        request = connection('item/get').get {|req| req.params['itemUrl'] = args[:item_url]}
+      def get(item_url)
+        request = connection('item/get').get {|req| req.params['itemUrl'] = item_url }
         return ::RmsWebService::Response::Item::Get.new(request.body)
       end
 
@@ -59,12 +60,12 @@ module RmsWebService
         return ::RmsWebService::Response::Item::Update.new(request.body)
       end
 
-      def delete(args)
+      def delete(item_url)
         xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
           xml.request do
             xml.itemDeleteRequest do
               xml.item do
-                args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
+                xml.itemUrl item_url
               end
             end
           end

data/lib/rms_web_service/version.rb

@@ -1,3 +1,3 @@
 module RmsWebService
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/rms_web_service/client/item_spec.rb

@@ -5,6 +5,8 @@ describe RmsWebService::Client::Item do
   subject(:client) {described_class.new(:service_secret => service_secret, :license_key => license_key)}
   let(:service_secret) {'dummy_service_secret'}
   let(:license_key) {'dummy_license_key'}
+  let(:default_url) {"https://api.rms.rakuten.co.jp/es/1.0/"}
+  let(:specified_url) {"https://example.com/"}
 
   describe '.new' do
     it { is_expected.to be_a RmsWebService::Client::Item }
@@ -20,12 +22,24 @@ describe RmsWebService::Client::Item do
     it { is_expected.to be_a Faraday::Connection }
   end
 
+  describe '.endpoint' do
+    context 'default URL' do
+      subject {client.endpoint("item/get")}
+      it { is_expected.to eq default_url + "item/get"}
+    end
+    context 'specify URL' do
+      let(:api) {described_class.new(:service_secret => service_secret, :license_key => license_key, :endpoint => specified_url)}
+      subject {api.endpoint("item/get")}
+      it { is_expected.to eq specified_url}
+    end
+  end
+
   describe '.get' do
     before do
       stub_request(:get, "https://api.rms.rakuten.co.jp/es/1.0/item/get?itemUrl=test001")
       .to_return(:status => 200, body: fixture('get.xml'))
     end
-    subject {client.get(:item_url => 'test001')}
+    subject {client.get('test001')}
     it {is_expected.to be_a RWS::Response::Item::Get}
   end
 
@@ -34,7 +48,7 @@ describe RmsWebService::Client::Item do
       stub_request(:post, "https://api.rms.rakuten.co.jp/es/1.0/item/delete")
       .to_return(:status => 200, body: fixture('delete.xml'))
     end
-    subject {client.delete(:item_url => 'test001')}
+    subject {client.delete('test001')}
     it {is_expected.to be_a RWS::Response::Item::Delete}
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rms_web_service
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - kamiya54
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-15 00:00:00.000000000 Z
+date: 2014-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday