rms_web_service 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f657900566ae9fc7c26ce9df5ef539fb9bd172f0
-  data.tar.gz: e2e50030c4ec72c2e81e522cc0c11fc0dbfb17c8
+  metadata.gz: 48677c86bf718efe72101c4ceb6ef142e9326b4a
+  data.tar.gz: 813da41d26251b10ed74baf5871261c8b815d870
 SHA512:
-  metadata.gz: 33b04d98d9d953d2f347c020e5b5c3274197cdee0bc99f25efc1a1e565ec98c40d0a90919a078ffcf74b1936d1f7ef7030361fe702fc788fe133d0bc509b62ae
-  data.tar.gz: 459ffdd6be56b9f1acf6ec3da91e5b2d2f4cc75015d2764a7cfc58fba7addeaaeaeaa8b6f7848e541b94e7770a17b5c609e19d86bbc86d9bb4a57981c237a0e8
+  metadata.gz: 0b4cbad54e393a229ccd5c51ebb8216c4b8986ced086dbdd2836af3ad4e766499dc87e20e460a0b40f5edaba4fe5bd2c8fc94df2e2967164951e41e67506f27a
+  data.tar.gz: 9be9a613238343dcad86e5f6b75b3cb1bf09780de4c60db32a4c7408303f37db8288dfd6eb65e9e3adfd902d90f372846dc513083ac4a5c55d61d94d747d97f2

data/.rspec

@@ -0,0 +1 @@
+--color --format doc

data/README.md

@@ -2,6 +2,7 @@
 
 RMS Webservice APIのRubyラッパーです。
 
+[![Gem Version](https://badge.fury.io/rb/rms_web_service.svg)](http://badge.fury.io/rb/rms_web_service)
 [![Build Status](https://travis-ci.org/kamiya54/rms_web_service.svg)](https://travis-ci.org/kamiya54/rms_web_service)
 
 #### ご注意
@@ -33,7 +34,7 @@ Or install it yourself as:
 `RmsWebService.configuration`でサービスIDとライセンスキーを設定できます。各キーはRMSより発行できます。
 
 ```ruby
-RmsWebService.configuration do |c|
+RmsWebService.configure do |c|
   c.service_secret = "dummy_service_secret"
   c.license_key = "dummy_license_key"
 end

data/lib/rms_web_service/configuration.rb

@@ -4,20 +4,16 @@ module RmsWebService
   class Configuration
     attr_accessor :service_secret, :license_key
 
-    def encoded_keys
-      if service_secret.present? && license_key.present?
-        return "ESA " + Base64.encode64(service_secret + ":" + license_key).gsub(/\n/, "")
-      else
-        raise AuthError, 'please set serviceSecret and licenseKey'
-      end
+    def initialize(args={})
+      @service_secret = args[:service_secret]
+      @license_key = args[:license_key]
     end
-  end
 
-  def configuration(&block)
-    @configuration ||= Configuration.new
-    block.call @configuration if block_given?
-    return @configuration
-  end
+    def encoded_keys
+        raise RmsWebService::ParameterError, 'service_secret is required' unless service_secret.present?
+        raise RmsWebService::ParameterError, 'license_key is required' unless license_key.present?
 
-  module_function :configuration
+        "ESA " + Base64.encode64(service_secret + ":" + license_key).chomp
+    end
+  end
 end

data/lib/rms_web_service/item/delete.rb

@@ -1,20 +1,5 @@
 module RmsWebService
   class Item
-    def self.delete(args)
-      xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
-        xml.request do
-          xml.itemDeleteRequest do
-            xml.item do
-              args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
-            end
-          end
-        end
-      end
-
-      request = connection("item/delete").post {|req| req.body = xml_object.to_xml}
-      return Delete.new(request.body)
-    end
-
     class Delete
       include Response
       def initialize(xml)

data/lib/rms_web_service/item/get.rb

@@ -1,10 +1,5 @@
 module RmsWebService
   class Item
-    def self.get(args)
-      request = connection('item/get').get {|req| req.params['itemUrl'] = args[:item_url]}
-      return Get.new(request.body)
-    end
-
     class Get
       include Response
       def initialize(xml)

data/lib/rms_web_service/item/insert.rb

@@ -1,20 +1,5 @@
 module RmsWebService
   class Item
-    def self.insert(args)
-      xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
-        xml.request do
-          xml.itemInsertRequest do
-            xml.item do
-              args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
-            end
-          end
-        end
-      end
-
-      request = connection("item/insert").post {|req| req.body = xml_object.to_xml}
-      return Insert.new(request.body)
-    end
-
     class Insert
       include Response
       def initialize(xml)

data/lib/rms_web_service/item/items_update.rb

@@ -1,24 +1,5 @@
 module RmsWebService
   class Item
-    def self.items_update(args)
-      xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
-        xml.request do
-          xml.itemsUpdateRequest do
-            xml.items do
-              args.each do |item|
-                xml.item do
-                  item.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
-                end
-              end
-            end
-          end
-        end
-      end
-
-      request = connection("items/update").post {|req| req.body = xml_object.to_xml}
-      return ItemsUpdate.new(request.body)
-    end
-
     class ItemsUpdate < Array
       include Response
       def initialize(xml)

data/lib/rms_web_service/item/search.rb

@@ -1,13 +1,5 @@
 module RmsWebService
   class Item
-    def self.search(args)
-      request = connection("item/search").get do |req|
-        args.each {|key, value| req.params["#{key.to_s.camelize(:lower)}"] = args[:"#{key}"]}
-      end
-
-      return Search.new(request.body)
-    end
-
     class Search < ::Array
       include Response
       def initialize(xml)

data/lib/rms_web_service/item/update.rb

@@ -1,20 +1,5 @@
 module RmsWebService
   class Item
-    def self.update(args)
-      xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
-        xml.request do
-          xml.itemUpdateRequest do
-            xml.item do
-              args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
-            end
-          end
-        end
-      end
-
-      request = connection("item/update").post {|req| req.body = xml_object.to_xml}
-      return Update.new(request.body)
-    end
-
     class Update
       include Response
       def initialize(xml)

data/lib/rms_web_service/item.rb

@@ -12,15 +12,94 @@ require 'rms_web_service/item/items_update'
 
 module RmsWebService
   class Item
-    def self.connection(method)
-      connection = Faraday.new(:url => endpoint(method)) do |c|
-        c.adapter Faraday.default_adapter
-        c.headers['Authorization'] = RmsWebService.configuration.encoded_keys
+    class << self
+      def connection(method)
+        connection = Faraday.new(:url => endpoint(method)) do |c|
+          c.adapter Faraday.default_adapter
+          c.headers['Authorization'] = RmsWebService.configuration.encoded_keys
+        end
+      end
+
+      def endpoint(method)
+        return Endpoint + method
+      end
+
+      def get(args)
+        request = connection('item/get').get {|req| req.params['itemUrl'] = args[:item_url]}
+        return Get.new(request.body)
       end
-    end
 
-    def self.endpoint(method)
-      return Endpoint + method
+      def insert(args)
+        xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
+          xml.request do
+            xml.itemInsertRequest do
+              xml.item do
+                args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
+              end
+            end
+          end
+        end
+
+        request = connection("item/insert").post {|req| req.body = xml_object.to_xml}
+        return Insert.new(request.body)
+      end
+
+      def update(args)
+        xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
+          xml.request do
+            xml.itemUpdateRequest do
+              xml.item do
+                args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
+              end
+            end
+          end
+        end
+
+        request = connection("item/update").post {|req| req.body = xml_object.to_xml}
+        return Update.new(request.body)
+      end
+
+      def delete(args)
+        xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
+          xml.request do
+            xml.itemDeleteRequest do
+              xml.item do
+                args.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
+              end
+            end
+          end
+        end
+
+        request = connection("item/delete").post {|req| req.body = xml_object.to_xml}
+        return Delete.new(request.body)
+      end
+
+      def search(args)
+        request = connection("item/search").get do |req|
+          args.each {|key, value| req.params["#{key.to_s.camelize(:lower)}"] = args[:"#{key}"]}
+        end
+
+        return Search.new(request.body)
+      end
+
+      def items_update(args)
+        xml_object = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
+          xml.request do
+            xml.itemsUpdateRequest do
+              xml.items do
+                args.each do |item|
+                  xml.item do
+                    item.each {|key, value| eval("xml.#{key.to_s.camelize(:lower)} '#{value}'")}
+                  end
+                end
+              end
+            end
+          end
+        end
+
+        request = connection("items/update").post {|req| req.body = xml_object.to_xml}
+        return ItemsUpdate.new(request.body)
+      end
     end
   end
 end

data/lib/rms_web_service/version.rb

@@ -1,3 +1,3 @@
 module RmsWebService
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/rms_web_service.rb

@@ -6,5 +6,22 @@ RWS = RmsWebService
 
 module RmsWebService
   Endpoint = "https://api.rms.rakuten.co.jp/es/1.0/"
-  class AuthError < StandardError;end
+
+  @@configuration = Configuration.new
+
+  def configure(&block)
+    block.call @@configuration if block_given?
+  end
+  module_function :configure
+
+  def configuration
+    @@configuration
+  end
+  module_function :configuration
+
+  class AuthError < StandardError
+  end
+
+  class ParameterError < StandardError
+  end
 end

data/rms_web_service.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["kamiya54@gmail.com"]
   spec.summary       = %q{Ruby wrapper for RMS Web Service.}
   spec.description   = %q{Ruby wrapper for RMS Web Service.}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/kamiya54/rms_web_service"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "faraday", "~> 0.9.0"
-  spec.add_dependency "nokogiri", "~> 1.6.2"
+  spec.add_dependency "faraday"
+  spec.add_dependency "nokogiri"
   spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler", "~> 1.6"

data/spec/rms_web_service/configuration_spec.rb

@@ -1,31 +1,44 @@
 require 'spec_helper'
-require 'rms_web_service/item'
-
-describe RmsWebService do
-  describe '.configuration' do
-    let(:config) {RmsWebService.configuration}
-  
-    context "don't set serviceSecret and licenseKey" do
-      it 'raise AuthError' do
-        expect{config.encoded_keys}.to raise_error RmsWebService::AuthError
-      end
+
+describe RmsWebService::Configuration do
+  let(:config){ described_class.new(service_secret: service_secret, license_key: license_key) }
+  let(:service_secret){ "dummy_service_secret" }
+  let(:license_key){ "dummy_license_key" }
+
+  describe "#service_secret" do
+    subject{ config.service_secret }
+    it { is_expected.to eq(service_secret) }
+  end
+
+  describe "#license_key" do
+    subject{ config.license_key }
+    it { is_expected.to eq(license_key) }
+  end
+
+  describe "#encoded_keys" do
+    context "with service_secret and license_key" do
+      let(:encoded_string){
+        encoded_credentials = Base64.encode64("#{service_secret}:#{license_key}")
+        "ESA #{encoded_credentials}".chomp
+      }
+
+      subject{ config.encoded_keys }
+      it { is_expected.to eq(encoded_string) }
     end
 
-    context 'set serviceSecret and licenseKey correctly' do
-      before :each do
-        RmsWebService.configuration do |c|
-          c.service_secret = 'dummy_service_secret'
-          c.license_key = 'dummy_license_key'
-        end
-      end
-  
-      it 'can set parameters properly' do
-        expect(config.service_secret).to eq 'dummy_service_secret'
-        expect(config.license_key).to eq 'dummy_license_key'
+    context "without service_secret" do
+      before { config.service_secret = nil }
+
+      it "should raise ParameterError" do
+        expect{ config.encoded_keys }.to raise_error(RmsWebService::ParameterError, /service_secret/)
       end
-  
-      it 'return encoded keys' do
-        expect(Base64.decode64(config.encoded_keys.gsub('ESA ', ''))).to eq 'dummy_service_secret:dummy_license_key'
+    end
+
+    context "without license_key" do
+      before { config.license_key = nil }
+
+      it "should raise ParameterError" do
+        expect{ config.encoded_keys }.to raise_error(RmsWebService::ParameterError, /license_key/)
       end
     end
   end

data/spec/rms_web_service/item/delete_spec.rb

@@ -6,12 +6,12 @@ describe RmsWebService::Item::Delete do
     let(:api) {RmsWebService::Item.delete({:item_url => 'test001'})}
 
     before :all do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end
     end
-  
+
     before :each do
       stub_request(:post, "https://api.rms.rakuten.co.jp/es/1.0/item/delete")
       .to_return(:status => 200, body: fixture('delete.xml'))

data/spec/rms_web_service/item/get_spec.rb

@@ -6,7 +6,7 @@ describe RmsWebService::Item::Get do
     let(:api) {RmsWebService::Item.get(:item_url => 'test001')}
 
     before do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end

data/spec/rms_web_service/item/insert_spec.rb

@@ -10,12 +10,12 @@ describe RmsWebService::Item::Insert do
     })}
 
     before :all do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end
     end
-  
+
     before :each do
       stub_request(:post, "https://api.rms.rakuten.co.jp/es/1.0/item/insert")
       .to_return(:status => 200, body: fixture('insert.xml'))

data/spec/rms_web_service/item/items_update_spec.rb

@@ -9,7 +9,7 @@ describe RmsWebService::Item::ItemsUpdate do
     ])}
 
     before do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end

data/spec/rms_web_service/item/search_spec.rb

@@ -6,7 +6,7 @@ describe RmsWebService::Item::Search do
     let(:api) {RmsWebService::Item.search(:item_name => 'test001', :item_price_from => 1)}
 
     before do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end

data/spec/rms_web_service/item/update_spec.rb

@@ -6,12 +6,12 @@ describe RmsWebService::Item::Update do
     let(:api) {RmsWebService::Item.update({:item_url => 'test001', :item_price => '10000'})}
 
     before :all do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end
     end
-  
+
     before :each do
       stub_request(:post, "https://api.rms.rakuten.co.jp/es/1.0/item/update")
       .to_return(:status => 200, body: fixture('update.xml'))

data/spec/rms_web_service/item_spec.rb

@@ -4,7 +4,7 @@ require 'rms_web_service/item'
 describe RmsWebService::Item do
   describe '.connection' do
     before do
-      RmsWebService.configuration do |c|
+      RmsWebService.configure do |c|
         c.service_secret = 'dummy_service_secret'
         c.license_key = 'dummy_license_key'
       end

data/spec/rms_web_service_spec.rb

@@ -1 +1,11 @@
 require 'spec_helper'
+
+describe RmsWebService do
+  describe '.configure' do
+  end
+
+  describe ".configuration" do
+    subject { described_class.configuration }
+    it { is_expected.to be_a(RmsWebService::Configuration) }
+  end
+end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: rms_web_service
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - kamiya54
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-10 00:00:00.000000000 Z
+date: 2014-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.6.2
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.6.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - .travis.yml
 - Gemfile
 - Guardfile
@@ -165,7 +166,7 @@ files:
 - spec/rms_web_service/item_spec.rb
 - spec/rms_web_service_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/kamiya54/rms_web_service
 licenses:
 - MIT
 metadata: {}