rmega 0.1.3 → 0.1.4

data/TODO.md

@@ -0,0 +1,6 @@
+## Rmega todos
+
+  * Handle timeouts in download/upload
+  * Handle error code -3 response, that is "A temporary congestion or server malfunction prevented your request from being processed.". I noticed that this occurs quite often when creating/deleting a folder node :/
+  * Search for TODO in the project for other minor tasks
+  * Resist the hypnotoad's will

data/lib/rmega/nodes/expandable.rb

@@ -10,7 +10,7 @@ module Rmega
         encrypted_attributes = Utils.a32_to_base64 Crypto.encrypt_attributes(key[0..3], {n: name.strip})
         encrypted_key = Utils.a32_to_base64 Crypto.encrypt_key(session.master_key, key)
         n = [{h: 'xxxxxxxx', t: 1, a: encrypted_attributes, k: encrypted_key}]
-        data = session.request a: 'p', t: parent_handle, n: n
+        data = session.request a: 'p', t: handle, n: n
         Folder.new(session, data['f'][0])
       end
 

data/lib/rmega/version.rb

@@ -1,3 +1,3 @@
 module Rmega
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/spec/integration/file_upload_spec.rb

@@ -61,6 +61,7 @@ describe 'File upload' do
 
       let!(:folder) { @storage.root.create_folder(@name) }
 
+      # TODO: `let` and `subject` declarations are not intended to be called in a `before(:all)`
       before(:all) { folder.upload(@path) }
 
       it 'finds the uploaded file and verify its content' do

data/spec/integration/folder_operations_spec.rb

@@ -5,12 +5,14 @@ describe 'Folders operations' do
   if account_file_exists?
 
     before(:all) do
-      @name = "test_folder_#{rand.denominator}_#{rand.denominator}"
+      @name = "folder_#{rand.denominator}_#{rand.denominator}"
+      @sub_folder_name = "folder_#{rand.denominator}_#{rand.denominator}"
       @storage = login
     end
 
-    def find_folder
-      @storage.root.folders.find { |f| f.name == @name }
+    # Note: node searching is traversal
+    def find_folder(name)
+      @storage.nodes.find { |f| f.type == :folder && f.name == name }
     end
 
     context 'when #create_folder is called on a node' do
@@ -18,24 +20,42 @@ describe 'Folders operations' do
       it 'creates a new folder under that node' do
         folder = @storage.root.create_folder(@name)
         expect(folder.name).to eql @name
+        expect(folder.parent_handle).to eq @storage.root.handle
       end
     end
 
     context 'searching for a folder by its name' do
 
       it 'returns the matching folder' do
-        expect(find_folder.name).to eql @name
+        expect(find_folder(@name).name).to eql @name
+      end
+    end
+
+    context "when #create_folder under created folder" do
+
+      it "creates a new folder under created folder" do
+        parent_folder = find_folder(@name)
+
+        sub_folder = parent_folder.create_folder(@sub_folder_name)
+
+        expect(parent_folder.folders.first.name).to eql @sub_folder_name
+        expect(sub_folder.parent_handle).to eql parent_folder.handle
       end
     end
 
     context 'when #delete is called on a folder node' do
 
+      it 'deletes sub folder' do
+        expect(find_folder(@sub_folder_name).delete).to eql 0
+      end
+
       it 'deletes the folder' do
-        expect(find_folder.delete).to eql 0
+        expect(find_folder(@name).delete).to eql 0
       end
 
-      it 'does not find the folder anymore' do
-        expect(find_folder).to be_nil
+      it 'does not find the folder (and its subfolder) anymore' do
+        expect(find_folder(@name)).to be_nil
+        expect(find_folder(@sub_folder_name)).to be_nil
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rmega
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-08 00:00:00.000000000 Z
+date: 2013-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -119,6 +119,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- TODO.md
 - lib/rmega.rb
 - lib/rmega/crypto/aes.rb
 - lib/rmega/crypto/aes_ctr.rb