rmail 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 83fc629623b0371334b9ddec04171dd155303142
-  data.tar.gz: dcf6d458a51418968fe84a0aa1c59bf257df4366
+SHA256:
+  metadata.gz: 419bee362a39a953f99c8e6ff8adbbc1c921df6a4db9bb64f549ec6ed6a6ba3b
+  data.tar.gz: f93bce83b84092e1c05ef2472f1d1936b03ad7ff5ef398b2f85dd61eff5f726c
 SHA512:
-  metadata.gz: 8bf88fee9db737461e6c00cd9fa0bc16c196dc1fae1ee2a97f4fb6cec2fbf77cb5375d22f9e23f0994b271c175e80cd2c4c694856bccc8aa7bd8334cfe574b00
-  data.tar.gz: 9b8b91f150c6f6a9d0bd53a3a9b438635f805e396d8245bea2d9eed0e3a34e936280ced7aafd47b3ef21b6246e1bb596469c2f84b8af4688abd00de5bcb1b238
+  metadata.gz: e3084bf084c2be23361db1cdc21321f623ab32e486ff3a101516d8f12999853c6650158b6082208320b79fd638bc51e7b06952bab9f41c2013b0675697e11e91
+  data.tar.gz: 4801d74331dfa38682cb4484f16f5cb9f07704bb8305fa5dcb2e3a42a10460e912327c63a00a7f02b92e1ffc2a7d653cfa33cf7c45bc4b055b3c6d4e29fcd95c

data/ChangeLog

@@ -1,3 +1,17 @@
+= Changes in RubyMail 1.1.4 (released 2020-07-08)
+
+- Fix 'warning: constant ::Fixnum is deprecated' since Ruby 2.5 (Martin Vidner)
+- Fix 'warning: instance variable @delimiters not initialized' (Martin Vidner)
+- Fix 'warning: shadowing outer local variable - name, value' (Martin Vidner)
+- Fix 'warning: optional boolean argument is obsoleted' (Martin Vidner)
+- Fix 'warning: character class has duplicated range' (Martin Vidner)
+- Fix 'warning: assigned but unused variable' (Martin Vidner)
+- Enable code coverage analysis (Martin Vidner)
+- Test Ruby 2.5 and 2.6 on Travis (Martin Vidner)
+- Test Ruby 2.7 (Martin Vidner)
+- include license text in a separate file (Dan Callaghan)
+- Rakefile: drop usage of deprecated rubygems feature (Antonio Terceiro)
+
 = Changes in RubyMail 1.1.3 (released 2017-07-16)
 
 - Fix tests that suddenly started failing for no apparent reason

data/Rakefile

@@ -141,7 +141,6 @@ spec = Gem::Specification.new do |s|
 
   s.required_ruby_version = Gem::Version::Requirement.new(">= 1.8.1")
 
-  s.has_rdoc = true
   s.extra_rdoc_files = rdoc.rdoc_files.reject { |fn| fn =~ /\.rb$/ }.to_a
   s.rdoc_options.concat([ '--title', rdoc.title, '--main', rdoc.main,
                           rdoc.options ].flatten)

data/lib/rmail/address.rb

@@ -661,7 +661,7 @@ module RMail
             comment
           when /\A""/           # skip empty quoted text
             @string = $'
-          when /\A[\w!$%&\'*+\/=?^_\`{\}|~#-]+/m
+          when /\A[\w!$%&\'*+\/=?^\`{\}|~#-]+/m
             @string = $'
             @sym = SYM_ATOM
             break
@@ -703,7 +703,7 @@ module RMail
 	    @sym = SYM_DOMAIN_LITERAL
 	    @lexeme = $1.gsub(/(^|[^\\])[\r\n\t ]+/, '\1').gsub(/\\(.)/, '\1')
 	    break
-          when /\A[\200-\377\w!$%&\'*+\/=?^_\`{\}|~#-]+/nm
+          when /\A[\200-\377\w!$%&\'*+\/=?^\`{\}|~#-]+/nm
             # This is just like SYM_ATOM, but includes all characters
             # with high bits.  This is so we can allow such tokens in
             # the display name portion of an address even though it

data/lib/rmail/header.rb

@@ -136,10 +136,10 @@ module RMail
     end
 
     # Return the value of the first matching field of a field name, or
-    # nil if none found.  If passed a Fixnum, returns the header
+    # nil if none found.  If passed an Integer, returns the header
     # indexed by the number.
     def [](name_or_index)
-      if name_or_index.kind_of? Fixnum
+      if name_or_index.kind_of? Integer
         temp = @fields[name_or_index]
         temp = temp.value unless temp.nil?
       else
@@ -474,9 +474,9 @@ module RMail
     #
     # See also: #match
     def match?(name, value)
-      massage_match_args(name, value) { |name, value|
+      massage_match_args(name, value) { |mname, mvalue|
         match = detect {|n, v|
-          n =~ name && v =~ value
+          n =~ mname && v =~ mvalue
         }
         ! match.nil?
       }
@@ -507,10 +507,10 @@ module RMail
     #
     # See also: #match?
     def match(name, value)
-      massage_match_args(name, value) { |name, value|
+      massage_match_args(name, value) { |mname, mvalue|
         header = RMail::Header.new
-        found = each { |n, v|
-          if n.downcase =~ name  &&  value =~ v
+        each { |n, v|
+          if n.downcase =~ mname  &&  mvalue =~ v
             header[n] = v
           end
         }
@@ -893,7 +893,7 @@ module RMail
 
     protected
 
-    attr :fields, true
+    attr_accessor :fields
 
     private
 

data/lib/rmail/message.rb

@@ -46,6 +46,7 @@ module RMail
       @body = nil
       @epilogue = nil
       @preamble = nil
+      @delimiters = nil
     end
 
     # Test if this message is structured exactly the same as the other
@@ -130,14 +131,14 @@ module RMail
     # Access the epilogue string for this message.  The epilogue
     # string is relevant only for multipart messages.  It is the text
     # that occurs after all parts of the message and is generally nil.
-    attr :epilogue, true
+    attr_accessor :epilogue
 
     # Access the preamble string for this message.  The preamble
     # string is relevant only for multipart messages.  It is the text
     # that occurs just before the first part of the message, and is
     # generally nil or simple English text describing the nature of
     # the message.
-    attr :preamble, true
+    attr_accessor :preamble
 
     # Returns the entire message in a single string.  This uses the
     # RMail::Serialize class.

data/lib/rmail/parser.rb

@@ -202,7 +202,6 @@ module RMail
     def parse_header(input, depth)
       data = nil
       header = nil
-      pushback = nil
       boundary = nil
       while chunk = input.read
         data ||= ''

data/lib/rmail/parser/pushbackreader.rb

@@ -81,11 +81,11 @@ module RMail
             end
           end
           chunk
-        when Fixnum
+        when Integer
           read_chunk(size)
         else
           raise ArgumentError,
-            "Read size (#{size.inspect}) must be a Fixnum or nil."
+            "Read size (#{size.inspect}) must be an Integer or nil."
         end
       end
 
@@ -102,7 +102,7 @@ module RMail
       # convenient to call from derived classes when super() isn't
       # easy to use.
       def standard_read_chunk(size)
-        unless size.is_a?(Fixnum) && size > 0
+        unless size.is_a?(Integer) && size > 0
           raise ArgumentError,
             "Read size (#{size.inspect}) must be greater than 0."
         end
@@ -132,11 +132,11 @@ module RMail
 
       # Set the chunk size of this reader in bytes.  This is useful
       # mainly for testing, though perhaps some operations could be
-      # optimized by tweaking this value.  The chunk size must be a
-      # Fixnum greater than 0.
+      # optimized by tweaking this value.  The chunk size must be an
+      # Integer greater than 0.
       def chunk_size=(size)
-        unless size.is_a?(Fixnum)
-          raise ArgumentError, "chunk size must be a Fixnum"
+        unless size.is_a?(Integer)
+          raise ArgumentError, "chunk size must be an Integer"
         end
         unless size >= 1
           raise ArgumentError, "invalid size #{size.inspect} given"

data/lib/rmail/serialize.rb

@@ -74,7 +74,7 @@ module RMail
 
     def serialize_low(message, depth = 0)
       if message.multipart?
-        delimiters, delimiters_boundary = message.get_delimiters
+        delimiters, _delimiters_boundary = message.get_delimiters
         unless delimiters
           boundary = "\n--" + message.header.param('Content-Type', 'boundary')
           delimiters = Array.new(message.body.length + 1, boundary + "\n")

data/lib/rmail/version.rb

@@ -1,3 +1,3 @@
 module RMail
-  VERSION = '1.1.3'
+  VERSION = '1.1.4'
 end

data/test/testaddress.rb

@@ -1129,13 +1129,13 @@ class TestRMailAddress < TestBase
     assert_equal(nil, addr.domain)
     assert_equal(nil, addr.local)
 
-    e = assert_raise(ArgumentError) {
+    assert_raise(ArgumentError) {
       RMail::Address.new(["bob"])
     }
-    e = assert_raise(ArgumentError) {
+    assert_raise(ArgumentError) {
       RMail::Address.new(Object.new)
     }
-    e = assert_raise(ArgumentError) {
+    assert_raise(ArgumentError) {
       RMail::Address.new(Hash.new)
     }
   end

data/test/testbase.rb

@@ -27,6 +27,26 @@
 
 # Base for all the test cases, providing a default setup and teardown
 
+if ENV["COVERAGE"] || ENV["TRAVIS"]
+  require "simplecov"
+  SimpleCov.start do
+    add_filter "/test/"
+  end
+  top = File.expand_path("../..", __FILE__)
+  # track all ruby files under lib
+  SimpleCov.track_files("#{top}/lib/**/*.rb")
+
+  # use coveralls for on-line code coverage reporting at Travis CI
+  if ENV["TRAVIS"]
+    require "coveralls"
+    SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new [
+      SimpleCov::Formatter::HTMLFormatter,
+      Coveralls::SimpleCov::Formatter
+    ]
+  end
+  SimpleCov.start
+end
+
 require 'test/unit'
 require 'rbconfig.rb'
 require 'tempfile'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rmail
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Matt Armstrong
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-16 00:00:00.000000000 Z
+date: 2020-07-08 00:00:00.000000000 Z
 dependencies: []
 description: |2
     RMail is a lightweight mail library containing various utility classes and
@@ -123,7 +123,7 @@ metadata: {}
 post_install_message: 
 rdoc_options:
 - "--title"
-- RubyMail Documentation (version 1.1.3)
+- RubyMail Documentation (version 1.1.4)
 - "--main"
 - README
 - "--exclude"
@@ -141,8 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A MIME mail parsing and generation library.