rmagick 4.2.5 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19f12f1fe15653484cfee177ac21d5174d912918ef9bdf874b74b940a91cf5ba
-  data.tar.gz: 9a187a8e989d9b0f984716a1bb5e8239e4e0d428de76f52cbbf56cbfb7c7e55a
+  metadata.gz: baffdb83618f956f81c5e8bf81873465642c2727f279514d416553b092590086
+  data.tar.gz: 2d65e812017b48d555ad5e0865b24074910f495e2ef94b9c70e9b7a53980acb6
 SHA512:
-  metadata.gz: d04c9a98d1004623c27fedda53f7f3d5de1ae7a9f938da386a803e6191d224e92bf71831bfc57ac946d45f4f2a820d1441fd3d19a8d78442d0046d7927819a13
-  data.tar.gz: b05b1c15617eb186b65edc55b97c6c8b4f58f25249f1295378efaf1e40f7242f82c46e20389eecd914e62d3e5c7233e3dc0b0308897a3f5825dda0c1cbaec796
+  metadata.gz: 6040c8ff49d8eb0441b4ebd8fe2c30de695c28f95d17f4475851eae564e25383558f6588595b6e21d887c8edf20965b4f4a8587122925be8ffdac702bdecb4af
+  data.tar.gz: 2012804b6a11228f960c89d8b3748e7917a9faa7ea8d717d18327f2ef3c3d390c1e892e9980c9d909d6bdf9a7594a0987c87797872043ab45775443d080b3df2

data/.devcontainer/Dockerfile

@@ -0,0 +1,14 @@
+ARG RUBY_VERSION
+
+FROM ruby:${RUBY_VERSION}
+
+ARG IMAGEMAGICK_VERSION
+
+RUN mkdir /setup
+ADD *.sh /setup
+
+ENV IMAGEMAGICK_VERSION ${IMAGEMAGICK_VERSION}
+
+RUN /setup/setup-user.sh
+
+WORKDIR /workspaces/rmagick

data/.devcontainer/ImageMagick6/devcontainer.json

@@ -0,0 +1,11 @@
+{
+  "name": "ImageMagick 6",
+  "build": {
+    "dockerfile": "../Dockerfile",
+    "args": {
+      "RUBY_VERSION": "3.1.2",
+      "IMAGEMAGICK_VERSION": "6.9.12-59"
+    }
+  },
+  "onCreateCommand": "/setup/setup-repo.sh"
+}

data/.devcontainer/devcontainer.json

@@ -0,0 +1,11 @@
+{
+  "name": "ImageMagick 7",
+  "build": {
+    "dockerfile": "Dockerfile",
+    "args": {
+      "RUBY_VERSION": "3.1.2",
+      "IMAGEMAGICK_VERSION": "7.1.0-44"
+    }
+  },
+  "onCreateCommand": "/setup/setup-repo.sh"
+}

data/.devcontainer/setup-repo.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+set -e
+
+apt-get update
+apt-get install sudo
+
+bash /workspaces/rmagick/before_install_linux.sh
+
+cd /workspaces/rmagick
+bundle install --path=vendor/bundle --jobs 4 --retry 3

data/.devcontainer/setup-user.sh

@@ -0,0 +1,45 @@
+#!/bin/bash
+set -e
+
+codespaces_bash="$(cat \
+<<'EOF'
+# Codespaces bash prompt theme
+__bash_prompt() {
+    local userpart='`export XIT=$? \
+        && [ ! -z "${GITHUB_USER}" ] && echo -n "\[\033[0;32m\]@${GITHUB_USER} " || echo -n "\[\033[0;32m\]\u " \
+        && echo -n "\[\033[0;36m\][IM ${IMAGEMAGICK_VERSION}]" \
+        && [ "$XIT" -ne "0" ] && echo -n "\[\033[1;31m\]➜" || echo -n "\[\033[0m\]➜"`'
+    local gitbranch='`\
+        if [ "$(git config --get codespaces-theme.hide-status 2>/dev/null)" != 1 ]; then \
+            export BRANCH=$(git symbolic-ref --short HEAD 2>/dev/null || git rev-parse --short HEAD 2>/dev/null); \
+            if [ "${BRANCH}" != "" ]; then \
+                echo -n "\[\033[0;36m\](\[\033[1;31m\]${BRANCH}" \
+                && if git ls-files --error-unmatch -m --directory --no-empty-directory -o --exclude-standard ":/*" > /dev/null 2>&1; then \
+                        echo -n " \[\033[1;33m\]✗"; \
+                fi \
+                && echo -n "\[\033[0;36m\]) "; \
+            fi; \
+        fi`'
+    local lightblue='\[\033[1;34m\]'
+    local removecolor='\[\033[0m\]'
+    PS1="${userpart} ${lightblue}\w ${gitbranch}${removecolor}\$ "
+    unset -f __bash_prompt
+}
+__bash_prompt
+
+__show_notice() {
+  local __message="
+\033[0;32mWelcome to Codespaces! You are using the pre-configured rmagick image.\033[0m
+
+\033[0;35mTests can be executed with:\033[0m bundle exec rake
+\033[0;35mCode style can be checked with:\033[0m STYLE_CHECKS=true bundle exec rubocop
+"
+  echo -e "$__message"
+
+  unset -f __show_notice
+}
+__show_notice
+EOF
+)"
+
+ echo "${codespaces_bash}" >> "/root/.bashrc"

data/.github/workflows/ci.yml

@@ -7,12 +7,15 @@ on:
   pull_request:
   workflow_dispatch:
 
+permissions:
+  contents: read
+
 jobs:
   lint:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby 2.3
       uses: ruby/setup-ruby@master
       with:
@@ -31,12 +34,12 @@ jobs:
         imagemagick-version:
           - { full: 6.7.7-10, major-minor: '6.7' }
           - { full: 6.8.9-10, major-minor: '6.8' }
-          - { full: 6.9.12-37, major-minor: '6.9' }
-          - { full: 7.1.0-22, major-minor: '7.0' }
+          - { full: 6.9.12-59, major-minor: '6.9' }
+          - { full: 7.1.0-44, major-minor: '7.0' }
 
     name: Linux, Ruby ${{ matrix.ruby-version }}, IM ${{ matrix.imagemagick-version.major-minor }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby ${{ matrix.ruby-version }}
       uses: ruby/setup-ruby@master
       with:
@@ -57,12 +60,12 @@ jobs:
       matrix:
         ruby-version: ['2.6', '2.7', '3.0', '3.1']
         imagemagick-version:
-          - { full: 6.9.12-37, major-minor: '6.9' }
-          - { full: 7.1.0-22, major-minor: '7.0' }
+          - { full: 6.9.12-59, major-minor: '6.9' }
+          - { full: 7.1.0-44, major-minor: '7.0' }
 
     name: macOS, Ruby ${{ matrix.ruby-version }}, IM ${{ matrix.imagemagick-version.major-minor }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby ${{ matrix.ruby-version }}
       uses: ruby/setup-ruby@master
       with:

data/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project are documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## RMagick 4.3.0
+
+Deprecates
+
+- Mark Magick.trace_proc= as deprecated (#1354)
+- Mark Magick::{Image, Image::Info}#monitor= as deprecated (#1353)
+
+These methods will be removed in RMagick 5.0 and no alternative.
+
+## RMagick 4.2.6
+
+Improvements
+
+- Remove test_files to reduce gem package size (#1338)
+
+Bug Fixes
+
+- Guard against an empty rpath (#1333)
+- Call GetImageDistortion instead of IsImagesEqual to fix the issue reported in #1342 (#1343)
+
 ## RMagick 4.2.5
 
 Bug Fixes

data/README.md

@@ -197,6 +197,8 @@ export LD_LIBRARY_PATH=/usr/local/lib
 On Linux, see `ld(1)` and `ld.so(8)` for more information. On other operating
 systems, see the documentation for the dynamic loading facility.
 
+This operation might not be required when you can use 4.2.5 or later.
+
 ### Segmentation fault
 
 Default stack size of your operating system might be too small. Try removing

data/before_install_linux.sh

@@ -41,7 +41,7 @@ build_imagemagick() {
   mkdir -p build-ImageMagick
 
   version=(${IMAGEMAGICK_VERSION//./ })
-  wget "https://imagemagick.org/download/releases/ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
+  wget "https://imagemagick.org/archive/releases/ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   tar -xf "ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   rm "ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   mv "ImageMagick-${IMAGEMAGICK_VERSION}" "${build_dir}"

data/before_install_osx.sh

@@ -16,10 +16,10 @@ if [ ! -v IMAGEMAGICK_VERSION ]; then
 fi
 
 export HOMEBREW_NO_AUTO_UPDATE=true
-brew install wget pkg-config ghostscript freetype jpeg little-cms2 libomp libpng libtiff liblqr libtool libxml2 zlib webp
+brew install wget pkg-config ghostscript freetype jpeg little-cms2 libomp libpng libtiff liblqr libtool zlib webp
 
 export LDFLAGS="-L/usr/local/opt/libxml2/lib -L/usr/local/opt/zlib/lib"
-export CPPFLAGS="-I/usr/local/opt/libxml2/include/libxml2 -I/usr/local/opt/zlib/include"
+export CPPFLAGS="-I/usr/local/opt/libxml2/include -I/usr/local/opt/zlib/include"
 
 project_dir=$(pwd)
 build_dir="${project_dir}/build-ImageMagick/ImageMagick-${IMAGEMAGICK_VERSION}"
@@ -31,7 +31,7 @@ build_imagemagick() {
   mkdir -p build-ImageMagick
 
   version=(${IMAGEMAGICK_VERSION//./ })
-  wget "https://imagemagick.org/download/releases/ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
+  wget "https://imagemagick.org/archive/releases/ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   tar -xf "ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   rm "ImageMagick-${IMAGEMAGICK_VERSION}.tar.xz"
   mv "ImageMagick-${IMAGEMAGICK_VERSION}" "${build_dir}"

data/ext/RMagick/extconf.rb

@@ -69,11 +69,12 @@ module RMagick
 
         libdir  = `pkg-config --libs-only-L #{$magick_package}`.chomp.sub('-L', '')
         ldflags = "#{ENV['LDFLAGS']} " + `pkg-config --libs #{$magick_package}`.chomp
+        rpath   = libdir.empty? ? '' : "-Wl,-rpath,#{libdir}"
 
         # Save flags
         $CPPFLAGS   = "#{ENV['CPPFLAGS']} " + `pkg-config --cflags #{$magick_package}`.chomp
         $LOCAL_LIBS = "#{ENV['LIBS']} "     + `pkg-config --libs #{$magick_package}`.chomp
-        $LDFLAGS    = "#{ldflags} -Wl,-rpath,#{libdir}"
+        $LDFLAGS    = "#{ldflags} #{rpath}"
 
         unless try_link("int main() { }")
           # if linker does not recognizes '-Wl,-rpath,somewhere' option, it revert to original option

data/ext/RMagick/rmimage.c

@@ -5205,6 +5205,7 @@ Image_difference(VALUE self, VALUE other)
     Image *image2;
     VALUE mean, nmean, nmax;
 #if defined(IMAGEMAGICK_7)
+    double distortion;
     ExceptionInfo *exception;
 #endif
 
@@ -5214,7 +5215,7 @@ Image_difference(VALUE self, VALUE other)
 
 #if defined(IMAGEMAGICK_7)
     exception = AcquireExceptionInfo();
-    IsImagesEqual(image, image2, exception);
+    GetImageDistortion(image, image2, MeanErrorPerPixelErrorMetric, &distortion, exception);
     CHECK_EXCEPTION();
     DestroyExceptionInfo(exception);
 #else
@@ -9203,12 +9204,15 @@ Image_modulate(int argc, VALUE *argv, VALUE self)
  *     print "%s is %3.0f%% complete.\n", method, (offset.to_f/span)*100)
  *     true
  *   end
+ * @deprecated Magick::Image#monitor= is deprecated. This method will be removed in RMagick 5.0.
  */
 VALUE
 Image_monitor_eq(VALUE self, VALUE monitor)
 {
     Image *image = rm_check_frozen(self);
 
+    rb_warning("Magick::Image#monitor= is deprecated. This method will be removed in RMagick 5.0.");
+
     if (NIL_P(monitor))
     {
         image->progress_monitor = NULL;

data/ext/RMagick/rminfo.c

@@ -1560,6 +1560,7 @@ Info_matte_color_eq(VALUE self, VALUE matte_arg)
  * @param monitor [Proc] the monitor
  * @return [Proc] monitor
  * @see Image#monitor=
+ * @deprecated Magick::Image::Info#monitor= is deprecated. This method will be removed in RMagick 5.0.
  */
 VALUE
 Info_monitor_eq(VALUE self, VALUE monitor)
@@ -1568,6 +1569,8 @@ Info_monitor_eq(VALUE self, VALUE monitor)
 
     Data_Get_Struct(self, Info, info);
 
+    rb_warning("Magick::Image::Info#monitor= is deprecated. This method will be removed in RMagick 5.0.");
+
     if (NIL_P(monitor))
     {
         info->progress_monitor = NULL;

data/lib/rmagick/version.rb

@@ -1,5 +1,5 @@
 module Magick
-  VERSION = '4.2.5'
+  VERSION = '4.3.0'
   MIN_RUBY_VERSION = '2.3.0'
   MIN_IM_VERSION = '6.7.7'
 end

data/lib/rmagick_internal.rb

@@ -83,7 +83,11 @@ module Magick
     #   Magick.trace_proc = proc do |which, description, id, method|
     #     ...
     #   end
+    #
+    # @deprecated Magick.trace_proc= is deprecated. This method will be removed in RMagick 5.0.
     def trace_proc=(p)
+      warn 'Magick.trace_proc= is deprecated. This method will be removed in RMagick 5.0.'
+
       if @trace_proc.nil? && !p.nil? && !@exit_block_set_up
         at_exit { @trace_proc = nil }
         @exit_block_set_up = true

data/rmagick.gemspec

@@ -15,11 +15,9 @@ Gem::Specification.new do |s|
 
   tracked_files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
   file_exclusion_regex = %r{\A(doc|benchmarks|examples|spec|lib/rvg/to_c.rb)}
-  files         = tracked_files.reject { |file| file[file_exclusion_regex] }
-  test_files    = files.grep(%r{^(test|spec|features)/})
+  files = tracked_files.reject { |file| file[file_exclusion_regex] }
 
-  s.files                       = files
-  s.test_files                  = test_files
+  s.files = files
   s.require_paths << 'ext' << 'deprecated'
 
   s.extensions = %w[ext/RMagick/extconf.rb]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rmagick
 version: !ruby/object:Gem::Version
-  version: 4.2.5
+  version: 4.3.0
 platform: ruby
 authors:
 - Tim Hunter
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-05 00:00:00.000000000 Z
+date: 2022-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -147,6 +147,11 @@ extensions:
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".devcontainer/Dockerfile"
+- ".devcontainer/ImageMagick6/devcontainer.json"
+- ".devcontainer/devcontainer.json"
+- ".devcontainer/setup-repo.sh"
+- ".devcontainer/setup-user.sh"
 - ".editorconfig"
 - ".github/ISSUE_TEMPLATE.md"
 - ".github/workflows/ci.yml"