rmagick 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd1b2d7e462a34be69913fc0315b6617b8043ca67c05b270193d1e974beacd73
-  data.tar.gz: 9d9f902fdc9fcc7a6e444bf7e101af46bf85ef5edcdc53897753d48bb23ca942
+  metadata.gz: 14fbc044f6437f806685330840ec7a65eca53394c52e9c83bb125764cbcfcec7
+  data.tar.gz: 5497e651500e3bcf58c1055e68fac7a5f754757119c03a3b6916663660c53ade
 SHA512:
-  metadata.gz: baa7de09c1c1691354b11f7734d447c5f25cd78d1f2633c493e4f53bf0947b7aa235a6d4e2ee97608359edf7e9569bfc7f4a2298fedd8211de82595c250ecc34
-  data.tar.gz: 4ade0d3f0c83db16296321c1dabe4f0e8d5e886ac6b7a8449f3db6022783fa1d95553dbafc8843ca883fe76176e4054bde2329795850b453906b45804e538791
+  metadata.gz: 14c5cabe80554f502aef129861aa8ba0fb0eb7d2c5ad37a8ea4120a2d600912fd8dcb4c40cca5e1c2d55a2372f82e54b885ec53acf69a1af227cc3ca553084d3
+  data.tar.gz: f72d9459f44f9680a3dd30a96d948e70aefceefa8b4b751bfd3286d36e06d1b834f9b1c850c119ebc61e6f2a7dde7167f6a44f554d56eccddb68151601782d7a

data/.appveyor.yml

@@ -1,12 +1,38 @@
+cache:
+  - vendor/bundle -> .appveyor.yml
+
 environment:
   matrix:
-    - RUBY_VERSION: "24-x64"
+    - RUBY_VERSION: 23-x64
+      IMAGEMAGICK_VERSION: 6.8.9
+      PATCH_VERSION: 10
+    - RUBY_VERSION: 23-x64
+      IMAGEMAGICK_VERSION: 6.9.10
+      PATCH_VERSION: 40
+    - RUBY_VERSION: 24-x64
+      IMAGEMAGICK_VERSION: 6.8.9
+      PATCH_VERSION: 10
+    - RUBY_VERSION: 24-x64
+      IMAGEMAGICK_VERSION: 6.9.10
+      PATCH_VERSION: 40
+    - RUBY_VERSION: 25-x64
+      IMAGEMAGICK_VERSION: 6.8.9
+      PATCH_VERSION: 10
+    - RUBY_VERSION: 25-x64
+      IMAGEMAGICK_VERSION: 6.9.10
+      PATCH_VERSION: 40
+    - RUBY_VERSION: 26-x64
+      IMAGEMAGICK_VERSION: 6.8.9
+      PATCH_VERSION: 10
+    - RUBY_VERSION: 26-x64
+      IMAGEMAGICK_VERSION: 6.9.10
+      PATCH_VERSION: 40
 
 install:
-  - appveyor DownloadFile https://ftp.icm.edu.pl/pub/graphics/ImageMagick/binaries/ImageMagick-6.8.9-10-Q16-x64-dll.exe
-  - ImageMagick-6.8.9-10-Q16-x64-dll.exe /VERYSILENT /TASKS=install_Devel
-  - SET PATH=C:\Ruby%RUBY_VERSION%\bin;C:\Program Files\ImageMagick-6.8.9-Q16;%PATH%
-  - bundle install
+  - appveyor-retry appveyor DownloadFile https://ftp.icm.edu.pl/pub/graphics/ImageMagick/binaries/ImageMagick-%IMAGEMAGICK_VERSION%-%PATCH_VERSION%-Q16-x64-dll.exe
+  - ImageMagick-%IMAGEMAGICK_VERSION%-%PATCH_VERSION%-Q16-x64-dll.exe /VERYSILENT /TASKS=install_Devel
+  - SET PATH=C:\Ruby%RUBY_VERSION%\bin;C:\Program Files\ImageMagick-%IMAGEMAGICK_VERSION%-Q16;%PATH%
+  - bundle install --path=vendor/bundle
 
 build: off
 
@@ -16,4 +42,4 @@ before_test:
   - bundle -v
 
 test_script:
-  - rake -rdevkit
+  - bundle exec rake -rdevkit

data/.circleci/config.yml

@@ -17,7 +17,7 @@ jobs:
       - run:
           name: setup linux
           command: |
-            IMAGEMAGICK_VERSION=6.8.9-10 bash before_install_linux.sh
+            IMAGEMAGICK_VERSION=6.9.10-40 bash before_install_linux.sh
 
       - run:
           name: install dependencies

data/.gitignore

@@ -13,6 +13,7 @@ rdoc
 spec/reports
 test/tmp
 test/version_tmp
+vendor/bundle
 tmp
 *.bundle
 *.so

data/.rubocop.yml

@@ -1,13 +1,13 @@
 inherit_from:
-    - .rubocop_todo.yml
+  - .rubocop_todo.yml
 
-# Custom configuration, edit with care!
+require:
+  - rubocop-rspec
 
-# Fixing this issues cause some test to fail
-Lint/UnifiedInteger:
-  Enabled: false
-
-Metrics/ClassLength:
-  Max: 500
+AllCops:
+  DefaultFormatter: fuubar
+  EnabledByDefault: true
+  TargetRubyVersion: 2.3
   Exclude:
-  - test/**/*
+    - 'vendor/bundle/**/*'
+    - '**/*\.spec'

data/.rubocop_todo.yml

@@ -1,12 +1,62 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-08 19:33:24 +0300 using RuboCop version 0.59.2.
+# on 2019-03-08 22:06:23 -0800 using RuboCop version 0.64.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 18
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: Categories, ExpectedOrder.
+# ExpectedOrder: module_inclusion, constants, public_class_methods, initializer, public_methods, protected_methods, private_methods
+Layout/ClassStructure:
+  Exclude:
+    - 'examples/histogram.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/pathdata.rb'
+    - 'lib/rvg/rvg.rb'
+    - 'lib/rvg/to_c.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Layout/FirstArrayElementLineBreak:
+  Exclude:
+    - 'doc/ex/add_noise.rb'
+    - 'doc/ex/clip_path.rb'
+    - 'doc/ex/crop_with_gravity.rb'
+    - 'doc/ex/polyline.rb'
+    - 'examples/crop_with_gravity.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/stylable.rb'
+    - 'test/Image3.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Layout/FirstHashElementLineBreak:
+  Exclude:
+    - 'doc/ex/writing_mode01.rb'
+    - 'doc/ex/writing_mode02.rb'
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 23
+# Cop supports --auto-correct.
+Layout/FirstMethodArgumentLineBreak:
+  Exclude:
+    - 'doc/ex/axes.rb'
+    - 'doc/ex/drawcomp.rb'
+    - 'doc/ex/fonts.rb'
+    - 'doc/ex/get_type_metrics.rb'
+    - 'doc/ex/polygon.rb'
+    - 'doc/ex/polygon01.rb'
+    - 'doc/ex/polyline01.rb'
+    - 'doc/ex/sparse_color.rb'
+    - 'examples/vignette.rb'
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 16
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
@@ -24,19 +74,38 @@ Layout/IndentHeredoc:
     - 'ext/RMagick/extconf.rb'
     - 'lib/rvg/to_c.rb'
 
-# Offense count: 1
+# Offense count: 95
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineArrayBraceLayout:
-  Exclude:
-    - 'ext/RMagick/extconf.rb'
+# SupportedTypes: block, case, class, if, kwbegin, module
+# SupportedStyles: same_line, new_line
+Layout/MultilineAssignmentLayout:
+  Enabled: false
 
 # Offense count: 1
+Lint/EmptyWhen:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 2
 Lint/HandleExceptions:
   Exclude:
     - 'lib/rmagick_internal.rb'
 
+# Offense count: 88
+Lint/NumberConversion:
+  Exclude:
+    - 'doc/ex/get_pixels.rb'
+    - 'doc/ex/stegano.rb'
+    - 'examples/describe.rb'
+    - 'examples/thumbnail.rb'
+    - 'ext/RMagick/extconf.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/to_c.rb'
+    - 'test/Import_Export.rb'
+    - 'test/Enum.rb'
+
 # Offense count: 1
 Lint/RescueException:
   Exclude:
@@ -47,6 +116,10 @@ Lint/ReturnInVoidContext:
   Exclude:
     - 'lib/rmagick_internal.rb'
 
+Lint/UselessComparison:
+  Exclude:
+    - 'test/Enum.rb'
+
 # Offense count: 6
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
@@ -54,11 +127,11 @@ Lint/Void:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/embellishable.rb'
 
-# Offense count: 170
+# Offense count: 167
 Metrics/AbcSize:
   Max: 559
 
-# Offense count: 21
+# Offense count: 22
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
@@ -69,11 +142,18 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 4
 
+# Offense count: 17
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 500
+  Exclude:
+    - 'test/**/*.rb'
+
 # Offense count: 22
 Metrics/CyclomaticComplexity:
   Max: 42
 
-# Offense count: 172
+# Offense count: 167
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 146
@@ -102,7 +182,7 @@ Naming/ClassAndModuleCamelCase:
     - 'test/Image3.rb'
     - 'test/Image_attributes.rb'
 
-# Offense count: 123
+# Offense count: 122
 Naming/ConstantName:
   Exclude:
     - 'doc/ex/arcs02.rb'
@@ -119,9 +199,8 @@ Naming/ConstantName:
     - 'examples/demo.rb'
     - 'lib/rmagick_internal.rb'
     - 'test/Image3.rb'
-    - 'test/test_all_basic.rb'
 
-# Offense count: 16
+# Offense count: 17
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
@@ -135,7 +214,7 @@ Naming/MethodName:
     - 'lib/rvg/misc.rb'
     - 'lib/rvg/transformable.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # NamePrefixBlacklist: is_, has_, have_
@@ -153,6 +232,11 @@ Naming/PredicateName:
 Naming/UncommunicativeMethodParamName:
   Enabled: false
 
+# Offense count: 1
+Performance/ChainArrayAllocation:
+  Exclude:
+    - 'lib/rvg/embellishable.rb'
+
 # Offense count: 6
 Performance/FixedSize:
   Exclude:
@@ -165,6 +249,108 @@ Performance/RedundantMatch:
     - 'examples/demo.rb'
     - 'test/Image2.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+RSpec/AlignLeftLetBrace:
+  Exclude:
+    - 'spec/rmagick/image/constitute_spec.rb'
+    - 'spec/rmagick/image/from_blob_spec.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+RSpec/AlignRightLetBrace:
+  Exclude:
+    - 'spec/rmagick/image/constitute_spec.rb'
+    - 'spec/rmagick/image/from_blob_spec.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+    - 'spec/rmagick/draw_spec.rb'
+    - 'spec/rmagick/image/composite_spec.rb'
+    - 'spec/rmagick/image/dispatch_spec.rb'
+    - 'spec/rmagick/image/ping_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 15
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 6
+
+# Offense count: 3
+RSpec/Pending:
+  Exclude:
+    - 'spec/rmagick/draw_spec.rb'
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: Strict, EnforcedStyle.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: **/test/**/*
+Rails/AssertNot:
+  Exclude:
+    - 'test/Image1.rb'
+    - 'test/Image2.rb'
+    - 'test/ImageList1.rb'
+    - 'test/Image_attributes.rb'
+    - 'test/Info.rb'
+    - 'test/Pixel.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/Date:
+  Exclude:
+    - 'doc/ex/polaroid.rb'
+    - 'rmagick.gemspec'
+
+# Offense count: 7
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
+Rails/Output:
+  Exclude:
+    - 'lib/rvg/deep_equal.rb'
+    - 'lib/rvg/rvg.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Exclude:
+    - 'Rakefile'
+    - 'ext/RMagick/extconf.rb'
+
 # Offense count: 4
 Security/MarshalLoad:
   Exclude:
@@ -173,6 +359,16 @@ Security/MarshalLoad:
     - 'test/Image2.rb'
     - 'test/ImageList2.rb'
 
+# Offense count: 2
+Style/AutoResourceCleanup:
+  Exclude:
+    - 'lib/rvg/to_c.rb'
+    - 'test/ImageList2.rb'
+
+Style/CaseEquality:
+  Exclude:
+    - 'test/Enum.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
@@ -184,14 +380,44 @@ Style/ClassAndModuleChildren:
     - 'spec/rmagick/draw_spec.rb'
     - 'test/Magick.rb'
 
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredMethods.
+Style/CollectionMethods:
+  Exclude:
+    - 'doc/ex/composite_layers.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/transformable.rb'
+    - 'test/ImageList1.rb'
+    - 'test/Import_Export.rb'
+
 # Offense count: 90
 Style/CommentedKeyword:
   Enabled: false
 
+# Offense count: 253
+# Cop supports --auto-correct.
+# Configuration parameters: Notice, AutocorrectNotice.
+Style/Copyright:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: AllowCoercion.
+Style/DateTime:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
 # Offense count: 36
 Style/Documentation:
   Enabled: false
 
+# Offense count: 74
+# Configuration parameters: RequireForNonPublicMethods.
+Style/DocumentationMethod:
+  Enabled: false
+
 # Offense count: 4
 Style/EvalWithLocation:
   Exclude:
@@ -208,19 +434,62 @@ Style/FormatStringToken:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/pathdata.rb'
 
-# Offense count: 65
+# Offense count: 253
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 40
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'examples/histogram.rb'
     - 'ext/RMagick/extconf.rb'
 
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
+# Offense count: 163
+Style/InlineComment:
+  Enabled: false
+
+# Offense count: 1051
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# SupportedStyles: require_parentheses, omit_parentheses
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
+
+# Offense count: 8
+Style/MethodCalledOnDoEndBlock:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+    - 'spec/rmagick/image/composite_spec.rb'
+    - 'spec/rmagick/image/dispatch_spec.rb'
+
 # Offense count: 2
 Style/MethodMissingSuper:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/misc.rb'
 
+# Offense count: 68
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: if, case, both
+Style/MissingElse:
+  Enabled: false
+
 # Offense count: 3
 Style/MissingRespondToMissing:
   Exclude:
@@ -243,12 +512,77 @@ Style/MixinUsage:
     - 'examples/thumbnail.rb'
     - 'examples/vignette.rb'
 
-# Offense count: 158
+# Offense count: 162
 # Cop supports --auto-correct.
 Style/MutableConstant:
   Enabled: false
 
-# Offense count: 672
+# Offense count: 34
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'test/Image2.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Exclude:
+    - 'test/Image3.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
+# Whitelist: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 5
+Style/Send:
+  Exclude:
+    - 'lib/rmagick_internal.rb'
+    - 'test/Image2.rb'
+
+# Offense count: 2
+# Configuration parameters: Methods.
+# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
+Style/SingleLineBlockParams:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+Style/StringHashKeys:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/misc.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'Rakefile'
+    - 'test/Image1.rb'
+    - 'test/ImageList2.rb'
+    - 'test/PolaroidOptions.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredMethods.
+Style/StringMethods:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 640
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength: